sr-dev October 2023

sr-dev@lists.kamailio.org

15 participants
288 discussions

git:master:1ebdc5c2: core: mem - print line after file name in qm_status_filter()
by Daniel-Constantin Mierla 23 Oct '23

23 Oct '23

Module: kamailio Branch: master Commit: 1ebdc5c2dd7640b778c0efac2baafe1894a75b77 URL: https://github.com/kamailio/kamailio/commit/1ebdc5c2dd7640b778c0efac2baafe1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-10-23T10:42:54+02:00 core: mem - print line after file name in qm_status_filter() --- Modified: src/core/mem/q_malloc.c --- Diff: https://github.com/kamailio/kamailio/commit/1ebdc5c2dd7640b778c0efac2baafe1… Patch: https://github.com/kamailio/kamailio/commit/1ebdc5c2dd7640b778c0efac2baafe1… --- diff --git a/src/core/mem/q_malloc.c b/src/core/mem/q_malloc.c index 5d05af88f9e..f440f452c1c 100644 --- a/src/core/mem/q_malloc.c +++ b/src/core/mem/q_malloc.c @@ -1023,9 +1023,9 @@ void qm_status_filter(void *qmp, str *fmatch, FILE *fp) i, (f->u.is_free) ? 'A' : 'N', (char *)f + sizeof(struct qm_frag), f, f->size, FRAG_WAS_USED(f)); - fprintf(fp, " %s from %s: %s(%ld)\n", - (f->u.is_free) ? "freed" : "alloc'd", f->file, f->func, - f->line); + fprintf(fp, " %s from %s:%ld / %s()\n", + (f->u.is_free) ? "freed" : "alloc'd", f->file, f->line, + f->func); fprintf(fp, " start check=%lx, end check= %lx, %lx\n", f->check, FRAG_END(f)->check1, FRAG_END(f)->check2); if(f->check != ST_CHECK_PATTERN) { @@ -1061,9 +1061,9 @@ void qm_status_filter(void *qmp, str *fmatch, FILE *fp) != NULL))) { fprintf(fp, "unused fragm.: hash = %3d, fragment %p," - " address %p size %lu, created from %s: %s(%lu)\n", + " address %p size %lu, created from %s:%lu / %s()\n", h, f, (char *)f + sizeof(struct qm_frag), f->size, - f->file, f->func, f->line); + f->file, f->line, f->func); } #endif }

1 0

git:master:338f848c: github: CODEOWNERS to protect workflows [skip ci]
by Victor Seva 23 Oct '23

23 Oct '23

Module: kamailio Branch: master Commit: 338f848c2dedac837c09914dafd29e1d39c22842 URL: https://github.com/kamailio/kamailio/commit/338f848c2dedac837c09914dafd29e1… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-10-23T10:41:41+02:00 github: CODEOWNERS to protect workflows [skip ci] > https://docs.github.com/en/repositories/managing-your-repositorys-settings-… > https://docs.github.com/en/actions/security-guides/security-hardening-for-g… --- Added: CODEOWNERS --- Diff: https://github.com/kamailio/kamailio/commit/338f848c2dedac837c09914dafd29e1… Patch: https://github.com/kamailio/kamailio/commit/338f848c2dedac837c09914dafd29e1… --- diff --git a/CODEOWNERS b/CODEOWNERS new file mode 100644 index 00000000000..7234200e5c6 --- /dev/null +++ b/CODEOWNERS @@ -0,0 +1,2 @@ +# workflows changes need admin approval +.github/workflows/ @kamailio/admin

1 0

git:master:e5ecb666: topos: remove check of th_param_mask_callid() for api callid masking
by Daniel-Constantin Mierla 21 Oct '23

21 Oct '23

Module: kamailio Branch: master Commit: e5ecb666abd24433b0de030980f79e2521439524 URL: https://github.com/kamailio/kamailio/commit/e5ecb666abd24433b0de030980f79e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-10-21T09:07:39+02:00 topos: remove check of th_param_mask_callid() for api callid masking - functions are not for topoh internal usage, but for intermodule API - reported as part of GH #3606 --- Modified: src/modules/topoh/th_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/e5ecb666abd24433b0de030980f79e2… Patch: https://github.com/kamailio/kamailio/commit/e5ecb666abd24433b0de030980f79e2… --- diff --git a/src/modules/topoh/th_msg.c b/src/modules/topoh/th_msg.c index f7ef0257f54..47637d3401a 100644 --- a/src/modules/topoh/th_msg.c +++ b/src/modules/topoh/th_msg.c @@ -508,12 +508,6 @@ int th_mask_callid_str(str *icallid, str *ocallid) { str out; - if(th_param_mask_callid == 0) - return 0; - - if(th_param_mask_callid == 0) - return 0; - if(icallid->s == NULL) { LM_ERR("invalid call-id value\n"); return -1; @@ -535,9 +529,6 @@ int th_unmask_callid_str(str *icallid, str *ocallid) { str out; - if(th_param_mask_callid == 0) - return 0; - if(icallid->s == NULL) { LM_ERR("invalid Call-Id value\n"); return -1;

1 0

git:master:37aa5b5f: core: set shm xsetfunc api field
by Daniel-Constantin Mierla 21 Oct '23

21 Oct '23

Module: kamailio Branch: master Commit: 37aa5b5f885d9c6a4915a3b3283d3cbbc04ecedd URL: https://github.com/kamailio/kamailio/commit/37aa5b5f885d9c6a4915a3b3283d3cb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-10-21T09:07:39+02:00 core: set shm xsetfunc api field - fix wrong variable added in previous commit for pkg api --- Modified: src/core/mem/pkg.c Modified: src/core/mem/shm.c --- Diff: https://github.com/kamailio/kamailio/commit/37aa5b5f885d9c6a4915a3b3283d3cb… Patch: https://github.com/kamailio/kamailio/commit/37aa5b5f885d9c6a4915a3b3283d3cb… --- diff --git a/src/core/mem/pkg.c b/src/core/mem/pkg.c index 6baf6ef6e64..803a68fca68 100644 --- a/src/core/mem/pkg.c +++ b/src/core/mem/pkg.c @@ -51,7 +51,7 @@ int pkg_init_api(sr_pkg_api_t *ap) _pkg_root.xrealloc = ap->xrealloc; _pkg_root.xreallocxf = ap->xreallocxf; _pkg_root.xstatus = ap->xstatus; - _shm_root.xstatus_filter = ap->xstatus_filter; + _pkg_root.xstatus_filter = ap->xstatus_filter; _pkg_root.xinfo = ap->xinfo; _pkg_root.xreport = ap->xreport; _pkg_root.xavailable = ap->xavailable; diff --git a/src/core/mem/shm.c b/src/core/mem/shm.c index 7a211856ac5..f321fff721c 100644 --- a/src/core/mem/shm.c +++ b/src/core/mem/shm.c @@ -252,6 +252,7 @@ int shm_init_api(sr_shm_api_t *ap) _shm_root.xfmodstats = ap->xfmodstats; _shm_root.xglock = ap->xglock; _shm_root.xgunlock = ap->xgunlock; + _shm_root.xsetfunc = ap->xsetfunc; return 0; }

1 0

git:master:e4f2cde5: core: mem - set xstatus_filter api field
by Daniel-Constantin Mierla 21 Oct '23

21 Oct '23

Module: kamailio Branch: master Commit: e4f2cde596387cc81ff0a26d89654d9d0e24ae10 URL: https://github.com/kamailio/kamailio/commit/e4f2cde596387cc81ff0a26d89654d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-10-21T09:07:39+02:00 core: mem - set xstatus_filter api field --- Modified: src/core/mem/pkg.c Modified: src/core/mem/shm.c --- Diff: https://github.com/kamailio/kamailio/commit/e4f2cde596387cc81ff0a26d89654d9… Patch: https://github.com/kamailio/kamailio/commit/e4f2cde596387cc81ff0a26d89654d9… --- diff --git a/src/core/mem/pkg.c b/src/core/mem/pkg.c index 3ad06ec4930..6baf6ef6e64 100644 --- a/src/core/mem/pkg.c +++ b/src/core/mem/pkg.c @@ -51,6 +51,7 @@ int pkg_init_api(sr_pkg_api_t *ap) _pkg_root.xrealloc = ap->xrealloc; _pkg_root.xreallocxf = ap->xreallocxf; _pkg_root.xstatus = ap->xstatus; + _shm_root.xstatus_filter = ap->xstatus_filter; _pkg_root.xinfo = ap->xinfo; _pkg_root.xreport = ap->xreport; _pkg_root.xavailable = ap->xavailable; diff --git a/src/core/mem/shm.c b/src/core/mem/shm.c index 75f2dde2790..7a211856ac5 100644 --- a/src/core/mem/shm.c +++ b/src/core/mem/shm.c @@ -242,6 +242,7 @@ int shm_init_api(sr_shm_api_t *ap) _shm_root.xreallocxf = ap->xreallocxf; _shm_root.xresize = ap->xresize; _shm_root.xstatus = ap->xstatus; + _shm_root.xstatus_filter = ap->xstatus_filter; _shm_root.xinfo = ap->xinfo; _shm_root.xreport = ap->xreport; _shm_root.xavailable = ap->xavailable;

1 0

[kamailio/kamailio] ims_dialog: Support for db storage (Issue #3602)
by mtryfoss 20 Oct '23

20 Oct '23

### Description I've been looking at the ims_dialog module and notice that the documentation states that db storage is not yet supported. According to the source code that only partial true. Not sure if it's residues from the other dialog module, or some unfinished work. After some initial testing and small adjustments, the main issue seems to that for my use the "Dialog-iD"/did is not filled. I can not see this being set for calls that are not "concurrently confirmed". The field in the database for this id is NON NULL, so the insert fails. It's also used as WHERE-criteria when restarting and fetching the dialog_out entries, belonging to each dialog_in, so it needs to be set for this to work. This is not really a feature request. It's more about a confirmation that my assumptions are correct, before trying to do the proposed changes. ### Expected behavior I do assume that this "did"-field should be or be linked to the same did added as Record-Route parameter, identifying each dialog. #### Actual observed behavior kamcmd dlg2.list displays NULL for Dialog-ID. ``` kamcmd dlg2.list { Size: 4096 Dialogs: { Dialog: { Entry: 1096 Id: 8069 RURI: sip:+4791500025@10.111.64.16;user=phone From: sip:+4746180445@10.111.64.16;user=phone Call-ID: 34c5d9f15ff42a0564f809cb35e19c75@10.111.64.16:5060 Caller Contact: sip:+4746180445@10.111.64.16:5060 Caller Route Set: <null string> Dialog-ID: <null string> From Tag: as4df55540 State: Confirmed Ref: 2 dlg_outs: { dlg_out: { Entry: 2680 Id: 0 } } } } } ``` ### Possible Solutions Always set this did field when a new dialog is created. I've also been studying the DB schema. All operations for the dialog_in table are done using hash_entry and hash_id as keys. Why are they not used as primary key instead, which would be much more efficient? Also, having an integer with auto_increment as primary key would make this stop when the integer hits max value, if it's not reset regularly. I can not see this field used anywhere in the code either, so it could probably just be removed. The same applies to dialog_out, but this one should have an index on the did field used for looking up the corresponding entries too. Altering this could have negative impact if there are old entries from a previous running process laying around. A duplicate key on an insert should be handled, and updated instead. The current behaviour would mean that Kamailio instead updates two records with the same values. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` master ``` * **Operating System**:  ``` CentOS 7.9 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3602 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3602(a)github.com>

2 2

git:master:664a788e: modules: readme files regenerated - ims_dialog ... [skip ci]
by Kamailio Dev 20 Oct '23

20 Oct '23

Module: kamailio Branch: master Commit: 664a788e9ed40c72f34310e65a5b6b85f80eead3 URL: https://github.com/kamailio/kamailio/commit/664a788e9ed40c72f34310e65a5b6b8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-10-20T20:16:19+02:00 modules: readme files regenerated - ims_dialog ... [skip ci] --- Modified: src/modules/ims_dialog/README --- Diff: https://github.com/kamailio/kamailio/commit/664a788e9ed40c72f34310e65a5b6b8… Patch: https://github.com/kamailio/kamailio/commit/664a788e9ed40c72f34310e65a5b6b8…

1 0

[kamailio/kamailio] ims_dialog: Add support for database backend (PR #3603)
by mtryfoss 20 Oct '23

20 Oct '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3602 #### Description Added missing code for database backend to work. Tested basic scenarios locally for all db modes. DB schema could be tweaked according to my thoughts in issue #3602, but that also applies to several other modules which are done in the same matter. Because of that, I didn't consider such a change now. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3603 -- Commit Summary -- * ims_dialog: Add support for database backend -- File Changes -- M src/modules/ims_dialog/dlg_db_handler.c (9) M src/modules/ims_dialog/dlg_handlers.c (52) M src/modules/ims_dialog/dlg_hash.c (5) M src/modules/ims_dialog/doc/ims_dialog_admin.xml (93) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3603.patch https://github.com/kamailio/kamailio/pull/3603.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3603 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3603(a)github.com>

2 6

git:master:cd54fdde: ims_dialog: Add support for database backend
by Daniel-Constantin Mierla 20 Oct '23

20 Oct '23

Module: kamailio Branch: master Commit: cd54fdde0572c62dc26fb8a8d11ddf60073a67a9 URL: https://github.com/kamailio/kamailio/commit/cd54fdde0572c62dc26fb8a8d11ddf6… Author: Morten Tryfoss <morten(a)tryfoss.no> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-10-20T20:11:09+02:00 ims_dialog: Add support for database backend --- Modified: src/modules/ims_dialog/dlg_db_handler.c Modified: src/modules/ims_dialog/dlg_handlers.c Modified: src/modules/ims_dialog/dlg_hash.c Modified: src/modules/ims_dialog/doc/ims_dialog_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/cd54fdde0572c62dc26fb8a8d11ddf6… Patch: https://github.com/kamailio/kamailio/commit/cd54fdde0572c62dc26fb8a8d11ddf6…

1 0

[kamailio/kamailio] Segfault tls.so on master branch when TLS_MALLOC_DBG is defined (Issue #3595)
by space88man 20 Oct '23

20 Oct '23

### Description Build kamailio master branch and define `TLS_MALLOC_DBG` in the `tls` module. There is an immediate segfault on startup. ### Troubleshooting Build kamailio master branch without `TLS_MALLOC_DBG` in the `tls` module. kamailio can start normally. #### Reproduction * use a distro with OpenSSL 3, e.g., AlmaLinux 9, Debian 12 * checkout kamailio master branch * in `src/modules/tls/tls_init.c` define `TLS_MALLOC_DBG` * build and run kamailio #### Debugging Data ``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in ?? () #1 0x00007efcca8f59ac in ser_malloc (size=56, file=0x7efc8a3399e3 "crypto/threads_pthread.c", line=50) at tls_init.c:269 #2 0x00007efc8a1b0b6e in CRYPTO_zalloc (num=56, file=<optimized out>, line=<optimized out>) at crypto/mem.c:197 #3 0x00007efc8a1bd7b4 in CRYPTO_THREAD_lock_new () at crypto/threads_pthread.c:50 #4 0x00007efc8a1b38cd in ossl_init_base () at crypto/init.c:64 #5 ossl_init_base_ossl_ () at crypto/init.c:55 #6 0x00007efcca6a4a48 in __pthread_once_slow (once_control=0x7efc8a42db84 <base>, init_routine=0x7efc8a1b38c0 <ossl_init_base_ossl_>) at pthread_once.c:117 #7 0x00007efc8a1bd92d in CRYPTO_THREAD_run_once (once=<optimized out>, init=<optimized out>) at crypto/threads_pthread.c:156 #8 0x00007efc8a1b823a in OPENSSL_init_crypto (settings=0x0, opts=131148) at crypto/init.c:507 #9 OPENSSL_init_crypto (opts=opts@entry=131148, settings=0x0) at crypto/init.c:462 #10 0x00007efcca84edf7 in OPENSSL_init_ssl (settings=<optimized out>, opts=131148) at ssl/ssl_init.c:115 #11 OPENSSL_init_ssl (opts=<optimized out>, settings=<optimized out>) at ssl/ssl_init.c:91 #12 0x00007efcca8f88ec in tls_h_mod_pre_init_f () at tls_init.c:767 #13 0x00000000006e5524 in pre_init_tls () at core/tls_hooks.c:68 #14 0x00000000004389d4 in main (argc=11, argv=0x7ffcb25aae08) at main.c:3141 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.0-dev1 (x86_64/linux) cd6d03 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: cd6d03 compiled on 08:53:04 Oct 7 2023 with gcc 11.3.1 ``` * **Operating System**: ``` NAME="AlmaLinux" VERSION="9.2 (Turquoise Kodkod)" ID="almalinux" ID_LIKE="rhel centos fedora" VERSION_ID="9.2" PLATFORM_ID="platform:el9" PRETTY_NAME="AlmaLinux 9.2 (Turquoise Kodkod)" ANSI_COLOR="0;34" LOGO="fedora-logo-icon" CPE_NAME="cpe:/o:almalinux:almalinux:9::baseos" HOME_URL="https://almalinux.org/" DOCUMENTATION_URL="https://wiki.almalinux.org/" BUG_REPORT_URL="https://bugs.almalinux.org/" ALMALINUX_MANTISBT_PROJECT="AlmaLinux-9" ALMALINUX_MANTISBT_PROJECT_VERSION="9.2" REDHAT_SUPPORT_PRODUCT="AlmaLinux" REDHAT_SUPPORT_PRODUCT_VERSION="9.2" 5.14.0-284.30.1.el9_2.x86_64 #1 SMP PREEMPT_DYNAMIC Tue Sep 12 09:28:32 EDT 2023 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3595 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3595(a)github.com>

2 3

← Newer
1
...
17
18
19
20
21
22
23
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2023