sr-dev November 2023

sr-dev@lists.kamailio.org

15 participants
394 discussions

git:master:721bfc88: devcontainer: add github-cli
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 721bfc880a7c01b1792e5770a26fc7d5fe4faa42 URL: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T22:46:07+01:00 devcontainer: add github-cli --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… Patch: https://github.com/kamailio/kamailio/commit/721bfc880a7c01b1792e5770a26fc7d… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index bc6019c6877..7ab1083ed00 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -10,7 +10,8 @@ // Features to add to the dev container. More info: https://containers.dev/features. "features": { - "ghcr.io/wxw-matt/devcontainer-features/command_runner:0": {} + "ghcr.io/wxw-matt/devcontainer-features/command_runner:0": {}, + "ghcr.io/devcontainers/features/github-cli:1": {} }, // Use 'forwardPorts' to make a list of ports inside the container available locally.

1 0

git:master:38585ea2: github: prebuild devcontainer image
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 38585ea29773543d9c2fe3559005487511ac90ce URL: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T22:45:54+01:00 github: prebuild devcontainer image --- Added: .github/workflows/devcontainer.yaml --- Diff: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… Patch: https://github.com/kamailio/kamailio/commit/38585ea29773543d9c2fe3559005487… --- diff --git a/.github/workflows/devcontainer.yaml b/.github/workflows/devcontainer.yaml new file mode 100644 index 00000000000..3321b4feec4 --- /dev/null +++ b/.github/workflows/devcontainer.yaml @@ -0,0 +1,56 @@ + +--- +name: build devcontainer image +'on': + push: + branches: + - master + # Allows you to run this workflow manually from the Actions tab + workflow_dispatch: + +env: + DIST: bookworm + +jobs: + build: + runs-on: ubuntu-latest + permissions: + contents: read + packages: write + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 2 + + - name: print latest_commit + run: echo ${{ github.sha }} + + - name: Get changed files + id: changed-files + uses: tj-actions/changed-files@v40 + with: + since_last_remote_commit: true + + - name: changes in relevant files + id: changed-files-builder + uses: tj-actions/changed-files@v40 + with: + files: | + .devcontainer/** + pkg/kamailio/deb/${{ env.DIST }}/** + + - name: Login to GitHub Container Registry + if: steps.changed-files-builder.outputs.any_changed == 'true' + uses: docker/login-action@v3 + with: + registry: ghcr.io + username: ${{ github.repository_owner }} + password: ${{ secrets.GITHUB_TOKEN }} + + - name: Pre-build dev container image + if: steps.changed-files-builder.outputs.any_changed == 'true' + uses: devcontainers/ci(a)v0.3 + with: + imageName: ghcr.io/${{ github.repository_owner }}/kamailio-${{ github.ref_name }}-devcontainer + cacheFrom: ghcr.io/${{ github.repository_owner }}/kamailio-${{ github.ref_name }}-devcontainer + push: always

1 0

git:master:9b4fe94d: devcontainer: add gitlens extension [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 9b4fe94d71c25e9ac3a43a5010a5dece7adaf14c URL: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T20:57:11+01:00 devcontainer: add gitlens extension [skip ci] --- Modified: .devcontainer/devcontainer.json --- Diff: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… Patch: https://github.com/kamailio/kamailio/commit/9b4fe94d71c25e9ac3a43a5010a5dec… --- diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index a0f156e25bb..bc6019c6877 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -25,6 +25,7 @@ "extensions": [ "ms-vscode.cpptools-extension-pack", "GitHub.vscode-github-actions", + "eamodio.gitlens", "xaver.clang-format" ] }

1 0

git:master:6aa940f7: dialplan: reformat exported structures more human friendly
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 6aa940f7acbc565545ae9199b288d16a50bafcab URL: https://github.com/kamailio/kamailio/commit/6aa940f7acbc565545ae9199b288d16… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T20:53:53+01:00 dialplan: reformat exported structures more human friendly revert to the format it had before 01d0d1de2c8 --- Modified: src/modules/dialplan/dialplan.c --- Diff: https://github.com/kamailio/kamailio/commit/6aa940f7acbc565545ae9199b288d16… Patch: https://github.com/kamailio/kamailio/commit/6aa940f7acbc565545ae9199b288d16… --- diff --git a/src/modules/dialplan/dialplan.c b/src/modules/dialplan/dialplan.c index 235158513f9..43aa6cd5a1b 100644 --- a/src/modules/dialplan/dialplan.c +++ b/src/modules/dialplan/dialplan.c @@ -96,47 +96,53 @@ int dp_append_branch = 1; int dp_reload_delta = 5; static time_t *dp_rpc_reload_time = NULL; +/* clang-format off */ +static param_export_t mod_params[]={ + { "db_url", PARAM_STR, &dp_db_url }, + { "table_name", PARAM_STR, &dp_table_name }, + { "dpid_col", PARAM_STR, &dpid_column }, + { "pr_col", PARAM_STR, &pr_column }, + { "match_op_col", PARAM_STR, &match_op_column }, + { "match_exp_col", PARAM_STR, &match_exp_column }, + { "match_len_col", PARAM_STR, &match_len_column }, + { "subst_exp_col", PARAM_STR, &subst_exp_column }, + { "repl_exp_col", PARAM_STR, &repl_exp_column }, + { "attrs_col", PARAM_STR, &attrs_column }, + { "attrs_pvar", PARAM_STR, &dp_attr_pvar_s }, + { "fetch_rows", PARAM_INT, &dp_fetch_rows }, + { "match_dynamic", PARAM_INT, &dp_match_dynamic }, + { "append_branch", PARAM_INT, &dp_append_branch }, + { "reload_delta", PARAM_INT, &dp_reload_delta }, + {0,0,0} +}; -static param_export_t mod_params[] = {{"db_url", PARAM_STR, &dp_db_url}, - {"table_name", PARAM_STR, &dp_table_name}, - {"dpid_col", PARAM_STR, &dpid_column}, - {"pr_col", PARAM_STR, &pr_column}, - {"match_op_col", PARAM_STR, &match_op_column}, - {"match_exp_col", PARAM_STR, &match_exp_column}, - {"match_len_col", PARAM_STR, &match_len_column}, - {"subst_exp_col", PARAM_STR, &subst_exp_column}, - {"repl_exp_col", PARAM_STR, &repl_exp_column}, - {"attrs_col", PARAM_STR, &attrs_column}, - {"attrs_pvar", PARAM_STR, &dp_attr_pvar_s}, - {"fetch_rows", PARAM_INT, &dp_fetch_rows}, - {"match_dynamic", PARAM_INT, &dp_match_dynamic}, - {"append_branch", PARAM_INT, &dp_append_branch}, - {"reload_delta", PARAM_INT, &dp_reload_delta}, {0, 0, 0}}; - -static cmd_export_t cmds[] = {{"dp_translate", (cmd_function)dp_translate_f, 2, - dp_trans_fixup, 0, ANY_ROUTE}, - {"dp_translate", (cmd_function)dp_translate_f, 1, dp_trans_fixup, 0, - ANY_ROUTE}, - {"dp_reload", (cmd_function)dp_reload_f, 0, 0, 0, ANY_ROUTE}, - {"dp_match", (cmd_function)w_dp_match, 2, fixup_igp_spve, - fixup_free_igp_spve, ANY_ROUTE}, - {"dp_replace", (cmd_function)w_dp_replace, 3, dp_replace_fixup, - dp_replace_fixup_free, ANY_ROUTE}, - {0, 0, 0, 0, 0, 0}}; - -struct module_exports exports = { - "dialplan", /* module's name */ - DEFAULT_DLFLAGS, /* dlopen flags */ - cmds, /* exported functions */ - mod_params, /* param exports */ - 0, /* exported RPC functions */ - 0, /* exported pseudo-variables */ - 0, /* reply processing function */ - mod_init, /* module initialization function */ - child_init, /* per-child init function */ - mod_destroy /* module destroy function */ +static cmd_export_t cmds[]={ + {"dp_translate",(cmd_function)dp_translate_f, 2, dp_trans_fixup, 0, + ANY_ROUTE}, + {"dp_translate",(cmd_function)dp_translate_f, 1, dp_trans_fixup, 0, + ANY_ROUTE}, + {"dp_reload",(cmd_function)dp_reload_f, 0, 0, 0, + ANY_ROUTE}, + {"dp_match",(cmd_function)w_dp_match, 2, fixup_igp_spve, + fixup_free_igp_spve, ANY_ROUTE}, + {"dp_replace",(cmd_function)w_dp_replace, 3, dp_replace_fixup, + dp_replace_fixup_free, ANY_ROUTE}, + {0,0,0,0,0,0} }; +struct module_exports exports= { + "dialplan", /* module's name */ + DEFAULT_DLFLAGS, /* dlopen flags */ + cmds, /* exported functions */ + mod_params, /* param exports */ + 0, /* exported RPC functions */ + 0, /* exported pseudo-variables */ + 0, /* reply processing function */ + mod_init, /* module initialization function */ + child_init, /* per-child init function */ + mod_destroy /* module destroy function */ +}; +/* clang-format on */ static int mod_init(void) {

1 0

git:master:4642a12c: debugger: reformat exported structures more human friendly
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 4642a12c109939f71f91ba7807ded1491e241e26 URL: https://github.com/kamailio/kamailio/commit/4642a12c109939f71f91ba7807ded14… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T20:03:49+01:00 debugger: reformat exported structures more human friendly revert to the format it had before 656e147c470 --- Modified: src/modules/debugger/debugger_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4642a12c109939f71f91ba7807ded14… Patch: https://github.com/kamailio/kamailio/commit/4642a12c109939f71f91ba7807ded14…

1 0

git:master:f0cf082e: dialog: reformat exported structures more human friendly
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: f0cf082effe6a0fd8893299e49a519d90bfc6151 URL: https://github.com/kamailio/kamailio/commit/f0cf082effe6a0fd8893299e49a519d… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T19:58:47+01:00 dialog: reformat exported structures more human friendly revert to the format it had before 783a416f1a5 --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/f0cf082effe6a0fd8893299e49a519d… Patch: https://github.com/kamailio/kamailio/commit/f0cf082effe6a0fd8893299e49a519d…

1 0

git:master:a62d7118: core: utils/srjson - use snprintf() for silenting analyzers
by Daniel-Constantin Mierla 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: a62d7118a2f86a82fd080ed4a89a0833e8c4d1a2 URL: https://github.com/kamailio/kamailio/commit/a62d7118a2f86a82fd080ed4a89a083… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-08T18:44:58+01:00 core: utils/srjson - use snprintf() for silenting analyzers --- Modified: src/core/utils/srjson.c --- Diff: https://github.com/kamailio/kamailio/commit/a62d7118a2f86a82fd080ed4a89a083… Patch: https://github.com/kamailio/kamailio/commit/a62d7118a2f86a82fd080ed4a89a083… --- diff --git a/src/core/utils/srjson.c b/src/core/utils/srjson.c index 76ef80a1555..5960932f545 100644 --- a/src/core/utils/srjson.c +++ b/src/core/utils/srjson.c @@ -205,20 +205,20 @@ static char *print_number(srjson_doc_t *doc, srjson_t *item) int i = (int)d; if(fabs(((double)i) - d) <= DBL_EPSILON && d <= INT_MAX && d >= INT_MIN) { str = (char *)doc->malloc_fn(21); /* 2^64+1 can be - * represented in 21 - * chars. */ + * represented in 20+1 + * chars (including 0-termination). */ if(str) - sprintf(str, "%d", i); + snprintf(str, 21, "%d", i); } else { str = (char *)doc->malloc_fn(64); /* This is a nice * tradeoff. */ if(str) { if(fabs(floor(d) - d) <= DBL_EPSILON) - sprintf(str, "%.0f", d); + snprintf(str, 21, "%.0f", d); else if(fabs(d) < 1.0e-6 || fabs(d) > 1.0e9) - sprintf(str, "%e", d); + snprintf(str, 21, "%e", d); else - sprintf(str, "%f", d); + snprintf(str, 21, "%f", d); } } return str; @@ -384,7 +384,7 @@ static char *print_string_ptr(srjson_doc_t *doc, const char *str) *ptr2++ = 't'; break; default: - sprintf(ptr2, "u%04x", token); + snprintf(ptr2, 6, "u%04x", token); ptr2 += 5; break; /* escape and print */ }

1 0

Github actions for opened issues and pull requests
by Daniel-Constantin Mierla 08 Nov '23

08 Nov '23

Hello, likely everyone on sr-dev likely noticed the rather large amount of github-actions notifications related to opened issues and pull requests, they happened because of trying to automatise/optimize tasks related to them and somehow keep both reporters and interested developers aware of items ageing. Enabling that action to see how it goes with it triggered rather large amount of notifications, because it worked also on existing items, not only on the future ones. Anyhow, if there is notification that an item is getting too old and nobody has interest on it, then it may be closed after a while, right now is 6 weeks notice of inactivity, plus 2 weeks to react on it -- these values can adjusted of course base on feedback. If there is interest in the item, simply the label stale can be removed. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and Development Services

2 2

git:master:8f84f668: topos: update headers for stateless cancel and non-2xx ack
by Daniel-Constantin Mierla 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: 8f84f6681570d5eb1018e6fe45f280173451bf62 URL: https://github.com/kamailio/kamailio/commit/8f84f6681570d5eb1018e6fe45f2801… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-08T11:06:53+01:00 topos: update headers for stateless cancel and non-2xx ack --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/8f84f6681570d5eb1018e6fe45f2801… Patch: https://github.com/kamailio/kamailio/commit/8f84f6681570d5eb1018e6fe45f2801… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 740f87b067f..0e697e8580e 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -1114,9 +1114,14 @@ int tps_request_sent(sip_msg_t *msg, int dialog, int local) if(tps_get_xuuid(msg, &xuuid) < 0) { LM_DBG("no x-uuid header - local message only - Call-ID mask if " "downstream \n"); - /* ACK and CANCEL go downstream so Call-ID mask required */ if(get_cseq(msg)->method_id == METHOD_ACK || get_cseq(msg)->method_id == METHOD_CANCEL) { + /* cover stateless forwarding */ + tps_remove_headers(msg, HDR_RECORDROUTE_T); + tps_remove_headers(msg, HDR_CONTACT_T); + tps_remove_headers(msg, HDR_VIA_T); + tps_reinsert_via(msg, &mtsd, &mtsd.x_via1); + /* ACK and CANCEL go downstream so Call-ID mask required */ tps_mask_callid(msg); } return 0;

1 0

git:master:e1c151fd: github: decrease operations-per-run [skip ci]
by Victor Seva 08 Nov '23

08 Nov '23

Module: kamailio Branch: master Commit: e1c151fdcb1da37f2cf2ffd76f364ec025a8d6e6 URL: https://github.com/kamailio/kamailio/commit/e1c151fdcb1da37f2cf2ffd76f364ec… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-08T09:50:03+01:00 github: decrease operations-per-run [skip ci] --- Modified: .github/workflows/issue_management.yml --- Diff: https://github.com/kamailio/kamailio/commit/e1c151fdcb1da37f2cf2ffd76f364ec… Patch: https://github.com/kamailio/kamailio/commit/e1c151fdcb1da37f2cf2ffd76f364ec… --- diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml index 142f63c2e1f..063df358c62 100644 --- a/.github/workflows/issue_management.yml +++ b/.github/workflows/issue_management.yml @@ -19,5 +19,5 @@ jobs: days-before-close: 14 exempt-issue-labels: bug remove-stale-when-updated: true - operations-per-run: 1000 + operations-per-run: 500 ascending: true

1 0

← Newer
1
...
32
33
34
35
36
37
38
39
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2023