sr-dev November 2023

sr-dev@lists.kamailio.org

15 participants
387 discussions

[kamailio/kamailio] wrong code for new mod param of pdt module (Issue #3626)

by doktorsip

### Description This new code in pdttree.c is not correct for this new pdt mode, it just print's a debug log instead of error. The return value should be 0 instead of 1 in case _pdt_mode is 1 otherwise it will still not start. <code> if(_pdt_mode & 1) { LM_DBG("prefix already allocated [%.*s/[%.*s] - ignoring\n", sp->len, sp->s, sd->len, sd->s); return -1; } else { LM_ERR("prefix already allocated [%.*s/[%.*s]\n", sp->len, sp->s, sd->len, sd->s); return -1; } </code> ### Troubleshooting #### Reproduction #### Debugging Data #### Log Messages #### SIP Traffic ### Possible Solutions ### Additional Information * **Operating System**: -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3626 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3626(a)github.com>

9 months, 2 weeks

git:master:ef5e889d: pdt: return 0 when add_to_tree() detect duplicated prefix with pdt mode 1

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ef5e889dce3e2ff077b300f183b6d3262aeab9f8 URL: https://github.com/kamailio/kamailio/commit/ef5e889dce3e2ff077b300f183b6d32… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-02T13:17:17+01:00 pdt: return 0 when add_to_tree() detect duplicated prefix with pdt mode 1 - GH #3626 --- Modified: src/modules/pdt/pdtree.c --- Diff: https://github.com/kamailio/kamailio/commit/ef5e889dce3e2ff077b300f183b6d32… Patch: https://github.com/kamailio/kamailio/commit/ef5e889dce3e2ff077b300f183b6d32… --- diff --git a/src/modules/pdt/pdtree.c b/src/modules/pdt/pdtree.c index b211ca6611d..5e60fe216e9 100644 --- a/src/modules/pdt/pdtree.c +++ b/src/modules/pdt/pdtree.c @@ -121,7 +121,7 @@ int add_to_tree(pdt_tree_t *pt, str *sp, str *sd) if(_pdt_mode & 1) { LM_DBG("prefix already allocated [%.*s/[%.*s] - ignoring\n", sp->len, sp->s, sd->len, sd->s); - return -1; + return 0; } else { LM_ERR("prefix already allocated [%.*s/[%.*s]\n", sp->len, sp->s, sd->len, sd->s);

9 months, 2 weeks

git:master:d9189306: modules: readme files regenerated - http_client ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: d9189306f38e8f79c16e3a9ea38a2fe90fc82fb7 URL: https://github.com/kamailio/kamailio/commit/d9189306f38e8f79c16e3a9ea38a2fe… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-11-02T13:16:27+01:00 modules: readme files regenerated - http_client ... [skip ci] --- Modified: src/modules/http_client/README --- Diff: https://github.com/kamailio/kamailio/commit/d9189306f38e8f79c16e3a9ea38a2fe… Patch: https://github.com/kamailio/kamailio/commit/d9189306f38e8f79c16e3a9ea38a2fe… --- diff --git a/src/modules/http_client/README b/src/modules/http_client/README index e10556dad09..6ffe4cab0cd 100644 --- a/src/modules/http_client/README +++ b/src/modules/http_client/README @@ -266,6 +266,13 @@ Chapter 1. Admin Guide 3.20. config_file (string) 3.21. netinterface (string) + The parameters are loaded in order. That can lead to unexpected + behavior: If httpcon is set at first, the default values for all other + parameters are used, and not the values that might be set after + httpcon. For example, if setting verify_peer=0 or verify_host=0 after + httpcon, the certificates are checked and self-signed certificates are + rejected nevertheless. + 3.1. httpredirect (int) If set to 1, enabled, http_client will follow HTTP 302 Redirects. If

9 months, 2 weeks

[kamailio/kamailio] cdp: Fix for undefined symbols when using older/unsupported OpenSSL (PR #3616)

by mtryfoss

This was originaly fixed in #3601, but that did not handle the change in #3612 very well.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Fix for undefined symbols when using older/unsupported OpenSSL. This was originaly fixed in #3601, but that did not handle the change in #3612 very well. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3616 -- Commit Summary -- * cdp: Fix for undefined symbols when using older/unsupported OpenSSL -- File Changes -- M src/modules/cdp/receiver.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3616.patch https://github.com/kamailio/kamailio/pull/3616.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3616 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3616(a)github.com>

9 months, 2 weeks

git:master:ba72724f: cdp: Fix for undefined symbols when using older/unsupported OpenSSL

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ba72724fd1c3547feccb56ae68bd8bed11a3d19a URL: https://github.com/kamailio/kamailio/commit/ba72724fd1c3547feccb56ae68bd8be… Author: Morten Tryfoss <morten(a)tryfoss.no> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-02T13:10:44+01:00 cdp: Fix for undefined symbols when using older/unsupported OpenSSL This was originaly fixed in #3601, but that did not handle the change in #3612 very well. --- Modified: src/modules/cdp/receiver.c --- Diff: https://github.com/kamailio/kamailio/commit/ba72724fd1c3547feccb56ae68bd8be… Patch: https://github.com/kamailio/kamailio/commit/ba72724fd1c3547feccb56ae68bd8be… --- diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index 223d14dd403..17200cf8143 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -533,6 +533,7 @@ void receiver_process(peer *p) static inline int do_read(serviced_peer_t *sp, char *dst, int n) { +#if OPENSSL_VERSION_NUMBER >= 0x10100000L int cnt, ssl_err; char *err_str; @@ -547,6 +548,11 @@ static inline int do_read(serviced_peer_t *sp, char *dst, int n) } else { cnt = recv(sp->tcp_socket, dst, n, 0); } +#else + int cnt; + + cnt = recv(sp->tcp_socket, dst, n, 0); +#endif return cnt; } @@ -684,6 +690,7 @@ static inline int do_receive(serviced_peer_t *sp) static int do_write(serviced_peer_t *sp, const void *buf, int num) { +#if OPENSSL_VERSION_NUMBER >= 0x10100000L int cnt, ssl_err; char *err_str; @@ -698,6 +705,11 @@ static int do_write(serviced_peer_t *sp, const void *buf, int num) } else { cnt = write(sp->tcp_socket, buf, num); } +#else + int cnt; + + cnt = write(sp->tcp_socket, buf, num); +#endif return cnt; }

9 months, 2 weeks

git:master:02dd4e2c: http_client: add information about parameter loading (#3619)

by GitHub

Module: kamailio Branch: master Commit: 02dd4e2c883585601f4dbcea0b63b858b4dd24d6 URL: https://github.com/kamailio/kamailio/commit/02dd4e2c883585601f4dbcea0b63b85… Author: Benjamin <92934023+tietzsg(a)users.noreply.github.com> Committer: GitHub <noreply(a)github.com> Date: 2023-11-02T13:09:57+01:00 http_client: add information about parameter loading (#3619) * http_client: add information about parameter loading - Inform that the order of the parameters is important when httpcon is loaded first * http_client: docs - typos from previous commit --------- Co-authored-by: Daniel-Constantin Mierla <miconda(a)gmail.com> --- Modified: src/modules/http_client/doc/http_client_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/02dd4e2c883585601f4dbcea0b63b85… Patch: https://github.com/kamailio/kamailio/commit/02dd4e2c883585601f4dbcea0b63b85… --- diff --git a/src/modules/http_client/doc/http_client_admin.xml b/src/modules/http_client/doc/http_client_admin.xml index 1449dc824d8..0e182cc95e3 100644 --- a/src/modules/http_client/doc/http_client_admin.xml +++ b/src/modules/http_client/doc/http_client_admin.xml @@ -88,6 +88,13 @@ <section> <title>Parameters</title> + <para> + The parameters are loaded in order. That can lead to unexpected behavior: + If httpcon is set at first, the default values for all other parameters are used, + and not the values that might be set after httpcon. + For example, if setting verify_peer=0 or verify_host=0 after httpcon, + the certificates are checked and self-signed certificates are rejected nevertheless. + </para> <section id="http_client.p.httpredirect"> <title><varname>httpredirect</varname> (int)</title> <para>

9 months, 2 weeks

[kamailio/kamailio] http_client: add information about parameter loading (PR #3619)

by Benjamin

- Inform that the order of the parameters is important when httpcon is loaded first #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3619 -- Commit Summary -- * http_client: add information about parameter loading -- File Changes -- M src/modules/http_client/doc/http_client_admin.xml (7) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3619.patch https://github.com/kamailio/kamailio/pull/3619.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3619 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3619(a)github.com>

9 months, 2 weeks

git:master:370991cf: core: accept ws and wss as advertised protocol

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 370991cfab3bd42fe0ca3cbff7dca7b40319f3f4 URL: https://github.com/kamailio/kamailio/commit/370991cfab3bd42fe0ca3cbff7dca7b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-02T10:25:52+01:00 core: accept ws and wss as advertised protocol --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/370991cfab3bd42fe0ca3cbff7dca7b… Patch: https://github.com/kamailio/kamailio/commit/370991cfab3bd42fe0ca3cbff7dca7b… --- diff --git a/src/core/cfg.y b/src/core/cfg.y index 98effbd9b75..9cfce12ce94 100644 --- a/src/core/cfg.y +++ b/src/core/cfg.y @@ -629,7 +629,7 @@ extern char *default_routename; %type <sockid> id_lst %type <sockid> phostport %type <sockid> listen_phostport -%type <intval> proto eqproto port +%type <intval> proto eqproto xproto port %type <intval> equalop strop cmpop rve_cmpop rve_equalop %type <intval> uri_type %type <attr> attr_id @@ -753,6 +753,15 @@ eqproto: | WSS { $$=PROTO_WSS; } | STAR { $$=0; } ; +xproto: + UDP { $$=PROTO_UDP; } + | TCP { $$=PROTO_TCP; } + | TLS { $$=PROTO_TLS; } + | SCTP { $$=PROTO_SCTP; } + | WS { $$=PROTO_WS; } + | WSS { $$=PROTO_WSS; } + ; + port: NUMBER { $$=$1; } | STAR { $$=0; } @@ -1665,7 +1674,7 @@ assign_stm: } free_socket_id_lst($3); } - | LISTEN EQUAL id_lst ADVERTISE proto COLON listen_id COLON NUMBER { + | LISTEN EQUAL id_lst ADVERTISE xproto COLON listen_id COLON NUMBER { for(lst_tmp=$3; lst_tmp; lst_tmp=lst_tmp->next) { if (add_listen_advertise_iface( lst_tmp->addr_lst->name, lst_tmp->addr_lst->next, @@ -1705,7 +1714,7 @@ assign_stm: } free_socket_id_lst($3); } - | LISTEN EQUAL id_lst ADVERTISE proto COLON listen_id COLON NUMBER STRNAME STRING { + | LISTEN EQUAL id_lst ADVERTISE xproto COLON listen_id COLON NUMBER STRNAME STRING { for(lst_tmp=$3; lst_tmp; lst_tmp=lst_tmp->next) { if (add_listen_advertise_iface_name(lst_tmp->addr_lst->name, lst_tmp->addr_lst->next, @@ -1732,7 +1741,7 @@ assign_stm: } free_socket_id_lst($3); } - | LISTEN EQUAL id_lst ADVERTISE proto COLON listen_id COLON NUMBER STRNAME STRING VIRTUAL { + | LISTEN EQUAL id_lst ADVERTISE xproto COLON listen_id COLON NUMBER STRNAME STRING VIRTUAL { for(lst_tmp=$3; lst_tmp; lst_tmp=lst_tmp->next) { lst_tmp->flags |= SI_IS_VIRTUAL; if (add_listen_advertise_iface_name(lst_tmp->addr_lst->name,

9 months, 2 weeks

git:master:b9a49de6: modules: readme files regenerated - tm ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: b9a49de69c9c184b7b3332a14ffaa85e60205ec2 URL: https://github.com/kamailio/kamailio/commit/b9a49de69c9c184b7b3332a14ffaa85… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-11-02T09:32:06+01:00 modules: readme files regenerated - tm ... [skip ci] --- Modified: src/modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/b9a49de69c9c184b7b3332a14ffaa85… Patch: https://github.com/kamailio/kamailio/commit/b9a49de69c9c184b7b3332a14ffaa85…

9 months, 2 weeks

git:master:f8981605: tm: docs for t_reply_error() function

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f8981605f01c755b963a9045a96e22398cca7201 URL: https://github.com/kamailio/kamailio/commit/f8981605f01c755b963a9045a96e223… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-02T09:29:41+01:00 tm: docs for t_reply_error() function --- Modified: src/modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/f8981605f01c755b963a9045a96e223… Patch: https://github.com/kamailio/kamailio/commit/f8981605f01c755b963a9045a96e223… --- diff --git a/src/modules/tm/doc/functions.xml b/src/modules/tm/doc/functions.xml index 7fa0ad83e93..7bcc3a43ccf 100644 --- a/src/modules/tm/doc/functions.xml +++ b/src/modules/tm/doc/functions.xml @@ -369,6 +369,27 @@ t_reply("404", "Not found"); </example> </section> + <section id="tm.f.t_reply_error"> + <title> + <function>t_reply_error()</function> + </title> + <para> + Sends a stateful reply based in internal error code, similar to + sl_send_error() from sl module. + </para> + <para> + This function can be used from REQUEST_ROUTE. + </para> + <example> + <title><function>t_reply_error</function> usage</title> + <programlisting> +... +t_reply_error(); +... + </programlisting> + </example> + </section> + <section id="tm.f.t_send_reply"> <title> <function>t_send_reply(code, reason)</function>

9 months, 2 weeks

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2023