sr-dev December 2023

sr-dev@lists.kamailio.org

14 participants
234 discussions

Start a nNew thread

Jenkins build is still unstable: kamailio57-nightly-binaries » amd64,stretch #39

by kamailio＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailio57-nightly-binaries/architecture=a…>

1 year

git:5.7:8674b333: core: parse privacy recompute lenght of rest to parse

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.7 Commit: 8674b333300d5829bff9cb4993886bcf7bea249b URL: https://github.com/kamailio/kamailio/commit/8674b333300d5829bff9cb4993886bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-08T22:12:01+01:00 core: parse privacy recompute lenght of rest to parse (cherry picked from commit 804ee651b45498727196886c97cb55d20b254c4a) --- Modified: src/core/parser/parse_privacy.c --- Diff: https://github.com/kamailio/kamailio/commit/8674b333300d5829bff9cb4993886bc… Patch: https://github.com/kamailio/kamailio/commit/8674b333300d5829bff9cb4993886bc… --- diff --git a/src/core/parser/parse_privacy.c b/src/core/parser/parse_privacy.c index 64431468675..89423c1dffa 100644 --- a/src/core/parser/parse_privacy.c +++ b/src/core/parser/parse_privacy.c @@ -178,14 +178,13 @@ int parse_privacy(struct sip_msg *msg) values = 0; p = next.s; - len = next.len; - beyond = p + len; + beyond = next.s + next.len; while(p < beyond) { + len = beyond - p; if((val_len = parse_priv_value(p, len, &value)) != 0) { values |= value; p = p + val_len; - len = len - val_len; } else { LM_ERR("invalid privacy value\n"); return -1;

1 year

git:master:804ee651: core: parse privacy recompute lenght of rest to parse

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 804ee651b45498727196886c97cb55d20b254c4a URL: https://github.com/kamailio/kamailio/commit/804ee651b45498727196886c97cb55d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-08T22:10:36+01:00 core: parse privacy recompute lenght of rest to parse --- Modified: src/core/parser/parse_privacy.c --- Diff: https://github.com/kamailio/kamailio/commit/804ee651b45498727196886c97cb55d… Patch: https://github.com/kamailio/kamailio/commit/804ee651b45498727196886c97cb55d… --- diff --git a/src/core/parser/parse_privacy.c b/src/core/parser/parse_privacy.c index 64431468675..89423c1dffa 100644 --- a/src/core/parser/parse_privacy.c +++ b/src/core/parser/parse_privacy.c @@ -178,14 +178,13 @@ int parse_privacy(struct sip_msg *msg) values = 0; p = next.s; - len = next.len; - beyond = p + len; + beyond = next.s + next.len; while(p < beyond) { + len = beyond - p; if((val_len = parse_priv_value(p, len, &value)) != 0) { values |= value; p = p + val_len; - len = len - val_len; } else { LM_ERR("invalid privacy value\n"); return -1;

1 year

[kamailio/kamailio] siptrace: add haproxy protocol support (Issue #3665)

by sergey-safarov

When used `tcp_accept_haproxy=yes` and inbound connection from load-balancer received via IPv6 protocol and client real IPv4 then i can see error in the kamailio log ``` 28(723055) ERROR: {1 27 REGISTER 4fkReTbLC-} siptrace [siptrace_hep.c:94]: trace_send_hep3_duplicate(): interworking detected ? ``` Looks like requried add haproxy protocol support into siptrace module -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3665 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3665(a)github.com>

1 year

[kamailio/kamailio] Redefine Advertised socket URI when used haproxy protocol (Issue #3667)

by sergey-safarov

### Description When used haproxy protocol then from client perspetive TCP connection established to loadbalancer IP address. Real Kamailio listener may be IPv6 and expected to see `$RAut` value with IP of load balancer IP. Really I can see for first message from the client ``` sip:2600::6:45060;transport=tcp ``` For second message ``` Advertised socket URI: sip:[2600::6]:5060 ``` For first case missed `[]` in the IP and expected to see loadbalancer IPv4 because client use IPv4 to establish connection to Kamailio. ### Expected behavior Used loadbalancerserver IP from haproxy protocol for `$RAut` value and for `Record-Route` headers generation. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3667 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3667(a)github.com>

1 year

git:master:5d97afef: core: xavp - info long when skipping serializing a field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5d97afefd2a8f53072a36b6eb8927c180fb984c9 URL: https://github.com/kamailio/kamailio/commit/5d97afefd2a8f53072a36b6eb8927c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-08T16:23:03+01:00 core: xavp - info long when skipping serializing a field --- Modified: src/core/xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/5d97afefd2a8f53072a36b6eb8927c1… Patch: https://github.com/kamailio/kamailio/commit/5d97afefd2a8f53072a36b6eb8927c1… --- diff --git a/src/core/xavp.c b/src/core/xavp.c index 58f3a567611..128ea631013 100644 --- a/src/core/xavp.c +++ b/src/core/xavp.c @@ -1184,7 +1184,8 @@ int xavp_serialize_fields_style(str *rname, int mode, char *obuf, int olen) } break; default: - LM_DBG("skipping value type: %d\n", avp->val.type); + LM_INFO("skipping field [%.*s] value type: %d\n", avp->name.len, + avp->name.s, avp->val.type); ostr.len = 0; } if(ostr.len > 0) { @@ -1678,7 +1679,8 @@ int xavu_serialize_fields(str *rname, char *obuf, int olen) } break; default: - LM_DBG("skipping value type: %d\n", avu->val.type); + LM_INFO("skipping field [%.*s] value type: %d\n", avu->name.len, + avu->name.s, avu->val.type); ostr.len = 0; } if(ostr.len > 0) { @@ -2652,7 +2654,8 @@ int xavi_serialize_fields(str *rname, char *obuf, int olen) } break; default: - LM_DBG("skipping value type: %d\n", avi->val.type); + LM_INFO("skipping field [%.*s] value type: %d\n", avi->name.len, + avi->name.s, avi->val.type); ostr.len = 0; } if(ostr.len > 0) {

1 year

[kamailio/kamailio] TOPOS callid masking (Issue #3606)

by Dennis

### Description PKG memory errors when configured mask_callid in TOPOS. ### Troubleshooting The poblem in detail desribed in mailing lists: https://www.mail-archive.com/sr-users@lists.kamailio.org/msg19997.html ### Possible Solutions Right way to configure topos for callid masking is: modparam("topoh", "use_mode", 1) modparam("topos", "mask_callid", 1) modparam("topoh", "mask_callid", 1) We need to set mask_callid module parameter for topoh also. There is not a word about this in the documentation, so docs correction needed. ### Additional Information * **Kamailio Version** - 5.7.X -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3606 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3606(a)github.com>

1 year

[kamailio/kamailio] pv: Add support to $hfl $hflc for Diversion header (PR #3651)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This PR adds support for $hfl(Diversion)[] and $hflc(Diversion). This parse_diversion.c was inspired by [parse_pai_ppi.c](https://github.com/kamailio/kamailio/blob/master/src/core/…. I am not sure if it's breaking the existing implementation and usage. Any feedback and review is welcome. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3651 -- Commit Summary -- * parser: Extend diversion for multiple bodies * pv: Add hfl and hflc support for Diversion header -- File Changes -- M src/core/parser/parse_diversion.c (152) M src/core/parser/parse_diversion.h (11) M src/modules/pv/pv_core.c (71) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3651.patch https://github.com/kamailio/kamailio/pull/3651.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3651 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3651(a)github.com>

1 year

[kamailio/kamailio] pv: Add support in $hfl and $hflc pv for PPI and PAI headers (PR #3652)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This PR adds support for $hfl(name)[] and $hflc(name) for P-Preferred-Identity and P-Asserted-Identity. Should probably also be documented in https://www.kamailio.org/wikidocs/cookbooks/devel/pseudovariables/#hflname-… Any feedback welcome. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3652 -- Commit Summary -- * pv: Add PPI and PAI support to hfl and hflc -- File Changes -- M src/modules/pv/pv_core.c (104) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3652.patch https://github.com/kamailio/kamailio/pull/3652.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3652 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3652(a)github.com>

1 year

[kamailio/kamailio] Segfault with tls init_mode 1 (Issue #3668)

by Bastian Triller

### Description Kamailio chrashes on startup when set init_mode to 1. Seems to be introduced with 4b068f49b618dca5fa85a1687bd9054c1d98ae6a  ### Troubleshooting #### Reproduction modparam("tls", "init_mode", 1)  #### Debugging Data  ``` #0 ___pthread_mutex_lock (mutex=0x0) at ./nptl/pthread_mutex_lock.c:80 #1 0x00007f9e93510614 in ser_malloc (size=56, fname=<optimized out>, fline=<optimized out>) at ./src/modules/tls/tls_init.c:388 #2 0x00007f9e93031b59 in CRYPTO_zalloc (num=num@entry=56, file=file@entry=0x7f9e9317563d "../crypto/threads_pthread.c", line=line@entry=50) at ../crypto/mem.c:197 #3 0x00007f9e9303dedf in CRYPTO_THREAD_lock_new () at ../crypto/threads_pthread.c:50 #4 0x00007f9e93030ad9 in ossl_init_base () at ../crypto/init.c:64 #5 ossl_init_base_ossl_ () at ../crypto/init.c:55 #6 0x00007f9e97affea7 in __pthread_once_slow (once_control=0x7f9e9327edcc <base>, init_routine=0x7f9e93030ad0 <ossl_init_base_ossl_>) at ./nptl/pthread_once.c:116 #7 0x00007f9e97afff85 in ___pthread_once (once_control=<optimized out>, init_routine=<optimized out>) at ./nptl/pthread_once.c:143 #8 0x00007f9e9303dfc9 in CRYPTO_THREAD_run_once (once=once@entry=0x7f9e9327edcc <base>, init=init@entry=0x7f9e93030ad0 <ossl_init_base_ossl_>) at ../crypto/threads_pthread.c:154 #9 0x00007f9e93030d48 in OPENSSL_init_crypto (opts=opts@entry=131148, settings=settings@entry=0x0) at ../crypto/init.c:507 #10 0x00007f9e93473a21 in OPENSSL_init_ssl (opts=131148, opts@entry=131072, settings=settings@entry=0x0) at ../ssl/ssl_init.c:115 #11 0x00007f9e93511f44 in tls_h_mod_pre_init_f () at ./src/modules/tls/tls_init.c:779 #12 0x000055c792122571 in main (argc=<optimized out>, argv=0x7ffd43d1a338) at ./src/main.c:3174 ``` #### Log Messages  ``` [ 1803.304680] kamailio[7700]: segfault at 10 ip 00007fe7b62c91c0 sp 00007ffd499a0db8 error 4 in libc.so.6[7fe7b6263000+155000] likely on CPU 1 (core 0, socket 1) [ 1803.304698] Code: 30 11 00 ba c2 01 00 00 48 8d 35 47 ad 10 00 48 8d 3d 55 ad 10 00 e8 3f 8c fa ff e8 4a bd 08 00 66 2e 0f 1f 84 00 00 00 00 00 <8b> 47 10 89 c2 81 e2 7f 01 00 00 83 e0 7c 0f 85 ac 00 00 00 53 48 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.3 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` ``` version: kamailio 5.8.0-dev2 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 12.2.0 ``` * **Operating System**:  ``` % cat /etc/os-release PRETTY_NAME="Debian GNU/Linux 12 (bookworm)" NAME="Debian GNU/Linux" VERSION_ID="12" VERSION="12 (bookworm)" VERSION_CODENAME=bookworm ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/" ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3668 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3668(a)github.com>

1 year

← Newer
1
...
16
17
18
19
20
21
22
23
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2023