sr-dev December 2023

sr-dev@lists.kamailio.org

14 participants
237 discussions

git:master:9db18bc4: dialog: check first the size
by Daniel-Constantin Mierla 11 Dec '23

11 Dec '23

Module: kamailio Branch: master Commit: 9db18bc48bff0d230e66973a45c8e72e1b7744e8 URL: https://github.com/kamailio/kamailio/commit/9db18bc48bff0d230e66973a45c8e72… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-11T10:07:39+01:00 dialog: check first the size --- Modified: src/modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/9db18bc48bff0d230e66973a45c8e72… Patch: https://github.com/kamailio/kamailio/commit/9db18bc48bff0d230e66973a45c8e72… --- diff --git a/src/modules/dialog/dlg_var.c b/src/modules/dialog/dlg_var.c index 10df9e90c3e..db5f61c4e05 100644 --- a/src/modules/dialog/dlg_var.c +++ b/src/modules/dialog/dlg_var.c @@ -667,8 +667,8 @@ int pv_set_dlg_ctx( break; case 4: if(val && val->flags & PV_VAL_STR) { - if(val->rs.s[val->rs.len] == '\0' - && val->rs.len < DLG_TOROUTE_SIZE) { + if(val->rs.len < DLG_TOROUTE_SIZE + && val->rs.s[val->rs.len] == '\0') { _dlg_ctx.to_route = route_lookup(&main_rt, val->rs.s); strcpy(_dlg_ctx.to_route_name, val->rs.s); } else {

1 0

git:master:e614575d: sca: check return for snprintf()
by Daniel-Constantin Mierla 11 Dec '23

11 Dec '23

Module: kamailio Branch: master Commit: e614575d53f5e3b7d3a4796a445728f862e60916 URL: https://github.com/kamailio/kamailio/commit/e614575d53f5e3b7d3a4796a445728f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-11T09:53:48+01:00 sca: check return for snprintf() --- Modified: src/modules/sca/sca_call_info.c --- Diff: https://github.com/kamailio/kamailio/commit/e614575d53f5e3b7d3a4796a445728f… Patch: https://github.com/kamailio/kamailio/commit/e614575d53f5e3b7d3a4796a445728f… --- diff --git a/src/modules/sca/sca_call_info.c b/src/modules/sca/sca_call_info.c index a1af143c017..2694239cb9f 100644 --- a/src/modules/sca/sca_call_info.c +++ b/src/modules/sca/sca_call_info.c @@ -112,6 +112,7 @@ static int sca_call_info_header_append_appearances( str state_str; int slot_idx; int len = -1; + int l1 = -1; int usedlen = -1; slot_idx = @@ -153,9 +154,14 @@ static int sca_call_info_header_append_appearances( sca_appearance_state_to_str(app->state, &state_str); // state_str.s is a nul-terminated string literal - len += snprintf(hdrbuf + len, maxlen - len, + l1 = snprintf(hdrbuf + len, maxlen - len, ">;appearance-index=%d;appearance-state=%s", app->index, state_str.s); + if(l1 < 0 || l1 >= maxlen - len) { + LM_ERR("failed to print the header\n"); + return -1; + } + len += l1; if(!SCA_STR_EMPTY(&app->uri)) { hdrbuf[len] = ';';

1 0

[kamailio/kamailio] Add support for Linux kernel anyIP feature (Issue #3394)
by mohsen 09 Dec '23

09 Dec '23

Hi I have a kimailio box that receives messages from one interface and send it from another interface and I use dispatcher module successfully. Now I assigned an I range to Linux loopback interface through Linux kernel anyip feature. And I can ping the range. ip -4 route add local 192.168.0.0/24 dev lo I want to send messages from source of the ip in this range but kamailio cant do this in the right way. I added this two directives to kamailio.cfg: mhomed=yes ip_free_bind = 1 and when I want to use an ip from the list I use $fs=”udp:192.168.0.120:5060”; With no luck If I use force_send_socket(udp:192.168.0.120:5060); kamailio returns an error bad force_send_socket argument: 192.168.0.120:5060 (kamailio doesn't listen on it) and if I add listen directive for one ip like: listen=udp:192.168.0.120:5060 everything works fine but I want to be able to use any ip from list not just one ip. Thanks. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3394 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3394(a)github.com>

6 10

Jenkins build is still unstable: kamailio57-nightly-binaries » amd64,stretch #39
by kamailio＠sipwise.com 09 Dec '23

09 Dec '23

See <https://kamailio.sipwise.com/job/kamailio57-nightly-binaries/architecture=a…>

1 0

git:5.7:8674b333: core: parse privacy recompute lenght of rest to parse
by Daniel-Constantin Mierla 08 Dec '23

08 Dec '23

Module: kamailio Branch: 5.7 Commit: 8674b333300d5829bff9cb4993886bcf7bea249b URL: https://github.com/kamailio/kamailio/commit/8674b333300d5829bff9cb4993886bc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-08T22:12:01+01:00 core: parse privacy recompute lenght of rest to parse (cherry picked from commit 804ee651b45498727196886c97cb55d20b254c4a) --- Modified: src/core/parser/parse_privacy.c --- Diff: https://github.com/kamailio/kamailio/commit/8674b333300d5829bff9cb4993886bc… Patch: https://github.com/kamailio/kamailio/commit/8674b333300d5829bff9cb4993886bc… --- diff --git a/src/core/parser/parse_privacy.c b/src/core/parser/parse_privacy.c index 64431468675..89423c1dffa 100644 --- a/src/core/parser/parse_privacy.c +++ b/src/core/parser/parse_privacy.c @@ -178,14 +178,13 @@ int parse_privacy(struct sip_msg *msg) values = 0; p = next.s; - len = next.len; - beyond = p + len; + beyond = next.s + next.len; while(p < beyond) { + len = beyond - p; if((val_len = parse_priv_value(p, len, &value)) != 0) { values |= value; p = p + val_len; - len = len - val_len; } else { LM_ERR("invalid privacy value\n"); return -1;

1 0

git:master:804ee651: core: parse privacy recompute lenght of rest to parse
by Daniel-Constantin Mierla 08 Dec '23

08 Dec '23

Module: kamailio Branch: master Commit: 804ee651b45498727196886c97cb55d20b254c4a URL: https://github.com/kamailio/kamailio/commit/804ee651b45498727196886c97cb55d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-08T22:10:36+01:00 core: parse privacy recompute lenght of rest to parse --- Modified: src/core/parser/parse_privacy.c --- Diff: https://github.com/kamailio/kamailio/commit/804ee651b45498727196886c97cb55d… Patch: https://github.com/kamailio/kamailio/commit/804ee651b45498727196886c97cb55d… --- diff --git a/src/core/parser/parse_privacy.c b/src/core/parser/parse_privacy.c index 64431468675..89423c1dffa 100644 --- a/src/core/parser/parse_privacy.c +++ b/src/core/parser/parse_privacy.c @@ -178,14 +178,13 @@ int parse_privacy(struct sip_msg *msg) values = 0; p = next.s; - len = next.len; - beyond = p + len; + beyond = next.s + next.len; while(p < beyond) { + len = beyond - p; if((val_len = parse_priv_value(p, len, &value)) != 0) { values |= value; p = p + val_len; - len = len - val_len; } else { LM_ERR("invalid privacy value\n"); return -1;

1 0

[kamailio/kamailio] siptrace: add haproxy protocol support (Issue #3665)
by sergey-safarov 08 Dec '23

08 Dec '23

When used `tcp_accept_haproxy=yes` and inbound connection from load-balancer received via IPv6 protocol and client real IPv4 then i can see error in the kamailio log ``` 28(723055) ERROR: {1 27 REGISTER 4fkReTbLC-} siptrace [siptrace_hep.c:94]: trace_send_hep3_duplicate(): interworking detected ? ``` Looks like requried add haproxy protocol support into siptrace module -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3665 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3665(a)github.com>

2 2

[kamailio/kamailio] Redefine Advertised socket URI when used haproxy protocol (Issue #3667)
by sergey-safarov 08 Dec '23

08 Dec '23

### Description When used haproxy protocol then from client perspetive TCP connection established to loadbalancer IP address. Real Kamailio listener may be IPv6 and expected to see `$RAut` value with IP of load balancer IP. Really I can see for first message from the client ``` sip:2600::6:45060;transport=tcp ``` For second message ``` Advertised socket URI: sip:[2600::6]:5060 ``` For first case missed `[]` in the IP and expected to see loadbalancer IPv4 because client use IPv4 to establish connection to Kamailio. ### Expected behavior Used loadbalancerserver IP from haproxy protocol for `$RAut` value and for `Record-Route` headers generation. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3667 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3667(a)github.com>

2 2

git:master:5d97afef: core: xavp - info long when skipping serializing a field
by Daniel-Constantin Mierla 08 Dec '23

08 Dec '23

Module: kamailio Branch: master Commit: 5d97afefd2a8f53072a36b6eb8927c180fb984c9 URL: https://github.com/kamailio/kamailio/commit/5d97afefd2a8f53072a36b6eb8927c1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-08T16:23:03+01:00 core: xavp - info long when skipping serializing a field --- Modified: src/core/xavp.c --- Diff: https://github.com/kamailio/kamailio/commit/5d97afefd2a8f53072a36b6eb8927c1… Patch: https://github.com/kamailio/kamailio/commit/5d97afefd2a8f53072a36b6eb8927c1… --- diff --git a/src/core/xavp.c b/src/core/xavp.c index 58f3a567611..128ea631013 100644 --- a/src/core/xavp.c +++ b/src/core/xavp.c @@ -1184,7 +1184,8 @@ int xavp_serialize_fields_style(str *rname, int mode, char *obuf, int olen) } break; default: - LM_DBG("skipping value type: %d\n", avp->val.type); + LM_INFO("skipping field [%.*s] value type: %d\n", avp->name.len, + avp->name.s, avp->val.type); ostr.len = 0; } if(ostr.len > 0) { @@ -1678,7 +1679,8 @@ int xavu_serialize_fields(str *rname, char *obuf, int olen) } break; default: - LM_DBG("skipping value type: %d\n", avu->val.type); + LM_INFO("skipping field [%.*s] value type: %d\n", avu->name.len, + avu->name.s, avu->val.type); ostr.len = 0; } if(ostr.len > 0) { @@ -2652,7 +2654,8 @@ int xavi_serialize_fields(str *rname, char *obuf, int olen) } break; default: - LM_DBG("skipping value type: %d\n", avi->val.type); + LM_INFO("skipping field [%.*s] value type: %d\n", avi->name.len, + avi->name.s, avi->val.type); ostr.len = 0; } if(ostr.len > 0) {

1 0

[kamailio/kamailio] TOPOS callid masking (Issue #3606)
by Dennis 08 Dec '23

08 Dec '23

### Description PKG memory errors when configured mask_callid in TOPOS. ### Troubleshooting The poblem in detail desribed in mailing lists: https://www.mail-archive.com/sr-users@lists.kamailio.org/msg19997.html ### Possible Solutions Right way to configure topos for callid masking is: modparam("topoh", "use_mode", 1) modparam("topos", "mask_callid", 1) modparam("topoh", "mask_callid", 1) We need to set mask_callid module parameter for topoh also. There is not a word about this in the documentation, so docs correction needed. ### Additional Information * **Kamailio Version** - 5.7.X -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3606 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3606(a)github.com>

3 5

← Newer
1
...
16
17
18
19
20
21
22
23
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2023