sr-dev February 2023

sr-dev@lists.kamailio.org

10 participants
297 discussions

git:master:d2e73f9c: dmq_usrloc: check if socket name is set when replicating
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: d2e73f9c51630f47fa7660b4c4831fcecd661f87 URL: https://github.com/kamailio/kamailio/commit/d2e73f9c51630f47fa7660b4c4831fc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:20:37+01:00 dmq_usrloc: check if socket name is set when replicating --- Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/d2e73f9c51630f47fa7660b4c4831fc… Patch: https://github.com/kamailio/kamailio/commit/d2e73f9c51630f47fa7660b4c4831fc… --- diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index dd2a7f2f42..62477198a2 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -692,7 +692,7 @@ int usrloc_dmq_send_multi_contact(ucontact_t* ptr, str aor, int action, dmq_node srjson_AddStrToObject(jdoc, jdoc_contact, "sock", ptr->sock->sock_str.s, ptr->sock->sock_str.len); jdoc_contact_group.size += ptr->sock->sock_str.len; } - else if (_dmq_usrloc_replicate_socket_info==DMQ_USRLOC_REPLICATE_SOCKNAME) { + else if (_dmq_usrloc_replicate_socket_info==DMQ_USRLOC_REPLICATE_SOCKNAME && ptr->sock!=NULL && ptr->sock->sockname.s!=NULL) { srjson_AddStrToObject(jdoc, jdoc_contact, "sockname", ptr->sock->sockname.s, ptr->sock->sockname.len); jdoc_contact_group.size += ptr->sock->sockname.len; }

1 0

[kamailio/kamailio] dmq_usrloc: Add option to replicate socket via its name (PR #3364)
by Bastian Triller 13 Feb '23

13 Feb '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description  Allow replicating location's socket via its name. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3364 -- Commit Summary -- * dmq_usrloc: Add option to replicate socket via its name -- File Changes -- M src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml (9) M src/modules/dmq_usrloc/usrloc_sync.c (24) M src/modules/dmq_usrloc/usrloc_sync.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3364.patch https://github.com/kamailio/kamailio/pull/3364.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3364 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3364(a)github.com>

2 2

git:master:353d7e6a: dmq_usrloc: Add option to replicate socket via its name
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: 353d7e6a5f8d751fc647fd687716cc2e0fb1aa77 URL: https://github.com/kamailio/kamailio/commit/353d7e6a5f8d751fc647fd687716cc2… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:18:09+01:00 dmq_usrloc: Add option to replicate socket via its name --- Modified: src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml Modified: src/modules/dmq_usrloc/usrloc_sync.c Modified: src/modules/dmq_usrloc/usrloc_sync.h --- Diff: https://github.com/kamailio/kamailio/commit/353d7e6a5f8d751fc647fd687716cc2… Patch: https://github.com/kamailio/kamailio/commit/353d7e6a5f8d751fc647fd687716cc2…

1 0

git:master:cc234290: modules: readme files regenerated - imc ... [skip ci]
by Kamailio Dev 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: cc2342908d08ee5322fd6830b0db9fd762bef38f URL: https://github.com/kamailio/kamailio/commit/cc2342908d08ee5322fd6830b0db9fd… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-02-13T12:17:06+01:00 modules: readme files regenerated - imc ... [skip ci] --- Modified: src/modules/imc/README Modified: src/modules/ims_auth/README Modified: src/modules/ims_charging/README Modified: src/modules/ims_dialog/README Modified: src/modules/ims_diameter_server/README Modified: src/modules/ims_icscf/README Modified: src/modules/ims_ipsec_pcscf/README Modified: src/modules/ims_isc/README Modified: src/modules/ims_qos/README Modified: src/modules/ims_registrar_pcscf/README Modified: src/modules/ims_registrar_scscf/README --- Diff: https://github.com/kamailio/kamailio/commit/cc2342908d08ee5322fd6830b0db9fd… Patch: https://github.com/kamailio/kamailio/commit/cc2342908d08ee5322fd6830b0db9fd…

1 0

git:master:c28b3a0a: ipops: typos
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: c28b3a0ae61c9fd1fc8e8b2972686a0f8424c44a URL: https://github.com/kamailio/kamailio/commit/c28b3a0ae61c9fd1fc8e8b2972686a0… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ipops: typos --- Modified: src/modules/ipops/ipops_mod.c Modified: src/modules/ipops/ipops_pv.c --- Diff: https://github.com/kamailio/kamailio/commit/c28b3a0ae61c9fd1fc8e8b2972686a0… Patch: https://github.com/kamailio/kamailio/commit/c28b3a0ae61c9fd1fc8e8b2972686a0… --- diff --git a/src/modules/ipops/ipops_mod.c b/src/modules/ipops/ipops_mod.c index d9f01317e5..a9f3962f61 100644 --- a/src/modules/ipops/ipops_mod.c +++ b/src/modules/ipops/ipops_mod.c @@ -695,7 +695,7 @@ static int ki_is_ip6_reference(sip_msg_t *msg, str *sval) } /*! \brief Return the IP type of the given argument (string or pv): - * 1 = IPv4, 2 = IPv6, 3 = IPv6 refenrece, -1 = invalid IP. */ + * 1 = IPv4, 2 = IPv6, 3 = IPv6 reference, -1 = invalid IP. */ static int w_ip_type(sip_msg_t* _msg, char* _s, char *_p2) { str string; @@ -728,7 +728,7 @@ static int w_ip_type(sip_msg_t* _msg, char* _s, char *_p2) } /*! \brief Return the IP type of the given argument (string or pv): - * 1 = IPv4, 2 = IPv6, 3 = IPv6 refenrece, -1 = invalid IP. */ + * 1 = IPv4, 2 = IPv6, 3 = IPv6 reference, -1 = invalid IP. */ static int ki_ip_type(sip_msg_t *msg, str *sval) { switch (ip_parser_execute(sval->s, sval->len)) { @@ -990,7 +990,7 @@ static int w_compare_pure_ips(sip_msg_t* _msg, char* _s1, char* _s2) } /*! \brief Return true if the first IP (string or pv) is within the subnet - * defined by the second commma-separated IP list in CIDR notation. + * defined by the second comma-separated IP list in CIDR notation. * IPv6 references not allowed. */ static int ki_ip_is_in_subnet(sip_msg_t* _msg, str* _sval1, str* _sval2) { @@ -1042,7 +1042,7 @@ static int ki_ip_is_in_subnet(sip_msg_t* _msg, str* _sval1, str* _sval2) /*! \brief Return true if the first IP (string or pv) is within the subnet - * defined by the second commma-separated IP list in CIDR notation. + * defined by the second comma-separated IP list in CIDR notation. * IPv6 references not allowed. */ static int w_ip_is_in_subnet(sip_msg_t* _msg, char* _s1, char* _s2) { diff --git a/src/modules/ipops/ipops_pv.c b/src/modules/ipops/ipops_pv.c index 9ee6f5879a..4eabbcac86 100644 --- a/src/modules/ipops/ipops_pv.c +++ b/src/modules/ipops/ipops_pv.c @@ -109,7 +109,7 @@ sr_dns_item_t *sr_dns_add_item(str *name) n++; } if(n > 20) { - LM_WARN("too many dns containers - adding nunmber %d - can fill memory\n", + LM_WARN("too many dns containers - adding number %d - can fill memory\n", n); }

1 0

git:master:398cf4dd: ims_usrloc_scscf: typos
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: 398cf4dd9645f8a9f7a1e4f1bb9659814bc2d041 URL: https://github.com/kamailio/kamailio/commit/398cf4dd9645f8a9f7a1e4f1bb96598… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_usrloc_scscf: typos --- Modified: src/modules/ims_usrloc_scscf/bin_utils.c Modified: src/modules/ims_usrloc_scscf/impurecord.c Modified: src/modules/ims_usrloc_scscf/subscribe.c Modified: src/modules/ims_usrloc_scscf/udomain.c Modified: src/modules/ims_usrloc_scscf/ul_callback.h Modified: src/modules/ims_usrloc_scscf/usrloc.h --- Diff: https://github.com/kamailio/kamailio/commit/398cf4dd9645f8a9f7a1e4f1bb96598… Patch: https://github.com/kamailio/kamailio/commit/398cf4dd9645f8a9f7a1e4f1bb96598…

1 0

git:master:94c1fa31: ims_usrloc_pcscf: typos
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: 94c1fa3123042e1f262750e2b23fad640717c5e1 URL: https://github.com/kamailio/kamailio/commit/94c1fa3123042e1f262750e2b23fad6… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_usrloc_pcscf: typos --- Modified: src/modules/ims_usrloc_pcscf/reginfo.h Modified: src/modules/ims_usrloc_pcscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/94c1fa3123042e1f262750e2b23fad6… Patch: https://github.com/kamailio/kamailio/commit/94c1fa3123042e1f262750e2b23fad6… --- diff --git a/src/modules/ims_usrloc_pcscf/reginfo.h b/src/modules/ims_usrloc_pcscf/reginfo.h index 9bc8873c4e..f0a3f84742 100644 --- a/src/modules/ims_usrloc_pcscf/reginfo.h +++ b/src/modules/ims_usrloc_pcscf/reginfo.h @@ -61,7 +61,7 @@ typedef struct _reginfo_subscription { /** Subscription list */ typedef struct { - gen_lock_t *lock; /**< lock fo subscription list operations */ + gen_lock_t *lock; /**< lock for subscription list operations */ reginfo_subscription *head; /**< first subscription in the list */ reginfo_subscription *tail; /**< last subscription in the list */ } reginfo_subscription_hash_slot; diff --git a/src/modules/ims_usrloc_pcscf/udomain.c b/src/modules/ims_usrloc_pcscf/udomain.c index efb19e6291..97fc3fbe97 100644 --- a/src/modules/ims_usrloc_pcscf/udomain.c +++ b/src/modules/ims_usrloc_pcscf/udomain.c @@ -444,7 +444,7 @@ int insert_pcontact(struct udomain* _d, str* _contact, struct pcontact_info* _ci * search for P-CSCF contact in usrloc * @udomain_t* _d - domain to search in * @str* _contact - contact to search for - should be a SIP URI - * @struct pontact** _c - contact to return to if found (null if not found) + * @struct pcontact** _c - contact to return to if found (null if not found) * @int reverse_search - reverse search for a contact in the memory * @return 0 if found <>0 if not */

1 0

git:master:b89353cd: ims_registrar_pcscf: typos
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: b89353cd766769552655f16a44d44ea0e55a8fea URL: https://github.com/kamailio/kamailio/commit/b89353cd766769552655f16a44d44ea… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_registrar_pcscf: typos --- Modified: src/modules/ims_registrar_pcscf/async_reginfo.c Modified: src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml Modified: src/modules/ims_registrar_pcscf/save.h Modified: src/modules/ims_registrar_pcscf/service_routes.c --- Diff: https://github.com/kamailio/kamailio/commit/b89353cd766769552655f16a44d44ea… Patch: https://github.com/kamailio/kamailio/commit/b89353cd766769552655f16a44d44ea… --- diff --git a/src/modules/ims_registrar_pcscf/async_reginfo.c b/src/modules/ims_registrar_pcscf/async_reginfo.c index c037f74215..52c861df3b 100644 --- a/src/modules/ims_registrar_pcscf/async_reginfo.c +++ b/src/modules/ims_registrar_pcscf/async_reginfo.c @@ -261,7 +261,7 @@ reginfo_event_t* pop_reginfo_event() if (ev == reginfo_event_list->tail) { //list now empty reginfo_event_list->tail = 0; } - ev->next = 0; //make sure whoever gets this cant access our list + ev->next = 0; //make sure whoever gets this can't access our list reginfo_event_list->size--; diff --git a/src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml b/src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml index b3d6b118fa..421f9ff09f 100644 --- a/src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml +++ b/src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml @@ -38,7 +38,7 @@ <section> <title>External Libraries or Applications</title> - <para>This modules requires the internal IMS library.</para> + <para>This module requires the internal IMS library.</para> </section> </section> @@ -98,7 +98,7 @@ modparam("ims_registrar_pcscf", "received_avp", "$avp(i:42)") <section> <title><varname>is_registered_fallback2ip</varname> (int)</title> - <para>Defines, whether a contact should be searched by it's contact only + <para>Defines, whether a contact should be searched by its Contact: only or alternatively by the received IP-Address.</para> <para>The option may have the following values:</para> diff --git a/src/modules/ims_registrar_pcscf/save.h b/src/modules/ims_registrar_pcscf/save.h index 0a077120c8..84e15cf3a6 100644 --- a/src/modules/ims_registrar_pcscf/save.h +++ b/src/modules/ims_registrar_pcscf/save.h @@ -51,7 +51,7 @@ #include "../../lib/ims/ims_getters.h" /*! \brief - * Process REGISTER request and save it's contacts + * Process REGISTER request and save its contacts */ int save(struct sip_msg* _m, udomain_t* _d, int _cflags); int save_pending(struct sip_msg* _m, udomain_t* _d); diff --git a/src/modules/ims_registrar_pcscf/service_routes.c b/src/modules/ims_registrar_pcscf/service_routes.c index 566ade5a56..b9b5654ad5 100644 --- a/src/modules/ims_registrar_pcscf/service_routes.c +++ b/src/modules/ims_registrar_pcscf/service_routes.c @@ -426,7 +426,7 @@ int check_service_routes(struct sip_msg* _m, udomain_t* _d) { goto error; } - LM_DBG("we have a contact which satisifes the routes...\n"); + LM_DBG("we have a contact which satisfies the routes...\n"); ul.unlock_udomain(_d, &vb->host, port, proto); return 1; }

1 0

git:master:4f3faaa4: ims_registrar_scscf: typos
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: 4f3faaa42006ce4b2a0ae2b684975fd385deea43 URL: https://github.com/kamailio/kamailio/commit/4f3faaa42006ce4b2a0ae2b684975fd… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_registrar_scscf: typos --- Modified: src/modules/ims_registrar_scscf/cxdx_avp.c Modified: src/modules/ims_registrar_scscf/cxdx_avp.h Modified: src/modules/ims_registrar_scscf/cxdx_sar.c Modified: src/modules/ims_registrar_scscf/cxdx_sar.h Modified: src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml Modified: src/modules/ims_registrar_scscf/registrar_notify.c Modified: src/modules/ims_registrar_scscf/save.c Modified: src/modules/ims_registrar_scscf/save.h Modified: src/modules/ims_registrar_scscf/userdata_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/4f3faaa42006ce4b2a0ae2b684975fd… Patch: https://github.com/kamailio/kamailio/commit/4f3faaa42006ce4b2a0ae2b684975fd…

1 0

git:master:b14a4208: ims_qos: typos
by Daniel-Constantin Mierla 13 Feb '23

13 Feb '23

Module: kamailio Branch: master Commit: b14a420834744b8bef871b10fd2fdeb6a5e7cd89 URL: https://github.com/kamailio/kamailio/commit/b14a420834744b8bef871b10fd2fdeb… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_qos: typos --- Modified: src/modules/ims_qos/cdpeventprocessor.c Modified: src/modules/ims_qos/doc/ims_qos_admin.xml Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_asr.c --- Diff: https://github.com/kamailio/kamailio/commit/b14a420834744b8bef871b10fd2fdeb… Patch: https://github.com/kamailio/kamailio/commit/b14a420834744b8bef871b10fd2fdeb…

1 0

← Newer
1
...
18
19
20
21
22
23
24
...
30
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2023