sr-dev February 2023

sr-dev@lists.kamailio.org

10 participants
294 discussions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8fefea2ef7f75b2e792601cee0f8de2652c8b598 URL: https://github.com/kamailio/kamailio/commit/8fefea2ef7f75b2e792601cee0f8de2… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_icscf: typos --- Modified: src/modules/ims_icscf/cxdx_avp.c Modified: src/modules/ims_icscf/cxdx_avp.h Modified: src/modules/ims_icscf/cxdx_lir.c Modified: src/modules/ims_icscf/cxdx_uar.c Modified: src/modules/ims_icscf/doc/ims_icscf_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8fefea2ef7f75b2e792601cee0f8de2… Patch: https://github.com/kamailio/kamailio/commit/8fefea2ef7f75b2e792601cee0f8de2… --- diff --git a/src/modules/ims_icscf/cxdx_avp.c b/src/modules/ims_icscf/cxdx_avp.c index a716117318..6d40896b49 100644 --- a/src/modules/ims_icscf/cxdx_avp.c +++ b/src/modules/ims_icscf/cxdx_avp.c @@ -778,7 +778,7 @@ int cxdx_get_auth_data_item_answer(AAAMessage *msg, AAA_AVP **auth_data, * @param nonce - Nonce * @param URI - URI * @param response - Response - * @param algoritm - Algorithm + * @param algorithm - Algorithm * @param method - Method * @param hash - Enitity-Body-Hash * @returns grouped str on success diff --git a/src/modules/ims_icscf/cxdx_avp.h b/src/modules/ims_icscf/cxdx_avp.h index 2348dcb0a3..5206bf7d3c 100644 --- a/src/modules/ims_icscf/cxdx_avp.h +++ b/src/modules/ims_icscf/cxdx_avp.h @@ -209,7 +209,7 @@ int cxdx_get_auth_data_item_answer(AAAMessage *msg, AAA_AVP **auth_data, * @param nonce - Nonce * @param URI - URI * @param response - Response - * @param algoritm - Algorithm + * @param algorithm - Algorithm * @param method - Method * @param hash - Enitity-Body-Hash * @returns grouped str on success diff --git a/src/modules/ims_icscf/cxdx_lir.c b/src/modules/ims_icscf/cxdx_lir.c index 473d3aa139..0e442dfc88 100644 --- a/src/modules/ims_icscf/cxdx_lir.c +++ b/src/modules/ims_icscf/cxdx_lir.c @@ -51,7 +51,7 @@ #include "ims_icscf_mod.h" #include "location.h" -//we use pseudo variables to communicate back to config file this takes the result and converys to a return code, publishes it a pseudo variable +//We use pseudo variables to communicate back to config file. This takes the result, converts it to a return code and publishes it as a pseudo variable. int create_lia_return_code(int result) { int rc; int_str avp_val, avp_name; diff --git a/src/modules/ims_icscf/cxdx_uar.c b/src/modules/ims_icscf/cxdx_uar.c index 0e7bcc8e50..eba64ac32c 100644 --- a/src/modules/ims_icscf/cxdx_uar.c +++ b/src/modules/ims_icscf/cxdx_uar.c @@ -52,8 +52,7 @@ #include "registration.h" #include "ims_icscf_mod.h" - -//we use pseudo variables to communicate back to config file this takes the result and converys to a return code, publishes it a pseudo variable +//We use pseudo variables to communicate back to config file. This takes the result, converts it to a return code and publishes it a as pseudo variable. int create_uaa_return_code(int result) { int rc; int_str avp_val, avp_name; diff --git a/src/modules/ims_icscf/doc/ims_icscf_admin.xml b/src/modules/ims_icscf/doc/ims_icscf_admin.xml index b73f67ab67..1af579623f 100644 --- a/src/modules/ims_icscf/doc/ims_icscf_admin.xml +++ b/src/modules/ims_icscf/doc/ims_icscf_admin.xml @@ -45,7 +45,7 @@ <section> <title>External Libraries or Applications</title> - <para>This modules requires the Kamailio internal IMS library.</para> + <para>This module requires the Kamailio internal IMS library.</para> </section> </section> @@ -135,7 +135,7 @@ modparam("ims_icscf", "cxdx_forced_peer", "hss.ims.smilecoms.com") <section> <title><varname>cxdx_dest_realm</varname> (string)</title> - <para>Destination realm to be used in Diameter messags to HSS</para> + <para>Destination realm to be used in Diameter messages to HSS</para> <para><emphasis> Default value is "ims.smilecoms.com".</emphasis></para>

1 year, 5 months

git:master:db62e037: ims_diameter_server: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: db62e0372eedce8708af23f806cce59d531817e6 URL: https://github.com/kamailio/kamailio/commit/db62e0372eedce8708af23f806cce59… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_diameter_server: typos --- Modified: src/modules/ims_diameter_server/avp_helper.c Modified: src/modules/ims_diameter_server/cJSON.c Modified: src/modules/ims_diameter_server/doc/ims_diameter_server.xml Modified: src/modules/ims_diameter_server/examples/kamailio.cfg Modified: src/modules/ims_diameter_server/ims_diameter_server.c --- Diff: https://github.com/kamailio/kamailio/commit/db62e0372eedce8708af23f806cce59… Patch: https://github.com/kamailio/kamailio/commit/db62e0372eedce8708af23f806cce59…

1 year, 5 months

git:master:c2f1da1b: ims_dialog: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c2f1da1bf804690766cdd9199b59e7261f0dcbaa URL: https://github.com/kamailio/kamailio/commit/c2f1da1bf804690766cdd9199b59e72… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_dialog: typos --- Modified: src/modules/ims_dialog/dlg_cb.c Modified: src/modules/ims_dialog/dlg_handlers.c Modified: src/modules/ims_dialog/dlg_handlers.h Modified: src/modules/ims_dialog/dlg_hash.c Modified: src/modules/ims_dialog/dlg_req_within.c Modified: src/modules/ims_dialog/doc/ims_dialog_admin.xml Modified: src/modules/ims_dialog/doc/ims_dialog_devel.xml Modified: src/modules/ims_dialog/ims_dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/c2f1da1bf804690766cdd9199b59e72… Patch: https://github.com/kamailio/kamailio/commit/c2f1da1bf804690766cdd9199b59e72…

1 year, 5 months

git:master:aa2cace5: ims_charging: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: aa2cace532cdf0891d48698e8a9386a5d8a96f07 URL: https://github.com/kamailio/kamailio/commit/aa2cace532cdf0891d48698e8a9386a… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_charging: typos --- Modified: src/modules/ims_charging/ccr.c Modified: src/modules/ims_charging/doc/ims_charging_admin.xml Modified: src/modules/ims_charging/ims_charging_mod.c Modified: src/modules/ims_charging/ro_session_hash.h Modified: src/modules/ims_charging/ro_timer.c Modified: src/modules/ims_charging/ro_timer.h --- Diff: https://github.com/kamailio/kamailio/commit/aa2cace532cdf0891d48698e8a9386a… Patch: https://github.com/kamailio/kamailio/commit/aa2cace532cdf0891d48698e8a9386a…

1 year, 5 months

git:master:6dded07a: ims_auth: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6dded07a538d1a68ff766c80e971b6e59535bb52 URL: https://github.com/kamailio/kamailio/commit/6dded07a538d1a68ff766c80e971b6e… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 ims_auth: typos --- Modified: src/modules/ims_auth/authorize.c Modified: src/modules/ims_auth/cxdx_avp.c Modified: src/modules/ims_auth/cxdx_avp.h Modified: src/modules/ims_auth/cxdx_mar.c Modified: src/modules/ims_auth/cxdx_mar.h Modified: src/modules/ims_auth/doc/ims_auth_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/6dded07a538d1a68ff766c80e971b6e… Patch: https://github.com/kamailio/kamailio/commit/6dded07a538d1a68ff766c80e971b6e…

1 year, 5 months

git:master:53f3bcd0: imc: typo

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 53f3bcd0eca4934b00eb4db05080a7ee33b11c92 URL: https://github.com/kamailio/kamailio/commit/53f3bcd0eca4934b00eb4db05080a7e… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T12:14:59+01:00 imc: typo --- Modified: src/modules/imc/doc/imc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/53f3bcd0eca4934b00eb4db05080a7e… Patch: https://github.com/kamailio/kamailio/commit/53f3bcd0eca4934b00eb4db05080a7e… --- diff --git a/src/modules/imc/doc/imc_admin.xml b/src/modules/imc/doc/imc_admin.xml index a2fd541ea7..853176eaa6 100644 --- a/src/modules/imc/doc/imc_admin.xml +++ b/src/modules/imc/doc/imc_admin.xml @@ -158,7 +158,7 @@ modparam("imc", "members_table", "members") </para> <para> <emphasis> - The default value is 4 (resultimg in hash size 16). + The default value is 4 (resulting in hash size 16). </emphasis> </para> <example>

1 year, 5 months

[kamailio/kamailio] Typos (PR #3363)

by Дилян Палаузов

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3363 -- Commit Summary -- * imc: typo * ims_auth: typos * ims_charging: typos * ims_dialog: typos * ims_diameter_server: typos * ims_icscf: typos * ims_ipsec_pcscf: typos * ims_isc: typos * ims_ocs: typos * ims_qos: typos * ims_registrar_scscf: typos * ims_registrar_pcscf: typos * ims_usrloc_pcscf: typos * ims_usrloc_scscf: typos * ipops: typos -- File Changes -- M src/modules/imc/doc/imc_admin.xml (2) M src/modules/ims_auth/authorize.c (4) M src/modules/ims_auth/cxdx_avp.c (2) M src/modules/ims_auth/cxdx_avp.h (2) M src/modules/ims_auth/cxdx_mar.c (6) M src/modules/ims_auth/cxdx_mar.h (2) M src/modules/ims_auth/doc/ims_auth_admin.xml (2) M src/modules/ims_charging/ccr.c (8) M src/modules/ims_charging/doc/ims_charging_admin.xml (2) M src/modules/ims_charging/ims_charging_mod.c (4) M src/modules/ims_charging/ro_session_hash.h (2) M src/modules/ims_charging/ro_timer.c (2) M src/modules/ims_charging/ro_timer.h (2) M src/modules/ims_dialog/dlg_cb.c (6) M src/modules/ims_dialog/dlg_handlers.c (4) M src/modules/ims_dialog/dlg_handlers.h (2) M src/modules/ims_dialog/dlg_hash.c (6) M src/modules/ims_dialog/dlg_req_within.c (4) M src/modules/ims_dialog/doc/ims_dialog_admin.xml (4) M src/modules/ims_dialog/doc/ims_dialog_devel.xml (6) M src/modules/ims_dialog/ims_dialog.c (2) M src/modules/ims_diameter_server/avp_helper.c (2) M src/modules/ims_diameter_server/cJSON.c (2) M src/modules/ims_diameter_server/doc/ims_diameter_server.xml (4) M src/modules/ims_diameter_server/examples/kamailio.cfg (8) M src/modules/ims_diameter_server/ims_diameter_server.c (4) M src/modules/ims_icscf/cxdx_avp.c (2) M src/modules/ims_icscf/cxdx_avp.h (2) M src/modules/ims_icscf/cxdx_lir.c (2) M src/modules/ims_icscf/cxdx_uar.c (3) M src/modules/ims_icscf/doc/ims_icscf_admin.xml (4) M src/modules/ims_ipsec_pcscf/cmd.c (4) M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (4) M src/modules/ims_ipsec_pcscf/ipsec.c (4) M src/modules/ims_ipsec_pcscf/spi_list.c (2) M src/modules/ims_isc/checker.c (2) M src/modules/ims_isc/doc/ims_isc_admin.xml (2) M src/modules/ims_isc/mark.c (10) M src/modules/ims_ocs/examples/full/kamailio.cfg (4) M src/modules/ims_ocs/examples/full/ocs.cfg.sample (2) M src/modules/ims_ocs/examples/simple/kamailio.cfg (4) M src/modules/ims_ocs/examples/simple/ocs.cfg.sample (2) M src/modules/ims_qos/cdpeventprocessor.c (2) M src/modules/ims_qos/doc/ims_qos_admin.xml (2) M src/modules/ims_qos/ims_qos_mod.c (14) M src/modules/ims_qos/rx_aar.c (4) M src/modules/ims_qos/rx_asr.c (2) M src/modules/ims_registrar_pcscf/async_reginfo.c (2) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (4) M src/modules/ims_registrar_pcscf/save.h (2) M src/modules/ims_registrar_pcscf/service_routes.c (2) M src/modules/ims_registrar_scscf/cxdx_avp.c (2) M src/modules/ims_registrar_scscf/cxdx_avp.h (2) M src/modules/ims_registrar_scscf/cxdx_sar.c (2) M src/modules/ims_registrar_scscf/cxdx_sar.h (2) M src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml (4) M src/modules/ims_registrar_scscf/registrar_notify.c (18) M src/modules/ims_registrar_scscf/save.c (6) M src/modules/ims_registrar_scscf/save.h (2) M src/modules/ims_registrar_scscf/userdata_parser.c (2) M src/modules/ims_usrloc_pcscf/reginfo.h (2) M src/modules/ims_usrloc_pcscf/udomain.c (2) M src/modules/ims_usrloc_scscf/bin_utils.c (18) M src/modules/ims_usrloc_scscf/impurecord.c (2) M src/modules/ims_usrloc_scscf/subscribe.c (2) M src/modules/ims_usrloc_scscf/udomain.c (6) M src/modules/ims_usrloc_scscf/ul_callback.h (2) M src/modules/ims_usrloc_scscf/usrloc.h (2) M src/modules/ipops/ipops_mod.c (8) M src/modules/ipops/ipops_pv.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3363.patch https://github.com/kamailio/kamailio/pull/3363.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3363 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3363(a)github.com>

1 year, 5 months

[kamailio/kamailio] tos as text does not works (Issue #3368)

by sergey-safarov

### Description According to [RFC4594](https://datatracker.ietf.org/doc/html/rfc4594#page-19) ``` ------------------------------------------------------------------ | Service | DSCP | DSCP | Application | | Class Name | Name | Value | Examples | |===============+=========+=============+==========================| |Network Control| CS6 | 110000 | Network routing | |---------------+---------+-------------+--------------------------| | Telephony | EF | 101110 | IP Telephony bearer | |---------------+---------+-------------+--------------------------| | Signaling | CS5 | 101000 | IP Telephony signaling | |---------------+---------+-------------+--------------------------| ``` Kamailio should relay SIP messages with DCSP value `CS5` To set this value I can use in config file ``` tos=0xA0 ``` This works as expected But when I use text form this does not work ``` tos=IPTOS_PREC_CRITIC_ECP ``` `IPTOS_PREC_CRITIC_ECP` defined in the `/usr/include/linux/ip.h` as ``` #define IPTOS_PREC_CRITIC_ECP 0xa0 ``` I expect both forms `0xA0` and `IPTOS_PREC_CRITIC_ECP` should works. Tested on 5.6.2 version -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3368 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3368(a)github.com>

1 year, 5 months

git:master:34ce0de7: presence: cast to uint64_t when using time_t value

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 34ce0de749c20e1b5a2e58fdaaca841d75622d2c URL: https://github.com/kamailio/kamailio/commit/34ce0de749c20e1b5a2e58fdaaca841… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T09:51:51+01:00 presence: cast to uint64_t when using time_t value - startup time stored as unsigned int insted of signed int --- Modified: src/modules/presence/presence.c Modified: src/modules/presence/presence.h Modified: src/modules/presence/presentity.c --- Diff: https://github.com/kamailio/kamailio/commit/34ce0de749c20e1b5a2e58fdaaca841… Patch: https://github.com/kamailio/kamailio/commit/34ce0de749c20e1b5a2e58fdaaca841… --- diff --git a/src/modules/presence/presence.c b/src/modules/presence/presence.c index d6e287c40e..599e048e4d 100644 --- a/src/modules/presence/presence.c +++ b/src/modules/presence/presence.c @@ -142,7 +142,7 @@ static int fixup_has_subscribers(void **param, int param_no); int pres_counter = 0; int pres_pid = 0; char pres_prefix = 'a'; -int pres_startup_time = 0; +unsigned int pres_startup_time = 0; str pres_db_url = {0, 0}; int pres_expires_offset = 0; int pres_cseq_offset = 0; @@ -447,7 +447,7 @@ static int mod_init(void) } - pres_startup_time = (int)time(NULL); + pres_startup_time = (unsigned int)(uint64_t)time(NULL); if(pres_clean_period > 0) { if(pres_timer_mode==0) { register_timer(ps_presentity_db_timer_clean, 0, pres_clean_period); diff --git a/src/modules/presence/presence.h b/src/modules/presence/presence.h index 381029184a..390aee49f8 100644 --- a/src/modules/presence/presence.h +++ b/src/modules/presence/presence.h @@ -73,7 +73,7 @@ extern str watchers_table; extern int pres_counter; extern int pres_pid; -extern int pres_startup_time; +extern unsigned int pres_startup_time; extern int pres_expires_offset; extern int pres_cseq_offset; extern str pres_server_address; diff --git a/src/modules/presence/presentity.c b/src/modules/presence/presentity.c index 2ac5190495..f9131e9a4e 100644 --- a/src/modules/presence/presentity.c +++ b/src/modules/presence/presentity.c @@ -69,7 +69,7 @@ char *generate_ETag(int publ_count) ERR_MEM(PKG_MEM_STR); } memset(etag, 0, ETAG_LEN * sizeof(char)); - size = snprintf(etag, ETAG_LEN, "%c.%d.%d.%d.%d", pres_prefix, + size = snprintf(etag, ETAG_LEN, "%c.%u.%d.%d.%d", pres_prefix, pres_startup_time, pres_pid, pres_counter, publ_count); if(size < 0) { LM_ERR("unsuccessful snprintf\n ");

1 year, 5 months

git:master:0259eaed: xmlrpc: cast to uint64_t when using time_t value

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0259eaedd507c314161c59b72eaa4564effac555 URL: https://github.com/kamailio/kamailio/commit/0259eaedd507c314161c59b72eaa456… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-13T09:51:51+01:00 xmlrpc: cast to uint64_t when using time_t value --- Modified: src/modules/xmlrpc/xmlrpc.c --- Diff: https://github.com/kamailio/kamailio/commit/0259eaedd507c314161c59b72eaa456… Patch: https://github.com/kamailio/kamailio/commit/0259eaedd507c314161c59b72eaa456… --- diff --git a/src/modules/xmlrpc/xmlrpc.c b/src/modules/xmlrpc/xmlrpc.c index 7cfb856774..bddf864206 100644 --- a/src/modules/xmlrpc/xmlrpc.c +++ b/src/modules/xmlrpc/xmlrpc.c @@ -43,6 +43,7 @@ #include <string.h> #include <stdlib.h> #include <stdio.h> +#include <stdint.h> #include <stdarg.h> #include <sys/types.h> #include <signal.h> @@ -1335,7 +1336,7 @@ static int get_int(int* val, struct xmlrpc_reply* reply, ret=-1; break; case XML_T_DATE: - *val = xmlrpc2time(val_str); + *val = (int)(uint64_t)xmlrpc2time(val_str); break; case XML_T_DOUBLE: *val = (int)strtod(val_str, &end_ptr);

1 year, 5 months

← Newer
1
...
19
20
21
22
23
24
25
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2023