Module: kamailio
Branch: master
Commit: 46df335ccfacb159a1f8ad1bc6e549967da30a91
URL: https://github.com/kamailio/kamailio/commit/46df335ccfacb159a1f8ad1bc6e5499…
Author: �������������������� �������������������������������� <git-dpa(a)aegee.org>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-02-13T12:14:59+01:00
ims_isc: typos
---
Modified: src/modules/ims_isc/checker.c
Modified: src/modules/ims_isc/doc/ims_isc_admin.xml
Modified: src/modules/ims_isc/mark.c
---
Diff: https://github.com/kamailio/kamailio/commit/46df335ccfacb159a1f8ad1bc6e5499…
Patch: https://github.com/kamailio/kamailio/commit/46df335ccfacb159a1f8ad1bc6e5499…
---
diff --git a/src/modules/ims_isc/checker.c b/src/modules/ims_isc/checker.c
index 3e17333dbd..b24946503b 100644
--- a/src/modules/ims_isc/checker.c
+++ b/src/modules/ims_isc/checker.c
@@ -468,7 +468,7 @@ isc_match* isc_checker_find(str uri, char direction, int skip,
LM_DBG("About to try p->s->service_profiles_cnt!! #profiles is %d\n",
p->s->service_profiles_cnt);
while (si < p->s->service_profiles_cnt) {
- LM_DBG("About to try p->s->service_profiles[a].filter_criterai_cnt\n");
+ LM_DBG("About to try p->s->service_profiles[a].filter_criteria_cnt\n");
next = cnt + p->s->service_profiles[si].filter_criteria_cnt;
if (cnt <= skip && skip < next) {
sj = skip - cnt;
diff --git a/src/modules/ims_isc/doc/ims_isc_admin.xml b/src/modules/ims_isc/doc/ims_isc_admin.xml
index 1c19ab2e97..612266a574 100644
--- a/src/modules/ims_isc/doc/ims_isc_admin.xml
+++ b/src/modules/ims_isc/doc/ims_isc_admin.xml
@@ -40,7 +40,7 @@
<section>
<title>External Libraries or Applications</title>
- <para>This modules requires the Kamailio internal IMS library.</para>
+ <para>This module requires the Kamailio internal IMS library.</para>
</section>
</section>
diff --git a/src/modules/ims_isc/mark.c b/src/modules/ims_isc/mark.c
index 8d22ffff87..eb6cdb3ec4 100644
--- a/src/modules/ims_isc/mark.c
+++ b/src/modules/ims_isc/mark.c
@@ -79,7 +79,7 @@ int bin_to_base16(char *from, int len, char *to) {
/**
* Retrieves the mark from message.
* - the marking should be in a header like described before
- * @param msg - SIP mesage to mark
+ * @param msg - SIP message to mark
* @param mark - mark to load into
* @returns 1 if found, 0 if not
*/
@@ -194,7 +194,7 @@ int base16_to_bin(char *from, int len, char *to) {
/**
* Deletes the previous marking attempts (lumps).
*
- * @param msg - SIP mesage to mark
+ * @param msg - SIP message to mark
* @returns 1 on success
*/
int isc_mark_drop_route(struct sip_msg *msg) {
@@ -227,7 +227,7 @@ int isc_mark_drop_route(struct sip_msg *msg) {
* Mark the message with the given mark.
* - old marking attempts are deleted
* - marking is performed by inserting the following header
- * @param msg - SIP mesage to mark
+ * @param msg - SIP message to mark
* @param match - the current IFC match
* @param mark - pointer to the mark
* @returns 1 on success or 0 on failure
@@ -268,8 +268,8 @@ int isc_mark_set(struct sip_msg *msg, isc_match *match, isc_mark *mark) {
* - else: \code Route: <sip:as@asdomain.net;lr>, <[iscmark]> \endcode
*
*
- * @param msg - SIP mesage to mark
- * @param as - SIP addres of the application server to forward to
+ * @param msg - SIP message to mark
+ * @param as - SIP address of the application server to forward to
* @param iscmark - the mark to write
* @returns 1 on success, else 0
*/
Module: kamailio
Branch: master
Commit: 8fefea2ef7f75b2e792601cee0f8de2652c8b598
URL: https://github.com/kamailio/kamailio/commit/8fefea2ef7f75b2e792601cee0f8de2…
Author: �������������������� �������������������������������� <git-dpa(a)aegee.org>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-02-13T12:14:59+01:00
ims_icscf: typos
---
Modified: src/modules/ims_icscf/cxdx_avp.c
Modified: src/modules/ims_icscf/cxdx_avp.h
Modified: src/modules/ims_icscf/cxdx_lir.c
Modified: src/modules/ims_icscf/cxdx_uar.c
Modified: src/modules/ims_icscf/doc/ims_icscf_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/8fefea2ef7f75b2e792601cee0f8de2…
Patch: https://github.com/kamailio/kamailio/commit/8fefea2ef7f75b2e792601cee0f8de2…
---
diff --git a/src/modules/ims_icscf/cxdx_avp.c b/src/modules/ims_icscf/cxdx_avp.c
index a716117318..6d40896b49 100644
--- a/src/modules/ims_icscf/cxdx_avp.c
+++ b/src/modules/ims_icscf/cxdx_avp.c
@@ -778,7 +778,7 @@ int cxdx_get_auth_data_item_answer(AAAMessage *msg, AAA_AVP **auth_data,
* @param nonce - Nonce
* @param URI - URI
* @param response - Response
- * @param algoritm - Algorithm
+ * @param algorithm - Algorithm
* @param method - Method
* @param hash - Enitity-Body-Hash
* @returns grouped str on success
diff --git a/src/modules/ims_icscf/cxdx_avp.h b/src/modules/ims_icscf/cxdx_avp.h
index 2348dcb0a3..5206bf7d3c 100644
--- a/src/modules/ims_icscf/cxdx_avp.h
+++ b/src/modules/ims_icscf/cxdx_avp.h
@@ -209,7 +209,7 @@ int cxdx_get_auth_data_item_answer(AAAMessage *msg, AAA_AVP **auth_data,
* @param nonce - Nonce
* @param URI - URI
* @param response - Response
- * @param algoritm - Algorithm
+ * @param algorithm - Algorithm
* @param method - Method
* @param hash - Enitity-Body-Hash
* @returns grouped str on success
diff --git a/src/modules/ims_icscf/cxdx_lir.c b/src/modules/ims_icscf/cxdx_lir.c
index 473d3aa139..0e442dfc88 100644
--- a/src/modules/ims_icscf/cxdx_lir.c
+++ b/src/modules/ims_icscf/cxdx_lir.c
@@ -51,7 +51,7 @@
#include "ims_icscf_mod.h"
#include "location.h"
-//we use pseudo variables to communicate back to config file this takes the result and converys to a return code, publishes it a pseudo variable
+//We use pseudo variables to communicate back to config file. This takes the result, converts it to a return code and publishes it as a pseudo variable.
int create_lia_return_code(int result) {
int rc;
int_str avp_val, avp_name;
diff --git a/src/modules/ims_icscf/cxdx_uar.c b/src/modules/ims_icscf/cxdx_uar.c
index 0e7bcc8e50..eba64ac32c 100644
--- a/src/modules/ims_icscf/cxdx_uar.c
+++ b/src/modules/ims_icscf/cxdx_uar.c
@@ -52,8 +52,7 @@
#include "registration.h"
#include "ims_icscf_mod.h"
-
-//we use pseudo variables to communicate back to config file this takes the result and converys to a return code, publishes it a pseudo variable
+//We use pseudo variables to communicate back to config file. This takes the result, converts it to a return code and publishes it a as pseudo variable.
int create_uaa_return_code(int result) {
int rc;
int_str avp_val, avp_name;
diff --git a/src/modules/ims_icscf/doc/ims_icscf_admin.xml b/src/modules/ims_icscf/doc/ims_icscf_admin.xml
index b73f67ab67..1af579623f 100644
--- a/src/modules/ims_icscf/doc/ims_icscf_admin.xml
+++ b/src/modules/ims_icscf/doc/ims_icscf_admin.xml
@@ -45,7 +45,7 @@
<section>
<title>External Libraries or Applications</title>
- <para>This modules requires the Kamailio internal IMS library.</para>
+ <para>This module requires the Kamailio internal IMS library.</para>
</section>
</section>
@@ -135,7 +135,7 @@ modparam("ims_icscf", "cxdx_forced_peer", "hss.ims.smilecoms.com")
<section>
<title><varname>cxdx_dest_realm</varname> (string)</title>
- <para>Destination realm to be used in Diameter messags to HSS</para>
+ <para>Destination realm to be used in Diameter messages to HSS</para>
<para><emphasis> Default value is "ims.smilecoms.com".</emphasis></para>
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3363
-- Commit Summary --
* imc: typo
* ims_auth: typos
* ims_charging: typos
* ims_dialog: typos
* ims_diameter_server: typos
* ims_icscf: typos
* ims_ipsec_pcscf: typos
* ims_isc: typos
* ims_ocs: typos
* ims_qos: typos
* ims_registrar_scscf: typos
* ims_registrar_pcscf: typos
* ims_usrloc_pcscf: typos
* ims_usrloc_scscf: typos
* ipops: typos
-- File Changes --
M src/modules/imc/doc/imc_admin.xml (2)
M src/modules/ims_auth/authorize.c (4)
M src/modules/ims_auth/cxdx_avp.c (2)
M src/modules/ims_auth/cxdx_avp.h (2)
M src/modules/ims_auth/cxdx_mar.c (6)
M src/modules/ims_auth/cxdx_mar.h (2)
M src/modules/ims_auth/doc/ims_auth_admin.xml (2)
M src/modules/ims_charging/ccr.c (8)
M src/modules/ims_charging/doc/ims_charging_admin.xml (2)
M src/modules/ims_charging/ims_charging_mod.c (4)
M src/modules/ims_charging/ro_session_hash.h (2)
M src/modules/ims_charging/ro_timer.c (2)
M src/modules/ims_charging/ro_timer.h (2)
M src/modules/ims_dialog/dlg_cb.c (6)
M src/modules/ims_dialog/dlg_handlers.c (4)
M src/modules/ims_dialog/dlg_handlers.h (2)
M src/modules/ims_dialog/dlg_hash.c (6)
M src/modules/ims_dialog/dlg_req_within.c (4)
M src/modules/ims_dialog/doc/ims_dialog_admin.xml (4)
M src/modules/ims_dialog/doc/ims_dialog_devel.xml (6)
M src/modules/ims_dialog/ims_dialog.c (2)
M src/modules/ims_diameter_server/avp_helper.c (2)
M src/modules/ims_diameter_server/cJSON.c (2)
M src/modules/ims_diameter_server/doc/ims_diameter_server.xml (4)
M src/modules/ims_diameter_server/examples/kamailio.cfg (8)
M src/modules/ims_diameter_server/ims_diameter_server.c (4)
M src/modules/ims_icscf/cxdx_avp.c (2)
M src/modules/ims_icscf/cxdx_avp.h (2)
M src/modules/ims_icscf/cxdx_lir.c (2)
M src/modules/ims_icscf/cxdx_uar.c (3)
M src/modules/ims_icscf/doc/ims_icscf_admin.xml (4)
M src/modules/ims_ipsec_pcscf/cmd.c (4)
M src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml (4)
M src/modules/ims_ipsec_pcscf/ipsec.c (4)
M src/modules/ims_ipsec_pcscf/spi_list.c (2)
M src/modules/ims_isc/checker.c (2)
M src/modules/ims_isc/doc/ims_isc_admin.xml (2)
M src/modules/ims_isc/mark.c (10)
M src/modules/ims_ocs/examples/full/kamailio.cfg (4)
M src/modules/ims_ocs/examples/full/ocs.cfg.sample (2)
M src/modules/ims_ocs/examples/simple/kamailio.cfg (4)
M src/modules/ims_ocs/examples/simple/ocs.cfg.sample (2)
M src/modules/ims_qos/cdpeventprocessor.c (2)
M src/modules/ims_qos/doc/ims_qos_admin.xml (2)
M src/modules/ims_qos/ims_qos_mod.c (14)
M src/modules/ims_qos/rx_aar.c (4)
M src/modules/ims_qos/rx_asr.c (2)
M src/modules/ims_registrar_pcscf/async_reginfo.c (2)
M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (4)
M src/modules/ims_registrar_pcscf/save.h (2)
M src/modules/ims_registrar_pcscf/service_routes.c (2)
M src/modules/ims_registrar_scscf/cxdx_avp.c (2)
M src/modules/ims_registrar_scscf/cxdx_avp.h (2)
M src/modules/ims_registrar_scscf/cxdx_sar.c (2)
M src/modules/ims_registrar_scscf/cxdx_sar.h (2)
M src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml (4)
M src/modules/ims_registrar_scscf/registrar_notify.c (18)
M src/modules/ims_registrar_scscf/save.c (6)
M src/modules/ims_registrar_scscf/save.h (2)
M src/modules/ims_registrar_scscf/userdata_parser.c (2)
M src/modules/ims_usrloc_pcscf/reginfo.h (2)
M src/modules/ims_usrloc_pcscf/udomain.c (2)
M src/modules/ims_usrloc_scscf/bin_utils.c (18)
M src/modules/ims_usrloc_scscf/impurecord.c (2)
M src/modules/ims_usrloc_scscf/subscribe.c (2)
M src/modules/ims_usrloc_scscf/udomain.c (6)
M src/modules/ims_usrloc_scscf/ul_callback.h (2)
M src/modules/ims_usrloc_scscf/usrloc.h (2)
M src/modules/ipops/ipops_mod.c (8)
M src/modules/ipops/ipops_pv.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3363.patchhttps://github.com/kamailio/kamailio/pull/3363.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3363
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3363(a)github.com>
### Description
According to [RFC4594](https://datatracker.ietf.org/doc/html/rfc4594#page-19)
```
------------------------------------------------------------------
| Service | DSCP | DSCP | Application |
| Class Name | Name | Value | Examples |
|===============+=========+=============+==========================|
|Network Control| CS6 | 110000 | Network routing |
|---------------+---------+-------------+--------------------------|
| Telephony | EF | 101110 | IP Telephony bearer |
|---------------+---------+-------------+--------------------------|
| Signaling | CS5 | 101000 | IP Telephony signaling |
|---------------+---------+-------------+--------------------------|
```
Kamailio should relay SIP messages with DCSP value `CS5`
To set this value I can use in config file
```
tos=0xA0
```
This works as expected
But when I use text form this does not work
```
tos=IPTOS_PREC_CRITIC_ECP
```
`IPTOS_PREC_CRITIC_ECP` defined in the `/usr/include/linux/ip.h` as
```
#define IPTOS_PREC_CRITIC_ECP 0xa0
```
I expect both forms `0xA0` and `IPTOS_PREC_CRITIC_ECP` should works.
Tested on 5.6.2 version
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3368
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3368(a)github.com>