sr-dev May 2023

sr-dev@lists.kamailio.org

16 participants
323 discussions

Re: clang-format changes
by Juha Heinanen 18 May '23

18 May '23

I guess I missed the clang-format discussion or did it happen? Fr example, I would have voted for SpaceBeforeParens: ControlStatements -- Juha

2 1

[kamailio/kamailio] presence: Add publ_cache sync RPC command. (PR #3460)
by Jake Greene 18 May '23

18 May '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Needed a way to sync the publ_cache with changes made to the presentity table when using publ_cache modes 1 or 2. This seems pretty simple, and works for me. Beneficial when adding numerous "message-summary" event entries from an external Voicemail application to the 'presentity' table. Usage: `presence.htable_db_restore` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3460 -- Commit Summary -- * presence: Add publ_cache sync RPC command. -- File Changes -- M src/modules/presence/doc/presence_admin.xml (21) M src/modules/presence/presence.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3460.patch https://github.com/kamailio/kamailio/pull/3460.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3460 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3460(a)github.com>

1 3

clang-format changes
by Victor Seva 18 May '23

18 May '23

Hi, I'm thinking we should start enforcing clang-format in order to have a coherent indentation and coding style in the project. I've added a check in the pull-request Github Action to check the clang-format in the commits but for sure now it will almost always fail due to our code is not always formatted properly. Is is OK if I start committing changes module by module of just changes related to clang-format formatting? I'm aware this will our life harder to backport fixes to supported branches but I think it will help us in the long run. Cheers -- ----------------------------------------------------------------- | ,''`. Victor Seva | | : :' : linuxmaniac(a)torreviejawireless.org | | `. `' PGP Key ID: 0x51A09B18CF5A5068 | | `- Debian Developer | -----------------------------------------------------------------

5 10

git:master:61833193: dispatcher: fix force send socket functionality, was not working in some TCP scenarios
by Henning Westerholt 18 May '23

18 May '23

Module: kamailio Branch: master Commit: 6183319381573e42b882d05ae1748539f7547d8c URL: https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae174853… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-18T10:52:52Z dispatcher: fix force send socket functionality, was not working in some TCP scenarios --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae174853… Patch: https://github.com/kamailio/kamailio/commit/6183319381573e42b882d05ae174853… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index a07f779ab8..f0322a6b57 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1869,7 +1869,8 @@ static inline int ds_push_dst( break; } if(sock) { - msg->force_send_socket = sock; + LM_DBG("set send socket to %.*s\n", sock->sock_str.len, sock->sock_str.s); + set_force_socket(msg, sock); } return 0; }

2 4

git:master:08fbc4fa: dispatcher: fix formatting after commit 1f53b159c311715b
by Henning Westerholt 18 May '23

18 May '23

Module: kamailio Branch: master Commit: 08fbc4fa8d44c2c0ee596e1f30b95b5b4fcfc823 URL: https://github.com/kamailio/kamailio/commit/08fbc4fa8d44c2c0ee596e1f30b95b5… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-18T11:37:44Z dispatcher: fix formatting after commit 1f53b159c311715b --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/08fbc4fa8d44c2c0ee596e1f30b95b5… Patch: https://github.com/kamailio/kamailio/commit/08fbc4fa8d44c2c0ee596e1f30b95b5… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index f0322a6b57c..e8d7886ec9b 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1869,7 +1869,8 @@ static inline int ds_push_dst( break; } if(sock) { - LM_DBG("set send socket to %.*s\n", sock->sock_str.len, sock->sock_str.s); + LM_DBG("set send socket to %.*s\n", sock->sock_str.len, + sock->sock_str.s); set_force_socket(msg, sock); } return 0;

1 0

git:master:1f53b159: modules: readme files regenerated - dispatcher ... [skip ci]
by Kamailio Dev 18 May '23

18 May '23

Module: kamailio Branch: master Commit: 1f53b159c311715b993ee33d40fb35017626e89c URL: https://github.com/kamailio/kamailio/commit/1f53b159c311715b993ee33d40fb350… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-05-18T13:01:45+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/1f53b159c311715b993ee33d40fb350… Patch: https://github.com/kamailio/kamailio/commit/1f53b159c311715b993ee33d40fb350… --- diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README index 166dcfc886..dc21ebd604 100644 --- a/src/modules/dispatcher/README +++ b/src/modules/dispatcher/README @@ -572,7 +572,8 @@ modparam("dispatcher", "xavp_dst", "_dsdst_") * attrs - the attributes - they are added if xavp_dst_mode does not have the bit 1 set (value 1). - Default value is ��0�� (add all fields). + Default value is ��0�� (add grp, uri, sock, attr and optionally dstid + fields). Example 1.13. Set the ��xavp_dst_mode�� parameter ...

1 0

git:5.5:0125f881: dispatcher: fix force send socket functionality, was not working in some TCP scenarios
by Henning Westerholt 18 May '23

18 May '23

Module: kamailio Branch: 5.5 Commit: 0125f8818c99d673c22ce8d9448d453124097e87 URL: https://github.com/kamailio/kamailio/commit/0125f8818c99d673c22ce8d9448d453… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-18T10:57:23Z dispatcher: fix force send socket functionality, was not working in some TCP scenarios (cherry picked from commit 6183319381573e42b882d05ae1748539f7547d8c) (cherry picked from commit da7944e2f4c7e6f344d125da325c388e1836662f) (cherry picked from commit d13a0b21d3a2d9c5f453957490c06d924af7e043) --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/0125f8818c99d673c22ce8d9448d453… Patch: https://github.com/kamailio/kamailio/commit/0125f8818c99d673c22ce8d9448d453… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index b7e8648cf5a..856e6123f02 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1834,7 +1834,8 @@ static inline int ds_push_dst(sip_msg_t *msg, str *uri, socket_info_t *sock, break; } if(sock) { - msg->force_send_socket = sock; + LM_DBG("set send socket to %.*s\n", sock->sock_str.len, sock->sock_str.s); + set_force_socket(msg, sock); } return 0; }

1 0

git:5.6:d13a0b21: dispatcher: fix force send socket functionality, was not working in some TCP scenarios
by Henning Westerholt 18 May '23

18 May '23

Module: kamailio Branch: 5.6 Commit: d13a0b21d3a2d9c5f453957490c06d924af7e043 URL: https://github.com/kamailio/kamailio/commit/d13a0b21d3a2d9c5f453957490c06d9… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-18T10:56:54Z dispatcher: fix force send socket functionality, was not working in some TCP scenarios (cherry picked from commit 6183319381573e42b882d05ae1748539f7547d8c) (cherry picked from commit da7944e2f4c7e6f344d125da325c388e1836662f) --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/d13a0b21d3a2d9c5f453957490c06d9… Patch: https://github.com/kamailio/kamailio/commit/d13a0b21d3a2d9c5f453957490c06d9… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 8f06f6f5cbb..7ed3d09fc71 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1859,7 +1859,8 @@ static inline int ds_push_dst(sip_msg_t *msg, str *uri, socket_info_t *sock, break; } if(sock) { - msg->force_send_socket = sock; + LM_DBG("set send socket to %.*s\n", sock->sock_str.len, sock->sock_str.s); + set_force_socket(msg, sock); } return 0; }

1 0

git:5.7:da7944e2: dispatcher: fix force send socket functionality, was not working in some TCP scenarios
by Henning Westerholt 18 May '23

18 May '23

Module: kamailio Branch: 5.7 Commit: da7944e2f4c7e6f344d125da325c388e1836662f URL: https://github.com/kamailio/kamailio/commit/da7944e2f4c7e6f344d125da325c388… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-18T10:56:23Z dispatcher: fix force send socket functionality, was not working in some TCP scenarios (cherry picked from commit 6183319381573e42b882d05ae1748539f7547d8c) --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/da7944e2f4c7e6f344d125da325c388… Patch: https://github.com/kamailio/kamailio/commit/da7944e2f4c7e6f344d125da325c388… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 484322f0ec7..87d12b786d2 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1860,7 +1860,8 @@ static inline int ds_push_dst(sip_msg_t *msg, str *uri, socket_info_t *sock, break; } if(sock) { - msg->force_send_socket = sock; + LM_DBG("set send socket to %.*s\n", sock->sock_str.len, sock->sock_str.s); + set_force_socket(msg, sock); } return 0; }

1 0

git:master:704f5895: dispatcher: clarification regarding xavp_dst_mode docs
by Henning Westerholt 18 May '23

18 May '23

Module: kamailio Branch: master Commit: 704f589577f51bb85b76070ca5722d54590b2c09 URL: https://github.com/kamailio/kamailio/commit/704f589577f51bb85b76070ca5722d5… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-05-18T10:50:53Z dispatcher: clarification regarding xavp_dst_mode docs --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/704f589577f51bb85b76070ca5722d5… Patch: https://github.com/kamailio/kamailio/commit/704f589577f51bb85b76070ca5722d5… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 3a012d47b1b..86d93ca27ef 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -384,7 +384,7 @@ modparam("dispatcher", "xavp_dst", "_dsdst_") </para> <para> <emphasis> - Default value is <quote>0</quote> (add all fields). + Default value is <quote>0</quote> (add grp, uri, sock, attr and optionally dstid fields). </emphasis> </para> <example>

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
33
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2023