sr-dev May 2023

sr-dev@lists.kamailio.org

16 participants
324 discussions

[kamailio/kamailio] topoh: memory leak fix for API call (PR #3456)
by Harish S 17 May '23

17 May '23

th_mask_callid_str & th_unmask_callid_str functions used for API call to encode/decode call-ID uses static array declaration for callid_mbuf was unable to free callid data lump after use and leads to memory leak. when these functions was used through API call for topos module memory leak bug as reported qm_free(): BUG: bad pointer 0x7faec4a7xxxx (out of memory block!) called from core: core/data_lump.c: free_lump(470) This two funtions are not used other than API.   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3456 -- Commit Summary -- * topoh: memory leak fix for API call -- File Changes -- M src/modules/topoh/th_msg.c (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3456.patch https://github.com/kamailio/kamailio/pull/3456.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3456 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3456(a)github.com>

2 1

git:5.7:a6513043: pkg/kamailio/obs: packaged math module
by Sergey Safarov 17 May '23

17 May '23

Module: kamailio Branch: 5.7 Commit: a651304380283854f916b8e6fae8ff0a4937d411 URL: https://github.com/kamailio/kamailio/commit/a651304380283854f916b8e6fae8ff0… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2023-05-17T10:24:24+03:00 pkg/kamailio/obs: packaged math module (cherry picked from commit bafefbc841eb7a6929baeff0b3fbe185860f4290) --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/a651304380283854f916b8e6fae8ff0… Patch: https://github.com/kamailio/kamailio/commit/a651304380283854f916b8e6fae8ff0… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index bb608525b54..838aaf7530e 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1570,6 +1570,7 @@ fi %doc %{_docdir}/kamailio/modules/README.kex %doc %{_docdir}/kamailio/modules/README.lrkproxy %doc %{_docdir}/kamailio/modules/README.mangler +%doc %{_docdir}/kamailio/modules/README.math %doc %{_docdir}/kamailio/modules/README.matrix %doc %{_docdir}/kamailio/modules/README.maxfwd %doc %{_docdir}/kamailio/modules/README.mediaproxy @@ -1731,6 +1732,7 @@ fi %{_libdir}/kamailio/modules/kex.so %{_libdir}/kamailio/modules/lrkproxy.so %{_libdir}/kamailio/modules/mangler.so +%{_libdir}/kamailio/modules/math.so %{_libdir}/kamailio/modules/matrix.so %{_libdir}/kamailio/modules/maxfwd.so %{_libdir}/kamailio/modules/mediaproxy.so

1 0

git:master:fe4c47bb: siptrace: fix destination target parameter on ki_sip_trace_msg
by Victor Seva 17 May '23

17 May '23

Module: kamailio Branch: master Commit: fe4c47bb47e466af2eddc0a8987c13cb976e5a3b URL: https://github.com/kamailio/kamailio/commit/fe4c47bb47e466af2eddc0a8987c13c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-05-17T09:22:10+02:00 siptrace: fix destination target parameter on ki_sip_trace_msg fixes #3457 --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/fe4c47bb47e466af2eddc0a8987c13c… Patch: https://github.com/kamailio/kamailio/commit/fe4c47bb47e466af2eddc0a8987c13c… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 0a2d9b327e1..538e3b6a70b 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1231,7 +1231,14 @@ static int w_sip_trace_msg(sip_msg_t *msg, char *vmsg, char *saddr, char *taddr, static int ki_sip_trace_msg(sip_msg_t *msg, str *vmsg, str *saddr, str *taddr, str *duri, str *corrid) { - trace_send_hep_duplicate(vmsg, saddr, taddr, (duri && duri->len>0)?&duri:NULL, + dest_info_t dest; + if(duri && duri->len>0) { + if (siptrace_parse_uri(duri, &dest) < 0) { + LM_ERR("failed to parse mirroring destination uri\n"); + return -1; + } + } + trace_send_hep_duplicate(vmsg, saddr, taddr, (duri && duri->len>0)?&dest:NULL, (corrid && corrid->len>0)?corrid:NULL); return 1;

1 0

[kamailio/kamailio] build warning (Issue #3457)
by sergey-safarov 17 May '23

17 May '23

**incompatible-pointer-types** ``` make[3]: 'libsrdb1.so.1.0' is up to date. LD (gcc) [M sipcapture.so] sipcapture.so CC (gcc) [M siptrace.so] siptrace.o siptrace.c: In function 'ki_sip_trace_msg': siptrace.c:1234:74: warning: passing argument 4 of 'trace_send_hep_duplicate' from incompatible pointer type [-Wincompatible-pointer-types] trace_send_hep_duplicate(vmsg, saddr, taddr, (duri && duri->len>0)?&duri:NULL, ^ In file included from siptrace.c:58: siptrace_hep.h:30:34: note: expected 'struct dest_info *' but argument is of type 'str **' {aka 'struct _str **'} str *body, str *from, str *to, struct dest_info *, str *correlation_id); ^~~~~~~~~~~~~~~~~~ CC (gcc) [M siptrace.so] siptrace_hep.o CC (gcc) [M siptrace.so] siptrace_send.o ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3457 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3457(a)github.com>

2 1

git:master:bafefbc8: pkg/kamailio/obs: packaged math module
by Sergey Safarov 17 May '23

17 May '23

Module: kamailio Branch: master Commit: bafefbc841eb7a6929baeff0b3fbe185860f4290 URL: https://github.com/kamailio/kamailio/commit/bafefbc841eb7a6929baeff0b3fbe18… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2023-05-17T09:23:07+03:00 pkg/kamailio/obs: packaged math module --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/bafefbc841eb7a6929baeff0b3fbe18… Patch: https://github.com/kamailio/kamailio/commit/bafefbc841eb7a6929baeff0b3fbe18… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index bb608525b54..838aaf7530e 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1570,6 +1570,7 @@ fi %doc %{_docdir}/kamailio/modules/README.kex %doc %{_docdir}/kamailio/modules/README.lrkproxy %doc %{_docdir}/kamailio/modules/README.mangler +%doc %{_docdir}/kamailio/modules/README.math %doc %{_docdir}/kamailio/modules/README.matrix %doc %{_docdir}/kamailio/modules/README.maxfwd %doc %{_docdir}/kamailio/modules/README.mediaproxy @@ -1731,6 +1732,7 @@ fi %{_libdir}/kamailio/modules/kex.so %{_libdir}/kamailio/modules/lrkproxy.so %{_libdir}/kamailio/modules/mangler.so +%{_libdir}/kamailio/modules/math.so %{_libdir}/kamailio/modules/matrix.so %{_libdir}/kamailio/modules/maxfwd.so %{_libdir}/kamailio/modules/mediaproxy.so

1 0

git:5.7:72db97b7: pkg/kamailio/deb: version set 5.7.0 [skip ci]
by Victor Seva 17 May '23

17 May '23

Module: kamailio Branch: 5.7 Commit: 72db97b7b8618e6cc9eed80ef670495547b7c2d0 URL: https://github.com/kamailio/kamailio/commit/72db97b7b8618e6cc9eed80ef670495… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-05-17T08:13:45+02:00 pkg/kamailio/deb: version set 5.7.0 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/72db97b7b8618e6cc9eed80ef670495… Patch: https://github.com/kamailio/kamailio/commit/72db97b7b8618e6cc9eed80ef670495…

1 0

Releasing Kamailio v5.7.0
by Daniel-Constantin Mierla 17 May '23

17 May '23

Hello, with a few public holidays coming soon around here, I am considering to release 5.7.0 this week on Wednesday, May 17, 2023. Rather short notice, but there were no major bug reports that need to be tracked. The list of new features is being built in the wiki: - https://github.com/kamailio/kamailio-wiki/blob/main/docs/features/new-in-5.… The other tutorials related to this major release should be ready by then as well. Should anyone think more time is needed, then it can be postponed, not a problem at all. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - June 5-7, 2023 - www.kamailioworld.com

1 1

git:5.7:422d469f: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 16 May '23

16 May '23

Module: kamailio Branch: 5.7 Commit: 422d469fb52c31074ff00eec445eff45fdfebb39 URL: https://github.com/kamailio/kamailio/commit/422d469fb52c31074ff00eec445eff4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-05-16T18:16:35+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/topos/README --- Diff: https://github.com/kamailio/kamailio/commit/422d469fb52c31074ff00eec445eff4… Patch: https://github.com/kamailio/kamailio/commit/422d469fb52c31074ff00eec445eff4… --- diff --git a/src/modules/topos/README b/src/modules/topos/README index 1f8e8c191dd..be21cb2ef51 100644 --- a/src/modules/topos/README +++ b/src/modules/topos/README @@ -171,6 +171,7 @@ Chapter 1. Admin Guide requests). * database module - to store the data for topology stripping and restoring. + * topoh module - in case of Call-ID mask for Call-ID masking. 2.2. External Libraries or Applications @@ -228,11 +229,11 @@ modparam("topos", "db_url", "dbdriver://username:password@dbhost/dbname") 3.3. mask_callid (int) - Note: this functionality is not implemented yet - the parameter is - present in order to be in pair with topoh module. - - Whether to replace or not the Call-ID with another unique id generated - by Kamailio. + Whether to encode the Call-id: header. Some SIP extensions include the + Call-id in the SIP message payload or header, so it is safe to not + encode Call-id in such cases. Well-known extensions such as call + transfer or conference join will be added to work with encoded Call-id. + Topoh module should be loaded with use_mode paramerter set to 1 Default value is 0 (do not mask).

1 0

git:5.7:7e53506f: topos: formatting and debug cleanup after last commit with callid masking
by Daniel-Constantin Mierla 16 May '23

16 May '23

Module: kamailio Branch: 5.7 Commit: 7e53506f27a6198d5f64799f2a8d672c5212d69c URL: https://github.com/kamailio/kamailio/commit/7e53506f27a6198d5f64799f2a8d672… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-16T18:04:07+02:00 topos: formatting and debug cleanup after last commit with callid masking (cherry picked from commit f4dc688548aa7753af93ce6e9089b53e9fc4c7ec) --- Modified: src/modules/topos/topos_mod.c Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/7e53506f27a6198d5f64799f2a8d672… Patch: https://github.com/kamailio/kamailio/commit/7e53506f27a6198d5f64799f2a8d672…

1 0

git:5.7:7e1f330e: Topos: Added CallID Mask Document for Topos
by Daniel-Constantin Mierla 16 May '23

16 May '23

Module: kamailio Branch: 5.7 Commit: 7e1f330e2dc916138aa9a899da49c452b9f59740 URL: https://github.com/kamailio/kamailio/commit/7e1f330e2dc916138aa9a899da49c45… Author: harish <toharishs(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-05-16T18:03:54+02:00 Topos: Added CallID Mask Document for Topos Added document for Call-ID Mask in Topos Module (cherry picked from commit 14d4b2422c0fed27fecf01665197f9d0669aa24e) --- Modified: src/modules/topos/doc/topos_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7e1f330e2dc916138aa9a899da49c45… Patch: https://github.com/kamailio/kamailio/commit/7e1f330e2dc916138aa9a899da49c45… --- diff --git a/src/modules/topos/doc/topos_admin.xml b/src/modules/topos/doc/topos_admin.xml index dcf61a0fed6..82e7c1e45eb 100644 --- a/src/modules/topos/doc/topos_admin.xml +++ b/src/modules/topos/doc/topos_admin.xml @@ -57,6 +57,12 @@ for topology stripping and restoring. </para> </listitem> + <listitem> + <para> + <emphasis>topoh module</emphasis> - in case of Call-ID mask + for Call-ID masking. + </para> + </listitem> </itemizedlist> </para> </section> @@ -130,14 +136,14 @@ modparam("topos", "db_url", "&exampledb;") <section id="topos.p.mask_callid"> <title><varname>mask_callid</varname> (int)</title> <para> - Note: this functionality is not implemented yet - the - parameter is present in order to be in pair with topoh - module. - </para> - <para> - Whether to replace or not the Call-ID with another - unique id generated by &kamailio;. + Whether to encode the Call-id: header. Some SIP extensions include + the Call-id in the SIP message payload or header, so it is safe to + not encode Call-id in such cases. Well-known extensions such as + call transfer or conference join will be added to work with encoded + Call-id. + Topoh module should be loaded with use_mode paramerter set to 1 </para> + <para> <emphasis> Default value is 0 (do not mask).

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
33
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2023