sr-dev October 2024

sr-dev@lists.kamailio.org

14 participants
114 discussions

git:master:35a87c98: ims_usrloc_pcscf: fix warning deprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 35a87c98f4e84b65f82376dfb57050f43d0f355f URL: https://github.com/kamailio/kamailio/commit/35a87c98f4e84b65f82376dfb57050f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:26:32+02:00 ims_usrloc_pcscf: fix warning deprecated-non-prototype > In file included from usrloc_db.c:12: > Warning: ./usrloc_db.h:131:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype] > int use_location_pcscf_table(); > ^ > usrloc_db.c:113:5: note: conflicting prototype is here > int use_location_pcscf_table(str *domain) > ^ > 1 warning generated. --- Modified: src/modules/ims_usrloc_pcscf/usrloc_db.h --- Diff: https://github.com/kamailio/kamailio/commit/35a87c98f4e84b65f82376dfb57050f… Patch: https://github.com/kamailio/kamailio/commit/35a87c98f4e84b65f82376dfb57050f… --- diff --git a/src/modules/ims_usrloc_pcscf/usrloc_db.h b/src/modules/ims_usrloc_pcscf/usrloc_db.h index 3c50c153b4e..688387b1b2d 100644 --- a/src/modules/ims_usrloc_pcscf/usrloc_db.h +++ b/src/modules/ims_usrloc_pcscf/usrloc_db.h @@ -128,7 +128,7 @@ typedef struct reusable_buffer int data_len; } t_reusable_buffer; -int use_location_pcscf_table(); +int use_location_pcscf_table(str *domain); void destroy_db(); int init_db(const str *db_url, int db_update_period, int fetch_num_rows); int connect_db(const str *db_url);

1 0

git:master:7dcc8405: ims_usrloc_pcscf: fix warnings deprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 7dcc8405ccec19132d27516426137e35e464d4ad URL: https://github.com/kamailio/kamailio/commit/7dcc8405ccec19132d27516426137e3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:23:08+02:00 ims_usrloc_pcscf: fix warnings deprecated-non-prototype > In file included from pcontact.c:46: > Warning: ./pcontact.h:63:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype] > int new_pcontact( > ^ > pcontact.c:166:5: note: conflicting prototype is here > int new_pcontact(struct udomain *_d, str *_contact, struct pcontact_info *_ci, > ^ > 1 warning generated. > Warning: udomain.c:232:17: warning: passing arguments to 'new_pcontact' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > if(new_pcontact(_d->name, _contact, _ci, _c) < 0) { > ^ > 1 warning generated. --- Modified: src/modules/ims_usrloc_pcscf/pcontact.c Modified: src/modules/ims_usrloc_pcscf/pcontact.h Modified: src/modules/ims_usrloc_pcscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/7dcc8405ccec19132d27516426137e3… Patch: https://github.com/kamailio/kamailio/commit/7dcc8405ccec19132d27516426137e3… --- diff --git a/src/modules/ims_usrloc_pcscf/pcontact.c b/src/modules/ims_usrloc_pcscf/pcontact.c index 76e061fe529..a885cd285e7 100644 --- a/src/modules/ims_usrloc_pcscf/pcontact.c +++ b/src/modules/ims_usrloc_pcscf/pcontact.c @@ -192,7 +192,7 @@ int new_pcontact(struct udomain *_d, str *_contact, struct pcontact_info *_ci, memcpy(p, _contact->s, _contact->len); p += _contact->len; (*_c)->aor.len = _contact->len; - (*_c)->domain = (str *)_d; + (*_c)->domain = _d->name; if(parse_uri((*_c)->aor.s, (*_c)->aor.len, &sip_uri) != 0) { LM_ERR("unable to determine contact host from uri [%.*s\n", diff --git a/src/modules/ims_usrloc_pcscf/pcontact.h b/src/modules/ims_usrloc_pcscf/pcontact.h index f1c130f4470..6f45d5aace2 100644 --- a/src/modules/ims_usrloc_pcscf/pcontact.h +++ b/src/modules/ims_usrloc_pcscf/pcontact.h @@ -60,8 +60,8 @@ void insert_ppublic(struct pcontact *_c, ppublic_t *_p); int new_ppublic(str *public_identity, int is_default, ppublic_t **_p); void free_ppublic(ppublic_t *_p); -int new_pcontact( - /*str* _dom, str* public_identity, int reg_state, int barring, ims_subscription** s, str* ccf1, str* ccf2, str* ecf1, str* ecf2, impurecord_t** _r*/); +int new_pcontact(struct udomain *_d, str *_contact, struct pcontact_info *_ci, + struct pcontact **_c); void free_pcontact(pcontact_t *_c); void print_pcontact(FILE *_f, pcontact_t *_r); ppublic_t *mem_insert_ppublic( diff --git a/src/modules/ims_usrloc_pcscf/udomain.c b/src/modules/ims_usrloc_pcscf/udomain.c index 248684cb00b..27158128d13 100644 --- a/src/modules/ims_usrloc_pcscf/udomain.c +++ b/src/modules/ims_usrloc_pcscf/udomain.c @@ -229,7 +229,7 @@ int mem_insert_pcontact(struct udomain *_d, str *_contact, { int sl; - if(new_pcontact(_d->name, _contact, _ci, _c) < 0) { + if(new_pcontact(_d, _contact, _ci, _c) < 0) { LM_ERR("creating pcontact failed\n"); return -1; }

1 0

git:master:f49012d1: cdp: fix warning deprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: f49012d15a06b27875cf6bca211ad953968b5217 URL: https://github.com/kamailio/kamailio/commit/f49012d15a06b27875cf6bca211ad95… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:10:57+02:00 cdp: fix warning deprecated-non-prototype > Warning: peerstatemachine.c:120:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:182:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:395:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:400:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:420:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:462:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > Warning: peerstatemachine.c:467:19: warning: passing arguments to 'log_peer_list' without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > log_peer_list(L_INFO); > ^ > 7 warnings generated. --- Modified: src/modules/cdp/peerstatemachine.c --- Diff: https://github.com/kamailio/kamailio/commit/f49012d15a06b27875cf6bca211ad95… Patch: https://github.com/kamailio/kamailio/commit/f49012d15a06b27875cf6bca211ad95… --- diff --git a/src/modules/cdp/peerstatemachine.c b/src/modules/cdp/peerstatemachine.c index 97edb129549..2571e5df252 100644 --- a/src/modules/cdp/peerstatemachine.c +++ b/src/modules/cdp/peerstatemachine.c @@ -117,7 +117,7 @@ int sm_process( R_Disc(p); p->state = Closed; } - log_peer_list(L_INFO); + log_peer_list(); break; case Stop: /* just ignore this state */ @@ -134,7 +134,7 @@ int sm_process( case I_Rcv_Conn_Ack: p->state = Wait_I_CEA; I_Snd_CER(p); - if (p->state == Closed) + if(p->state == Closed) sm_process(p, Start, 0, 1, 0); break; case I_Rcv_Conn_NAck: @@ -179,7 +179,7 @@ int sm_process( Cleanup(p, p->I_sock); p->state = Closed; } - log_peer_list(L_INFO); + log_peer_list(); break; case R_Conn_CER: if(p->r_cer) @@ -392,12 +392,12 @@ int sm_process( Snd_DPA(p, msg, AAA_SUCCESS, p->R_sock); R_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case R_Peer_Disc: R_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case R_Rcv_CER: result_code = Process_CER(p, msg); @@ -417,7 +417,7 @@ int sm_process( /*R_Disc(p);p.state = Closed;*/ p->state = R_Open; /* Or maybe I should disconnect it?*/ } - log_peer_list(L_INFO); + log_peer_list(); break; default: LM_ERR("sm_process(): In state %s invalid event %s\n", @@ -459,12 +459,12 @@ int sm_process( Snd_DPA(p, msg, 2001, p->I_sock); I_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case I_Peer_Disc: I_Disc(p); p->state = Closed; - log_peer_list(L_INFO); + log_peer_list(); break; case I_Rcv_CER: result_code = Process_CER(p, msg); @@ -669,13 +669,13 @@ void I_Snd_CER(peer *p) if((ret = getsockname(p->I_sock, &(addr_u.addr), &addrlen)) == -1) { LM_ERR("I_Snd_CER(): Error on finding local host address > %s\n", strerror(errno)); - Cleanup(p,p->I_sock); + Cleanup(p, p->I_sock); p->state = Closed; AAAFreeMessage(&cer); return; } - if (ret != -1) { + if(ret != -1) { switch(addr_u.addr.sa_family) { case AF_INET: set_2bytes(x, 1);

1 0

git:master:03e49d4e: presence: fix warning conflicting prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 03e49d4e1d806f39ee6aadaedd183a6578108d96 URL: https://github.com/kamailio/kamailio/commit/03e49d4e1d806f39ee6aadaedd183a6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:07:37+02:00 presence: fix warning conflicting prototype > Warning: presence_dmq.c:38:5: warning: a function declaration without a prototype is deprecated in all versions of C and is treated as a zero-parameter prototype in C2x, conflicting with a subsequent definition [-Wdeprecated-non-prototype] > int pres_dmq_send_all_presentities(); > ^ > presence_dmq.c:487:5: note: conflicting prototype is here > int pres_dmq_send_all_presentities(dmq_node_t *dmq_node) > ^ > 1 warning generated. --- Modified: src/modules/presence/presence_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/03e49d4e1d806f39ee6aadaedd183a6… Patch: https://github.com/kamailio/kamailio/commit/03e49d4e1d806f39ee6aadaedd183a6… --- diff --git a/src/modules/presence/presence_dmq.c b/src/modules/presence/presence_dmq.c index 97c6f5831b5..2e26187383f 100644 --- a/src/modules/presence/presence_dmq.c +++ b/src/modules/presence/presence_dmq.c @@ -35,7 +35,7 @@ dmq_api_t pres_dmqb; dmq_peer_t *pres_dmq_peer = NULL; dmq_resp_cback_t pres_dmq_resp_callback = {&pres_dmq_resp_callback_f, 0}; -int pres_dmq_send_all_presentities(); +int pres_dmq_send_all_presentities(dmq_node_t *dmq_node); int pres_dmq_request_sync(); /**

1 0

git:master:b0e16a57: call_control: fix warning unused variable
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: b0e16a57eab4d4d4113054aa2b79452da82dd7c9 URL: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:20+02:00 call_control: fix warning unused variable > Warning: call_control.c:1098:7: warning: unused variable 'param' [-Wunused-variable] > int *param; > ^ > Warning: call_control.c:1099:13: warning: unused variable 'type' [-Wunused-variable] > modparam_t type; > ^ > 2 warnings generated. --- Modified: src/modules/call_control/call_control.c --- Diff: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… Patch: https://github.com/kamailio/kamailio/commit/b0e16a57eab4d4d4113054aa2b79452… --- diff --git a/src/modules/call_control/call_control.c b/src/modules/call_control/call_control.c index 41b36eeedd6..a635f107324 100644 --- a/src/modules/call_control/call_control.c +++ b/src/modules/call_control/call_control.c @@ -1095,9 +1095,6 @@ static int CallControl(struct sip_msg *msg, char *str1, char *str2) static int mod_init(void) { pv_spec_t avp_spec; - int *param; - modparam_t type; - // initialize the canonical_uri_avp structure if(canonical_uri_avp.spec.s == NULL || canonical_uri_avp.spec.len <= 0) {

1 0

git:master:ce4107a6: tm: fix warning uninitialized variable
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: ce4107a6f654a4bc4462efb90f3cc5e8c73bf9ed URL: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:19+02:00 tm: fix warning uninitialized variable > Warning: t_fwd.c:1919:46: warning: variable 'port' is uninitialized when used here [-Wuninitialized] > ret = forward_request_uac(p_msg, &host, port, &dst); > ^~~~ > t_fwd.c:1843:21: note: initialize the variable 'port' to silence this warning > unsigned short port; > ^ > = 0 > 1 warning generated. --- Modified: src/modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… Patch: https://github.com/kamailio/kamailio/commit/ce4107a6f654a4bc4462efb90f3cc5e… --- diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c index 9568b6adb1b..23e61ae818b 100644 --- a/src/modules/tm/t_fwd.c +++ b/src/modules/tm/t_fwd.c @@ -1840,7 +1840,7 @@ int t_forward_cancel(struct sip_msg *p_msg, struct proxy_l *proxy, int proto, int new_tran; struct dest_info dst; str host; - unsigned short port; + unsigned short port = 0; short comp; t = 0;

1 0

git:master:9475837b: core/rand: fix -Wdeprecated-non-prototype
by Victor Seva 08 Oct '24

08 Oct '24

Module: kamailio Branch: master Commit: 9475837b209c91366e8bb40416552b02c13aaf3a URL: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2024-10-08T13:05:19+02:00 core/rand: fix -Wdeprecated-non-prototype > Warning: core/rand/isaac/rand.c:28:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > void isaac(ctx) randctx *ctx; > ^ > Warning: core/rand/isaac/rand.c:81:6: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype] > void randinit(ctx, flag) randctx *ctx; --- Modified: src/core/rand/isaac/rand.c --- Diff: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… Patch: https://github.com/kamailio/kamailio/commit/9475837b209c91366e8bb40416552b0… --- diff --git a/src/core/rand/isaac/rand.c b/src/core/rand/isaac/rand.c index eb917fdd34f..52d44d5eb6d 100644 --- a/src/core/rand/isaac/rand.c +++ b/src/core/rand/isaac/rand.c @@ -25,7 +25,7 @@ rand.c: By Bob Jenkins. My random number generator, ISAAC. Public Domain. *(r++) = b = ind(mm, y >> RANDSIZL) + x; \ } -void isaac(ctx) randctx *ctx; +void isaac(randctx *ctx) { register ub4 a, b, x, y, *m, *mm, *m2, *r, *mend; mm = ctx->randmem; @@ -78,8 +78,7 @@ void isaac(ctx) randctx *ctx; } /* if (flag==TRUE), then use the contents of randrsl[] to initialize mm[]. */ -void randinit(ctx, flag) randctx *ctx; -word flag; +void randinit(randctx *ctx, word flag) { word i; ub4 a, b, c, d, e, f, g, h;

1 0

[kamailio/kamailio] <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f7cd10b07d8) (Issue #3971)
by 87LuckyMan321 08 Oct '24

08 Oct '24

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) <core> [core/mem/q_malloc.c:519]: qm_free(): BUG: freeing already freed pointer (0x7f7cd10b07d8), called from core: core/xavp.c: xavp_free_unsafe(100), first free core: core/xavp.c: xavp_new_value(116) - ignoring #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.6.4 (x86_64/linux) 0a4d88 (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3971 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3971(a)github.com>

2 3

[kamailio/kamailio] Build for el9 without legacy geoip (PR #3886)
by Oded Arbel 07 Oct '24

07 Oct '24

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #3592 #### Description The `kamailio-geoip` RPM sub package currently builds both the `geoip` module - based on [the old and out of support MaxMind GeoIP library](https://github.com/maxmind/geoip-api-c) - and the newer `geoip2` module - based on [the currently supported `libmaxminddb`](https://github.com/maxmind/libmaxminddb). The old GeoIP C library had its end of support date at May 2022 but for a while was still shipped for many distributions. At this point though, the EPEL repository that shipped the GeoIP library for RHEL-based operating systems, has removed it from their repositories for "Enterprise Linux 9": ![Screenshot_20240620_144233](https://github.com/kamailio/kamailio/assets/381782/bb1f2481-57f7-48af-b0f1-0ba1c14a3042) Therefor builds using the bundled spec file fail on EL9 installations. The suggested change is to add an RPM build option `--with geoip2` that when specified will build just the `geoip2` module for the `kamailio-geoip` RPM subpackage. This build option is not enabled by default, unless the build is running on a RHEL 9 based OS - in which case it is set as the default, because otherwise trivial builds break. To revert to the older behavior in RHEL 9 based OSs (and assuming you have the required unsupported library installed correctly) one will need to set both `--without geoip2 --with geoip`. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3886 -- Commit Summary -- * packaging: RPM build option to build just the geoip2 module * packaging: make 'with geoip2' the default behavior for EL9 -- File Changes -- M pkg/kamailio/obs/kamailio.spec (36) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3886.patch https://github.com/kamailio/kamailio/pull/3886.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3886 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3886(a)github.com>

6 22

[kamailio/kamailio] IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql (orig. from misc/examples/ims/icscf.sql) (PR #3876)
by markusmonka 03 Oct '24

03 Oct '24

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Adding sqlfile ims i-cscf to utils/kamctl/mysql copied from misc/examples/ims/icscf so that sql file will be automatically included in kamailio-mysql-module packages in the future You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3876 -- Commit Summary -- * IMS DB: Adding i-cscf database/tables under utils/kamctl/mysql -- File Changes -- A utils/kamctl/mysql/ims-icscf.sql (94) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3876.patch https://github.com/kamailio/kamailio/pull/3876.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3876 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3876(a)github.com>

4 8

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2024