sr-dev October 2024

sr-dev@lists.kamailio.org

14 participants
115 discussions

[kamailio/kamailio] rtpengine: disable aggressive redetection by default (PR #3992)
by Stefan Mititelu 21 Oct '24

21 Oct '24

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #3297 #### Description  The setup is a kamailio with no available rtpengine. (e.g. has a list with rtpengine urls but those are not reachable) Recently had a crash similar to #3297, but in an outdated kamailio version (5.5.7). Tried to reproduce this in 5.5.7 and 5.8.3 but could not crash any of them. However I managed to get the logs similar to ones right before the crash happened: ``` 2024-10-04T17:39:58.026206+03:00 kamailio[450237]: ERROR: {1 1 INVITE 203-450290(a)192.168.100.93} <core> [core/action.c:1595]: run_actions(): alert - action [corefunc (16)] cfg [/home/stefan/kamailio.cfg:625] took too long [29310906 us] ``` ...directly related to how much rtpengine_manage() function took to execute. So routing of SIP is delayed by that ammount. Tracked this in code, down to where this lock is get, when "aggressive_redetection" modparam is enabled: https://github.com/kamailio/kamailio/blob/66fe6eb71e58a02222d1a2fb00f9a0cdb… I will double check that part of the code, since I don't think a lock get is necessary. It only updates a value inside a node, inside the list of nodes, but not changes the list links at all. (this in another PR) For now I propose to disable this aggressive_redetection mechanism by default. Since it delays the SIP routing logic when no rtpengines available (and in some cases lead to crashes in transaction module). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3992 -- Commit Summary -- * rtpengine: disable aggressive redetection by default -- File Changes -- M src/modules/rtpengine/config.c (2) M src/modules/rtpengine/doc/rtpengine_admin.xml (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3992.patch https://github.com/kamailio/kamailio/pull/3992.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3992 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3992(a)github.com> [View Less]

3 4

git:master:b1aae565: rtpengine: disable aggressive redetection by default (#3992)
by GitHub 21 Oct '24

21 Oct '24

Module: kamailio Branch: master Commit: b1aae5658e84453ce5849a627832efbbb6c20117 URL: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: GitHub <noreply(a)github.com> Date: 2024-10-21T08:53:39-04:00 rtpengine: disable aggressive redetection by default (#3992) --- Modified: src/modules/rtpengine/config.c Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.… [View More]

1 0

[kamailio/kamailio] app_python3s: initial support for free-threading Python (PR #3987)
by space88man 19 Oct '24

19 Oct '24

3 17

git:master:62b4ee4a: app_python3s: refactor GIL and thread state handling
by S-P Chan 19 Oct '24

19 Oct '24

Module: kamailio Branch: master Commit: 62b4ee4a0d0b62b35c8bdf67e5daf9cbe9a28499 URL: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-10-19T10:15:34+08:00 app_python3s: refactor GIL and thread state handling * incorrectly using PyGILState_XXX functions; these functions are for threads launched by Python unaware libraries * if the KEMI script used … [View More]

1 0

git:master:c81b2b33: app_python3s: initial support for free-threading Python
by S-P Chan 19 Oct '24

19 Oct '24

Module: kamailio Branch: master Commit: c81b2b3383c5900aba83672da024c812d8e6d89d URL: https://github.com/kamailio/kamailio/commit/c81b2b3383c5900aba83672da024c81… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-10-19T10:15:34+08:00 app_python3s: initial support for free-threading Python * build the modules as free-threading compatible if free-threading Python is detected * can be gated by -DKSR_PYTHON_DISABLE_FREETHREADING … [View More]

1 0

git:master:c7f89e81: core: parser sdp - check if body is enough for rtpmap
by Daniel-Constantin Mierla 17 Oct '24

17 Oct '24

Module: kamailio Branch: master Commit: c7f89e81504c425a83f3423bc4b4d9d1a8a48909 URL: https://github.com/kamailio/kamailio/commit/c7f89e81504c425a83f3423bc4b4d9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-17T08:21:43+02:00 core: parser sdp - check if body is enough for rtpmap --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

[kamailio/kamailio] Usrloc keepalive: Not sending OPTIONS to UDP endpoints- 5.8.0 and 5.8.1 (Issue #3844)
by Luke Escudé 17 Oct '24

17 Oct '24

Running compiled Kamailio 5.8.1 (previously 5.8.0) on Debian 12 64-bit We're seeing an issue with UDP endpoints (this issue does not happen with TCP and TLS) where usrloc will not send OPTIONS packet keepalives. Here are all of our usrloc parameters: modparam("usrloc", "db_mode", 0) modparam("usrloc", "ka_domain", "SIPDOMAIN") #-- SIPDOMAIN is a fqdn modparam("usrloc", "ka_from", "sip:proxy-ping@SIPDOMAIN") modparam("usrloc", "ka_mode", 1) modparam("usrloc", "timer_interval", 20) #-- How … [View More]

4 9

git:master:1869a9d9: modules: readme files regenerated - async ... [skip ci]
by Kamailio Dev 16 Oct '24

16 Oct '24

Module: kamailio Branch: master Commit: 1869a9d9a7639c6e18e0cc14779a0078ae165917 URL: https://github.com/kamailio/kamailio/commit/1869a9d9a7639c6e18e0cc14779a007… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-10-16T12:01:11+02:00 modules: readme files regenerated - async ... [skip ci] --- Modified: src/modules/async/README Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/… [View More]

1 0

git:master:cce29af4: async: docs updates for async_sleep()
by Daniel-Constantin Mierla 16 Oct '24

16 Oct '24

Module: kamailio Branch: master Commit: cce29af41120cf30c4c22979e772d1ca666408c6 URL: https://github.com/kamailio/kamailio/commit/cce29af41120cf30c4c22979e772d1c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-16T11:46:37+02:00 async: docs updates for async_sleep() --- Modified: src/modules/async/doc/async_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]cce29af41120cf30c4c22979e772d1c… Patch: https://github.com/kamailio/kamailio/commit/cce29af41120cf30c4c22979e772d1c… --- diff --git a/src/modules/async/doc/async_admin.xml b/src/modules/async/doc/async_admin.xml index 027cea11ed7..152c6be5db7 100644 --- a/src/modules/async/doc/async_admin.xml +++ b/src/modules/async/doc/async_admin.xml @@ -234,8 +234,11 @@ route[RESUME] { </title> <para> Simulate a sleep of 'seconds' and then continue the processing of SIP - request with the next action. In case of internal errors, the function - returns false. + request with the next action. Note that the processing continues till + the last action in the current route block. Consider using async_route() + instead if you want to control better what is executed after the wait + time. Beacuse the execution is resumed in another process, do not use + private memory variables before and after the async sleep. </para> <para> The sleep parameter represent the number of seconds to suspend the @@ -243,6 +246,9 @@ route[RESUME] { a static integer or a variable holding an integer. </para> <para> + In case of internal errors, the function returns false. + </para> + <para> This function can be used from REQUEST_ROUTE. </para> <example> @@ -262,15 +268,13 @@ exit; <function moreinfo="none">async_ms_sleep(milliseconds)</function> </title> <para> - Simulate a sleep of 'milliseconds' and then continue the processing of SIP - request with the next action. In case of internal errors, the function - returns false. - This function works only if the ms_timer parameter has a value greater than 0. + Similar to async_sleep(), but with a 'milliseconds' parameter. This + function works only if the ms_timer parameter has a value greater than 0. </para> <para> The sleep parameter represent the number of milliseconds to suspend the - processing of SIP request. Maximum value is 30000 (30 sec). The parameter can be - a static integer or a variable holding an integer. + processing of SIP request. Maximum value is 30000 (30 sec). The parameter + can be a static integer or a variable holding an integer. </para> <para> This function can be used from REQUEST_ROUTE. [View Less]

1 0

git:master:e18c5203: tls: docs - relocate overview notes to Important Notes section
by Daniel-Constantin Mierla 16 Oct '24

16 Oct '24

Module: kamailio Branch: master Commit: e18c52030e202716df9f5e8e953c19fb4a9c65e2 URL: https://github.com/kamailio/kamailio/commit/e18c52030e202716df9f5e8e953c19f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-16T11:05:04+02:00 tls: docs - relocate overview notes to Important Notes section --- Modified: src/modules/tls/doc/tls.xml --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]e18c52030e202716df9f5e8e953c19f… Patch: https://github.com/kamailio/kamailio/commit/e18c52030e202716df9f5e8e953c19f… --- diff --git a/src/modules/tls/doc/tls.xml b/src/modules/tls/doc/tls.xml index 3a0416fed61..53397e2d50a 100644 --- a/src/modules/tls/doc/tls.xml +++ b/src/modules/tls/doc/tls.xml @@ -60,27 +60,9 @@ must be added to the Kamailio config file. </para> <para> - IMPORTANT: the tls module must be loaded before any other &kamailio; module - that uses libssl (OpenSSL library). A safe option is to have the tls module - loaded first (be in the first "loadmodule" in &kamailio;.cfg). - </para> - <para> - IMPORTANT: For libssl v3.x, the core parameter "tls_threads_mode" - has to be set, see the Core Cookbook for possible values. - </para> - <para> - IMPORTANT: using this module compiled with newer versions of libssl - (e.g., v1.1+) may require &kamailio; to be started with - <emphasis>--atexit=no</emphasis> command line parameters to avoid - calling C atexit callbacks inside the process ending during - daemonize procedure as well as during shut down, which can lead - to crashes because it destroys and then accesses shared memory. For - example, such case has been reported for Ubuntu 20.04 or RedHat 8. - </para> - <para> - Note: with some particular combination of OS, openssl and mysql-client - libraries, there were reports of random crashes, in such case try to set - the db_mysql module parameter opt_ssl_mode to 1. + Read the "Important Notes" section because it has relevant information + about configuring properly the module for various libssl versions, + components and operating systems. </para> </section> <section id="tls.quick_start"> @@ -134,7 +116,7 @@ request_route { <para> The TLS module needs some special options enabled when compiling Kamailio. These options are enabled by default, however in case - you're using a modified Kamailio version or Makefile, make sure + you are using a modified Kamailio version or Makefile, make sure that you enable -DUSE_TLS and -DTLS_HOOKS (or compile with make TLS_HOOKS=1 which will take care of both options). </para> @@ -188,6 +170,29 @@ request_route { </itemizedlist> The bug reports can be viewed at <ulink url="http://rt.openssl.org/">http://rt.openssl.org/</ulink>. </para> + <para> + Note 1: the tls module must be loaded before any other &kamailio; module + that uses libssl (OpenSSL library). A safe option is to have the tls module + loaded first (be in the first "loadmodule" in &kamailio;.cfg). + </para> + <para> + Note 2: for libssl v3.x, the core parameter "tls_threads_mode" + has to be set, see the Core Cookbook for possible values. + </para> + <para> + Note 3: using this module compiled with newer versions of libssl + (e.g., v1.1+) may require &kamailio; to be started with + <emphasis>--atexit=no</emphasis> command line parameters to avoid + calling C atexit callbacks inside the process ending during + daemonize procedure as well as during shut down, which can lead + to crashes because it destroys and then accesses shared memory. For + example, such case has been reported for Ubuntu 20.04 or RedHat 8. + </para> + <para> + Note 4: with some particular combination of OS, openssl and mysql-client + libraries, there were reports of random crashes, in such case try to set + the db_mysql module parameter opt_ssl_mode to 1. + </para> </section> [View Less]

1 0

← Newer
1
...
5
6
7
8
9
10
11
12
Older →

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2024