sr-dev October 2024

sr-dev@lists.kamailio.org

14 participants
110 discussions

git:master:0cbb2eb0: jwt: print decode result in error log message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0cbb2eb035c7d2a29ae707cde94a2c0573e0ffd5 URL: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-22T07:34:29+02:00 jwt: print decode result in error log message --- Modified: src/modules/jwt/jwt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… Patch: https://github.com/kamailio/kamailio/commit/0cbb2eb035c7d2a29ae707cde94a2c0… --- diff --git a/src/modules/jwt/jwt_mod.c b/src/modules/jwt/jwt_mod.c index 0efb793c47f..af3d42f79c5 100644 --- a/src/modules/jwt/jwt_mod.c +++ b/src/modules/jwt/jwt_mod.c @@ -498,7 +498,7 @@ static int ki_jwt_verify_key( ret = jwt_decode( &jwt, jwtval->s, (unsigned char *)kdata.s, (size_t)kdata.len); if(ret != 0 || jwt == NULL) { - LM_ERR("failed to decode jwt value\n"); + LM_ERR("failed to decode jwt value (ret: %d jwt: %p)\n", ret, jwt); goto error; } if(jwt_validate(jwt, jwt_valid) != 0) {

1 month

git:master:6b7894d6: modules: readme files regenerated - rtpengine ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 6b7894d66ca65ca99b5987ddc35a7f28c7a88949 URL: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2024-10-21T15:01:11+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… Patch: https://github.com/kamailio/kamailio/commit/6b7894d66ca65ca99b5987ddc35a7f2… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index 6b1d875d77e..4658b7a3f35 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -674,15 +674,15 @@ modparam("rtpengine", "rtpengine_disable_tout", 20) to all rtpengines, else no rtpengine will be queried until its rtpengine_disable_tout timeout passes. - Default value is ��1�� (enabled). + Default value is ��0�� (disabled). Can be set at runtime, e.g.: $ kamcmd cfg.set_now_int rtpengine aggressive_redetectio -n 0 +n 1 Example 1.3. Set aggressive_redetection parameter ... -modparam("rtpengine", "aggressive_redetection", 0) +modparam("rtpengine", "aggressive_redetection", 1) ... 4.4. rtpengine_tout_ms (integer)

1 month

[kamailio/kamailio] rtpengine: disable aggressive redetection by default (PR #3992)

by Stefan Mititelu

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [X] Related to issue #3297 #### Description  The setup is a kamailio with no available rtpengine. (e.g. has a list with rtpengine urls but those are not reachable) Recently had a crash similar to #3297, but in an outdated kamailio version (5.5.7). Tried to reproduce this in 5.5.7 and 5.8.3 but could not crash any of them. However I managed to get the logs similar to ones right before the crash happened: ``` 2024-10-04T17:39:58.026206+03:00 kamailio[450237]: ERROR: {1 1 INVITE 203-450290(a)192.168.100.93} <core> [core/action.c:1595]: run_actions(): alert - action [corefunc (16)] cfg [/home/stefan/kamailio.cfg:625] took too long [29310906 us] ``` ...directly related to how much rtpengine_manage() function took to execute. So routing of SIP is delayed by that ammount. Tracked this in code, down to where this lock is get, when "aggressive_redetection" modparam is enabled: https://github.com/kamailio/kamailio/blob/66fe6eb71e58a02222d1a2fb00f9a0cdb… I will double check that part of the code, since I don't think a lock get is necessary. It only updates a value inside a node, inside the list of nodes, but not changes the list links at all. (this in another PR) For now I propose to disable this aggressive_redetection mechanism by default. Since it delays the SIP routing logic when no rtpengines available (and in some cases lead to crashes in transaction module). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3992 -- Commit Summary -- * rtpengine: disable aggressive redetection by default -- File Changes -- M src/modules/rtpengine/config.c (2) M src/modules/rtpengine/doc/rtpengine_admin.xml (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3992.patch https://github.com/kamailio/kamailio/pull/3992.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3992 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3992(a)github.com>

1 month

git:master:b1aae565: rtpengine: disable aggressive redetection by default (#3992)

by GitHub

Module: kamailio Branch: master Commit: b1aae5658e84453ce5849a627832efbbb6c20117 URL: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: GitHub <noreply(a)github.com> Date: 2024-10-21T08:53:39-04:00 rtpengine: disable aggressive redetection by default (#3992) --- Modified: src/modules/rtpengine/config.c Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… Patch: https://github.com/kamailio/kamailio/commit/b1aae5658e84453ce5849a627832efb… --- diff --git a/src/modules/rtpengine/config.c b/src/modules/rtpengine/config.c index 7ea1a0d68e9..ba2bd5c5747 100644 --- a/src/modules/rtpengine/config.c +++ b/src/modules/rtpengine/config.c @@ -32,7 +32,7 @@ struct cfg_group_rtpengine default_rtpengine_cfg = { 60, /* default disable timeout in seconds */ - 1, /* default aggressive_redetection enabled */ + 0, /* default aggressive_redetection disabled */ 1000, /* default wait timeout in milliseconds */ MAX_RTPP_TRIED_NODES, 5, /* rtprengine retries */ }; diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index f898aa32979..b443fbc0290 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -219,20 +219,20 @@ modparam("rtpengine", "rtpengine_disable_tout", 20) </para> <para> <emphasis> - Default value is <quote>1</quote> (enabled). + Default value is <quote>0</quote> (disabled). </emphasis> </para> <para> Can be set at runtime, e.g.: <programlisting> - $ &sercmd; cfg.set_now_int rtpengine aggressive_redetection 0 + $ &sercmd; cfg.set_now_int rtpengine aggressive_redetection 1 </programlisting> </para> <example> <title>Set <varname>aggressive_redetection</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("rtpengine", "aggressive_redetection", 0) +modparam("rtpengine", "aggressive_redetection", 1) ... </programlisting> </example>

1 month

[kamailio/kamailio] app_python3s: initial support for free-threading Python (PR #3987)

by space88man

1 month

git:master:62b4ee4a: app_python3s: refactor GIL and thread state handling

by S-P Chan

Module: kamailio Branch: master Commit: 62b4ee4a0d0b62b35c8bdf67e5daf9cbe9a28499 URL: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-10-19T10:15:34+08:00 app_python3s: refactor GIL and thread state handling * incorrectly using PyGILState_XXX functions; these functions are for threads launched by Python unaware libraries * if the KEMI script used Python threading these threads would be blocked after returning to the Kamailio event loop as the GIL was not released Fix is to use Py_BLOCK|UNBLOCK_THREADS macros --- Modified: src/modules/app_python3s/app_python3s_mod.c Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c… Patch: https://github.com/kamailio/kamailio/commit/62b4ee4a0d0b62b35c8bdf67e5daf9c…

1 month

git:master:c81b2b33: app_python3s: initial support for free-threading Python

by S-P Chan

Module: kamailio Branch: master Commit: c81b2b3383c5900aba83672da024c812d8e6d89d URL: https://github.com/kamailio/kamailio/commit/c81b2b3383c5900aba83672da024c81… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2024-10-19T10:15:34+08:00 app_python3s: initial support for free-threading Python * build the modules as free-threading compatible if free-threading Python is detected * can be gated by -DKSR_PYTHON_DISABLE_FREETHREADING --- Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/c81b2b3383c5900aba83672da024c81… Patch: https://github.com/kamailio/kamailio/commit/c81b2b3383c5900aba83672da024c81… --- diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index 38c67b9e1d5..0fb7879ef6b 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -746,6 +746,11 @@ static PyObject *init_KSR(void) /* special sub-modules - x.modf() can have variable number of params */ _sr_apy_ksr_modules_list[m] = PyModule_Create(&KSR_x_moduledef); PyModule_AddObject(_sr_apy_ksr_module, "x", _sr_apy_ksr_modules_list[m]); +#if defined(Py_GIL_DISABLED) && !defined(KSR_PYTHON_DISABLE_FREETHREADING) +#warning Python Free Threading build + PyUnstable_Module_SetGIL(_sr_apy_ksr_module, Py_MOD_GIL_NOT_USED); + PyUnstable_Module_SetGIL(_sr_apy_ksr_modules_list[m], Py_MOD_GIL_NOT_USED); +#endif Py_INCREF(_sr_apy_ksr_modules_list[m]); m++; @@ -781,6 +786,11 @@ static PyObject *init_KSR(void) mmodule->m_size = -1; _sr_apy_ksr_modules_list[m] = PyModule_Create(mmodule); +#if defined(Py_GIL_DISABLED) && !defined(KSR_PYTHON_DISABLE_FREETHREADING) +#warning Python Free Threading build + PyUnstable_Module_SetGIL( + _sr_apy_ksr_modules_list[m], Py_MOD_GIL_NOT_USED); +#endif PyModule_AddObject(_sr_apy_ksr_module, emods[k].kexp[0].mname.s, _sr_apy_ksr_modules_list[m]); Py_INCREF(_sr_apy_ksr_modules_list[m]);

1 month

[kamailio/kamailio] Module dispatcher: ds_is_active() return incorrect. (Issue #4001)

by Minh Vũ

#### Kamailo 5.8 ### Description I use ```ds_is_active function()``` in ```dispatcher``` module. ``` $var(sip_url) = $sht(conf_fs=>$var(conf_id)); # sip:192.168.1.44:5060 if(ds_is_active("1", "$var(sip_url)")){ #### is allways run } ``` or ```ds_is_active("1", $var(sip_url))``` #### Debugging Data When I check dispatcher: ``` "DEST": { "URI": "sip:192.168.1.44:5060", "FLAGS": "IP", "PRIORITY": 0, "ATTRS": { "BODY": "rweight=50;weight=50;cc=1", "DUID": null, "MAXLOAD": 0, "WEIGHT": 50, "RWEIGHT": 50, "SOCKET": null, "SOCKNAME": null, "OBPROXY": null } } ``` Why is the flag set to ```IP```, but ```ds_is_active()``` returns true? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4001 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4001(a)github.com>

1 month, 1 week

git:master:c7f89e81: core: parser sdp - check if body is enough for rtpmap

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c7f89e81504c425a83f3423bc4b4d9d1a8a48909 URL: https://github.com/kamailio/kamailio/commit/c7f89e81504c425a83f3423bc4b4d9d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-10-17T08:21:43+02:00 core: parser sdp - check if body is enough for rtpmap --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c7f89e81504c425a83f3423bc4b4d9d… Patch: https://github.com/kamailio/kamailio/commit/c7f89e81504c425a83f3423bc4b4d9d… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 079a9992402..a74f78abb84 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -152,7 +152,8 @@ int extract_rtpmap(str *body, str *rtpmap_payload, str *rtpmap_encoding, int len; if(strncasecmp(body->s, "a=rtpmap:", 9) != 0) { - /*LM_DBG("We are not pointing to an a=rtpmap: attribute =>`%.*s'\n", body->len, body->s); */ + /*LM_DBG("We are not pointing to an a=rtpmap: attribute =>`%.*s'\n", + * body->len, body->s); */ return -1; }

1 month, 1 week

[kamailio/kamailio] Usrloc keepalive: Not sending OPTIONS to UDP endpoints- 5.8.0 and 5.8.1 (Issue #3844)

by Luke Escudé

Running compiled Kamailio 5.8.1 (previously 5.8.0) on Debian 12 64-bit We're seeing an issue with UDP endpoints (this issue does not happen with TCP and TLS) where usrloc will not send OPTIONS packet keepalives. Here are all of our usrloc parameters: modparam("usrloc", "db_mode", 0) modparam("usrloc", "ka_domain", "SIPDOMAIN") #-- SIPDOMAIN is a fqdn modparam("usrloc", "ka_from", "sip:proxy-ping@SIPDOMAIN") modparam("usrloc", "ka_mode", 1) modparam("usrloc", "timer_interval", 20) #-- How often to qualify endpoints and clean mem tables? modparam("usrloc", "timer_procs", 4) modparam("usrloc", "ka_randomize", 10) modparam("usrloc", "use_domain", 0) modparam("usrloc", "server_id_filter", 1) modparam("usrloc", "ka_filter", 0) modparam("usrloc", "ka_timeout", 60) #-- How quickly to expire a contact if it does not reply to keepalive? modparam("usrloc", "matching_mode", 0) modparam("usrloc", "handle_lost_tcp", 1) modparam("usrloc", "close_expired_tcp", 1) modparam("usrloc", "desc_time_order", 1) modparam("usrloc", "hash_size", 14) It seems usrloc is not actually using timer_interval at all for UDP devices. However, it does seem to be sending OPTIONS every 20 seconds on TCP/TLS. (this is confirmed via packet capture on a SIP phone). -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3844 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3844(a)github.com>

1 month, 1 week

← Newer
1
...
4
5
6
7
8
9
10
11
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2024