sr-dev November 2024

sr-dev@lists.kamailio.org

17 participants
305 discussions

[kamailio/kamailio] db_sqlite: Add busy timeout param to improve concurrency (PR #4029)

by Andreas Granig

It's needed specifically when setting WAL, because on module loading, each child creates its own DB connection and sets the WAL (or other options you might set), and it all happens roughly at the same time. Without setting the busy-timeout, starting of kamailio will fail due to locking issues with sqlite.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4029 -- Commit Summary -- * db_sqlite: Add busy timeout param to improve concurrency -- File Changes -- M src/modules/db_sqlite/db_sqlite.c (52) M src/modules/db_sqlite/db_sqlite.h (1) M src/modules/db_sqlite/dbase.c (16) M src/modules/db_sqlite/doc/db_sqlite.xml (16) M src/modules/db_sqlite/doc/db_sqlite_admin.xml (49) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4029.patch https://github.com/kamailio/kamailio/pull/4029.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4029 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4029(a)github.com>

5 days, 13 hours

git:master:9d21fa05: db_sqlite: Add busy timeout param to improve concurrency

by Andreas Granig

Module: kamailio Branch: master Commit: 9d21fa0562b8b4379b882d89715c58028eb358dd URL: https://github.com/kamailio/kamailio/commit/9d21fa0562b8b4379b882d89715c580… Author: Andreas Granig <agranig(a)linguin.org> Committer: Andreas Granig <agranig(a)linguin.org> Date: 2024-11-19T14:18:09+01:00 db_sqlite: Add busy timeout param to improve concurrency It's needed specifically when setting WAL, because on module loading, each child creates its own DB connection and sets the WAL (or other options you might set), and it all happens roughly at the same time. Without setting the busy-timeout, starting of kamailio will fail due to locking issues with sqlite. --- Modified: src/modules/db_sqlite/db_sqlite.c Modified: src/modules/db_sqlite/db_sqlite.h Modified: src/modules/db_sqlite/dbase.c Modified: src/modules/db_sqlite/doc/db_sqlite.xml Modified: src/modules/db_sqlite/doc/db_sqlite_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9d21fa0562b8b4379b882d89715c580… Patch: https://github.com/kamailio/kamailio/commit/9d21fa0562b8b4379b882d89715c580…

5 days, 13 hours

[kamailio/kamailio] db_sqlite: Add busy timeout param to improve concurrency. (PR #4028)

by Andreas Granig

It's needed specifically when setting WAL, because on module loading, each child creates its own DB connection and sets the WAL (or other options you might set), and it all happens roughly at the same time. Without setting the busy-timeout, starting of kamailio will fail due to locking issues with sqlite.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4028 -- Commit Summary -- * db_sqlite: Add busy timeout param to improve concurrency. -- File Changes -- M src/modules/db_sqlite/db_sqlite.c (52) M src/modules/db_sqlite/db_sqlite.h (1) M src/modules/db_sqlite/dbase.c (13) M src/modules/db_sqlite/doc/db_sqlite_admin.xml (48) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4028.patch https://github.com/kamailio/kamailio/pull/4028.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4028 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4028(a)github.com>

5 days, 13 hours

[kamailio/kamailio] Add timer to ping rtpengine (PR #4016)

by Xenofon Karamanos

- Added parameter to control the interval   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR adds a timer that its interval can be controlled with the param `ping_interval`. The timer pings all registered rtpengines and disables if any are found not responsive and vice versa. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4016 -- Commit Summary -- * Add timer to ping rtpengines -- File Changes -- M src/modules/rtpengine/rtpengine.c (50) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4016.patch https://github.com/kamailio/kamailio/pull/4016.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4016 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4016(a)github.com>

5 days, 14 hours

git:master:0d68c816: textops: free substitution expression for subst_v()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0d68c816bd72be78fef827ee923897f90c521570 URL: https://github.com/kamailio/kamailio/commit/0d68c816bd72be78fef827ee923897f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-19T12:20:21+01:00 textops: free substitution expression for subst_v() --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/0d68c816bd72be78fef827ee923897f… Patch: https://github.com/kamailio/kamailio/commit/0d68c816bd72be78fef827ee923897f… --- diff --git a/src/modules/textops/textops.c b/src/modules/textops/textops.c index d28d7f508cf..8be84dfca3c 100644 --- a/src/modules/textops/textops.c +++ b/src/modules/textops/textops.c @@ -1555,6 +1555,7 @@ static int subst_v_helper_f( if(nmatches < 0) { LM_ERR("substitution failed\n"); } + subst_expr_free(se); return -1; } memset(&val, 0, sizeof(pv_value_t)); @@ -1565,6 +1566,7 @@ static int subst_v_helper_f( pkg_free(result->s); pkg_free(result); + subst_expr_free(se); return 1; }

5 days, 15 hours

git:master:67497692: dispatcher: updated boundary checks for uint32_t ocmin and ocmax

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 67497692ff4a74a5cb3dc774184252243ea5c47b URL: https://github.com/kamailio/kamailio/commit/67497692ff4a74a5cb3dc7741842522… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-19T11:55:34+01:00 dispatcher: updated boundary checks for uint32_t ocmin and ocmax --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/67497692ff4a74a5cb3dc7741842522… Patch: https://github.com/kamailio/kamailio/commit/67497692ff4a74a5cb3dc7741842522… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 83bb7636206..1c31ca3fc95 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -412,13 +412,13 @@ int ds_set_attrs(ds_dest_t *dest, str *vattrs) if(dest->ocdata.ocmax > 100) { dest->ocdata.ocmax = 100; } - if(dest->ocdata.ocmax <= 0) { + if(dest->ocdata.ocmax == 0) { dest->ocdata.ocmax = 100; } if(dest->ocdata.ocmin > 100) { dest->ocdata.ocmin = 0; } - if(dest->ocdata.ocmin < 0) { + if(dest->ocdata.ocmin > dest->ocdata.ocmax) { dest->ocdata.ocmin = 0; } if(dest->ocdata.ocrate > 100) {

5 days, 15 hours

git:master:5957ba50: core: socket info - relocate ip address conversion for log message

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5957ba50c8da1c543272643994190ba015221432 URL: https://github.com/kamailio/kamailio/commit/5957ba50c8da1c543272643994190ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-18T14:19:38+01:00 core: socket info - relocate ip address conversion for log message --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/5957ba50c8da1c543272643994190ba… Patch: https://github.com/kamailio/kamailio/commit/5957ba50c8da1c543272643994190ba… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 35b85d6be7f..566dbf830b1 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -1784,6 +1784,8 @@ int add_interfaces(char *if_name, int family, unsigned short port, continue; if(family && family != ifa->ifa_addr->sa_family) continue; + sockaddr2ip_addr(&addr, (struct sockaddr *)ifa->ifa_addr); + tmp = ip_addr2a(&addr); if(ifa->ifa_addr->sa_family == AF_INET6) { struct sockaddr_in6 *caddr = (struct sockaddr_in6 *)ifa->ifa_addr; if((sr_bind_ipv6_link_local & KSR_IPV6_LINK_LOCAL_SKIP) @@ -1794,8 +1796,6 @@ int add_interfaces(char *if_name, int family, unsigned short port, continue; } } - sockaddr2ip_addr(&addr, (struct sockaddr *)ifa->ifa_addr); - tmp = ip_addr2a(&addr); if(ifa->ifa_flags & IFF_LOOPBACK) flags = SI_IS_LO; else

6 days, 4 hours

git:master:37905817: tsilo: switch to get/set T/branch tm api functions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 37905817d2a5a2e25a357d5797d0e26c9bb80a39 URL: https://github.com/kamailio/kamailio/commit/37905817d2a5a2e25a357d5797d0e26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-18T08:29:43+01:00 tsilo: switch to get/set T/branch tm api functions --- Modified: src/modules/tsilo/ts_append.c --- Diff: https://github.com/kamailio/kamailio/commit/37905817d2a5a2e25a357d5797d0e26… Patch: https://github.com/kamailio/kamailio/commit/37905817d2a5a2e25a357d5797d0e26… --- diff --git a/src/modules/tsilo/ts_append.c b/src/modules/tsilo/ts_append.c index 7ad83aaa02a..406ff7c97b0 100644 --- a/src/modules/tsilo/ts_append.c +++ b/src/modules/tsilo/ts_append.c @@ -113,8 +113,7 @@ int ts_append_to(struct sip_msg *msg, int tindex, int tlabel, char *table, contact->len, contact->s); } - orig_t = _tmb.t_gett(); - orig_branch = _tmb.t_gett_branch(); + _tmb.get_tb(&orig_t, &orig_branch); /* lookup a transaction based on its identifier (hash_index:label) */ if(_tmb.t_lookup_ident(&t, tindex, tlabel) < 0) { @@ -164,7 +163,7 @@ int ts_append_to(struct sip_msg *msg, int tindex, int tlabel, char *table, * Restore the original transaction (if any) */ if(t) _tmb.unref_cell(t); - _tmb.t_sett(orig_t, orig_branch); + _tmb.set_tb(orig_t, orig_branch); return ret; } @@ -212,8 +211,7 @@ int ts_append_branches(sip_msg_t *msg, str *ruri) LM_DBG("transaction %u:%u found for %.*s, going to append branches\n", ptr->tindex, ptr->tlabel, t_uri->len, t_uri->s); - orig_t = _tmb.t_gett(); - orig_branch = _tmb.t_gett_branch(); + _tmb.get_tb(&orig_t, &orig_branch); /* lookup a transaction based on its identifier (hash_index:label) */ if(_tmb.t_lookup_ident(&t, ptr->tindex, ptr->tlabel) < 0 || t == NULL) { @@ -247,7 +245,7 @@ int ts_append_branches(sip_msg_t *msg, str *ruri) /* unref the transaction which had been referred by t_lookup_ident() call. * Restore the original transaction (if any) */ _tmb.unref_cell(t); - _tmb.t_sett(orig_t, orig_branch); + _tmb.set_tb(orig_t, orig_branch); } unlock_entry_by_ruri(t_uri);

6 days, 16 hours

git:master:da33e5bd: tm: exports get/set t/branch functions to intermodule api

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: da33e5bdefb45730f9b0536ec86d0ef7abc8e3d8 URL: https://github.com/kamailio/kamailio/commit/da33e5bdefb45730f9b0536ec86d0ef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-18T06:59:10+01:00 tm: exports get/set t/branch functions to intermodule api --- Modified: src/modules/tm/t_lookup.h Modified: src/modules/tm/tm_load.c Modified: src/modules/tm/tm_load.h --- Diff: https://github.com/kamailio/kamailio/commit/da33e5bdefb45730f9b0536ec86d0ef… Patch: https://github.com/kamailio/kamailio/commit/da33e5bdefb45730f9b0536ec86d0ef… --- diff --git a/src/modules/tm/t_lookup.h b/src/modules/tm/t_lookup.h index e9c019c7b46..25f6d9eaa6e 100644 --- a/src/modules/tm/t_lookup.h +++ b/src/modules/tm/t_lookup.h @@ -79,7 +79,9 @@ int get_t_branch(void); typedef void (*tsett_f)(struct cell *t, int branch); void set_t(struct cell *t, int branch); +typedef void (*tm_get_tb_f)(struct cell **t, int *branch); void tm_get_tb(struct cell **t, int *branch); +typedef void (*tm_set_tb_f)(struct cell *t, int branch); void tm_set_tb(struct cell *t, int branch); #define T_GET_TI "t_get_trans_ident" diff --git a/src/modules/tm/tm_load.c b/src/modules/tm/tm_load.c index 7149873515e..0b4ff49e447 100644 --- a/src/modules/tm/tm_load.c +++ b/src/modules/tm/tm_load.c @@ -144,6 +144,8 @@ int load_tm(struct tm_binds *tmb) tmb->t_release_transaction = t_release_transaction; tmb->t_uas_request_clean_parsed = t_uas_request_clean_parsed; tmb->t_reply_error = ki_t_reply_error; + tmb->get_tb = tm_get_tb; + tmb->set_tb = tm_set_tb; return 1; } diff --git a/src/modules/tm/tm_load.h b/src/modules/tm/tm_load.h index bf41eb789ef..4d160b585dc 100644 --- a/src/modules/tm/tm_load.h +++ b/src/modules/tm/tm_load.h @@ -131,6 +131,8 @@ struct tm_binds trelease_t t_release_transaction; t_uas_request_clean_parsed_f t_uas_request_clean_parsed; t_no_param_f t_reply_error; + tm_get_tb_f get_tb; + tm_set_tb_f set_tb; }; typedef struct tm_binds tm_api_t;

6 days, 16 hours

[kamailio/kamailio] no corresponding socket found error (Issue #3583)

by descartin

Hello all we are seeing these kind of logs in a Debian GNU/Linux 11 using kamailio 5.5.6 ```Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155702]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[164.152.22.248:5060](http://164.152.22.248:5060/)) Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155698]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.184:5060](http://208.74.138.184:5060/)) Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155695]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.181:5060](http://208.74.138.181:5060/)) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155693]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[38.102.250.60:5060](http://38.102.250.60:5060/)) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[87.1.1.27:5060](http://87.1.1.27:5060/)) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [ut.h:302]: uri2dst2(): no corresponding socket for "87.1.1.27" af 2 Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [t_fwd.c:470]: prepare_new_uac(): can't fwd to af 2, proto 1 (no corresponding listening socket) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155697]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.184:5060](http://208.74.138.184:5060/)) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155694]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[192.40.216.97:5060](http://192.40.216.97:5060/)) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155694]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.180:5060](http://208.74.138.180:5060/)) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155714]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[87.1.1.27:5060](http://87.1.1.27:5060/)) ``` The kamailio instance we are using is receiving around 1500 calls per second in average when we do start seeing these errors more frequently In this instance we are using multihomed the listen address list is ``` children=14 socket_workers=1 listen=udp:[192.168.99.70:5081](http://192.168.99.70:5081/) listen=udp:[192.168.99.81:5060](http://192.168.99.81:5060/) listen=udp:[87.1.1.27:5060](http://87.1.1.27:5060/) listen=tcp:[192.168.96.105:8095](http://192.168.96.105:8095/) listen=tcp:[87.1.1.27:5060](http://87.1.1.27:5060/) tcp_children=6 port=5060 ``` We use the first worker only to perform the OPTIONS requests from the dispatcher module. The sockets listen=udp:[192.168.99.81:5060](http://192.168.99.81:5060/) listen=udp:[87.1.1.27:5060](http://87.1.1.27:5060/) are used to communicate both A and B legs so when a message is received at [192.168.99.81:5060](http://192.168.99.81:5060/) we send it to [87.1.1.27:5060](http://87.1.1.27:5060/) and viceversa We were using $fs variable before doing the t_relay() function. This way is working, but when load increases, seems sometimes kamailio doesn't get the proper socket to forward the reply. I think the errors mainly are related to responses which are being forwarded, like if the function get_sock_info_list was not able to retrieve the listen interfaces we have tried to set in the onreply routes the commands set_recv_socket("udp:[192.168.99.81:5060](http://192.168.99.81:5060/)"); set_send_socket("udp:[87.1.1.27:5060](http://87.1.1.27:5060/)"); (when reply goes from private to public domain) and it seems it reduces the number of ``` Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155702]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[164.152.22.248:5060](http://164.152.22.248:5060/)) Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155698]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.184:5060](http://208.74.138.184:5060/)) Sep 21 17:41:13 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155695]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[208.74.138.181:5060](http://208.74.138.181:5060/)) Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155693]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:[38.102.250.60:5060](http://38.102.250.60:5060/)) errors ``` But i honestly don't know why the ```Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [ut.h:302]: uri2dst2(): no corresponding socket for "87.1.1.27" af 2 Sep 21 17:41:14 lax-dedge-1 /usr/local/kamailio/sbin/kamailio[3155707]: ERROR: tm [t_fwd.c:470]: prepare_new_uac(): can't fwd to af 2, proto 1 (no corresponding listening socket) appear ``` We also tried to increase the kernel buffers rmem and wmem from 208KB (as we had by default) to 4MB Do you know a reason which could cause these logs to appear? Any setup that could mitigate them? thanks a lot and regards david escartin -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3583 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3583(a)github.com>

1 week, 1 day

← Newer
1
...
18
19
20
21
22
23
24
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2024