sr-dev November 2024

sr-dev@lists.kamailio.org

17 participants
305 discussions

Re: [kamailio/kamailio] Create .mergify.yml (819e1c4)

by Victor Seva

I force push master to remove it -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4016f60f63/149088713(a)github.com>

1 week, 3 days

Re: [kamailio/kamailio] Create .mergify.yml (819e1c4)

by Xenofon Karamanos

Hmm this was intended for my personal repo and testing... Can we revert it somehow? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4016f60f63/149087912(a)github.com>

1 week, 3 days

git:master:819e1c4a: Create .mergify.yml

by Xenofon Karamanos

Module: kamailio Branch: master Commit: 819e1c4a68e5c9fd500e129eccc6dd4016f60f63 URL: https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4… Author: Xenofon Karamanos <22965395+xkaraman(a)users.noreply.github.com> Committer: Xenofon Karamanos <xk(a)gilawa.com> Date: 2024-11-14T13:58:50Z Create .mergify.yml --- Added: .github/mergify.yml --- Diff: https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4… Patch: https://github.com/kamailio/kamailio/commit/819e1c4a68e5c9fd500e129eccc6dd4… --- diff --git a/.github/mergify.yml b/.github/mergify.yml new file mode 100644 index 00000000000..6f8704aba32 --- /dev/null +++ b/.github/mergify.yml @@ -0,0 +1,14 @@ +pull_request_rules: + - name: backport patches to the stable branch + conditions: + - label=backport + actions: + backport: + body: | + {{ body }} + + {% for c in commits %} + (cherry picked from commit {{ c.sha }}) + {% endfor %} + branches: + - "5.8"

1 week, 3 days

[kamailio/kamailio] Add fix_actions function parameter in fix_actions to allow call of free_fixup functions and free resources (PR #4023)

by Xenofon Karamanos

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3814 #### Description  When the fixup is done in main using fix_rls function (fixing the route lists in cfg file), all the children inherit the memory allocated as a copy that needs separate management. The function responsible for the fixup (fix_actions) is also used to call the free_fixup function with an added argument. Then on main, we call the free_rls ( as fix_rls) on two separate occasions. Once in cleanup() function for the main process and once in the sig_usr() function for each of the children. This seems to work fine and after debugging with `file_out` fixups, I can no longer see memory leaks due to the malloced memory in one of the fixups. - main.c: Call free_rls() in cleanup() function to clean route lists and fixed up parameters in main process. - main.c: Call free_rls() in sig_usr() function to clean route lists and fixed up parameters in child processes. My question is, after a parameter is fixed, is it saved somewhere else, therefore we can immediately free the fix-up resources and not on shutdown? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4023 -- Commit Summary -- * core: Add fix_actions function parameter in fix_actions to free fixed up resources -- File Changes -- M src/core/route.c (61) M src/core/route.h (3) M src/core/rvalue.c (2) M src/core/switch.c (4) M src/main.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4023.patch https://github.com/kamailio/kamailio/pull/4023.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4023 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4023(a)github.com>

1 week, 3 days

git:master:879e074c: tm: backup and restore existing T-references for rpc tm.cancel

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 879e074c4517cdda7bbdad343191dcfc9dedcb3c URL: https://github.com/kamailio/kamailio/commit/879e074c4517cdda7bbdad343191dcf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-14T10:51:58+01:00 tm: backup and restore existing T-references for rpc tm.cancel - GH #4011 --- Modified: src/modules/tm/t_cancel.c --- Diff: https://github.com/kamailio/kamailio/commit/879e074c4517cdda7bbdad343191dcf… Patch: https://github.com/kamailio/kamailio/commit/879e074c4517cdda7bbdad343191dcf… --- diff --git a/src/modules/tm/t_cancel.c b/src/modules/tm/t_cancel.c index 753b261111e..5f733d71cc1 100644 --- a/src/modules/tm/t_cancel.c +++ b/src/modules/tm/t_cancel.c @@ -403,9 +403,10 @@ void rpc_cancel(rpc_t *rpc, void *c) static char cseq[128], callid[128]; struct cancel_info cancel_data; int i, j; - str cseq_s; /* cseq */ str callid_s; /* callid */ + tm_cell_t *orig_t = NULL; + int orig_branch; cseq_s.s = cseq; callid_s.s = callid; @@ -416,6 +417,8 @@ void rpc_cancel(rpc_t *rpc, void *c) return; } + orig_t = get_t(); + orig_branch = get_t_branch(); if(t_lookup_callid(&trans, callid_s, cseq_s) < 0) { LM_DBG("Lookup failed\n"); rpc->fault(c, 400, "Transaction not found"); @@ -430,6 +433,7 @@ void rpc_cancel(rpc_t *rpc, void *c) /* t_lookup_callid REF`d the transaction for us, we must UNREF here! */ UNREF(trans); + set_t(orig_t, orig_branch); j = 0; while(i) { j++;

1 week, 3 days

git:master:76b250c8: jwt: use JWT_VALIDATION_SUCCESS for validate check

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 76b250c8b4c2b5bd81b5e776e9e726350bb65b7b URL: https://github.com/kamailio/kamailio/commit/76b250c8b4c2b5bd81b5e776e9e7263… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-14T09:57:52+01:00 jwt: use JWT_VALIDATION_SUCCESS for validate check --- Modified: src/modules/jwt/jwt_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/76b250c8b4c2b5bd81b5e776e9e7263… Patch: https://github.com/kamailio/kamailio/commit/76b250c8b4c2b5bd81b5e776e9e7263… --- diff --git a/src/modules/jwt/jwt_mod.c b/src/modules/jwt/jwt_mod.c index af3d42f79c5..90d8fa5bd03 100644 --- a/src/modules/jwt/jwt_mod.c +++ b/src/modules/jwt/jwt_mod.c @@ -437,6 +437,7 @@ static int ki_jwt_verify_key( jwt_valid_t *jwt_valid = NULL; str sparams = STR_NULL; long lval = 0; + unsigned int jwtret = 0; if(key == NULL || key->s == NULL || alg == NULL || alg->s == NULL || claims == NULL || claims->s == NULL || claims->len <= 0 @@ -501,9 +502,10 @@ static int ki_jwt_verify_key( LM_ERR("failed to decode jwt value (ret: %d jwt: %p)\n", ret, jwt); goto error; } - if(jwt_validate(jwt, jwt_valid) != 0) { + if((jwtret = jwt_validate(jwt, jwt_valid)) != JWT_VALIDATION_SUCCESS) { _jwt_verify_status = jwt_valid_get_status(jwt_valid); - LM_ERR("failed to validate jwt: %08x\n", _jwt_verify_status); + LM_ERR("failed to validate jwt: %08x (ret: %08x)\n", _jwt_verify_status, + jwtret); goto error; }

1 week, 3 days

git:master:85456e17: topoh: check if socket name is set for building sockets strings

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 85456e17df760b3d716aa1207a59ef0c3a29b4b4 URL: https://github.com/kamailio/kamailio/commit/85456e17df760b3d716aa1207a59ef0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2024-11-13T14:58:57+01:00 topoh: check if socket name is set for building sockets strings --- Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/85456e17df760b3d716aa1207a59ef0… Patch: https://github.com/kamailio/kamailio/commit/85456e17df760b3d716aa1207a59ef0… --- diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index 7dffa829504..450b0c7d93a 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -316,10 +316,19 @@ int th_build_socket_strings(socket_info_t *socket) struct str_hash_entry *table_entry = NULL; str *socket_ip = NULL; + if(socket->sockname.s == NULL || socket->sockname.len <= 0) { + LM_ERR("the socket [%.*s] has no name - it must be set\n", + socket->address_str.len, socket->address_str.s); + return -1; + } + if(str_hash_get( th_socket_hash_table, socket->sockname.s, socket->sockname.len) - != 0) + != 0) { + LM_DBG("entry found for socket name [%.*s]\n", socket->sockname.len, + socket->sockname.s); return 0; + } socket_strings = pkg_mallocxz(sizeof(struct th_socket_strings)); if(socket_strings == NULL) {

1 week, 4 days

[kamailio/kamailio] Service crashed for IMS VoLTE MT call (Issue #3973)

by citicims

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data ``` root@imstester04:~/core_dump_test# gdb kamailio core._usr_local_sbin_kamailio.0.d660bb15-1623-4c0c-ae29-64c78dc89d8c.3799655.792169952 GNU gdb (Ubuntu 9.2-0ubuntu1~20.04.2) 9.2 Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from kamailio... [New LWP 3799655] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/local/sbin/kamailio -P /var/run/kamailio_pcscf/kamailio_pcscf.pid -f /etc/'. Program terminated with signal SIGABRT, Aborted. #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 50 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory. (gdb) bt full #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 set = {__val = {0, 19989655252, 140370540584975, 1725509713, 94706844523408, 341, 64424509453, 21474836492, 532575944712, 1065151889412, 140368121167872, 28800, 94706843944736, 560, 71148340464, 0}} pid = <optimized out> tid = <optimized out> ret = <optimized out> #1 0x00007faa94995859 in __GI_abort () at abort.c:79 save_stage = 1 act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction = 0x0}, sa_mask = {__val = {0, 140366190491840, 140366190223360, 0, 0, 0, 0, 0, 94706838593952, 94706840315664, 94706840316072, 140366318452096, 2001317716380379136, 0, 94706840315898, 0}}, sa_flags = -1483647068, sa_restorer = 0x7faa94a8b410 <__syslog>} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x00005622a778e1c7 in qm_debug_check_frag (qm=0x7fa98ce82000, f=0x7fa9948cbd80, file=0x7faa908fc84e "rom %s:%u\n", line=171, efile=0x5622a7932729 "core/mem/q_malloc.c", eline=546) at core/mem/q_malloc.c:143 p = 0x0 __func__ = "qm_debug_check_frag" #3 0x00005622a77923f8 in qm_free (qmp=0x7fa98ce82000, p=0x7fa9948cbdc0, file=0x7faa908fc84e "rom %s:%u\n", func=0x7faa908fc460 "%s%s%sadd_blind failed\n", line=171, mname=0x7faa908fc28e "") at core/mem/q_malloc.c:546 qm = 0x7fa98ce82000 f = 0x7fa9948cbd80 size = 0 next = 0x0 prev = 0x0 __func__ = "qm_free" #4 0x00007faa907e3749 in free_cell_helper (dead_cell=0x7fa994875c90, silent=0, fname=0x7faa90915362 <__func__.11447+2> "_init_timers", fline=651) at h_table.c:126 b = 0x0 i = 0 rpl = 0x7ffca5bc65e0 tt = 0x1 foo = 0x0 cbs = 0x7fa98cfb76d0 cbs_tmp = 0x7faa907e1041 <t_write_req+481> __func__ = "free_cell_helper" #5 0x00007faa9089f28f in wait_handler (ti=872968975, wait_tl=0x7fa994875d48, data=0x7fa994875c90) at timer.c:651 p_cell = 0x7fa994875c90 ret = 0 unlinked = 0 rcount = 1 __func__ = "wait_handler" #6 0x00005622a7522813 in timer_list_expire (t=872968975, h=0x7fa98cf0a950, slow_l=0x7fa98cf0dd50, slow_mark=6936) at core/timer.c:861 tl = 0x7fa994875d48 ret = 0 #7 0x00005622a7522d52 in timer_handler () at core/timer.c:925 saved_ticks = 872968975 run_slow_timer = 0 i = 792 __func__ = "timer_handler" #8 0x00005622a7523280 in timer_main () at core/timer.c:963 No locals. #9 0x00005622a744501a in main_loop () at main.c:1932 i = 64 pid = 0 si = 0x0 si_desc = "udp receiver child=63 sock=10.51.0.10:20004\000\324\002\000\000\003\000\000\000\345\002\000\000\000h\214\017\334\033\306\033\000\000\000\000\000\000\000\000\210��\247\"V\000\000\000\000\000\000\000\000\000\000\303W\221\247\"V\000\000\345\002\000\000\000\000\000\000\020\264\250\224\252\177\000\000\340i\274\245\374\177\000\000\061\237_\247\"V\000" nrprocs = 64 woneinit = 1 __func__ = "main_loop" #10 0x00005622a7450425 in main (argc=13, argv=0x7ffca5bc6f48) at main.c:3257 cfg_stream = 0x5622a7b512a0 --Type <RET> for more, q to quit, c to continue without paging--c c = -1 r = 0 tmp = 0x7ffca5bc7e58 "" tmp_len = 32682 port = 5060 proto = 0 aproto = 0 ahost = 0x0 aport = 0 options = 0x5622a78c0368 ":f:cm:M:dVIhEeb:B:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3374692201 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x0 p = 0x7faa94cfa410 "" st = {st_dev = 25, st_ino = 754, st_nlink = 2, st_mode = 16832, st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1717582113, tv_nsec = 155483622}, st_mtim = {tv_sec = 1717582113, tv_nsec = 155483622}, st_ctim = {tv_sec = 1717582113, tv_nsec = 155483622}, __glibc_reserved = {0, 0, 0}} l1 = 4096 tbuf = "\020n\274\245\374\177\000\000\273\327��\252\177", '\000' <repeats 18 times>, "��\277X��\377\377\000\000\000\000\000\000\000\000\004\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\000\207��\252\177\000\000@#\227\224\252\177\000\000`\201��\252\177\000\000\001l\274\245\374\177\000\000\350y��\252\177", '\000' <repeats 26 times>, "\220\274\266\224\252\177\000\000\004\000\000\024\000\000\000\000 \224\267\224\252\177", '\000' <repeats 130 times>... option_index = 0 long_options = {{name = 0x5622a78c28f6 "help", has_arg = 0, flag = 0x0, val = 104}, {name = 0x5622a78bd54c "version", has_arg = 0, flag = 0x0, val = 118}, {name = 0x5622a78c28fb "alias", has_arg = 1, flag = 0x0, val = 1024}, {name = 0x5622a78c2901 "subst", has_arg = 1, flag = 0x0, val = 1025}, {name = 0x5622a78c2907 "substdef", has_arg = 1, flag = 0x0, val = 1026}, {name = 0x5622a78c2910 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, {name = 0x5622a78c291a "server-id", has_arg = 1, flag = 0x0, val = 1028}, {name = 0x5622a78c2924 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, {name = 0x5622a78c292f "modparam", has_arg = 1, flag = 0x0, val = 1030}, {name = 0x5622a78c2938 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, {name = 0x5622a78c2943 "debug", has_arg = 1, flag = 0x0, val = 1032}, {name = 0x5622a78c2949 "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, {name = 0x5622a78c2953 "atexit", has_arg = 1, flag = 0x0, val = 1034}, {name = 0x5622a78c295a "all-errors", has_arg = 0, flag = 0x0, val = 1035}, {name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" (gdb) (gdb) (gdb) ``` #### Log Messages #### SIP Traffic ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` `Kamailio release 5.8.2`` ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3973 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3973(a)github.com>

1 week, 4 days

[kamailio/kamailio] fr_timer documentation mistake (Issue #3939)

by Dmitry Sinina

Documentation https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.p.fr_timer says: >Timer which hits if no **final reply** for a request or ACK for a negative INVITE reply arrives (in milliseconds). Looks like it is not correct description - fr_timer value works until 1xx(not **final**) response received and then timer restarted with fr_inv_timer value there: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_reply.c#L… Looks like old doc from sip router https://sip-router.org/wiki/ref_manual/timers explains it correctly: > fr_timer This timer is used for all SIP requests. It hits if no reply for an INVITE request or other request has been received (F in milliseconds). If a provisional reply is received for an INVITE (any 1xx), then the fr_inv_timer will be used instead. And if no replies (at all) for an INVITE are received before `fr_timer` hits, the transaction is terminated with a 408 in failure route. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3939 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3939(a)github.com>

1 week, 4 days

[kamailio/kamailio] Documentation link is incorrect on https://kamailio.org/docs/modules/5.8.x/ for python3s (Issue #4022)

by Ben Kaufman

### Description On https://kamailio.org/docs/modules/5.8.x/ the link for python3s actually links to python3 (https://kamailio.org/docs/modules/5.8.x/modules/app_python3.html). It should link to https://kamailio.org/docs/modules/5.8.x/modules/app_python3s.html -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4022 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4022(a)github.com>

1 week, 5 days

← Newer
1
...
22
23
24
25
26
27
28
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2024