sr-dev February 2024

sr-dev@lists.kamailio.org

19 participants
247 discussions

Latest point releases seem to break early dialog UPDATEs from B-side when using topos (again)
by George Diamantopoulos 16 Feb '24

16 Feb '24

Hello all, I've noticed that there seems to be a regression with the topos module, more specifically the redis flavour, but I'm assuming the storage backend shouldn't make a difference. I have confirmed this affects both 5.6.5 and 5.7-nightly, so I'm assuming some backported commit is to blame. Kamailio 5.6.4 used previously, to the best of my memory, was not affected. Early dialog UPDATEs sent from the callee seem to be somehow malformed, since the 200 OK the UAS produces goes directly to … [View More]

2 3

[kamailio/kamailio] file_out: Fix a bug on fixup function, update docs, logging information. (PR #3756)
by Xenofon Karamanos 16 Feb '24

16 Feb '24

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  This PR fixes small bugs, and improves docs. #### Main bug fix: - Fixup now should be able to handle the string from `.cfg` with multiple PVs, strings, and more. - Add fixup_free functions #### Smaller fixes: - `base_folder` should not contain a trailing slash. Trailing slash is allowed, but resulting paths can contain `//log_file.extenion`, which in more OS is fine and equal to `/`. - Add initial Readme and fix some docs. - Switch to `str` type in internal types for better string handling. - Free message when done You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3756 -- Commit Summary -- * file_out: Change default base folder format * file_out: Add initial Readme and improve docs * file_out: Switch to str type for string handling * file_out: Free message when done * file_out: Improve logging * file_out: Fix fixup functions to handle all string. -- File Changes -- A src/modules/file_out/README (171) M src/modules/file_out/doc/file_out_admin.xml (4) M src/modules/file_out/file_out.c (52) M src/modules/file_out/types.c (19) M src/modules/file_out/types.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3756.patch https://github.com/kamailio/kamailio/pull/3756.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3756 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3756(a)github.com> [View Less]

1 1

git:master:d2459f4a: file_out: Fix fixup functions to handle all string.
by Xenofon Karamanos 16 Feb '24

16 Feb '24

Module: kamailio Branch: master Commit: d2459f4a9978e6b42ba99212b77dd856005df0d7 URL: https://github.com/kamailio/kamailio/commit/d2459f4a9978e6b42ba99212b77dd85… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2024-02-16T12:20:44+02:00 file_out: Fix fixup functions to handle all string. --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:d3fbee58: file_out: Improve logging
by Xenofon Karamanos 16 Feb '24

16 Feb '24

Module: kamailio Branch: master Commit: d3fbee58cb5505130ea73cfa0143adfd470d2c27 URL: https://github.com/kamailio/kamailio/commit/d3fbee58cb5505130ea73cfa0143adf… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2024-02-16T12:20:44+02:00 file_out: Improve logging --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/d3fbee58cb5505130ea73cfa0143adf… Patch: https://github.… [View More]

1 0

git:master:6ac4148d: file_out: Free message when done
by Xenofon Karamanos 16 Feb '24

16 Feb '24

Module: kamailio Branch: master Commit: 6ac4148d3d7e6ea772438b7c5b42807175e5888a URL: https://github.com/kamailio/kamailio/commit/6ac4148d3d7e6ea772438b7c5b42807… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2024-02-16T12:20:44+02:00 file_out: Free message when done --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/6ac4148d3d7e6ea772438b7c5b42807… Patch: https://… [View More]

1 0

git:master:e4163d28: file_out: Switch to str type for string handling
by Xenofon Karamanos 16 Feb '24

16 Feb '24

Module: kamailio Branch: master Commit: e4163d287e1c8c617ef9f21452a88f09c040bd47 URL: https://github.com/kamailio/kamailio/commit/e4163d287e1c8c617ef9f21452a88f0… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2024-02-16T12:20:44+02:00 file_out: Switch to str type for string handling --- Modified: src/modules/file_out/file_out.c Modified: src/modules/file_out/types.c Modified: src/modules/file_out/types.h --- Diff: … [View More] https://github.com/kamailio/kamailio/commit/e4163d287e1c8c617ef9f21452a88f0… Patch: https://github.com/kamailio/kamailio/commit/e4163d287e1c8c617ef9f21452a88f0… --- diff --git a/src/modules/file_out/file_out.c b/src/modules/file_out/file_out.c index b52dad270d5..5815d61cb63 100644 --- a/src/modules/file_out/file_out.c +++ b/src/modules/file_out/file_out.c @@ -199,8 +199,14 @@ static void fo_log_writer_process(int rank) return; } - fprintf(out, "%s\n", log_message.message); - fflush(out); + if(fprintf(out, "%.*s\n", log_message.message->len, + log_message.message->s) + < 0) { + LM_ERR("Failed to write to file with err {%s}\n", strerror(errno)); + } + if(fflush(out) < 0) { + LM_ERR("Failed to flush file with err {%s}\n", strerror(errno)); + } } } @@ -463,7 +469,7 @@ static int fo_write_to_file(sip_msg_t *msg, char *index, char *log_message) return -1; } - str value; + str value = str_init(""); result = get_str_fparam(&value, msg, (fparam_t *)log_message); if(result < 0) { LM_ERR("Failed to string from param 1: %d\n", result); @@ -471,8 +477,8 @@ static int fo_write_to_file(sip_msg_t *msg, char *index, char *log_message) } /* Add the logging string to the global gueue */ - fo_log_message_t logMessage; - logMessage.message = value.s; + fo_log_message_t logMessage = {0, 0}; + logMessage.message = &value; logMessage.dest_file = file_index; fo_enqueue(fo_queue, logMessage); diff --git a/src/modules/file_out/types.c b/src/modules/file_out/types.c index a80566dfc8f..d2815333dd0 100644 --- a/src/modules/file_out/types.c +++ b/src/modules/file_out/types.c @@ -22,6 +22,7 @@ #include <stdlib.h> #include "types.h" +#include "../../core/ut.h" static fo_node_t *fo_new_node(fo_log_message_t data) { @@ -37,8 +38,18 @@ int fo_enqueue(fo_queue_t *q, fo_log_message_t data) /* Copy the contents of data.message */ - char *message_copy = (char *)shm_malloc(strlen(data.message) + 1); - strcpy(message_copy, data.message); + str *message_copy = 0; + message_copy = (str *)shm_malloc(sizeof(str)); + if(message_copy == 0) { + SHM_MEM_ERROR; + return -1; + } + + if(shm_str_dup(message_copy, data.message) < 0) { + LM_ERR("Failed to duplicate message\n"); + return -1; + } + data.message = message_copy; fo_node_t *temp = fo_new_node(data); @@ -74,10 +85,6 @@ int fo_dequeue(fo_queue_t *q, fo_log_message_t *data) if(temp != NULL) { - if(temp->data.message != NULL) { - shm_free(temp->data.message); - temp->data.message = NULL; - } shm_free(temp); temp = NULL; } diff --git a/src/modules/file_out/types.h b/src/modules/file_out/types.h index 0c81cb20a7b..c6fb72b28ef 100644 --- a/src/modules/file_out/types.h +++ b/src/modules/file_out/types.h @@ -22,7 +22,7 @@ typedef struct log_message { - char *message; + str *message; int dest_file; } fo_log_message_t; [View Less]

1 0

git:master:e15a15cf: file_out: Add initial Readme and improve docs
by Xenofon Karamanos 16 Feb '24

16 Feb '24

Module: kamailio Branch: master Commit: e15a15cf8ce0c09aa6b26200dd2bce0e3933b6cd URL: https://github.com/kamailio/kamailio/commit/e15a15cf8ce0c09aa6b26200dd2bce0… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2024-02-16T12:20:44+02:00 file_out: Add initial Readme and improve docs --- Added: src/modules/file_out/README Modified: src/modules/file_out/doc/file_out_admin.xml --- Diff: https://github.com/kamailio/… [View More]

1 0

git:master:107d8c9a: file_out: Change default base folder format
by Xenofon Karamanos 16 Feb '24

16 Feb '24

Module: kamailio Branch: master Commit: 107d8c9ae4cb1191d9e0132a42acad8af4cc66c9 URL: https://github.com/kamailio/kamailio/commit/107d8c9ae4cb1191d9e0132a42acad8… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Xenofon Karamanos <xenakiskaramanos(a)gmail.com> Date: 2024-02-16T12:20:44+02:00 file_out: Change default base folder format --- Modified: src/modules/file_out/file_out.c --- Diff: https://github.com/kamailio/kamailio/commit/107d8c9ae4cb1191d9e0132a42acad8… … [View More]

1 0

[kamailio/kamailio] Undocumented TCP connection limit introduced in 5.7.3 must be configurable (Issue #3755)
by Sebastian Damm 15 Feb '24

15 Feb '24

### Description Scenario: Kamailio servers running behind a loadbalancer (AWS network loadbalancer in this case). This causes all packets to come from the same IP address in Kamailio's POV. The change https://github.com/kamailio/kamailio/commit/a902e4a032a85a7755de32eeadac800… introduced a connection limit per source IP address. This obviously conflicts with the setup mentioned above. We need up to 10000 client connections, which would seem to all come from the same IP address. Apart from … [View More]this limit being introduced without a changelog entry (at least I didn't find one), I would expect it to be configurable. But from the commit it looks like it is a compile time option only.  #### Log Messages ``` Feb 15 09:24:00 sipproxy /usr/sbin/kamailio[174]: CRITICAL: <core> [core/tcp_main.c:4447]: handle_new_connect(): hit the limit of connections per source IP (100.68.15.172:33334) - rejecting Feb 15 09:24:01 sipproxy /usr/sbin/kamailio[174]: CRITICAL: <core> [core/tcp_main.c:4447]: handle_new_connect(): hit the limit of connections per source IP (100.68.15.172:1153) - rejecting Feb 15 09:24:01 sipproxy /usr/sbin/kamailio[174]: CRITICAL: <core> [core/tcp_main.c:4447]: handle_new_connect(): hit the limit of connections per source IP (100.68.15.172:59946) - rejecting ``` ### Additional Information Using the packages from the official Kamailio repository. * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.7.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 11.4.0 ``` * **Operating System**:  ``` Ubuntu Jammy ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3755 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3755(a)github.com> [View Less]

2 3

Missing values in xhttp_prom output
by Christian Berger 15 Feb '24

15 Feb '24

Hi, we at sipgate would like to know if there is a reason why the xhttp_prom module doesn't export statistics like stats.fetch all. We are missing the tls.info as well as pkg.stats values. Is there a reason for this? Are there any pointers on how we could implement it ourselves and provide patches? Best regards Christian Berger -- Christian Berger - berger(a)sipgate.de Telefon: +49 (0)211-63 55 55-0 Telefax: +49 (0)211-63 55 55-22 sipgate GmbH - Gladbacher Str. 74 - 40219 Düsseldorf … [View More]

2 2

← Newer
1
...
10
11
12
13
14
15
16
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2024