sr-dev February 2025

sr-dev@lists.kamailio.org

9 participants
163 discussions

[kamailio/kamailio] rtpengine: fix race condn (same ip:port) in parallel forks due to gencookie (PR #4139)
by Souradeep Bera 21 Feb '25

21 Feb '25

- avoid parallel calls to gencookie from generating the same cookie for rtpengine #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4139 -- Commit Summary -- * rtpengine: fix race condn assigning same ip:port due to gencookie in parallel forks -- File Changes -- M src/modules/rtpengine/rtpengine.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4139.patch https://github.com/kamailio/kamailio/pull/4139.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4139 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4139(a)github.com>

3 3

git:master:c67afd6b: modules: readme files regenerated - nathelper ... [skip ci]
by Kamailio Dev 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: c67afd6ba65c612125b13ea9f264657a532f7396 URL: https://github.com/kamailio/kamailio/commit/c67afd6ba65c612125b13ea9f264657… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-02-21T08:46:10+01:00 modules: readme files regenerated - nathelper ... [skip ci] --- Modified: src/modules/nathelper/README --- Diff: https://github.com/kamailio/kamailio/commit/c67afd6ba65c612125b13ea9f264657… Patch: https://github.com/kamailio/kamailio/commit/c67afd6ba65c612125b13ea9f264657…

1 0

[kamailio/kamailio] dispatcher: skip ping for DS_NODNSARES_DST (PR #4150)
by Stefan Mititelu 21 Feb '25

21 Feb '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Dispatcher timer regularly pings the nodes. Should skip resolving and pinging the no-dns-A flag ones since those node do not have an A record by definition. Otherwise that no-dns-A flag(state) is overwritten by the pinging process. This leads to node removal from group, after RPC commands e.g. "kamcmd dispatcher.add/remove". You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4150 -- Commit Summary -- * dispatcher: skip ping for DS_NODNSARES_DST -- File Changes -- M src/modules/dispatcher/dispatch.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4150.patch https://github.com/kamailio/kamailio/pull/4150.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4150 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4150(a)github.com>

2 2

git:master:5f29b449: dispatcher: skip ping for DS_NODNSARES_DST
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 5f29b4491634c360ade5691977d622617ae014ad URL: https://github.com/kamailio/kamailio/commit/5f29b4491634c360ade5691977d6226… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:44:12+01:00 dispatcher: skip ping for DS_NODNSARES_DST --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/5f29b4491634c360ade5691977d6226… Patch: https://github.com/kamailio/kamailio/commit/5f29b4491634c360ade5691977d6226… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 9968eab5537..fb0e233df7c 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -4114,6 +4114,9 @@ void ds_ping_set(ds_set_t *node) /* skip addresses with no-ping flag */ if((node->dlist[j].flags & DS_NOPING_DST) != 0) continue; + /* skip addresses with no-DNS-A flag */ + if((node->dlist[j].flags & DS_NODNSARES_DST) != 0) + continue; /* If the Flag of the entry has "Probing set, send a probe: */ if(ds_ping_result_helper(node, j)) { LM_DBG("probing set #%d, URI %.*s\n", node->id,

1 0

[kamailio/kamailio] nathelper: Add modparam to not send ping to Path (PR #4152)
by Stefan Mititelu 21 Feb '25

21 Feb '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  OPTIONS ping is always sent to Path uri, if contact has it set. Add option to ignore this and still send OPTIONS to contact. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4152 -- Commit Summary -- * nathelper: Add modparam to not send ping to Path -- File Changes -- M src/modules/nathelper/doc/nathelper_admin.xml (20) M src/modules/nathelper/nathelper.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4152.patch https://github.com/kamailio/kamailio/pull/4152.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4152 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4152(a)github.com>

2 2

git:master:31c807aa: nathelper: Add modparam to not send ping to Path
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 31c807aaf20dc4c85ed9f1b0d91340b430d60d41 URL: https://github.com/kamailio/kamailio/commit/31c807aaf20dc4c85ed9f1b0d91340b… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:39:26+01:00 nathelper: Add modparam to not send ping to Path --- Modified: src/modules/nathelper/doc/nathelper_admin.xml Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/31c807aaf20dc4c85ed9f1b0d91340b… Patch: https://github.com/kamailio/kamailio/commit/31c807aaf20dc4c85ed9f1b0d91340b… --- diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml index c8b14caea54..9f3e19eed87 100644 --- a/src/modules/nathelper/doc/nathelper_admin.xml +++ b/src/modules/nathelper/doc/nathelper_admin.xml @@ -428,6 +428,26 @@ modparam("nathelper", "udpping_from_path", 1) </programlisting> </example> </section> + <section id="nathelper.p.ignore_path"> + <title><varname>ignore_path</varname> (int)</title> + <para> + Enable ignore of Path header address when sending UDP pings (keepalives). + </para> + <para> + <emphasis> + Default value is <quote>0</quote> (feature disabled). + UDP pings are sent to Path header if header is present. + </emphasis> + </para> + <example> + <title>Set <varname>ignore_path</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("nathelper", "ignore_path", 1) +... + </programlisting> + </example> + </section> <section id="nathelper.p.append_sdp_oldmediaip"> <title><varname>append_sdp_oldmediaip</varname> (int)</title> <para> diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index ec543079f31..b3335960fbd 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -193,6 +193,7 @@ static avp_name_t rcv_avp_name; static char *natping_socket = NULL; static int udpping_from_path = 0; +static int ignore_path = 0; static int sdp_oldmediaip = 1; static int raw_sock = -1; static unsigned int raw_ip = 0; @@ -277,6 +278,7 @@ static param_export_t params[] = { {"natping_socket", PARAM_STRING, &natping_socket }, {"keepalive_timeout", PARAM_INT, &nh_keepalive_timeout }, {"udpping_from_path", PARAM_INT, &udpping_from_path }, + {"ignore_path", PARAM_INT, &ignore_path}, {"append_sdp_oldmediaip", PARAM_INT, &sdp_oldmediaip }, {"filter_server_id", PARAM_INT, &nh_filter_srvid }, {"nat_addr_mode", PARAM_INT, &nh_nat_addr_mode }, @@ -2387,7 +2389,7 @@ static void nh_timer(unsigned int ticks, void *timer_idx) dst_uri = &c; /* determine the destination */ - if(path.len && (flags & sipping_flag) != 0) { + if(path.len && (flags & sipping_flag) != 0 && !ignore_path) { /* send to first URI in path */ if(get_path_dst_uri(&path, &opt) < 0) { LM_ERR("failed to get dst_uri for Path\n"); @@ -2398,7 +2400,7 @@ static void nh_timer(unsigned int ticks, void *timer_idx) LM_ERR("can't parse contact dst_uri\n"); continue; } - } else if(path.len && udpping_from_path) { + } else if(path.len && udpping_from_path && !ignore_path) { path_ip_str = extract_last_path_ip(path); if(path_ip_str == NULL) { LM_ERR("unable to parse path from location\n");

1 0

[kamailio/kamailio] fr_timer documentation mistake (Issue #3939)
by Dmitry Sinina 21 Feb '25

21 Feb '25

Documentation https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.p.fr_timer says: >Timer which hits if no **final reply** for a request or ACK for a negative INVITE reply arrives (in milliseconds). Looks like it is not correct description - fr_timer value works until 1xx(not **final**) response received and then timer restarted with fr_inv_timer value there: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_reply.c#L… Looks like old doc from sip router https://sip-router.org/wiki/ref_manual/timers explains it correctly: > fr_timer This timer is used for all SIP requests. It hits if no reply for an INVITE request or other request has been received (F in milliseconds). If a provisional reply is received for an INVITE (any 1xx), then the fr_inv_timer will be used instead. And if no replies (at all) for an INVITE are received before `fr_timer` hits, the transaction is terminated with a 408 in failure route. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3939 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3939(a)github.com>

3 7

[kamailio/kamailio] TM module memory leak of BYE transction (Issue #4140)
by Stefan Mititelu 20 Feb '25

20 Feb '25

### Description BYE transactions keept increasing and were never freed. #### Reproduction 1. Compile kamailio 5.8.5 and run it under no traffic, with default config 2. Connect 1 WSS client 3. Send INVITE with "Session-Expires" header from WSS client -> kamailio -> PBX (e.g. asterisk) 4. Wait for WSS client to refresh session in re-INVITE with another "Session-Expires" 5. Force kill WSS client and wait 6. PBX (asterisk) will send BYE to end session 7. kamailio replies "477 Unfortunately error on sending to next hop occurred (477/SL)" 8. kamcmd tm.list | grep BYE -> will see that transaction there is never freed #### Debugging Data + Log Messages ``` DEBUG: tm [h_table.c:415]: build_cell(): created new cell 0x7f673e2552d0 INFO: <script>: [pdn60n9cob1j3j0doi36] MANAGE_BRANCH: New branch [0] to ....., BYE WARNING: tm [../../core/forward.h:217]: msg_send_buffer(): TCP/TLS connection for WebSocket could not be found DEBUG: tm [t_fwd.c:1566]: t_send_branch(): send to 169.132.91.64:1702 (5) failed WARNING: tm [t_fwd.c:1586]: t_send_branch(): sending request on branch 0 failed DEBUG: tm [t_funcs.c:358]: t_relay_to(): t_forward_nonack returned error -1 (-477) DEBUG: tm [t_funcs.c:376]: t_relay_to(): -477 error reply generation delayed DEBUG: sl [sl_funcs.c:564]: sl_run_callbacks(): execute callback for event type 1 ERROR: sl [sl_funcs.c:428]: sl_reply_error(): stateless error reply used: Unfortunately error on sending to next hop occurred (477/SL) DEBUG: dialog [dlg_hash.c:780]: dlg_lookup_mode(): ref dlg 0x7f673e5dbae0 with 1 -> 2 DEBUG: dialog [dlg_hash.c:784]: dlg_lookup_mode(): dialog id=6986 found on entry 2734 DEBUG: dialog [dlg_hash.c:1088]: dlg_unref_helper(): unref op on 0x7f673e5dbae0 with 1 from dlg_hash.c:1106 DEBUG: dialog [dlg_hash.c:1092]: dlg_unref_helper(): unref dlg 0x7f673e5dbae0 with 1 -> 1 ``` #### SIP Traffic  ``` ![Image](https://github.com/user-attachments/assets/abc99b7a-9830-4928-81c3-3aa02bb8acbe) ``` ### Possible Solutions Tracked this down to this "#ifdef" that is defined inside the C file itself: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_funcs.c#L… Solution 1: remove all the code related to TM_DELAYED_REPLY since it is anyway local to t_funcs.c file Solution 2: t_release_transaction(t); /* kill it silently */ in case of TM_DELAYED_REPLY too ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` all up to latest one ``` * **Operating System**:  ``` not relevant ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4140 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4140(a)github.com>

2 4

git:master:ccf33100: acc: avoid local variable hides global variable
by Victor Seva 19 Feb '25

19 Feb '25

Module: kamailio Branch: master Commit: ccf33100c1eba5dcd9494f1558ff03703fb8e7bf URL: https://github.com/kamailio/kamailio/commit/ccf33100c1eba5dcd9494f1558ff037… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-02-19T19:26:10+01:00 acc: avoid local variable hides global variable --- Modified: src/modules/acc/acc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ccf33100c1eba5dcd9494f1558ff037… Patch: https://github.com/kamailio/kamailio/commit/ccf33100c1eba5dcd9494f1558ff037… --- diff --git a/src/modules/acc/acc_mod.c b/src/modules/acc/acc_mod.c index 7000d003f83..41710ad0d18 100644 --- a/src/modules/acc/acc_mod.c +++ b/src/modules/acc/acc_mod.c @@ -335,7 +335,7 @@ static int free_acc_fixup(void **param, int param_no) /************************** INTERFACE functions ****************************/ -static int parse_failed_filter(char *s, unsigned short *failed_filter) +static int parse_failed_filter(char *s, unsigned short *_failed_filter) { unsigned int n; char *at; @@ -354,16 +354,16 @@ static int parse_failed_filter(char *s, unsigned short *failed_filter) LM_ERR("response code in failed_filter must have 3 digits\n"); return 0; } - failed_filter[n] = + _failed_filter[n] = (*s - '0') * 100 + (*(s + 1) - '0') * 10 + (*(s + 2) - '0'); - if(failed_filter[n] < 300) { + if(_failed_filter[n] < 300) { LM_ERR("invalid response code %u in failed_filter\n", - failed_filter[n]); + _failed_filter[n]); return 0; } - LM_DBG("failed_filter %u = %u\n", n, failed_filter[n]); + LM_DBG("failed_filter %u = %u\n", n, _failed_filter[n]); n++; - failed_filter[n] = 0; + _failed_filter[n] = 0; s = at; if(*s == 0) return 1;

1 0

git:master:b019dbc5: db_cfg: avoid local variable hides global variable
by Victor Seva 19 Feb '25

19 Feb '25

Module: kamailio Branch: master Commit: b019dbc5dc88a58a50a3d272a30e6a1aa3b174c0 URL: https://github.com/kamailio/kamailio/commit/b019dbc5dc88a58a50a3d272a30e6a1… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2025-02-19T19:22:52+01:00 db_cfg: avoid local variable hides global variable --- Modified: src/modules/cfg_db/cfg_db.c --- Diff: https://github.com/kamailio/kamailio/commit/b019dbc5dc88a58a50a3d272a30e6a1… Patch: https://github.com/kamailio/kamailio/commit/b019dbc5dc88a58a50a3d272a30e6a1… --- diff --git a/src/modules/cfg_db/cfg_db.c b/src/modules/cfg_db/cfg_db.c index 840417da7f7..d307d0e6963 100644 --- a/src/modules/cfg_db/cfg_db.c +++ b/src/modules/cfg_db/cfg_db.c @@ -405,30 +405,35 @@ static int mod_init(void) return 0; } +/* clang-format off */ /* * Exported parameters */ -static param_export_t params[] = {{"db_url", PARAM_STRING, &db_url}, - {"transl_tbl", PARAM_STRING, &transl_tbl}, - /* {"transl_group_name_fld", PARAM_STRING, &transl_group_name_fld}, +static param_export_t mod_params[] = { + {"db_url", PARAM_STRING, &db_url}, + {"transl_tbl", PARAM_STRING, &transl_tbl}, +/* + {"transl_group_name_fld", PARAM_STRING, &transl_group_name_fld}, {"transl_cfg_table_fld", PARAM_STRING, &transl_cfg_table_fld}, {"transl_cfg_table_group_name_field_fld", PARAM_STRING, &transl_cfg_table_group_name_field_fld}, {"transl_cfg_table_name_field_fld", PARAM_STRING, &transl_cfg_table_name_field_fld}, {"transl_cfg_table_value_field_fld", PARAM_STRING, &transl_cfg_table_value_field_fld}, */ - {"custom_tbl", PARAM_STRING, &custom_tbl}, - - {0, 0, 0}}; + {"custom_tbl", PARAM_STRING, &custom_tbl}, + {0, 0, 0} +}; /* Module interface */ struct module_exports exports = { - MODULE_NAME, DEFAULT_DLFLAGS, /* dlopen flags */ - 0, /* Exported functions */ - params, /* Exported parameters */ - 0, /* RPC methods */ - 0, /* exported pseudo-variables */ - 0, /* response function */ - mod_init, /* module initialization function */ - 0, /* child initialization function */ - 0 /* destroy function */ + MODULE_NAME, + DEFAULT_DLFLAGS, /* dlopen flags */ + 0, /* Exported functions */ + mod_params, /* Exported parameters */ + 0, /* RPC methods */ + 0, /* exported pseudo-variables */ + 0, /* response function */ + mod_init, /* module initialization function */ + 0, /* child initialization function */ + 0 /* destroy function */ }; +/* clang-format on */

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
17
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2025