sr-dev February 2025

sr-dev@lists.kamailio.org

9 participants
171 discussions

git:master:f43c132d: sl: stats for 1xx replies
by Daniel-Constantin Mierla 24 Feb '25

24 Feb '25

Module: kamailio Branch: master Commit: f43c132db9b1dc71f623d592fb46d487ba492c7d URL: https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d48… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-24T09:57:38+01:00 sl: stats for 1xx replies - GH #4144 --- Modified: src/modules/sl/sl_stats.c --- Diff: https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d48… Patch: https://github.com/kamailio/kamailio/commit/f43c132db9b1dc71f623d592fb46d48… --- diff --git a/src/modules/sl/sl_stats.c b/src/modules/sl/sl_stats.c index 3394e0251f0..8e8c835c23b 100644 --- a/src/modules/sl/sl_stats.c +++ b/src/modules/sl/sl_stats.c @@ -148,7 +148,7 @@ void update_sl_stats(int code) my_stats = &(*sl_stats)[process_no]; - if(code >= 700 || code < 200) { + if(code >= 700 || code < 100) { my_stats->err[RT_xxx]++; } else if(code >= 600) { my_stats->err[RT_6xx]++; @@ -203,7 +203,7 @@ void update_sl_stats(int code) my_stats->err[RT_3xx]++; break; } - } else { /* 2xx */ + } else if(code >= 200) { switch(code) { case 200: my_stats->err[RT_200]++; @@ -215,6 +215,8 @@ void update_sl_stats(int code) my_stats->err[RT_2xx]++; break; } + } else { /* 1xx */ + my_stats->err[RT_1xx]++; } }

1 0

[kamailio/kamailio] SEGV in dialog module (PR #4151)
by Dennis 24 Feb '25

24 Feb '25

Fixes for SEGV in dialog module.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Hi ! The problem - periodically, 2-3 times in а month, kamailio dumps core with SEGV. Different OS versions (Ubuntu 18,20,22), different kamailio versions from 5.7.1 up to 5.8.4, high call load, python kemi, actively used dialog module. Analyzing core files shows more or less the same picture - SEGV happends in dialog mododule around the dialog vars, can be in rpc call (dlg.list), in destroy dlg, in accessing dlg variable. Backtrace can look like: ``` Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.pid -f /etc/kamailio/kamailio.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. #0 get_dlg_variable_unsafe (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:236 236 dlg_var.c: No such file or directory. (gdb) bt full #0 get_dlg_variable_unsafe (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:236 var = 0x8 var_list = <optimized out> #1 0x00007fa2a2ce0397 in get_dlg_varref (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:297 var = 0x0 __func__ = "get_dlg_varref" #2 0x00007fa2a2ccd429 in ki_dlg_var_get_mode (msg=<optimized out>, name=0x7ffe67990d68, rmode=0) at dialog.c:2462 dlg = 0x7fa2818849b8 pval = <optimized out> #3 0x000055e2d5b87cbb in sr_kemi_exec_func (ket=ket@entry=0x7fa2a2d0c0c0 <sr_kemi_dialog_exports+1728>, msg=msg@entry=0x7fa2a34577c0, pno=pno@entry=1, vps=vps@entry=0x7ffe67990d60) at core/kemiexec.c:82 ret = <optimized out> __func__ = "sr_kemi_exec_func" #4 0x00007fa2a2930376 in sr_apy_kemi_exec_func_ex (ket=ket@entry=0x7fa2a2d0c0c0 <sr_kemi_dialog_exports+1728>, self=self@entry=0x7fa280ce2b80, args=args@entry=0x7fa2804ba3a0, idx=idx@entry=485) at apy_kemi.c:327 fname = <optimized out> i = <optimized out> ret = <optimized out> vps = {{vtype = 2, v = {n = -2142122656, l = 140335914274144, s = {s = 0x7fa28051cd60 "rtpe_setid", len = 10}, dict = 0x7fa28051cd60}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = { n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}, {vtype = 0, v = {n = 0, l = 0, s = {s = 0x0, len = 0}, dict = 0x0}}} env_P = <optimized out> lmsg = 0x7fa2a34577c0 xret = <optimized out> slen = 10 alen = 1 pobj = <optimized out> __func__ = "sr_apy_kemi_exec_func_ex" #5 0x00007fa2a2931f45 in sr_apy_kemi_exec_func (self=0x7fa280ce2b80, args=0x7fa2804ba3a0, idx=485) at apy_kemi.c:356 ket = 0x7fa2a2d0c0c0 <sr_kemi_dialog_exports+1728> ret = 0x0 pstate = 0x0 pframe = 0x0 tvb = {tv_sec = 0, tv_usec = 0} tve = {tv_sec = 0, tv_usec = 0} tz = {tz_minuteswest = 2, tz_dsttime = 0} tdiff = <optimized out> __func__ = "sr_apy_kemi_exec_func" #6 0x00007fa2a266f697 in ?? () from /lib/x86_64-linux-gnu/libpython3.8.so.1.0 ``` Inspecting dlg vars, the chain look like this: ``` (gdb) frame 0 #0 get_dlg_variable_unsafe (dlg=dlg@entry=0x7fa2818849b8, key=key@entry=0x7ffe67990d68) at dlg_var.c:236 236 in dlg_var.c (gdb) p *dlg.vars $1 = {key = {s = 0x7fa2833ea040 "mos", len = 3}, value = {s = 0x7fa2833ea0b0 "4.3", len = 3}, vflags = 1, next = 0x7fa2825fa3d0} (gdb) p *$.next $2 = {key = {s = 0x7fa200332e34 <error: Cannot access memory at address 0x7fa200332e34>, len = -1061109568}, value = {s = 0xabcdefed <error: Cannot access memory at address 0xabcdefed>, len = 49}, vflags = 1, next = 0x8} (gdb) ``` Additionaly, inspecting logs i found that this is happends in SIP race conditions, f.e. when caller and calle sends BYE at the same time and kamailio processing two different transactions of same dialog in two different workers, so present some competition from identical scenarios. Long time i can't reproduce this in lab, until insert an artificial delay into the scenario which process BYE request to increase competition. This code quickly causes SEGV in race conditions with BYE: ``` #kemi get/set dlg var while time.time()-start < 0.5: for i in ('bbb','ccc'): dlgvar=KSR.dialog.var_get(i) KSR.dialog.var_sets(i,str(random.randint(1,500000))) ``` SEGV not fire if i change dialog var_get/set to kamscript variant: ``` while time.time()-start < 0.5: for i in ('bbb','ccc'): dlgvar=KSR.pv.get(f"$dlg_var({i})") KSR.pv.sets(f"$dlg_var({i})", str(random.randint(1,500000))) ``` By analyzing source i found some places which are not properly covered by locks, and some dangerous places where direct pointer to dialog var structure used, which can change in concurrent process, so in first case i insert the locks, in second - it is better to use the clone of variable in private PV buffer. Also found some mistakes with dialog flags, which can potentionaly affect DMQ and DB dialog behavior. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4151 -- Commit Summary -- * dialog: covering by locks accessing/changing variables in kemi functions -- File Changes -- M src/modules/dialog/dialog.c (36) M src/modules/dialog/dlg_hash.h (2) M src/modules/dialog/dlg_var.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4151.patch https://github.com/kamailio/kamailio/pull/4151.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4151 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4151(a)github.com>

3 7

[kamailio/kamailio] Wrong Route header order in called party re-INVITE when using topos (Issue #3778)
by Javi Montoro 24 Feb '25

24 Feb '25

Hi There, We found a situation where topos seems to break, let me explain... Assuming the following scenario: ``` Caller ---- Callee A: ------INVITE-----> Record-Route:A.A.A.A, Record-Route:B.B.B.B B: <-----200 OK------ C: <-----INVITE------ Route: A.A.A.A, B.B.B.B D: ------200 OK-----> Record-Route:B.B.B.B, Record-Route:A.A.A.A (reversed order) E: <======INVITE===== Route: B.B.B.B, A.A.A.A (wrong) ``` A and B establish the connection from caller to callee, and topos works fine. C (re-INVITE from callee) sends the Route header according to the Record-Routes from the original INVITE (A) D is the 200 OK sent from the caller to the first re-INVITE (C) coming from the callee, with the Record-Route headers reversed, because is the order in which the callee received them; and according to the RFC it's working as intended: ``` When a UAS responds to a request with a response that establishes a dialog (such as a 2xx to INVITE), the UAS MUST copy all Record-Route header field values from the request into the response (including the URIs, URI parameters, and any Record-Route header field parameters, whether they are known or unknown to the UAS) and MUST maintain the order of those values. [...] [When a UAC receives a response...] The route set MUST be set to the list of URIs in the Record-Route header field from the response, taken in reverse order and preserving all URI parameters. ``` E takes the Route order from the last 200 OK ignoring they are in reversed order and assuming the top one is the first one, when it should be the other way around, sending to an IP address not reachable from the callee. And I think here is the issue, topos should not update the path on the Record-Routes from a 200 OK but if it does, it should take the reverse order When disabling topos, everything works fine, or with topos enabled, by setting rr_update=0 works for us, but what if there is a real path update, rr_update=0 wouldn't work for us anymore. The Kamailio version is 5.8.0-rc0 Let me know if you need more information. Thanks a lot, Javi -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3778 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3778(a)github.com>

5 16

git:master:2b1ca781: dialog: fixed DLG_FLAG_CHANGED_PROF value and setting DLG_FLAG_DEL
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 2b1ca7813cf5014553c807c1a5034c404b3685a5 URL: https://github.com/kamailio/kamailio/commit/2b1ca7813cf5014553c807c1a5034c4… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T10:49:47+01:00 dialog: fixed DLG_FLAG_CHANGED_PROF value and setting DLG_FLAG_DEL - GH #4151 --- Modified: src/modules/dialog/dlg_hash.h Modified: src/modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/2b1ca7813cf5014553c807c1a5034c4… Patch: https://github.com/kamailio/kamailio/commit/2b1ca7813cf5014553c807c1a5034c4… --- diff --git a/src/modules/dialog/dlg_hash.h b/src/modules/dialog/dlg_hash.h index 804b736b4ee..5d19841465a 100644 --- a/src/modules/dialog/dlg_hash.h +++ b/src/modules/dialog/dlg_hash.h @@ -70,7 +70,7 @@ #define DLG_FLAG_TM (1 << 9) /*!< dialog is set in transaction */ #define DLG_FLAG_EXPIRED (1 << 10) /*!< dialog is expired */ -#define DLG_FLAG_CHANGED_PROF (1 << 10) /*!< dialog-profiles changed DMQ*/ +#define DLG_FLAG_CHANGED_PROF (1 << 11) /*!< dialog-profiles changed - DMQ */ #define DLG_FLAG_DB_LOAD_EXTRA (1 << 12) /*!< dialog loaded extra from db */ /* internal flags stored in db */ diff --git a/src/modules/dialog/dlg_var.c b/src/modules/dialog/dlg_var.c index db5f61c4e05..3368728297c 100644 --- a/src/modules/dialog/dlg_var.c +++ b/src/modules/dialog/dlg_var.c @@ -197,8 +197,8 @@ int set_dlg_variable_unsafe(struct dlg_cell *dlg, str *key, str *val) it_prev->next = it->next; else *var_list = it->next; - /* Set the delete-flag for the current var: */ - it->vflags &= DLG_FLAG_DEL; + /* set the delete-flag for the current var */ + it->vflags |= DLG_FLAG_DEL; } else { /* replace the current it with var and free the it */ var->next = it->next;

1 0

git:master:3b213f1d: dialog: get vars via value instead of reference for kemi functions
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 3b213f1d008656682f1733d59f6c3bacd474c4b9 URL: https://github.com/kamailio/kamailio/commit/3b213f1d008656682f1733d59f6c3ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T10:49:47+01:00 dialog: get vars via value instead of reference for kemi functions - do lock/unlock - GH #4151 --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/3b213f1d008656682f1733d59f6c3ba… Patch: https://github.com/kamailio/kamailio/commit/3b213f1d008656682f1733d59f6c3ba… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index 6871cc960e3..382941c9925 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -1852,32 +1852,36 @@ static int fixup_dlg_bridge(void **param, int param_no) return 0; } -static str *ki_dlg_get_var_helper( - sip_msg_t *msg, str *sc, str *sf, str *st, str *key) +static int ki_dlg_get_var_helper( + sip_msg_t *msg, str *sc, str *sf, str *st, str *key, str *val) { dlg_cell_t *dlg = NULL; unsigned int dir = 0; - str *val = NULL; if(sc == NULL || sc->s == NULL || sc->len == 0) { LM_ERR("invalid Call-ID parameter\n"); - return val; + return -1; } if(sf == NULL || sf->s == NULL || sf->len == 0) { LM_ERR("invalid From tag parameter\n"); - return val; + return -1; } if(st == NULL) { LM_ERR("invalid To tag parameter\n"); - return val; + return -1; } dlg = get_dlg(sc, sf, st, &dir); - if(dlg == NULL) - return val; - val = get_dlg_varref(dlg, key); + if(dlg == NULL) { + LM_DBG("dialog not found for call-id: %.*s\n", sc->len, sc->s); + return -1; + } + if(get_dlg_varval(dlg, key, val) != 0) { + dlg_release(dlg); + return -1; + } dlg_release(dlg); - return val; + return 0; } /** @@ -1888,18 +1892,15 @@ static sr_kemi_xval_t _sr_kemi_dialog_xval = {0}; static sr_kemi_xval_t *ki_dlg_get_var( sip_msg_t *msg, str *sc, str *sf, str *st, str *key) { - str *val = NULL; - memset(&_sr_kemi_dialog_xval, 0, sizeof(sr_kemi_xval_t)); - val = ki_dlg_get_var_helper(msg, sc, sf, st, key); - if(!val) { + if(ki_dlg_get_var_helper(msg, sc, sf, st, key, &_sr_kemi_dialog_xval.v.s) + < 0) { sr_kemi_xval_null(&_sr_kemi_dialog_xval, SR_KEMI_XVAL_NULL_NONE); return &_sr_kemi_dialog_xval; } _sr_kemi_dialog_xval.vtype = SR_KEMIP_STR; - _sr_kemi_dialog_xval.v.s = *val; return &_sr_kemi_dialog_xval; } @@ -2504,8 +2505,12 @@ static int ki_dlg_var_sets(sip_msg_t *msg, str *name, str *val) int ret; dlg = dlg_get_msg_dialog(msg); + if(dlg) { + dlg_cell_lock(dlg); + } ret = set_dlg_variable_unsafe(dlg, name, val); if(dlg) { + dlg_cell_unlock(dlg); dlg_release(dlg); } @@ -2518,7 +2523,6 @@ static int ki_dlg_var_sets(sip_msg_t *msg, str *name, str *val) static sr_kemi_xval_t *ki_dlg_var_get_mode(sip_msg_t *msg, str *name, int rmode) { dlg_cell_t *dlg; - str *pval; memset(&_sr_kemi_dialog_xval, 0, sizeof(sr_kemi_xval_t)); @@ -2527,14 +2531,12 @@ static sr_kemi_xval_t *ki_dlg_var_get_mode(sip_msg_t *msg, str *name, int rmode) sr_kemi_xval_null(&_sr_kemi_dialog_xval, rmode); return &_sr_kemi_dialog_xval; } - pval = get_dlg_varref(dlg, name); - if(pval == NULL || pval->s == NULL) { + if(get_dlg_varval(dlg, name, &_sr_kemi_dialog_xval.v.s) < 0) { sr_kemi_xval_null(&_sr_kemi_dialog_xval, rmode); goto done; } _sr_kemi_dialog_xval.vtype = SR_KEMIP_STR; - _sr_kemi_dialog_xval.v.s = *pval; done: dlg_release(dlg); @@ -2572,7 +2574,12 @@ static int ki_dlg_var_rm(sip_msg_t *msg, str *name) dlg_cell_t *dlg; dlg = dlg_get_msg_dialog(msg); - set_dlg_variable_unsafe(dlg, name, NULL); + if(dlg) { + dlg_cell_lock(dlg); + set_dlg_variable_unsafe(dlg, name, NULL); + dlg_cell_unlock(dlg); + dlg_release(dlg); + } return 1; }

1 0

git:master:862a0f5f: modules: readme files regenerated - dmq ... [skip ci]
by Kamailio Dev 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 862a0f5fa50ad2d6f97078e3d856f6379e53ff1d URL: https://github.com/kamailio/kamailio/commit/862a0f5fa50ad2d6f97078e3d856f63… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2025-02-21T09:01:09+01:00 modules: readme files regenerated - dmq ... [skip ci] --- Modified: src/modules/dmq/README Modified: src/modules/dmq_usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/862a0f5fa50ad2d6f97078e3d856f63… Patch: https://github.com/kamailio/kamailio/commit/862a0f5fa50ad2d6f97078e3d856f63…

1 0

[kamailio/kamailio] dmq and dmq_usrloc additions (PR #4134)
by Stefan Mititelu 21 Feb '25

21 Feb '25

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Add new api function to dmq to get local socket. Use that in dmq_usrloc. Sync dmq_usrloc UL_CONTACT_EXPIRE. Very useful for lost TCP connections, so contacts will be expired on all dmq nodes. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4134 -- Commit Summary -- * dmq: add new api function * dmq_usrloc: new value for replicate_socket_info * dmq_usrloc: add new modparam to sync UL_CONTACT_EXPIRE actions -- File Changes -- M src/modules/dmq/bind_dmq.c (1) M src/modules/dmq/bind_dmq.h (2) M src/modules/dmq/dmq_funcs.c (5) M src/modules/dmq/dmq_funcs.h (1) M src/modules/dmq_usrloc/dmq_usrloc.c (3) M src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml (26) M src/modules/dmq_usrloc/usrloc_sync.c (22) M src/modules/dmq_usrloc/usrloc_sync.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4134.patch https://github.com/kamailio/kamailio/pull/4134.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4134 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4134(a)github.com>

2 4

git:master:f9b503b3: dmq_usrloc: warn log when no dmq module server socket found
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: f9b503b35758b9f0f261ebf7e83ffbbe1d537f9f URL: https://github.com/kamailio/kamailio/commit/f9b503b35758b9f0f261ebf7e83ffbb… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq_usrloc: warn log when no dmq module server socket found --- Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/f9b503b35758b9f0f261ebf7e83ffbb… Patch: https://github.com/kamailio/kamailio/commit/f9b503b35758b9f0f261ebf7e83ffbb… --- diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index 1760616aed5..87e151b4fa3 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -317,7 +317,7 @@ int usrloc_dmq_initialize() dmq_server_socket = usrloc_dmqb.get_dmq_server_socket(); dmq_server_socket_local = lookup_local_socket(&dmq_server_socket); if(dmq_server_socket_local == 0) { - LM_DBG("dmq local server socket <%.*s> not found ...ignoring\n", + LM_WARN("dmq local server socket <%.*s> not found ...ignoring\n", dmq_server_socket.len, dmq_server_socket.s); }

1 0

git:master:a83ec388: dmq_usrloc: add modparam for cflags replication
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: a83ec38863fca0473685b81f708938660a08da81 URL: https://github.com/kamailio/kamailio/commit/a83ec38863fca0473685b81f7089386… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq_usrloc: add modparam for cflags replication --- Modified: src/modules/dmq_usrloc/dmq_usrloc.c Modified: src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/a83ec38863fca0473685b81f7089386… Patch: https://github.com/kamailio/kamailio/commit/a83ec38863fca0473685b81f7089386… --- diff --git a/src/modules/dmq_usrloc/dmq_usrloc.c b/src/modules/dmq_usrloc/dmq_usrloc.c index 8c4544b1633..a568d3d3148 100644 --- a/src/modules/dmq_usrloc/dmq_usrloc.c +++ b/src/modules/dmq_usrloc/dmq_usrloc.c @@ -37,6 +37,7 @@ static int child_init(int); int dmq_usrloc_enable = 0; int _dmq_usrloc_sync = 1; int _dmq_usrloc_replicate_socket_info = 0; +int _dmq_usrloc_replicate_cflags = 1; int _dmq_usrloc_batch_size = 0; int _dmq_usrloc_batch_msg_contacts = 1; int _dmq_usrloc_batch_msg_size = 60000; @@ -54,6 +55,7 @@ static param_export_t params[] = { {"enable", PARAM_INT, &dmq_usrloc_enable}, {"sync", PARAM_INT, &_dmq_usrloc_sync}, {"replicate_socket_info", PARAM_INT, &_dmq_usrloc_replicate_socket_info}, + {"replicate_cflags", PARAM_INT, &_dmq_usrloc_replicate_cflags}, {"batch_msg_contacts", PARAM_INT, &_dmq_usrloc_batch_msg_contacts}, {"batch_msg_size", PARAM_INT, &_dmq_usrloc_batch_msg_size}, {"batch_size", PARAM_INT, &_dmq_usrloc_batch_size}, diff --git a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml index ff612b32eda..5d6727b5c83 100644 --- a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml +++ b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml @@ -292,6 +292,44 @@ modparam("dmq_usrloc", "replicate_socket_info", 1) </programlisting> </example> </section> + <section id="usrloc_dmq.p.replicate_cflags"> + <title><varname>replicate_cflags</varname> (int)</title> + <para> + The parameter controls whether the cflags replication is active or not. + This is important for anycast scenarios. + The value can be: + <itemizedlist> + <listitem> + <para> + 0 - disabled + </para> + </listitem> + <listitem> + <para> + 1 - enabled, replicate cflags + </para> + </listitem> + <listitem> + <para> + > 1 - enabled, set cflags corresponding to this value, on replicated peers + </para> + </listitem> + </itemizedlist> + </para> + <para> + <emphasis> + Default value is 1. + </emphasis> + </para> + <example> + <title>Set <varname>replicate_cflags</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dmq_usrloc", "replicate_cflags", 97) # will set cflags corresponding to 1 + 32 + 64 +... + </programlisting> + </example> + </section> <section id="usrloc_dmq.p.usrloc_delete"> <title><varname>usrloc_delete</varname> (int)</title> <para> diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index 73017c52877..1760616aed5 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -60,6 +60,7 @@ static void srjson_to_xavp(srjson_t *json, sr_xavp_t **xavp); extern int _dmq_usrloc_sync; extern int _dmq_usrloc_replicate_socket_info; +extern int _dmq_usrloc_replicate_cflags; extern int _dmq_usrloc_batch_msg_contacts; extern int _dmq_usrloc_batch_msg_size; extern int _dmq_usrloc_batch_size; @@ -421,7 +422,12 @@ static int usrloc_dmq_execute_action(srjson_t *jdoc_action, dmq_node_t *node) } else if(strcmp(it->string, "flags") == 0) { flags = SRJSON_GET_UINT(it); } else if(strcmp(it->string, "cflags") == 0) { - cflags = SRJSON_GET_UINT(it); + if(_dmq_usrloc_replicate_cflags == 1) { + cflags = SRJSON_GET_UINT(it); + } else if(_dmq_usrloc_replicate_cflags > 1) { + cflags = _dmq_usrloc_replicate_cflags; + } + // else don't replicate cflags } else if(strcmp(it->string, "q") == 0) { q = SRJSON_GET_UINT(it); } else if(strcmp(it->string, "last_modified") == 0) {

1 0

git:master:2a1bd40c: dmq_usrloc: add new modparam to sync UL_CONTACT_EXPIRE actions
by Daniel-Constantin Mierla 21 Feb '25

21 Feb '25

Module: kamailio Branch: master Commit: 2a1bd40c0264a600107c653e5803760d7173bdc2 URL: https://github.com/kamailio/kamailio/commit/2a1bd40c0264a600107c653e5803760… Author: Stefan Mititelu <stefan.mititelu(a)net2phone.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-02-21T08:53:34+01:00 dmq_usrloc: add new modparam to sync UL_CONTACT_EXPIRE actions --- Modified: src/modules/dmq_usrloc/dmq_usrloc.c Modified: src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml Modified: src/modules/dmq_usrloc/usrloc_sync.c --- Diff: https://github.com/kamailio/kamailio/commit/2a1bd40c0264a600107c653e5803760… Patch: https://github.com/kamailio/kamailio/commit/2a1bd40c0264a600107c653e5803760… --- diff --git a/src/modules/dmq_usrloc/dmq_usrloc.c b/src/modules/dmq_usrloc/dmq_usrloc.c index 98f3b222728..8c4544b1633 100644 --- a/src/modules/dmq_usrloc/dmq_usrloc.c +++ b/src/modules/dmq_usrloc/dmq_usrloc.c @@ -43,6 +43,7 @@ int _dmq_usrloc_batch_msg_size = 60000; int _dmq_usrloc_batch_usleep = 0; str _dmq_usrloc_domain = str_init("location"); int _dmq_usrloc_delete = 1; +int _dmq_usrloc_delete_expired = 0; usrloc_api_t dmq_ul; @@ -59,6 +60,7 @@ static param_export_t params[] = { {"batch_usleep", PARAM_INT, &_dmq_usrloc_batch_usleep}, {"usrloc_domain", PARAM_STR, &_dmq_usrloc_domain}, {"usrloc_delete", PARAM_INT, &_dmq_usrloc_delete}, + {"usrloc_delete_expired", PARAM_INT, &_dmq_usrloc_delete_expired}, {0, 0, 0} }; @@ -116,6 +118,7 @@ static int mod_init(void) LM_ERR("Error in dmq_usrloc_initialize()\n"); } } + return 0; } diff --git a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml index b94947e2c77..ff612b32eda 100644 --- a/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml +++ b/src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml @@ -303,11 +303,30 @@ modparam("dmq_usrloc", "replicate_socket_info", 1) </emphasis> </para> <example> - <title>Set <varname>usrloc_domain</varname> parameter</title> + <title>Set <varname>usrloc_delete</varname> parameter</title> <programlisting format="linespecific"> ... modparam("dmq_usrloc", "usrloc_delete", 0) ... +</programlisting> + </example> + </section> + <section id="usrloc_dmq.p.usrloc_delete_expired"> + <title><varname>usrloc_delete_expired</varname> (int)</title> + <para> + Enable (1) or disable (0) synchronizing usrloc expire actions using delete actions. In other words, sync delete of (UL_CONTACT_EXPIRE) expired contacts. + </para> + <para> + <emphasis> + Default value is 0. + </emphasis> + </para> + <example> + <title>Set <varname>usrloc_delete_expired</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("dmq_usrloc", "usrloc_delete_expired", 1) +... </programlisting> </example> </section> diff --git a/src/modules/dmq_usrloc/usrloc_sync.c b/src/modules/dmq_usrloc/usrloc_sync.c index 00cf877e64b..73017c52877 100644 --- a/src/modules/dmq_usrloc/usrloc_sync.c +++ b/src/modules/dmq_usrloc/usrloc_sync.c @@ -66,6 +66,7 @@ extern int _dmq_usrloc_batch_size; extern int _dmq_usrloc_batch_usleep; extern str _dmq_usrloc_domain; extern int _dmq_usrloc_delete; +extern int _dmq_usrloc_delete_expired; static int add_contact(str aor, ucontact_info_t *ci) { @@ -1043,7 +1044,9 @@ void dmq_ul_cb_contact(ucontact_t *ptr, int type, void *param) } break; case UL_CONTACT_EXPIRE: - //usrloc_dmq_send_contact(ptr, aor, DMQ_UPDATE); + if(_dmq_usrloc_delete_expired >= 1) { + usrloc_dmq_send_contact(ptr, aor, DMQ_RM, 0); + } LM_DBG("Contact <%.*s> expired\n", aor.len, aor.s); break; }

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
18
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2025