sr-dev April 2025

sr-dev@lists.kamailio.org

14 participants
206 discussions

git:6.0:24b095d8: app_python3: fix threads_mode = 1
by S-P Chan 22 Apr '25

22 Apr '25

Module: kamailio Branch: 6.0 Commit: 24b095d86ae3288dac2e703dc865f9b43a7c40c6 URL: https://github.com/kamailio/kamailio/commit/24b095d86ae3288dac2e703dc865f9b… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:57:46+08:00 app_python3: fix threads_mode = 1 - fixes gh #4153 - commit 0ffe157: incorrect use of thread-local storage to save python thread state (cherry picked from commit 9c746b26bf7ecb4922f445318de7756d21e0d041) --- Modified: src/modules/app_python3/app_python3_mod.c Modified: src/modules/app_python3/python_exec.c --- Diff: https://github.com/kamailio/kamailio/commit/24b095d86ae3288dac2e703dc865f9b… Patch: https://github.com/kamailio/kamailio/commit/24b095d86ae3288dac2e703dc865f9b… --- diff --git a/src/modules/app_python3/app_python3_mod.c b/src/modules/app_python3/app_python3_mod.c index 7436d528f26..a25a0e354af 100644 --- a/src/modules/app_python3/app_python3_mod.c +++ b/src/modules/app_python3/app_python3_mod.c @@ -59,7 +59,7 @@ int _apy_process_rank = 0; int _ksr_apy3_threads_mode = 0; PyThreadState *myThreadState = NULL; -__thread PyThreadState *_save = NULL; +PyThreadState *_save = NULL; /* clang-format off */ /** module parameters */ diff --git a/src/modules/app_python3/python_exec.c b/src/modules/app_python3/python_exec.c index 3c62265abf6..d4c0f519d1c 100644 --- a/src/modules/app_python3/python_exec.c +++ b/src/modules/app_python3/python_exec.c @@ -49,7 +49,7 @@ sr_apy_env_t *sr_apy_env_get() return &_sr_apy_env; } -extern __thread PyThreadState *_save; +extern PyThreadState *_save; extern int _ksr_apy3_threads_mode; #define LOCK_RELEASE \

1 0

git:master:fcedbd70: app_python3s: update docs for threads_mode parameter
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: fcedbd7099a15e09d1dd21c933f3ebfe3c55f5c5 URL: https://github.com/kamailio/kamailio/commit/fcedbd7099a15e09d1dd21c933f3ebf… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3s: update docs for threads_mode parameter --- Modified: src/modules/app_python3s/doc/app_python3s_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fcedbd7099a15e09d1dd21c933f3ebf… Patch: https://github.com/kamailio/kamailio/commit/fcedbd7099a15e09d1dd21c933f3ebf… --- diff --git a/src/modules/app_python3s/doc/app_python3s_admin.xml b/src/modules/app_python3s/doc/app_python3s_admin.xml index 8381dda274f..bb9e86c8c5c 100644 --- a/src/modules/app_python3s/doc/app_python3s_admin.xml +++ b/src/modules/app_python3s/doc/app_python3s_admin.xml @@ -160,6 +160,10 @@ def ksr_script_child_init(): v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). </para> + <para> + If set to 1, Python threading Thread objects created in the KEMI script will be scheduled. Otherwise, + additional Python threads will not be scheduled (no release of GIL). + </para> <para> <emphasis> Default value is <quote>0</quote>.

1 0

git:master:168d289e: app_python3: update docs for threads_mode parameter
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 168d289ebd6daadf58199f4461ef7cd30dc7442a URL: https://github.com/kamailio/kamailio/commit/168d289ebd6daadf58199f4461ef7cd… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3: update docs for threads_mode parameter --- Modified: src/modules/app_python3/doc/app_python3_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/168d289ebd6daadf58199f4461ef7cd… Patch: https://github.com/kamailio/kamailio/commit/168d289ebd6daadf58199f4461ef7cd… --- diff --git a/src/modules/app_python3/doc/app_python3_admin.xml b/src/modules/app_python3/doc/app_python3_admin.xml index 87b97f0824d..20eeae6ffce 100644 --- a/src/modules/app_python3/doc/app_python3_admin.xml +++ b/src/modules/app_python3/doc/app_python3_admin.xml @@ -168,6 +168,10 @@ modparam("app_python3", "child_init_method", "my_child_init") v6.0.x). If set to 0, use PyGILState_Ensure()/PyGILState_Release() (the mode implemented initially). </para> + <para> + If set to 1, Python threading Thread objects created in the KEMI script will be scheduled. Otherwise, + additional Python threads will not be scheduled (no release of GIL). + </para> <para> <emphasis> Default value is <quote>0</quote>.

1 0

git:master:779cb229: app_python3s: fix threads_mode = 1
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 779cb229ba9a693ac241f4b359c596c0ed46bb7b URL: https://github.com/kamailio/kamailio/commit/779cb229ba9a693ac241f4b359c596c… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3s: fix threads_mode = 1 - fixes gh #4153 - commit 62b4ee4: incorrect use of thread-local storage to save python thread state --- Modified: src/modules/app_python3s/app_python3s_mod.c Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/779cb229ba9a693ac241f4b359c596c… Patch: https://github.com/kamailio/kamailio/commit/779cb229ba9a693ac241f4b359c596c… --- diff --git a/src/modules/app_python3s/app_python3s_mod.c b/src/modules/app_python3s/app_python3s_mod.c index a99154366ad..876bd3c2a20 100644 --- a/src/modules/app_python3s/app_python3s_mod.c +++ b/src/modules/app_python3s/app_python3s_mod.c @@ -60,7 +60,7 @@ int _apy3s_process_rank = 0; int _ksr_apy3s_threads_mode = 0; PyThreadState *myThreadState = NULL; -__thread PyThreadState *_save = NULL; +PyThreadState *_save = NULL; static int apy3s_script_init_exec(PyObject *pModule, str *fname, int *vparam); diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index c25ccfdc91a..48ee1c46b67 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -52,7 +52,7 @@ extern str _sr_python_load_file; extern int _apy3s_process_rank; extern int _ksr_apy3s_threads_mode; -extern __thread PyThreadState *_save; +extern PyThreadState *_save; int apy_reload_script(void); @@ -69,8 +69,6 @@ sr_apy_env_t *sr_apy_env_get() /** * */ -extern __thread PyThreadState *_save; - int apy3s_exec_func(sip_msg_t *_msg, char *fname, char *fparam, int emode) { PyObject *pFunc, *pArgs, *pValue;

1 0

git:master:9c746b26: app_python3: fix threads_mode = 1
by S-P Chan 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 9c746b26bf7ecb4922f445318de7756d21e0d041 URL: https://github.com/kamailio/kamailio/commit/9c746b26bf7ecb4922f445318de7756… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2025-04-22T07:34:29+08:00 app_python3: fix threads_mode = 1 - fixes gh #4153 - commit 0ffe157: incorrect use of thread-local storage to save python thread state --- Modified: src/modules/app_python3/app_python3_mod.c Modified: src/modules/app_python3/python_exec.c --- Diff: https://github.com/kamailio/kamailio/commit/9c746b26bf7ecb4922f445318de7756… Patch: https://github.com/kamailio/kamailio/commit/9c746b26bf7ecb4922f445318de7756… --- diff --git a/src/modules/app_python3/app_python3_mod.c b/src/modules/app_python3/app_python3_mod.c index 7436d528f26..a25a0e354af 100644 --- a/src/modules/app_python3/app_python3_mod.c +++ b/src/modules/app_python3/app_python3_mod.c @@ -59,7 +59,7 @@ int _apy_process_rank = 0; int _ksr_apy3_threads_mode = 0; PyThreadState *myThreadState = NULL; -__thread PyThreadState *_save = NULL; +PyThreadState *_save = NULL; /* clang-format off */ /** module parameters */ diff --git a/src/modules/app_python3/python_exec.c b/src/modules/app_python3/python_exec.c index 3c62265abf6..d4c0f519d1c 100644 --- a/src/modules/app_python3/python_exec.c +++ b/src/modules/app_python3/python_exec.c @@ -49,7 +49,7 @@ sr_apy_env_t *sr_apy_env_get() return &_sr_apy_env; } -extern __thread PyThreadState *_save; +extern PyThreadState *_save; extern int _ksr_apy3_threads_mode; #define LOCK_RELEASE \

1 0

git:master:47aa53eb: cdp: free in case of errors inside load_certificates()
by Daniel-Constantin Mierla 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 47aa53ebd55eba4b36c38329f8619d9f7d20c076 URL: https://github.com/kamailio/kamailio/commit/47aa53ebd55eba4b36c38329f8619d9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-21T08:24:18+02:00 cdp: free in case of errors inside load_certificates() --- Modified: src/modules/cdp/cdp_tls.c --- Diff: https://github.com/kamailio/kamailio/commit/47aa53ebd55eba4b36c38329f8619d9… Patch: https://github.com/kamailio/kamailio/commit/47aa53ebd55eba4b36c38329f8619d9… --- diff --git a/src/modules/cdp/cdp_tls.c b/src/modules/cdp/cdp_tls.c index a3cfdfa9252..f2c7c7b8b63 100644 --- a/src/modules/cdp/cdp_tls.c +++ b/src/modules/cdp/cdp_tls.c @@ -149,16 +149,20 @@ int load_certificates(SSL_CTX *ctx, str *cert, str *key) } if(pkg_str_dup(&key_fixed, key) < 0) { LM_ERR("Failed to copy key parameter\n"); + pkg_free(cert_fixed.s); return -1; } if(!SSL_CTX_use_certificate_chain_file(ctx, cert_fixed.s)) { LM_ERR("Unable to load certificate file\n"); TLS_LM_ERR("load_cert:", ctx); + pkg_free(key_fixed.s); + pkg_free(cert_fixed.s); return -1; } if(SSL_CTX_use_PrivateKey_file(ctx, key_fixed.s, SSL_FILETYPE_PEM) <= 0) { LM_ERR("Unable to load private key file\n"); TLS_LM_ERR("load_private_key:", ctx); + pkg_free(key_fixed.s); return -1; } if(!SSL_CTX_check_private_key(ctx)) {

1 0

git:master:5aee159c: prefix_route: more debug messages
by Daniel-Constantin Mierla 21 Apr '25

21 Apr '25

Module: kamailio Branch: master Commit: 5aee159c2881aff29a2973073e1dd6c5c61bfdb9 URL: https://github.com/kamailio/kamailio/commit/5aee159c2881aff29a2973073e1dd6c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-20T09:15:59+02:00 prefix_route: more debug messages - GH #4218 --- Modified: src/modules/prefix_route/prefix_route.c --- Diff: https://github.com/kamailio/kamailio/commit/5aee159c2881aff29a2973073e1dd6c… Patch: https://github.com/kamailio/kamailio/commit/5aee159c2881aff29a2973073e1dd6c… --- diff --git a/src/modules/prefix_route/prefix_route.c b/src/modules/prefix_route/prefix_route.c index 686962089b5..92059cd5497 100644 --- a/src/modules/prefix_route/prefix_route.c +++ b/src/modules/prefix_route/prefix_route.c @@ -262,16 +262,20 @@ static int ki_prefix_route(sip_msg_t *msg, str *ruser) int err; int route; + LM_DBG("trying to run route block for [%.*s]\n", ruser->len, ruser->s); route = tree_route_get(ruser); - if(route <= 0) + if(route <= 0) { + LM_DBG("route block for [%.*s] not found\n", ruser->len, ruser->s); return -1; + } /* If match send to route[x] */ init_run_actions_ctx(&ra_ctx); err = run_actions(&ra_ctx, main_rt.rlist[route], msg); if(err < 0) { - LM_ERR("run_actions failed (%d)\n", err); + LM_ERR("run actions failed (%d) for [%.*s]\n", err, ruser->len, + ruser->s); return -1; }

1 0

[kamailio/kamailio] Error when sending NOTIFYs in the presence of disconnected websocket watchers (Issue #4118)
by Flavio Grossi 20 Apr '25

20 Apr '25

### Description if multiple sip websocket clients are subscribed to some UA and one of the watchers suddenly disappears (e.g. the web page is reloaded), then no NOTIFY is ever sent after issuing a `pres_refresh_watchers()`. The following error is logged: ``` WARNING: <core> [core/msg_translator.c:3007]: via_builder(): TCP/TLS connection (id: 0) for WebSocket could not be found ERROR: tm [t_msgbuilder.c:1423]: assemble_via(): via building failed ERROR: tm [t_msgbuilder.c:1614]: build_uac_req(): error while assembling Via ERROR: tm [uac.c:552]: t_uac_prepare(): Error while building message ERROR: presence [notify.c:1734]: send_notify_request(): in function tm t_request_within() ERROR: presence [notify.c:1829]: notify(): sending Notify not successful ERROR: presence [notify.c:1585]: query_db_notify(): Could not send notify for [event]=dialog ERROR: presence [presence.c:739]: pres_refresh_watchers(): sending Notify requests ``` ### Troubleshooting when the client disconnects, the old watcher is not removed from the active_watchers table, instead it coexists with the new one, but the stale connection causes the error above when sending the notify, and then all of the following watchers (even the valid ones) are skipped too. Looking at the logs, the valid watchers are not notified because the while loop [here](https://github.com/kamailio/kamailio/blob/b96bc11a54f11ec688429c057bf… is skipped because of the `goto done` line in case of errors, which happens because it fails to build the via header for the message relevant to the stale websocket connection. By breaking out of the while loop, the remaining subs in the `subs_array` are skipped. #### Reproduction Just subscribe to a sip client using a websocket-based phone, then abruptly disconnect it (e.g. by reloading the web page) and then issue a `pres_refresh_watchers()` to make it generate a notify. #### Debugging Data #### Log Messages #### SIP Traffic ### Possible Solutions I tried to use the "websocket:closed" route to purge stale connections, but to my knowledge there are no APIs to clean invalid watchers. A possible solution could be to automatically remove the watchers on disconnection and maybe skip the invalid ones without exiting from the refresh loop ### Additional Information kamailio 5.8.2 * **Operating System**: Rocky Linux 9 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4118 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4118(a)github.com>

4 5

[kamailio/kamailio] fr_timer documentation mistake (Issue #3939)
by Dmitry Sinina 20 Apr '25

20 Apr '25

Documentation https://www.kamailio.org/docs/modules/devel/modules/tm.html#tm.p.fr_timer says: >Timer which hits if no **final reply** for a request or ACK for a negative INVITE reply arrives (in milliseconds). Looks like it is not correct description - fr_timer value works until 1xx(not **final**) response received and then timer restarted with fr_inv_timer value there: https://github.com/kamailio/kamailio/blob/master/src/modules/tm/t_reply.c#L… Looks like old doc from sip router https://sip-router.org/wiki/ref_manual/timers explains it correctly: > fr_timer This timer is used for all SIP requests. It hits if no reply for an INVITE request or other request has been received (F in milliseconds). If a provisional reply is received for an INVITE (any 1xx), then the fr_inv_timer will be used instead. And if no replies (at all) for an INVITE are received before `fr_timer` hits, the transaction is terminated with a 408 in failure route. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3939 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3939(a)github.com>

3 10

[kamailio/kamailio] cfgutils.unlock [apy_kemi.c:278]: sr_apy_kemi_exec_func_ex(): invalid number of parameters - idx: 1 argc: 1 (Issue #4216)
by space88man 19 Apr '25

19 Apr '25

space88man created an issue (kamailio/kamailio#4216) ### Description Use cfgengine python and KSR.cfgutils.unlock ### Troubleshooting #### Reproduction In cfgengine python call ``` KSR.cfgutils.lock("something") # do some work KSR.cfgutils.unlock("something") ``` #### Debugging Data n/a #### Log Messages ```ERROR: app_python3 [apy_kemi.c:278]: sr_apy_kemi_exec_func_ex(): invalid number of parameters - idx: 1 argc: 1 ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 17:27:30 Mar 29 2025 with gcc 8.5.0 ``` * **Operating System**: ``` AlmaLinux 9.5 x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4216 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4216(a)github.com>

2 2

← Newer
1
...
8
9
10
11
12
13
14
...
21
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2025