ChristianBergerSipgate created an issue (kamailio/kamailio#4168)
We think we have found a potential bug in the path module.
When we call `add_path_received()` we get the following for WSS connections:
`Path: <sip:217.10.77.242;lr;received=sip:217.10.69.93:42612%3Btransport%3Dws>`
We think there should be a `transport%3Dwss` appended instead of ws.
We have looked a bit into the code and think that this is caused by the following definition:
```
in modules/path/path.c
const static char *proto_strings[] = {
[PROTO_TCP] = "%3Btransport%3Dtcp",
[PROTO_TLS] = "%3Btransport%3Dtls",
[PROTO_SCTP] = "%3Btransport%3Dsctp",
[PROTO_WS] = "%3Btransport%3Dws",
[PROTO_WSS] = "%3Btransport%3Dws",
};
```
We think that on the last line, it should read
` [PROTO_WSS] = "%3Btransport%3Dwss",`
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4168
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/4168(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
fixes bug when `ping_socket` for destination overwrites `dp->sock` which is used for normal (not probing OPTIONS) requests
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4217
-- Commit Summary --
* dispatcher: fix sock overwrite by ping_socket
-- File Changes --
M src/modules/dispatcher/dispatch.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4217.patchhttps://github.com/kamailio/kamailio/pull/4217.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4217
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4217(a)github.com>