sr-dev April 2025

sr-dev@lists.kamailio.org

14 participants
194 discussions

[kamailio/kamailio] core: docs: Update type identifiers that can be used in the RPC API (PR #4228)
by Xenofon Karamanos 29 Apr '25

29 Apr '25

- format as well   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #4227 #### Description  There was missing information of type identifiers that can be used in [rpc tutorial docs](https://www.kamailio.org/docs/docbooks/5.7.x/rpc_api/rpc_api.html#rpc…. This is an update to those docs. The most recent I could find was for 5.7. Maybe there is a need for manual updating the page? Also during the relevant PR #4227 , we found the `t` identifier is never used in the code. since it can overflow on 64bit systems due to being a `long` and not `int` type when saved/load, maybe we can remove it completely?. One can just cast the `time_t` to the relevant type and use the correct identifier as done in https://github.com/kamailio/kamailio/blob/2081b3aac394223b68b849fbac2a9e5ac… You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4228 -- Commit Summary -- * Update type identifiers that can be used in the RPC API -- File Changes -- M doc/tutorials/rpc/kamailio_rpc.xml (86) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4228.patch https://github.com/kamailio/kamailio/pull/4228.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4228 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4228(a)github.com>

1 1

[kamailio/kamailio] cdp: Cast time for printing and Improve cdp docs (PR #4227)
by Xenofon Karamanos 29 Apr '25

29 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4226 #### Description  - Improve and add missing function documentation `list_peers`. - Use correct identifier in `struct_add` rpc function and cast `time_t` for time_t field. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4227 -- Commit Summary -- * cdp: Cast time_t and use 'L' (long long) identifier in rpc function. * cdp/docs: Add missing list_peers function -- File Changes -- M src/modules/cdp/cdp_rpc.c (4) M src/modules/cdp/doc/cdp_admin.xml (29) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4227.patch https://github.com/kamailio/kamailio/pull/4227.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4227 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4227(a)github.com>

1 0

[kamailio/kamailio] Corrupted output with log-engine json (Issue #4203)
by Matteo 29 Apr '25

29 Apr '25

xadhoom created an issue (kamailio/kamailio#4203)  ### Description Enabled json logging engine, with the following setup: - kam cmd line params: `--log-engine=json:Mp` - prefix: `log_prefix=", \"callid\": \"$ci\",\"srcip\": \"$si\", \"ts\": $TV(Sn), \"method\": \"$rm\", \"mt\": $mt, \"ua\": \"$(ua{s.escape.common})\", \"cseq\": \"$hdr(CSeq)\", \"status\": $rs "` - another prefix (same result): `log_prefix=", \"callid\": \"$ci\", \"ts\": $TV(Sn) "` What I see that certain json lines are truncated, for example - one line is interrupted by another json entry - one line starts "truncated" ### Troubleshooting What I can observe is that seems to happens always with same "kind" of line, usually internal logs, which don't have callid etc. #### Log Messages  The following first 3 lines are ok, then the latest is corrupted: ``` { "time": "2025-04-04T15:51:44.448427533Z", "idx": 193, "pid": 200, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:51:44.448682606Z", "idx": 194, "pid": 201, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448279053Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/receive.c", "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } { "time": "2025-04-04T15:52:14.448505797Z", "idx": 196, "pid": 203, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T15:52:14.448508084Z", "idx": 195, "pid": 202, "level": "DEBUG", "module": "core", "file": "core/parser/msg, "line": 128, "function": "sip_check_fline", "message": "first line indicates a SIP reply" } ``` or (notice 2nd line or 5th one) ``` { "time": "2025-04-04T16:13:33.789641936Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "core", "file": "core/receive.c"{ "time": "2025-04-04T16:13:33.789642978Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", ", "line": 265, "function": "ksr_evrt_pre_routing", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "event route core:pre-routing not defined" } line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789646470Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/xavp.c", "line": 630, "function": "xavp_destroy_list", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "destroying xavp list (nil)" } { "time": "2025-04-04T16:13:33.789648201Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1579, "function": "t_check_msg", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "msg (0x7f{ "time": "2025-04-04T16:13:33.789649346Z", "idx": 222, "pid": 229, "level": "DEBUG", "module": "core", "file": "core/receive.c"8f7a693c50) id=2/228 global id=1/228 T start=0xffffffffffffffff" } , "line": 637, "function": "receive_msg", "callid": "5715efe40e9b7720-264(a)127.0.0.1", "ts": 1743783213.789527 , "message": "cleaning up" } { "time": "2025-04-04T16:13:33.789652839Z", "idx": 221, "pid": 228, "level": "DEBUG", "module": "tm", "file": "t_lookup.c", "line": 1424, "function": "t_reply_matching", "callid": "5715efe40e9b7721-264(a)127.0.0.1", "ts": 1743783213.789640 , "message": "t_reply_matching: hash 26404 label 0 branch 0" } ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` 6.0.1 ``` happens also with 5.8.x * **Operating System**:  ``` Debian noble, docker container ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4203 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4203(a)github.com>

3 8

git:master:2081b3aa: core: utils/tmrec - reworked bymonth matching for negative indexes
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 2081b3aac394223b68b849fbac2a9e5ac4392334 URL: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T11:49:04+02:00 core: utils/tmrec - reworked bymonth matching for negative indexes - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… Patch: https://github.com/kamailio/kamailio/commit/2081b3aac394223b68b849fbac2a9e5… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index d609e136310..eec02d22431 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1104,6 +1104,7 @@ int check_min_unit(tmrec_t *_trp, ac_tm_t *_atp, tr_res_t *_tsw) int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { int i; + int v; ac_maxval_t *_amp = NULL; if(!_trp || !_atp) return REC_ERR; @@ -1117,10 +1118,12 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { - if(_atp->t.tm_mon - == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] - + 12) - % 12) + if(_trp->bymonth->req[i] < 0) { + v = 12 - _trp->bymonth->xxx[i]; + } else { + v = _trp->bymonth->xxx[i] - 1; + } + if(_atp->t.tm_mon == v) break; } if(i >= _trp->bymonth->nr)

1 0

[kamailio/kamailio] dispatcher: Check if tm is enabled before probing (PR #4223)
by Xenofon Karamanos 29 Apr '25

29 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4212 #### Description  Probing a host correctly needs the tm module to be loaded. This PR adds a check for when adding a target in dispatcher with probing enabled to verify whether tm is loaded. If it's not, it emmits a warning and disable the probing to the target. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4223 -- Commit Summary -- * dispatcher: Check if tm is enabled before probing -- File Changes -- M src/modules/dispatcher/dispatch.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4223.patch https://github.com/kamailio/kamailio/pull/4223.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4223 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4223(a)github.com>

2 2

git:master:512c5f51: dispatcher: Check if tm is enabled before probing
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 512c5f51bba77529b9cc844a6b4904a1d6275c1e URL: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:28:29+02:00 dispatcher: Check if tm is enabled before probing --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… Patch: https://github.com/kamailio/kamailio/commit/512c5f51bba77529b9cc844a6b4904a… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index a49e5638cd3..a90daa2abfa 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -745,6 +745,12 @@ ds_dest_t *add_dest2list(int id, str uri, int flags, int priority, str *attrs, ds_dest_t *dp0 = NULL; ds_dest_t *dp1 = NULL; + /* Check if tm binding (by testing tmb.t_gett) is loaded and if not, disable the probing */ + if(tmb.t_gett == NULL && (flags & DS_PROBING_DST)) { + LM_WARN("tm module not loaded, disabling probing\n"); + flags &= ~DS_PROBING_DST; + } + dp = pack_dest(uri, flags, priority, attrs, dload); if(!dp) { goto error;

1 0

[kamailio/kamailio] The <bymonth> logic in tmrec_match() is flawed (Issue #4214)
by intliang 29 Apr '25

29 Apr '25

intliang created an issue (kamailio/kamailio#4214) ### Description The **<bymonth>** comparison logic in **tmrec_match()** fails to properly evaluate equivalence conditions, as shown below: ``` int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) { ... if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) % 12) break; } ... ``` ### Troubleshooting #### Reproduction Rule string: "20250403T100000|PT14H|weekly|20250425T000000|2|-1WE, -2WE|16|||4" Date time: 20250416T190000 Expected output: MATCH Actual output: NOT MATCH  #### Debugging Data  ``` ((lldb) p _trp->bymonth->xxx[0] (int) 4 (lldb) p _trp->bymonth->req[0] (int) 1 (lldb) p _atp->t.tm_mon (int) 3 (lldb) p _trp->bymonth->nr (int) 1 ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions The **tm_mon** field in the tm struct uses a 0-11 range (January=0), while the **<bymonth>** parameter follows a 1-12 convention (January=1) as documented in the tmrec module's README. Therefore, we should first decrement the value of **_trp->bymonth->xxx[i]** by 1 for proper conversion. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.1.0-dev0 (x86_64/Darwin) 9f24f1-dirty flags: , EXTRA_DEBUGUSE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: 9f24f1 dirty compiled on 11:59:55 Apr 16 2025 with AppleClang 17.0.0.17000013 ``` * **Operating System**: ``` Darwin yintiliangdeMacBook-Pro19.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 18:41:43 PST 2024; root:xnu-11215.61.5~2/RELEASE_X86_64 x86_64 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4214 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4214(a)github.com>

2 2

git:master:8f1a8c50: core: utils/tmrec - decrement month for bymonth matching
by Daniel-Constantin Mierla 29 Apr '25

29 Apr '25

Module: kamailio Branch: master Commit: 8f1a8c50ff230a1fffdd6b376f172cabe9fe60e3 URL: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-04-29T09:23:07+02:00 core: utils/tmrec - decrement month for bymonth matching - struct tm uses 0-11, comparing with 1-12 in the date format - GH #4214 --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… Patch: https://github.com/kamailio/kamailio/commit/8f1a8c50ff230a1fffdd6b376f172ca… --- diff --git a/src/core/utils/tmrec.c b/src/core/utils/tmrec.c index 7cbe6153824..d609e136310 100644 --- a/src/core/utils/tmrec.c +++ b/src/core/utils/tmrec.c @@ -1118,7 +1118,8 @@ int check_byxxx(tmrec_t *_trp, ac_tm_t *_atp) if(_trp->bymonth) { for(i = 0; i < _trp->bymonth->nr; i++) { if(_atp->t.tm_mon - == (_trp->bymonth->xxx[i] * _trp->bymonth->req[i] + 12) + == ((_trp->bymonth->xxx[i] - 1) * _trp->bymonth->req[i] + + 12) % 12) break; }

1 0

[kamailio/kamailio] Improve and document cdp module list_peers output (Issue #4226)
by Henning Westerholt 29 Apr '25

29 Apr '25

henningw created an issue (kamailio/kamailio#4226) Improve and document cdp module list_peers output Example output: reg03:~$ sudo kamcmd cdp.list_peers { Realm: YYY.com Identity: 212.XX.XX.3 Accept unknown peers: 0 Connect timeout: 5 Transaction timeout: 5 Default auth session timeout: 3600 Queue length: 32 Workers: 8 Peer count: 3 Peers: { FQDN: 212.XX.XX.1 Details: { State: R_Open Disabled: False Last used: 1745907094 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.2 Details: { State: R_Open Disabled: False Last used: -1406883582 Applications: { appid:vendorid: 4:10415 } } FQDN: 212.XX.XX.3 Details: { State: R_Open Disabled: False Last used: 1745907095 Applications: { appid:vendorid: 4:10415 } } } } 1. Add list_peers command to module XML docs 2. Document State meaning (e.g. what means R_Open etc..) 3. Check/ probably cast time_t value to not output negative numbers -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4226 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4226(a)github.com>

1 0

[kamailio/kamailio] rtpengine: select node with weight=0 if no other nodes online (Issue #4180)
by sergey-safarov 29 Apr '25

29 Apr '25

sergey-safarov created an issue (kamailio/kamailio#4180) ### Description I have installed two `rtpengine` instances and want to use them as an `active backup`. I want to use `backup` only when `active` is unavailable. Closest settings for this rtpengine node `weight` and want to use settings like ``` MariaDB [kamailio]> select * from rtpengine; +----+-------+---------------------------------+--------+----------+---------------------+ | id | setid | url | weight | disabled | stamp | +----+-------+---------------------------------+--------+----------+---------------------+ | 1 | 0 | udp6:[2005:84c0:bf:11::20]:2223 | 1 | 0 | 1900-01-01 00:00:01 | | 2 | 0 | udp6:[2005:84c0:bf:11::21]:2223 | 0 | 0 | 1900-01-01 00:00:01 | +----+-------+---------------------------------+--------+----------+---------------------+ ``` But in case `weight=0` node is not selected and handled as disabled. It will be fine do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. ### Expected behavior Do not use rtpengine nodes with `weight=0` when other rtpengine with `weight!=0` are available. But if no other nodes are available, use `weight=0` nodes as last resort. #### Actual observed behavior The node is not selected and handled as disabled when `weight=0`. #### Log Messages ``` rtpengine [rtpengine.c:3430]: rtpp_test(): rtpengine instance <udp6:[2005:84c0:bf:11::21]:2223> found, support for it enabled rtpengine [rtpengine.c:3883]: select_rtpp_node(): rtpengine failed to select new for calllen=27 callid=1-10824@2005:84c0:bf:11::22 rtpengine [rtpengine.c:3183]: rtpp_function_call(): no available proxies ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4180 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4180(a)github.com>

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2025