sr-dev April 2025

sr-dev@lists.kamailio.org

14 participants
194 discussions

[kamailio/kamailio] siptrace: sip_trace_mode("d") not working (Issue #4178)
by c.long 27 Apr '25

27 Apr '25

longchun4835 created an issue (kamailio/kamailio#4178)  ### Description Using function sip_trace_mode() with parameter d to enable dialog tracing mode logs: ``` BUG: siptrace [siptrace.c:1671]: add_info_xavp(): URI should be in raw format here ERROR: siptrace [siptrace.c:888]: sip_trace_helper(): failed to serialize siptrace info! Won't trace dialog! ``` ### Troubleshooting #### Reproduction my module parameters: ``` #!ifdef WITH_HOMER loadmodule "siptrace.so" modparam("siptrace", "duplicate_uri", HOMER_URL) modparam("siptrace", "hep_mode_on", 1) modparam("siptrace", "trace_to_database", 0) modparam("siptrace", "trace_flag", 22) modparam("siptrace", "trace_on", 1) modparam("siptrace", "hep_version", 3) modparam("siptrace", "hep_capture_id", HOMER_HEP_ID) #!endif ... request_route { ... if (is_method("INVITE")) { sip_trace_mode("d"); } } ``` ### Possible Solutions I checked the source code and found that the issue occurs when sip_trace_helper() is called inside the ki_sip_trace_mode() function, with the third parameter (duri) set to NULL. I don’t quite understand the logic behind passing NULL does this mean that the 'D' parameter will never working when calling sip_trace_mode()? Additionally, I have another question: in the sip_trace_helper() function, why does it call trace_transaction() instead of trace_dialog() when strace_type == SIPTRACE_DIALOG? ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.6.4 (x86_64/linux) a004cf flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a004cf compiled on 09:14:30 Jan 23 2025 with gcc 8.3.1 ``` * **Operating System**: ``` NAME="CentOS Linux" VERSION="7 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:7" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4178 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4178(a)github.com>

3 2

[kamailio/kamailio] Handling Duplicate Values in secfilter Module's kamcmd Commands (Issue #4091)
by AsedMorteza 26 Apr '25

26 Apr '25

**Description** The `secfilter` module in `kamcmd` currently allows duplicate entries when adding values to certain lists (e.g., blacklists, whitelists). This can lead to unexpected behavior and potential inconsistencies. Could you clarify the reason behind accepting duplicate values? Recently, I submitted a pull request to add delete commands to the `secfilter` module #4089. When a user, for example, executes: `kamcmd secfilter.del_bl user 1005` I iterate through the entire list to ensure all occurrences of `1005` are removed, as I realized duplicates might exist. This is inefficient and could be avoided by preventing duplicates in the first place. **Proposed Solutions** 1. **Prevent Duplicates in Existing `add` Commands:** * I can modify existing `add` commands to directly prevent the addition of duplicate values. This would simplify future operations and improve performance. 2. **Introduce New `add_unique` Commands:** * I can maintain the current `add` commands for backward compatibility. * I can introduce new `add_unique` commands (e.g., `secfilter.add_bl_unique`) that explicitly reject duplicate entries. **Recommendation** I recommend implementing the first solution (preventing duplicates in existing `add` commands) as it provides the most straightforward and efficient approach. **Further Considerations** * Consider adding a check for duplicates during the `add` operation and returning an appropriate error message if a duplicate is encountered. * Document the behavior of duplicate values in the `secfilter` module's documentation. **I would appreciate your feedback and guidance on the best course of action.** -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4091 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4091(a)github.com>

6 9

[kamailio/kamailio] cmake: switching deb rules (Issue #4053)
by Victor Seva 26 Apr '25

26 Apr '25

Opening this generic issue to track issues when trying to switch deb package generation to cmake: -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4053 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4053(a)github.com>

5 54

[kamailio/kamailio] prefix_route - prefix longer than 12 characters ignored (Issue #4218)
by Barry Flanagan 25 Apr '25

25 Apr '25

flantel created an issue (kamailio/kamailio#4218) ### Description If I add a prefix of greater than 12 characters in to prefix_route it does not return the correct route but instead acts as if no record was found. ### Troubleshooting #### Reproduction Create a prefix_route prefix of more than 12 characters and the route will not be chosen. #### Debugging Data There is none. #### Log Messages prefix_route does not seem to produce DEBUG level messages. ### Additional Information ``` kamailio 5.8.6 (x86_64/linux) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4218 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4218(a)github.com>

2 2

[kamailio/kamailio] Pepelux/secfilter Allow single quotes in From name and To name in secf_check_sqli_all(); (PR #4224)
by Jose Luis Verdeguer 25 Apr '25

25 Apr '25

1 1

git:master:e02eb4b2: add secf_remove_rule in header file
by Jose Luis Verdeguer 25 Apr '25

25 Apr '25

Module: kamailio Branch: master Commit: e02eb4b2ce854fc0f64a887d15588630d67a663b URL: https://github.com/kamailio/kamailio/commit/e02eb4b2ce854fc0f64a887d1558863… Author: AsedMorteza <mortezatorabi001(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2025-04-25T17:05:48+02:00 add secf_remove_rule in header file --- Modified: src/modules/secfilter/secfilter.h --- Diff: https://github.com/kamailio/kamailio/commit/e02eb4b2ce854fc0f64a887d1558863… Patch: https://github.com/kamailio/kamailio/commit/e02eb4b2ce854fc0f64a887d1558863… --- diff --git a/src/modules/secfilter/secfilter.h b/src/modules/secfilter/secfilter.h index 92d96f5916e..8317fac5453 100644 --- a/src/modules/secfilter/secfilter.h +++ b/src/modules/secfilter/secfilter.h @@ -58,6 +58,7 @@ extern int *secf_stats; void secf_reset_stats(void); int secf_append_rule(int action, int type, str *value); +int secf_remove_rule(int action, int type, str *value); /* Get header values from message */ int secf_get_ua(struct sip_msg *msg, str *ua);

1 0

git:master:d2d90af5: Fixing problems
by Jose Luis Verdeguer 25 Apr '25

25 Apr '25

Module: kamailio Branch: master Commit: d2d90af5c7177bbfdcd10d39fa70d6ddd481d583 URL: https://github.com/kamailio/kamailio/commit/d2d90af5c7177bbfdcd10d39fa70d6d… Author: AsedMorteza <mortezatorabi001(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2025-04-25T17:05:48+02:00 Fixing problems --- Modified: src/modules/secfilter/secfilter_db.c --- Diff: https://github.com/kamailio/kamailio/commit/d2d90af5c7177bbfdcd10d39fa70d6d… Patch: https://github.com/kamailio/kamailio/commit/d2d90af5c7177bbfdcd10d39fa70d6d… --- diff --git a/src/modules/secfilter/secfilter_db.c b/src/modules/secfilter/secfilter_db.c index e4dfc4ad77c..1c0138b0193 100644 --- a/src/modules/secfilter/secfilter_db.c +++ b/src/modules/secfilter/secfilter_db.c @@ -284,7 +284,7 @@ int secf_remove_rule(int action, int type, str *value) LM_DBG("Total matches removed: %d", total); return 0; // Return the total number of removed items } else { - LM_DGB("No matching values found in the list."); + LM_DBG("No matching values found in the list."); return -1; // Return -1 on no matches } }

1 0

git:master:350c6dc9: secfilterâ: support remove rule in Whitelist and Blacklist
by Jose Luis Verdeguer 25 Apr '25

25 Apr '25

Module: kamailio Branch: master Commit: 350c6dc9ac559987d627935f43743b62f95bd350 URL: https://github.com/kamailio/kamailio/commit/350c6dc9ac559987d627935f43743b6… Author: AsedMorteza <mortezatorabi001(a)gmail.com> Committer: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Date: 2025-04-25T17:05:48+02:00 secfilterâ: support remove rule in Whitelist and Blacklist --- Modified: src/modules/secfilter/secfilter.c Modified: src/modules/secfilter/secfilter.h Modified: src/modules/secfilter/secfilter_db.c Modified: src/modules/secfilter/secfilter_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/350c6dc9ac559987d627935f43743b6… Patch: https://github.com/kamailio/kamailio/commit/350c6dc9ac559987d627935f43743b6…

1 0

[kamailio/kamailio] Kam fixes (PR #4219)
by Paul Donald 25 Apr '25

25 Apr '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description spelling/grammar two version number bumps for ctl tools. Should the commits be separated into different PRs? You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4219 -- Commit Summary -- * kamdbctl: version set to 6.0.0 * kamctl: version set to 6.0.0 * treewide: spelling/grammar fixes -- File Changes -- M doc/README.md (2) M doc/tutorials/ser_radius/ser_radius.xml (2) M pkg/kamailio/deb/bionic/kamailio.README.Debian (2) M pkg/kamailio/deb/bookworm/kamailio.README.Debian (2) M pkg/kamailio/deb/bullseye/kamailio.README.Debian (2) M pkg/kamailio/deb/buster/kamailio.README.Debian (2) M pkg/kamailio/deb/debian/kamailio.README.Debian (2) M pkg/kamailio/deb/focal/kamailio.README.Debian (2) M pkg/kamailio/deb/jammy/kamailio.README.Debian (2) M pkg/kamailio/deb/jessie/kamailio.README.Debian (2) M pkg/kamailio/deb/noble/kamailio.README.Debian (2) M pkg/kamailio/deb/precise/kamailio.README.Debian (2) M pkg/kamailio/deb/sid/kamailio.README.Debian (2) M pkg/kamailio/deb/stretch/kamailio.README.Debian (2) M pkg/kamailio/deb/trusty/kamailio.README.Debian (2) M pkg/kamailio/deb/wheezy/kamailio.README.Debian (2) M pkg/kamailio/deb/xenial/kamailio.README.Debian (2) M src/core/atomic/atomic_sparc.h (2) M src/core/atomic/atomic_sparc64.h (2) M src/core/atomic/atomic_x86.h (2) M src/core/cfg/cfg.h (2) M src/core/cfg/cfg_script.c (2) M src/core/cfg/cfg_script.h (2) M src/core/cfg/cfg_select.c (2) M src/core/cfg/cfg_struct.c (6) M src/core/cfg/cfg_struct.h (16) M src/core/parser/hf.c (2) M src/core/parser/hf.h (2) M src/core/sr_module.h (6) M src/core/udp_server.c (2) M src/lib/srdb1/db_query.h (20) M src/lib/trie/dtrie.c (2) M src/lib/trie/dtrie.h (2) M src/modules/app_java/README-draft (4) M src/modules/app_java/kamailio_java_folder/java-untested/siprouter_src/NativeInterface.java (4) M src/modules/app_java/kamailio_java_folder/java/siprouter_src/NativeInterface.java (4) M src/modules/app_jsdt/duktape.c (26) M src/modules/avpops/doc/avpops_admin.xml (2) M src/modules/call_control/doc/call_control_admin.xml (2) M src/modules/carrierroute/doc/carrierroute_admin.xml (2) M src/modules/cplc/doc/cplc_admin.xml (2) M src/modules/db_berkeley/doc/db_berkeley_admin.xml (4) M src/modules/db_berkeley/km_doc/db_berkeley_admin.xml (4) M src/modules/db_postgres/km_res.c (2) M src/modules/http_async_client/http_multi.c (2) M src/modules/imc/doc/imc_admin.xml (2) M src/modules/ims_charging/doc/ims_charging_admin.xml (2) M src/modules/ims_qos/doc/ims_qos_admin.xml (2) M src/modules/ims_registrar_pcscf/doc/ims_registrar_pcscf_admin.xml (2) M src/modules/ims_usrloc_pcscf/pcontact.c (2) M src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c (2) M src/modules/ims_usrloc_scscf/ucontact.c (2) M src/modules/janssonrpcc/janssonrpc_connect.c (2) M src/modules/janssonrpcc/janssonrpcc_mod.c (2) M src/modules/keepalive/doc/keepalive_devel.xml (2) M src/modules/matrix/doc/matrix_admin.xml (2) M src/modules/memcached/doc/memcached_admin.xml (2) M src/modules/mohqueue/mohq_db.c (6) M src/modules/nsq/nsq_mod.c (2) M src/modules/p_usrloc/doc/p_usrloc_admin.xml (4) M src/modules/p_usrloc/doc/p_usrloc_devel.xml (2) M src/modules/presence/presentity.c (4) M src/modules/qos/qos.c (2) M src/modules/qos/qos_handlers.c (4) M src/modules/rabbitmq/doc/rabbitmq_admin.xml (2) M src/modules/rr/doc/rr_admin.xml (2) M src/modules/rtpengine/doc/rtpengine_admin.xml (2) M src/modules/secfilter/doc/secfilter_admin.xml (2) M src/modules/sipcapture/doc/sipcapture_admin.xml (2) M src/modules/siptrace/doc/siptrace_admin.xml (2) M src/modules/sms/libsms_modem.c (2) M src/modules/snmpstats/snmpstats.c (4) M src/modules/snmpstats/sub_agent.c (2) M src/modules/sst/sst.c (2) M src/modules/sst/sst_handlers.c (22) M src/modules/tm/doc/tm.xml (4) M src/modules/userblocklist/doc/userblocklist_admin.xml (6) M src/modules/xmpp/xode.c (2) M test/unit/1.sh (2) M test/unit/10.sh (2) M test/unit/13.sh (2) M test/unit/17.sh (2) M test/unit/18.sh (2) M test/unit/23.sh (6) M test/unit/24.sh (2) M test/unit/25.sh (2) M test/unit/26.sh (4) M test/unit/3.sh (4) M test/unit/30.sh (2) M test/unit/31.sh (2) M test/unit/32.sh (2) M test/unit/37.sh (6) M test/unit/39.sh (4) M test/unit/4.sh (2) M test/unit/42.sh (6) M test/unit/43.sh (2) M test/unit/8.sh (4) M test/unit/9.sh (4) M utils/kamctl/CMakeLists.txt (2) M utils/kamctl/kamctl (2) M utils/kamctl/kamctlrc (2) M utils/kamctl/kamdbctl (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4219.patch https://github.com/kamailio/kamailio/pull/4219.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4219 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4219(a)github.com>

2 3

[kamailio/kamailio] dispatcher: OPTIONS check does not triggered after new target added (Issue #4212)
by sergey-safarov 25 Apr '25

25 Apr '25

sergey-safarov created an issue (kamailio/kamailio#4212) ### Description When I add a new dispatcher target using the kamcmd command, then kamailio does not start send OPTIONS. #### Reproduction Need to start Kamailio with config file ``` listen=eth0 loadmodule "xlog.so" loadmodule "pv.so" loadmodule "ctl.so" loadmodule "jsonrpcs.so" loadmodule "dispatcher.so" modparam("dispatcher", "list_file", "/dev/null") route{ xerr("TEST $ci\n"); drop; } ``` And then execute comands ``` kamcmd dispatcher.add 1 "sip:sip.telnyx.com:5060;transport=tcp" 8 kamcmd dispatcher.list ``` After the last command expected output ``` { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:sip.telnyx.com:5060;transport=tcp FLAGS: AP PRIORITY: 0 } } } } } ``` As you can see, the target has `AP` flags, which means the target is active and probing enabled. But no OPTIONS messages were sent. #### Log Messages Here is kamailio debug output for during kamcmd execitions and some time after ``` 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 68 12(94363) DEBUG: <core> [core/dns_cache.c:533]: _dns_hash_find(): (sip.telnyx.com(14), 1), h=507 12(94363) DEBUG: <core> [core/resolve.c:1021]: get_record(): skipping 0 NS (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/resolve.c:1035]: get_record(): parsing 0 ARs (p=0x9c6ad0, end=0x9c6ad0) 12(94363) DEBUG: <core> [core/dns_cache.c:1699]: dns_get_related(): (0x7fce63a32000 (sip.telnyx.com, 1), 1, *(nil)) (0) 12(94363) DEBUG: <core> [core/dns_cache.c:1702]: dns_get_related(): record not alone: 0x7fce63a32000 - type: 1 12(94363) DEBUG: <core> [core/dns_cache.c:748]: dns_cache_add_unsafe(): adding sip.telnyx.com(14) 1 (flags=0) at 507 12(94363) DEBUG: dispatcher [dispatch.c:768]: add_dest2list(): dest [1/1] <sip:sip.telnyx.com:5060;transport=tcp> 12(94363) DEBUG: dispatcher [dispatch.c:258]: ds_log_dst_cb(): dst>> 1 sip:sip.telnyx.com:5060;transport=tcp 8 0 (,0,0,0) 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 68 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called 12(94363) DEBUG: ctl [../../core/io_wait.h:368]: io_watch_add(): processing io_watch_add(0x7fce67ac03a0, 10, 3, 0x21186bf0) - fd_no=1 12(94363) DEBUG: ctl [io_listener.c:440]: handle_new_connect(): new connection (1) on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [io_listener.c:501]: handle_stream_read(): bytes read: 25 12(94363) DEBUG: ctl [io_listener.c:522]: handle_stream_read(): bytes processed: 25 12(94363) DEBUG: ctl [io_listener.c:498]: handle_stream_read(): handle_stream read: eof on /var/run/kamailio//kamailio_ctl 12(94363) DEBUG: ctl [../../core/io_wait.h:599]: io_watch_del(): DBG: io_watch_del (0x7fce67ac03a0, 10, -1, 0x10) fd_no=2 called ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 6.0.1 (x86_64/linux) fce50d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: fce50d compiled on 00:00:00 Sep 13 2022 with gcc 14.2.1 ``` * **Operating System**:  ``` root@nout:~# cat /etc/os-release NAME="Fedora Linux" VERSION="41 (Workstation Edition)" RELEASE_TYPE=stable ID=fedora VERSION_ID=41 VERSION_CODENAME="" PLATFORM_ID="platform:f41" PRETTY_NAME="Fedora Linux 41 (Workstation Edition)" ANSI_COLOR="0;38;2;60;110;180" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fedora:41" DEFAULT_HOSTNAME="fedora" HOME_URL="https://fedoraproject.org/" DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/f41/system-administrators-guide/" SUPPORT_URL="https://ask.fedoraproject.org/" BUG_REPORT_URL="https://bugzilla.redhat.com/" REDHAT_BUGZILLA_PRODUCT="Fedora" REDHAT_BUGZILLA_PRODUCT_VERSION=41 REDHAT_SUPPORT_PRODUCT="Fedora" REDHAT_SUPPORT_PRODUCT_VERSION=41 SUPPORT_END=2025-12-15 VARIANT="Workstation Edition" VARIANT_ID=workstation ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4212 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4212(a)github.com>

3 6

← Newer
1
2
3
4
5
6
7
8
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2025