sr-dev

sr-dev@lists.kamailio.org

4 participants
45456 discussions

git:6.0:cf14f324: websocket: updated a couple of debug messages with id and hash id
by Daniel-Constantin Mierla 24 Jun '25

24 Jun '25

Module: kamailio Branch: 6.0 Commit: cf14f3244567658bee3f226834baea424dceff32 URL: https://github.com/kamailio/kamailio/commit/cf14f3244567658bee3f226834baea4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-24T18:53:55+02:00 websocket: updated a couple of debug messages with id and hash id (cherry picked from commit 868240b75b9bc6a2263a31a46038d11064269000) --- Modified: src/modules/websocket/ws_conn.c --- Diff: https://github.com/kamailio/kamailio/commit/cf14f3244567658bee3f226834baea4… Patch: https://github.com/kamailio/kamailio/commit/cf14f3244567658bee3f226834baea4… --- diff --git a/src/modules/websocket/ws_conn.c b/src/modules/websocket/ws_conn.c index b41cb2e91d9..18e0e4667bd 100644 --- a/src/modules/websocket/ws_conn.c +++ b/src/modules/websocket/ws_conn.c @@ -328,7 +328,8 @@ static void wsconn_dtor(ws_connection_t *wsc) if(!wsc) return; - LM_DBG("wsconn_dtor for [%p] refcnt [%d]\n", wsc, atomic_get(&wsc->refcnt)); + LM_DBG("wsconn id: %d / %u [%p] refcnt [%d]\n", wsc->id, wsc->id_hash, wsc, + atomic_get(&wsc->refcnt)); if(wsc->run_event) wsconn_run_route(wsc); @@ -337,12 +338,13 @@ static void wsconn_dtor(ws_connection_t *wsc) shm_free(wsc); - LM_DBG("wsconn_dtor for [%p] destroyed\n", wsc); + LM_DBG("wsconn id: %d / %u [%p] destroyed\n", wsc->id, wsc->id_hash, wsc); } int wsconn_rm(ws_connection_t *wsc, ws_conn_eventroute_t run_event_route) { - LM_DBG("wsconn_rm for [%p] refcnt [%d]\n", wsc, atomic_get(&wsc->refcnt)); + LM_DBG("remove wscon id: %d / %u [%p] refcnt [%d]\n", wsc->id, wsc->id_hash, + wsc, atomic_get(&wsc->refcnt)); if(run_event_route == WSCONN_EVENTROUTE_YES) wsc->run_event = 1;

1 0

[kamailio/kamailio] If fix_nated_contact is used, then remove_hf("Contact"), the contact header will not be deleted cleanly. (Issue #4190)
by QuincyGao 24 Jun '25

24 Jun '25

QuincyGao created an issue (kamailio/kamailio#4190)  ### Description  I want to use opensips as SBC, When the agent registers to kamailio, the contact content is modified to the ip and port of kamailio, and then Register is forwarded to the agent. remove_hf("Contact") can't remove the whole Contact( field, vlue). here is my config: ``` route[REGISTRAR] { if (!is_method("REGISTER")) return; if(isflagset(FLT_NATS)) { setbflag(FLB_NATB); #!ifdef WITH_NATSIPPING # do SIP NAT pinging setbflag(FLB_NATSIPPING); #!endif } fix_nated_contact(); if (!save("location","0x02")) { #if (!save("location")) { sl_reply_error(); } $fs="udp:172.16.4.111:5461"; $du="sip:172.16.4.114:5060"; remove_hf("Contact"); $var(contact) = "Contact: <sip:" +$fU+"@"+"172.16.4.111:5461>;expires=120\r\n" ; append_hf("$var(contact)"); route(RELAY); exit; } ``` here is the sip message: ``` 2025/03/26 16:36:07.706093 172.16.4.111:5461 -> 172.16.4.114:5060 REGISTER sip:172.16.4.111:5460 SIP/2.0 Via: SIP/2.0/UDP 172.16.4.111:5461;branch=z9hG4bKfc7e.d2df36f3b5681afeb71e442e645de38d.0 Via: SIP/2.0/UDP 172.16.80.3:49309;received=172.16.80.3;rport=49309;branch=z9hG4bKPj8ab8bd1d3c3a4c1bb0cd639540fa3183 Max-Forwards: 69 From: <sip:1008@172.16.4.111>;tag=95f7f5601f8b40458a1efe6923ab0a29 To: <sip:1008@172.16.4.111> Call-ID: f84b643f5d284d18a0d8175e1ef4d747 CSeq: 33264 REGISTER User-Agent: MicroSIP/3.21.6 sip:1008@172.16.80.3:49309;obExpires: 120 Allow: PRACK, INVITE, ACK, BYE, CANCEL, UPDATE, INFO, SUBSCRIBE, NOTIFY, REFER, MESSAGE, OPTIONS Content-Length: 0 Contact: <sip:1008@172.16.4.111:5461>;expires=120 ``` you can see the problem is that: `sip:1008@172.16.80.3:49309;obExpires: 120` , `sip:1008@172.16.80.3:49309` is the value of the Contact field after fix_nated_contact(). ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.8.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, MEM_JOIN_FREE, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_SEND_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: compiled on 11:27:01 Mar 21 2025 with gcc 4.8.5 ``` * **Operating System**:  ``` Centos7.9 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4190 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4190(a)github.com>

2 4

[kamailio/kamailio] Dispatcher sets IP flag on servers even though SIP OPTIONS receive 200 OK (Issue #4298)
by al286320 24 Jun '25

24 Jun '25

al286320 created an issue (kamailio/kamailio#4298) Hi all, I'm new to Kamailio, and maybe this is a silly question. I’ve set up Kamailio as a SIP proxy with two Asterisk servers acting as media services. This is my configuration for the dispatcher module: ``` loadmodule "dispatcher.so" modparam("dispatcher", "db_url", DBURL) modparam("dispatcher", "table_name", "dispatcher") modparam("dispatcher", "flags", 2) modparam("dispatcher", "ds_ping_interval", 20) modparam("dispatcher", "ds_ping_method", "OPTIONS") modparam("dispatcher", "ds_probing_threshold", 5) modparam("dispatcher", "ds_inactive_threshold", 5) modparam("dispatcher", "ds_ping_latency_stats", 1) modparam("dispatcher", "ds_probing_mode", 1) modparam("dispatcher", "ds_ping_reply_codes", "class=2;code=403;code=488;class=3") modparam("dispatcher", "ds_ping_from", SIPCALL) ``` I can see the SIP OPTIONS requests going from Kamailio to Asterisk and receiving 200 OK responses. ![Image](https://github.com/user-attachments/assets/d7350e89-c2f8-42cb-b8a8-e456d396ab3a) However, the dispatcher is still setting the IP (Inactive Probing) flag on the servers: ``` kamcmd dispatcher.list { NRSETS: 1 RECORDS: { SET: { ID: 1 TARGETS: { DEST: { URI: sip:172.16.254.21:5060 FLAGS: IP PRIORITY: 0 LATENCY: { AVG: 0 STD: 0 EST: 0 MAX: 0 TIMEOUT: 183 } } DEST: { URI: sip:172.16.254.20:5060 FLAGS: IP PRIORITY: 0 LATENCY: { AVG: 0 STD: 0 EST: 0 MAX: 0 TIMEOUT: 183 } } } } } } ``` So when I try to use `ds_select_dst("1", "4")`, it always fails. Did I miss something in my configuration? Thanks! -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4298 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4298(a)github.com>

2 2

git:master:15a97680: secsipid: set global url pointer to null after free
by Daniel-Constantin Mierla 24 Jun '25

24 Jun '25

Module: kamailio Branch: master Commit: 15a976808f5e785a6d234734b0a7de0d735d4a5a URL: https://github.com/kamailio/kamailio/commit/15a976808f5e785a6d234734b0a7de0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-24T15:11:18+02:00 secsipid: set global url pointer to null after free - GH #4284 --- Modified: src/modules/secsipid/secsipid_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/15a976808f5e785a6d234734b0a7de0… Patch: https://github.com/kamailio/kamailio/commit/15a976808f5e785a6d234734b0a7de0… --- diff --git a/src/modules/secsipid/secsipid_mod.c b/src/modules/secsipid/secsipid_mod.c index ebe2e2e50ef..eecf18c77bd 100644 --- a/src/modules/secsipid/secsipid_mod.c +++ b/src/modules/secsipid/secsipid_mod.c @@ -916,6 +916,7 @@ static sr_kemi_xval_t *ki_secsipid_get_url(sip_msg_t *msg, str *surl) if(_secsipid_get_url_val.s != NULL) { free(_secsipid_get_url_val.s); + _secsipid_get_url_val.s = NULL; _secsipid_get_url_val.len = 0; } @@ -959,6 +960,7 @@ static int w_secsipid_get_url(sip_msg_t *msg, char *purl, char *povar) } if(_secsipid_get_url_val.s != NULL) { free(_secsipid_get_url_val.s); + _secsipid_get_url_val.s = NULL; _secsipid_get_url_val.len = 0; }

1 0

[kamailio/kamailio] Issue #3165 was closed by mistake (Issue #4294)
by dennis 24 Jun '25

24 Jun '25

kerozin created an issue (kamailio/kamailio#4294) Kamailio 5.7.4 When I write A new value to $fU pseudovariable it acttually appends, but not replace. A from header before manipulation: <sip:3451088@192.168.107.17> In failure route I do $fU = "77719365301"; The header after manipulation looks as: <sip:345108877719365301@192.168.107.17> this behavior was reported in #3165 but closed. I believe this was happen by mistake. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4294 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4294(a)github.com>

2 3

[kamailio/kamailio] Writing to $fU or $tU appends to header user (Issue #3165)
by Benoît Panizzon 24 Jun '25

24 Jun '25

Dear Gang Possibly @oej could provide more in-depth information as he has witnessed this issue. Usually the user of the from URI is the phone number displayed at the destination. There are situations where this phone number is translated. As example. In Switzerland, the user is used to see numbers in a local format. National number starting with 0 and international numbers with 00 but on interconnection between telcos, e164 is used. So basically when a call is sent to a customer '+41' is replaced by '0' and '+' is replaced by '00'. Let's start with an example From: header: `From: "Maurice Moss" <sip:+41991234567@example.com>;user=phone` So shortly before the call is sent out to the location of the registered CPE, this is done: ``` if ($fU =~ "^\+41") { $fU = "0" + $(fU{s.substr,3,0}); } else if ($fU = ~ "^\+") { $fU = "00" + $(fU{s.substr,1,0}); } ``` What is sent to the CPE now looks like this: `From: "Maurice Moss" <sip:0991234567@example.com>;user=phone` Now we hit an error like 486 BUSY and the destination has call forwarding active to a mobile phone on another TSP. So we have to send the call out back the IC and numbers need to be translated back to e164. We handle this in a failure route, which in turn could trigger a branch route. So we revert the number back to e164: `$fU = "+41" + $(fU{s.substr,1,0});` Expected outcome: `From: "Maurice Moss" <sip:+41991234567@example.com>;user=phone` Observed outcome: `From: "Maurice Moss" <sip:0991234567+41991234567@example.com>;user=phone` So setting $fU more than once is appending to the user element of the From header URI. This behavior has not been found in any documentation. I have been working around most of the issues by making sure I change $fU (and $tU) at the latest possible time and only once. But in the case described above, I have not been able to come up with a work-around yet. I also can't think of any benefit of the way those PV are handled or any harm that could be done, to handle them differently and make the last 'write' overwrite and previous value, instead of appending. Thank you for looking into this. -Benoît- -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3165 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3165(a)github.com>

3 4

git:master:a70a55df: dispatcher: set state from config without depending on keepalive thresholds
by Daniel-Constantin Mierla 24 Jun '25

24 Jun '25

Module: kamailio Branch: master Commit: a70a55df0dbe5fc9231329327e3d6acf6a37c5c4 URL: https://github.com/kamailio/kamailio/commit/a70a55df0dbe5fc9231329327e3d6ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-24T13:30:13+02:00 dispatcher: set state from config without depending on keepalive thresholds --- Modified: src/modules/dispatcher/dispatch.c Modified: src/modules/dispatcher/dispatch.h Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/a70a55df0dbe5fc9231329327e3d6ac… Patch: https://github.com/kamailio/kamailio/commit/a70a55df0dbe5fc9231329327e3d6ac…

1 0

[kamailio/kamailio] For network initiated ue de-registration, ims_registrar_scscf is populating Subscription-State header of NOTIFY message as active;expires=3581 instead of terminated;reason=deactivated (Issue #4296)
by Rik Biswas 24 Jun '25

24 Jun '25

therikb31 created an issue (kamailio/kamailio#4296) For network-initiated UE de-registration, `ims_registrar_scscf` is populating the `Subscription-State` header of the `NOTIFY` message as `active;expires=3581` instead of `terminated`. ### Description We are simulating a network-initiated UE de-registration by sending a **Registration-Termination Request** from the HSS to the S-CSCF for a registered IMSI. **Call Flow**: 1. UE registers to the IMS core 2. S-CSCF performs third-party registration with the Application Server on behalf of the UE 3. Application Server subscribes to `Event: reg` for the registered IMSI 4. HSS sends a Registration-Termination Request for network-initiated UE de-registration 5. S-CSCF sends a `NOTIFY` to subscribers for the `IMS_REGISTRAR_CONTACT_DEREGISTERED` event (issue with the `NOTIFY` SIP message) **Observation**: 1. `NOTIFY` messages are initiated to subscribers of `Event: reg`, but instead of having the `Subscription-State` header set to **terminated**, we observe the value **active;expires=3581**. (Image for the `NOTIFY` SIP message packet is attached below) ![Image](https://github.com/user-attachments/assets/08abc9a8-43b9-486c-9de5-370e465ea527) ### Troubleshooting #### Reproduction To reproduce this, we are performing the following steps: 1. Performing SIP registration of the UE with the target S-CSCF node 2. Sending `SUBSCRIBE` requests from a third-party Application Server and the UE with `Event: reg` to get notified of registration events 3. HSS sends a `Registration-Termination Request` to the target S-CSCF for the registered IMSI (network-initiated de-registration) #### Debugging Data #### Log Messages While going through the logs, we find that this header is being populated based on the expiry timer and a comparison with the current timestamp: ``` 2025-06-20 12:45:20 | 19(56) DEBUG: ims_registrar_scscf [registrar_notify.c:1716]: create_notifications(): Expires is greater than current time! Subscription state: [active;expires=3581] ``` #### SIP Traffic ### Possible Solutions **Workaround**: In the `create_notifications()` method of `src/modules/ims_registrar_scscf/registrar_notify.c`, when populating the `Subscription-State` header, if the `event_type` is `10` (`IMS_REGISTRAR_CONTACT_DEREGISTERED`), we can populate `Subscription-State` as `terminated`. ### Additional Information --- -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4296 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4296(a)github.com>

1 0

git:master:a878e7f2: dispatcher: use rewrite/reset uri for event route with faked msg
by Daniel-Constantin Mierla 24 Jun '25

24 Jun '25

Module: kamailio Branch: master Commit: a878e7f2ec015015f53b1ad152554a81c9422674 URL: https://github.com/kamailio/kamailio/commit/a878e7f2ec015015f53b1ad152554a8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-24T12:20:20+02:00 dispatcher: use rewrite/reset uri for event route with faked msg --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/a878e7f2ec015015f53b1ad152554a8… Patch: https://github.com/kamailio/kamailio/commit/a878e7f2ec015015f53b1ad152554a8… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index bdcf4a6fd98..9af886d6cad 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -3513,8 +3513,7 @@ static void ds_run_route(sip_msg_t *msg, str *uri, char *route, ds_rctx_t *rctx) return; } fmsg = faked_msg_next(); - fmsg->parsed_orig_ruri_ok = 0; - fmsg->new_uri = *uri; + rewrite_uri(fmsg, uri); } else { fmsg = msg; } @@ -3540,6 +3539,9 @@ static void ds_run_route(sip_msg_t *msg, str *uri, char *route, ds_rctx_t *rctx) set_route_type(backup_rt); _ds_rctx = NULL; } + if(fmsg != msg) { + reset_uri(fmsg); + } }

1 0

git:master:e01f50fa: core: dset - wrapper function to reset request uri
by Daniel-Constantin Mierla 24 Jun '25

24 Jun '25

Module: kamailio Branch: master Commit: e01f50fa3de5b0eb24ba0852917d682fe1d83ea1 URL: https://github.com/kamailio/kamailio/commit/e01f50fa3de5b0eb24ba0852917d682… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-06-24T12:15:37+02:00 core: dset - wrapper function to reset request uri --- Modified: src/core/dset.c Modified: src/core/dset.h --- Diff: https://github.com/kamailio/kamailio/commit/e01f50fa3de5b0eb24ba0852917d682… Patch: https://github.com/kamailio/kamailio/commit/e01f50fa3de5b0eb24ba0852917d682… --- diff --git a/src/core/dset.c b/src/core/dset.c index d449f33e325..29a376e99a0 100644 --- a/src/core/dset.c +++ b/src/core/dset.c @@ -813,6 +813,22 @@ int rewrite_uri(struct sip_msg *_m, str *_s) return 1; } +/* + * Reset Request-URI + */ +void reset_uri(sip_msg_t *msg) +{ + if(msg->new_uri.s == NULL) { + return; + } + pkg_free(msg->new_uri.s); + msg->new_uri.len = 0; + msg->new_uri.s = 0; + msg->parsed_uri_ok = 0; + ruri_mark_new(); + return; +} + /** * return src ip, port and proto as a SIP uri or proxy address * - value stored in a static buffer diff --git a/src/core/dset.h b/src/core/dset.h index a46639a1adb..f8fd86c17f7 100644 --- a/src/core/dset.h +++ b/src/core/dset.h @@ -233,6 +233,8 @@ inline static int get_request_uri(struct sip_msg *_m, str *_u) int rewrite_uri(struct sip_msg *_m, str *_s); +void reset_uri(sip_msg_t *msg); + /*! \brief * Set a per-branch flag to 1. *

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev