sr-dev

sr-dev@lists.kamailio.org

13 participants
44935 discussions

git:master: uac(k): set type for tm callback
by Daniel-Constantin Mierla 24 Jan '10

24 Jan '10

Module: sip-router Branch: master Commit: 3476f0ca4d1431eeee2244383b568a10409367bf URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3476f0c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Sun Jan 24 19:43:09 2010 +0100 uac(k): set type for tm callback - requires to be TMCB_LOCAL_COMPLETED --- modules_k/uac/uac_send.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/modules_k/uac/uac_send.c b/modules_k/uac/uac_send.c index 6e26b4d..9a1f2b9 100644 --- a/modules_k/uac/uac_send.c +++ b/modules_k/uac/uac_send.c @@ -383,10 +383,14 @@ int uac_req_send(struct sip_msg *msg, char *s1, char *s2) uac_r.method = &_uac_req.s_method; uac_r.headers = (_uac_req.s_hdrs.len <= 0) ? NULL : &_uac_req.s_hdrs; uac_r.body = (_uac_req.s_body.len <= 0) ? NULL : &_uac_req.s_body; - uac_r.cb = (_uac_req.onreply > 0) ? uac_send_tm_callback : NULL; - /* Callback function */ - uac_r.cbp = (_uac_req.onreply > 0) ? (void*)(long)_uac_req.onreply : 0; - /* Callback parameter */ + if(_uac_req.onreply > 0) + { + uac_r.cb_flags = TMCB_LOCAL_COMPLETED; + /* Callback function */ + uac_r.cb = uac_send_tm_callback; + /* Callback parameter */ + uac_r.cbp = (void*)(long)_uac_req.onreply; + } ret = tmb.t_request(&uac_r, /* UAC Req */ &_uac_req.s_ruri, /* Request-URI */ (_uac_req.s_turi.len<=0)?&_uac_req.s_ruri:&_uac_req.s_turi, /* To */

1 0

[Fwd: Re: AW: AW: AW: AW: [SR-Users] TLS problems]
by Klaus Darilion 22 Jan '10

22 Jan '10

(forgotten to cc the list) Andreas Rehbein schrieb: > Hi Klaus, > > until now (OpenSER 1.3.x without client verification) it was not necessary > to import certs into snom. > To force the snom to send Messages via tls, you need to insert something > like "192.168.0.89:5061;transport=tls" in the outbound proxy field (but I'm > sure you already knew) Looks like SNOMs TLS implementation is a piece of crap. If the server uses a TLS certificate with depth 1 (CA->server-cert), then the SNOM phone accepts the certificate and handshake succeeds. If the certificate has depth 2 (CA->subCA->server-cert), then the SNOM phone raises an error during handshake. And strangely, the "trusted certificates" are not used at all for validation. Thus, SNOM uses the TLS connection solely for encryption, not for server authentication. regards klaus > > regards > Andreas > > > -----Ursprüngliche Nachricht----- > Von: Klaus Darilion [mailto:klaus.mailinglists@pernau.at] > Gesendet: Freitag, 22. Januar 2010 13:17 > An: Andreas Rehbein > Cc: sr-users(a)lists.sip-router.org > Betreff: Re: AW: AW: AW: [SR-Users] TLS problems > > > > Andreas Rehbein schrieb: >> Hello Klaus, >> >> Linux: Red Hat Enterprise Linux 5; Kernel: 2.6.18-92.1.10.el5 >> OpenSSL: OpenSSL 0.9.8e-fips-rhel5 01 Jul 2008 > > Hi Andreas! > > I fail to configure SNOM to accept the certificate. I imported the CA > cert as trusted certificates, but TLS handshake is not successful. Is > there something else I need to take care of? > > I'm quite sure my certificates are OK as it works with eyebeam and QjSimple. > > regards > Klaus >

1 0

git:master: modules_k/ratelimit Using ser' s cfg framework for modifying module parameters at runtime( reply_code and reply_reason).
by Marius Zbihlei 22 Jan '10

22 Jan '10

Module: sip-router Branch: master Commit: 81ee9cdfdd2d276f9b90490deb799b74ffff2038 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=81ee9cd… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Fri Jan 22 12:23:33 2010 +0200 modules_k/ratelimit Using ser's cfg framework for modifying module parameters at runtime(reply_code and reply_reason). The patch allow reply_code and reply_reason to be modified using sercmd (modules/ctl/ctl.so and modules/cfg_rpc/cfg_rpc.so must be loaded).Check module documentation for example. Also it is interesting if we can modify at runtime other parameters of the module, like queue and pipe --- modules_k/ratelimit/README | 52 ++++++++++++++++---------- modules_k/ratelimit/config.c | 52 +++++++++++++++++++++++++++ modules_k/ratelimit/config.h | 41 +++++++++++++++++++++ modules_k/ratelimit/doc/ratelimit_admin.xml | 24 ++++++++++++- modules_k/ratelimit/ratelimit.c | 35 +++++++++++++----- 5 files changed, 173 insertions(+), 31 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=81e…

1 0

Doesn't SIREMIS create the MD5 hash by itself?
by Iñaki Baz Castillo 21 Jan '10

21 Jan '10

Hi, trying to create a new subscriber I've realized that I must insert the ha1 (ha1b doesn't appear) by hand... doesn't SIREMIS implement the generation of the MD5 values by inserting the text plain password? Regards. -- Iñaki Baz Castillo <ibc(a)aliax.net>

3 3

[tracker] Task closed: ldapsearch with empty filter
by sip-router 21 Jan '10

21 Jan '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task is now closed: FS#23 - ldapsearch with empty filter User who did this - Henning Westerholt (henningw) Reason for closing: Fixed More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=23 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] User took ownership: ldapsearch with empty filter
by sip-router 21 Jan '10

21 Jan '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. Henning Westerholt has taken ownership of the following task: FS#23 - ldapsearch with empty filter More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=23 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

[tracker] Comment added: ldapsearch with empty filter
by sip-router 21 Jan '10

21 Jan '10

THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added: FS#23 - ldapsearch with empty filter User who did this - Henning Westerholt (henningw) ---------- Hey Andrey, thank you for the patch. I applied it to the git master branch and will also backport it to the 3.0 branches after some time. Regards, Henning ---------- More information can be found at the following URL: http://sip-router.org/tracker/index.php?do=details&task_id=23#comment26 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above.

1 0

git:master: ldap(k): fix ldapsearch with empty filter
by Henning Westerholt 21 Jan '10

21 Jan '10

Module: sip-router Branch: master Commit: 73655cc83851f1f406ce23b8d6130632d731ef2d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=73655cc… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Thu Jan 21 19:26:08 2010 +0100 ldap(k): fix ldapsearch with empty filter * fix ldapsearch with empty filter * When in routing script ldapsearch() is executed on LDAP query URL without the ‘filter’ section, request forming fails: ERROR: ldap [ldap_api_fn.c:193]: vsnprintf failed * Workaround for administrators can be filling filter section with ‘(objectclass=*)’, what is anyway substituted by ldap library to request in case filter parameter set to NULL. * Please notice that va_end() call is missing in original code. * Patch FS#23 from andrey dot utkin at wildix dot com --- modules_k/ldap/ldap_api_fn.c | 44 +++++++++++++++++++++++------------------ 1 files changed, 25 insertions(+), 19 deletions(-) diff --git a/modules_k/ldap/ldap_api_fn.c b/modules_k/ldap/ldap_api_fn.c index c2176fc..20fd869 100644 --- a/modules_k/ldap/ldap_api_fn.c +++ b/modules_k/ldap/ldap_api_fn.c @@ -158,6 +158,7 @@ int ldap_params_search( { int rc; static char filter_str[LDAP_MAX_FILTER_LEN]; + char *filter_ptr = NULL; va_list filter_vars; /* @@ -174,24 +175,29 @@ int ldap_params_search( return -1; } - /* - * vsnprintf - */ - va_start(filter_vars, _filter); - rc = vsnprintf(filter_str, (size_t)LDAP_MAX_FILTER_LEN, _filter, - filter_vars); - if (rc >= LDAP_MAX_FILTER_LEN) - { - LM_ERR( "[%s]: filter string too long (len [%d], max len [%d])\n", - _lds_name, - rc, - LDAP_MAX_FILTER_LEN); - return -1; - } - else if (rc < 0) - { - LM_ERR("vsnprintf failed\n"); - return -1; + if (_filter) { + /* + * vsnprintf + */ + va_start(filter_vars, _filter); + rc = vsnprintf(filter_str, (size_t)LDAP_MAX_FILTER_LEN, _filter, + filter_vars); + va_end(filter_vars); + + if (rc >= LDAP_MAX_FILTER_LEN) + { + LM_ERR( "[%s]: filter string too long (len [%d], max len [%d])\n", + _lds_name, + rc, + LDAP_MAX_FILTER_LEN); + return -1; + } + else if (rc < 0) + { + LM_ERR("vsnprintf failed\n"); + return -1; + } + filter_ptr = filter_str; } /* @@ -200,7 +206,7 @@ int ldap_params_search( if (lds_search(_lds_name, _dn, _scope, - filter_str, + filter_ptr, _attrs, NULL, _ld_result_count,

1 0

Re: [sr-dev] sip router and presence setup
by Klaus Darilion 21 Jan '10

21 Jan '10

forgotten to cc the list :-) Klaus Darilion schrieb: > > > Aymeric Moizard schrieb: >> >> >> On Thu, 21 Jan 2010, Klaus Darilion wrote: >> >>> Aymeric Moizard schrieb: >> >> [...] >> >>>> Last general question: What about mixing kamailio & ser? I've seen >>>> for example modules with same namings: "auth" and "auth_db" in both >>>> modules_s & modules_k: does this means we can use the same core but >>>> have to choose between using modules_s or modules_k? >>> >>> You can mix, but not arbitrarily. The biggest difference between ser >>> and kamailio is the database structure. ser uses a new database >>> schema with numeric user-ids which map to SIP AoR. kamailio still >>> uses the old (ser 0.9.x) database schema where every user has a fixed >>> AoR. >>> >>> Therefore you can not mix modules which require different database >>> layouts. >>> >>> Thus, in your scenario you have to mix database layouts: >>> provisioning/location from ser and presence from kamailio. That might >>> work. But probably much easier would be to use kamailio modules only >>> (unless you need numeric user ids). >> >> Then my first comment would be: why have the "pa" been removed if it's >> not possible to use the presence module from kamailio... > > I think you can (I have not tried, but it should work, maybe needs some > tuning) - as presence tables are not related to provisioning/location > tables. But it is more work. > >> In my mind, presence & presence_xml are using different independant >> database table and doesn't conflict with ser database? >> >> Most probably, there could be conflict with modules that depends >> on usrloc for example? (like pua_usrloc) Looking at developper APIs, >> for both usrloc kam/ser modules they are very close. > > Agreed. > >> I don't fully understand yet what "numeric user ids" are, but I would >> really like to use the ser database layout for >> user/location/credentials which seems really flexible compared to >> kamailio. >> >> So where sip-router is going? Do you target to have only the same >> core for both kamailio & ser, but still be different projects? > > There is already the same "core". But different database schema (used by > modules) > >> Is having a common database layout an objective of the sip-router >> project? > > I think this is not agreed yet. But as it is planned to merge common > modules, this probably includes merging the schema too. > > The problem is existing schemas. Although ser's schema is more flexible, > users avoid changing their existing schema (as this impacts the whole > provisioning/billing subsystems). > >> If I intent to implement to additionnal event package, do you advise >> me to stick with kamailio subscriber layout? > > Do you need subscriber layout for the presence module? Maybe you can > describe your module a bit more. > >> I finally understood why my "make deb" was compiling a ser version: >> I just forgot to checkout the kamailio branch... That was also a >> source of confusion for understanding why normal step for the >> kamailio branch was to setup a ser database layout... Because >> of that error, I though first the same layout was already used... > > This is what I do to build kamailio: > git clone ..uri... > cd sip-router > git branch --track kamailio_3.0 origin/kamailio_3.0 > git checkout kamailio_3.0 > make deb > > regards > klaus > > >> >> Tks, >> Aymeric MOIZARD / ANTISIP >> amsip - http://www.antisip.com >> osip2 - http://www.osip.org >> eXosip2 - http://savannah.nongnu.org/projects/exosip/ >> >> >>> regards >>> klaus >>> >>>> >>>> Tks much for your help & advise, >>>> >>>> Aymeric MOIZARD / ANTISIP >>>> amsip - http://www.antisip.com >>>> osip2 - http://www.osip.org >>>> eXosip2 - http://savannah.nongnu.org/projects/exosip/ >>>> >>>> >>>> _______________________________________________ >>>> sr-dev mailing list >>>> sr-dev(a)lists.sip-router.org >>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev >>> >

1 0

git:master: utils/sercmd: Fixed getopt() missing param
by Marius Zbihlei 21 Jan '10

21 Jan '10

Module: sip-router Branch: master Commit: 7c701df1be3d71afe49e7d017a90fa10c081b790 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=7c701df… Author: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Committer: Marius Zbihlei <marius.zbihlei(a)1and1.ro> Date: Thu Jan 21 17:32:42 2010 +0200 utils/sercmd: Fixed getopt() missing param Getopt was missing the -U param --- utils/sercmd/sercmd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils/sercmd/sercmd.c b/utils/sercmd/sercmd.c index ada5ff6..1f1a721 100644 --- a/utils/sercmd/sercmd.c +++ b/utils/sercmd/sercmd.c @@ -1885,7 +1885,7 @@ int main(int argc, char** argv) port_no=0; sock_type=UNIXS_SOCK; opterr=0; - while((c=getopt(argc, argv, "Vhs:D:R:vf:"))!=-1){ + while((c=getopt(argc, argv, "UVhs:D:R:vf:"))!=-1){ switch(c){ case 'V': printf("version: %s\n", version);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev