sr-dev

sr-dev@lists.kamailio.org

15 participants
44239 discussions

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: ded509e08679fe9f836386badca21c0fe3170de1 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=ded509e… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Jul 21 01:15:02 2009 +0200 tm: new uri2dst() version - new uri2dst2() function which can have the send_socket passed directly to it. - uri2dst() is now a wrapper over uri2dst2(). --- modules/tm/ut.h | 65 ++++++++++++++++++++++++++++++++++++++++++++---------- 1 files changed, 53 insertions(+), 12 deletions(-) diff --git a/modules/tm/ut.h b/modules/tm/ut.h index 436a7b8..0c7afaf 100644 --- a/modules/tm/ut.h +++ b/modules/tm/ut.h @@ -209,7 +209,8 @@ inline static int get_uri_send_info(str* uri, str* host, unsigned short* port, /* - * Convert a URI into a dest_info structure + * Convert a URI into a dest_info structure. + * Same as uri2dst, but uses directly force_send_socket instead of msg. * If the uri host resolves to multiple ips and dns_h!=0 the first ip for * which a send socket is found will be used. If no send_socket are found, * the first ip is selected. @@ -218,9 +219,8 @@ inline static int get_uri_send_info(str* uri, str* host, unsigned short* port, * null. If null or use_dns_failover==0 normal dns lookup will * be performed (no failover). * dst - will be filled - * msg - sip message used to set dst->send_sock, if 0 dst->send_sock - * will be set to the default w/o using msg->force_send_socket - * (see get_send_socket()) + * force_send_sock - if 0 dst->send_sock will be set to the default + * (see get_send_socket2()) * uri - uri in str form * proto - if != PROTO_NONE, this protocol will be forced over the * uri_proto, otherwise the uri proto will be used if set or @@ -228,14 +228,14 @@ inline static int get_uri_send_info(str* uri, str* host, unsigned short* port, * returns 0 on error, dst on success */ #ifdef USE_DNS_FAILOVER -inline static struct dest_info *uri2dst(struct dns_srv_handle* dns_h, +inline static struct dest_info *uri2dst2(struct dns_srv_handle* dns_h, struct dest_info* dst, - struct sip_msg *msg, str *uri, - int proto ) + struct socket_info *force_send_socket, + str *uri, int proto ) #else -inline static struct dest_info *uri2dst(struct dest_info* dst, - struct sip_msg *msg, str *uri, - int proto ) +inline static struct dest_info *uri2dst2(struct dest_info* dst, + struct socket_info *force_send_socket, + str *uri, int proto ) #endif { struct sip_uri parsed_uri; @@ -297,7 +297,8 @@ inline static struct dest_info *uri2dst(struct dest_info* dst, dst->to=to; ip_found=1; } - dst->send_sock = get_send_socket(msg, &to, dst->proto); + dst->send_sock = get_send_socket2(force_send_socket, &to, + dst->proto, 0); if (dst->send_sock){ dst->to=to; return dst; /* found a good one */ @@ -313,7 +314,8 @@ inline static struct dest_info *uri2dst(struct dest_info* dst, ERR("failed to resolve \"%.*s\"\n", host->len, ZSW(host->s)); return 0; } - dst->send_sock = get_send_socket(msg, &dst->to, dst->proto); + dst->send_sock = get_send_socket2(force_send_socket, &dst->to, + dst->proto, 0); if (dst->send_sock==0) { ERR("no corresponding socket for af %d\n", dst->to.s.sa_family); /* ser_error = E_NO_SOCKET;*/ @@ -323,6 +325,45 @@ inline static struct dest_info *uri2dst(struct dest_info* dst, } + +/* + * Convert a URI into a dest_info structure + * If the uri host resolves to multiple ips and dns_h!=0 the first ip for + * which a send socket is found will be used. If no send_socket are found, + * the first ip is selected. + * + * params: dns_h - pointer to a valid dns_srv_handle structure (intialized!) or + * null. If null or use_dns_failover==0 normal dns lookup will + * be performed (no failover). + * dst - will be filled + * msg - sip message used to set dst->send_sock, if 0 dst->send_sock + * will be set to the default w/o using msg->force_send_socket + * (see get_send_socket()) + * uri - uri in str form + * proto - if != PROTO_NONE, this protocol will be forced over the + * uri_proto, otherwise the uri proto will be used if set or + * the proto obtained from the dns lookup + * returns 0 on error, dst on success + */ +#ifdef USE_DNS_FAILOVER +inline static struct dest_info *uri2dst(struct dns_srv_handle* dns_h, + struct dest_info* dst, + struct sip_msg *msg, str *uri, + int proto ) +{ + return uri2dst2(dns_h, dst, msg?msg->force_send_socket:0, uri, proto); +} +#else +inline static struct dest_info *uri2dst(struct dest_info* dst, + struct sip_msg *msg, str *uri, + int proto ) +{ + return uri2dst2(dst, msg?msg->force_send_socket:0, uri, proto); +} +#endif /* USE_DNS_FAILOVER */ + + + #if 0 /* * Convert a URI into the corresponding sockaddr_union (address to send to) and

15 years, 6 months

git:master: core: get_send_socket fix for tcp or tls forced socket

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: bc71de00c3e8cddf76044180315f5ce8c93495f4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bc71de0… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Jul 21 01:10:05 2009 +0200 core: get_send_socket fix for tcp or tls forced socket One of the get_send_socket() sanity tests, checks if ser really listens on the forced socket. For tcp and tls this test should not be performed (the sockets are closed for the processes that do not need them => cannot test by looking at the fd). --- forward.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/forward.c b/forward.c index b9e8ead..3080b1d 100644 --- a/forward.c +++ b/forward.c @@ -195,7 +195,12 @@ struct socket_info* get_send_socket2(struct socket_info* force_send_socket, if (likely(mismatch)) *mismatch=SS_MISMATCH_AF; goto not_forced; } - if (likely((force_send_socket->socket!=-1) && + /* check if listening on the socket (the check does not work + for TCP and TLS, for them socket==-1 on all the processes + except tcp_main(), see close_extra_socks() */ + if (likely((force_send_socket->socket!=-1 || + force_send_socket->proto==PROTO_TCP || + force_send_socket->proto==PROTO_TLS) && !(force_send_socket->flags & SI_IS_MCAST))) return force_send_socket; else{

15 years, 6 months

git:master: core: enhanced get_send_socket() version

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 9981e48a4f9517c016402897e6b90916d5f64eb2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=9981e48… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Mon Jul 20 23:51:27 2009 +0200 core: enhanced get_send_socket() version get_send_socket2() added. --- forward.c | 53 ++++++++++++++++++++++++++++++++++------------------- forward.h | 21 +++++++++++++++++++-- 2 files changed, 53 insertions(+), 21 deletions(-) diff --git a/forward.c b/forward.c index 3a9cb0c..b9e8ead 100644 --- a/forward.c +++ b/forward.c @@ -151,43 +151,58 @@ error: -/* returns a socket_info pointer to the sending socket or 0 on error - * params: sip msg (can be null), destination socket_union pointer, protocol - * if msg!=null and msg->force_send_socket, the force_send_socket will be - * used +/** get the sending socket for a corresponding destination. + * @param force_send_socket - if !=0 and the protocol and af correspond + * with the destination, it will be returned. + * If the protocol or af check fail, a look-alike + * socket will be searched for and mismatch will be + * set. If no look-alike socket is found it will + * fallback to normal resolution. + * @param to - destination + * @param proto - protocol + * @param mismatch - result parameter, set if a force_send_socket was used, but + * there was an error matching it exactly to the destination. + * Possible values: 0 ok, SS_MISMATCH_PROTO, + * SS_MISMATCH_ADDR, SS_MISMATCH_AF, SS_MISMATCH_MCAST. + * @return a socket_info pointer to the sending socket on success (and possibly + * sets mismatch) or 0 on error. */ -struct socket_info* get_send_socket(struct sip_msg *msg, - union sockaddr_union* to, int proto) +struct socket_info* get_send_socket2(struct socket_info* force_send_socket, + union sockaddr_union* to, int proto, + enum ss_mismatch* mismatch) { struct socket_info* send_sock; + if (likely(mismatch)) *mismatch=0; /* check if send interface is not forced */ - if (unlikely(msg && msg->force_send_socket)){ - if (unlikely(msg->force_send_socket->proto!=proto)){ - DBG("get_send_socket: force_send_socket of different proto" - " (%d)!\n", proto); - msg->force_send_socket=find_si(&(msg->force_send_socket->address), - msg->force_send_socket->port_no, + if (unlikely(force_send_socket)){ + if (unlikely(force_send_socket->proto!=proto)){ + force_send_socket=find_si(&(force_send_socket->address), + force_send_socket->port_no, proto); - if (unlikely(msg->force_send_socket == 0)){ + if (unlikely(force_send_socket == 0)){ + if (likely(mismatch)) *mismatch=SS_MISMATCH_ADDR; LOG(L_WARN, "WARNING: get_send_socket: " "protocol/port mismatch\n"); goto not_forced; } + if (likely(mismatch)) *mismatch=SS_MISMATCH_PROTO; } - if (unlikely(msg->force_send_socket->address.af!=to->s.sa_family)){ + if (unlikely(force_send_socket->address.af!=to->s.sa_family)){ DBG("get_send_socket: force_send_socket of different af (dst %d," " forced %d)\n", - to->s.sa_family, msg->force_send_socket->address.af); + to->s.sa_family, force_send_socket->address.af); + if (likely(mismatch)) *mismatch=SS_MISMATCH_AF; goto not_forced; } - if (likely((msg->force_send_socket->socket!=-1) && - !(msg->force_send_socket->flags & SI_IS_MCAST))) - return msg->force_send_socket; + if (likely((force_send_socket->socket!=-1) && + !(force_send_socket->flags & SI_IS_MCAST))) + return force_send_socket; else{ - if (!(msg->force_send_socket->flags & SI_IS_MCAST)) + if (!(force_send_socket->flags & SI_IS_MCAST)) LOG(L_WARN, "WARNING: get_send_socket: not listening" " on the requested socket, no fork mode?\n"); + else if (likely(mismatch)) *mismatch=SS_MISMATCH_MCAST; } }; not_forced: diff --git a/forward.h b/forward.h index f30703b..0a5750a 100644 --- a/forward.h +++ b/forward.h @@ -62,9 +62,26 @@ #include "compiler_opt.h" +enum ss_mismatch { + SS_MISMATCH_OK=0, + SS_MISMATCH_PROTO, /* proto mismatch, but found same addr:port */ + SS_MISMATCH_ADDR, /* proto and addr:port mismatch */ + SS_MISMATCH_AF, /* af mismatch */ + SS_MISMATCH_MCAST /* mcast forced send socket */ +}; + +struct socket_info* get_send_socket2(struct socket_info* force_send_socket, + union sockaddr_union* su, int proto, + enum ss_mismatch* mismatch); + + +inline static struct socket_info* get_send_socket(struct sip_msg* msg, + union sockaddr_union* su, int proto) +{ + return get_send_socket2(msg?msg->force_send_socket:0, su, proto, 0); +} + -struct socket_info* get_send_socket(struct sip_msg* msg, - union sockaddr_union* su, int proto); struct socket_info* get_out_socket(union sockaddr_union* to, int proto); int check_self(str* host, unsigned short port, unsigned short proto); int check_self_port(unsigned short port, unsigned short proto);

15 years, 6 months

almost ok with testing

by jh＠tutpro.com

i have now managed to get all my stuff working using sr except t_uac_dlg. t_uac_dlg is not working because for some reason sr tm module does not implement t_uac_dlg and mi_rpc tells "async mi cmd not implemented yet". i would prefer native support of t_uac_dlg in tm module, because the idea was that sr will use ser tm module. if t_uac is difficult to implement in ser tm module or if that would still not make t_uac_dlg to work via rpc, then i guess i need to wait until mi_rpc supports async mi functions. otherwise things thus look pretty good to me. thanks for your efforts. -- juha

15 years, 6 months

dlg_bridge problems

by jh＠tutpro.com

i tried dlg_bridge, but found some problems. first, if i didn't define tm module param fr_inv_timer_avp, i got these kind of errors to syslog: Jul 22 10:28:53 localhost /usr/sbin/sip-router[15075]: INFO: INVITE <sip:jh@test.fi> by untrusted <sip:controller@kamailio.org> from <192.98.101.10> Jul 22 10:28:53 localhost /usr/sbin/sip-router[15073]: INFO: <core> [tcp_main.c:1919]: tcp_send: quick connect for 0xb3331098 Jul 22 10:28:53 localhost /usr/sbin/sip-router[15075]: ERROR: <core> [usr_avp.c:159]: ERROR:avp:add_avp: 0 ID or NULL NAME AVP! Jul 22 10:28:53 localhost /usr/sbin/sip-router[15075]: ERROR: tm [t_serial.c:430]: setting of fr_inv_timer_avp failed Jul 22 10:28:53 localhost /usr/sbin/sip-router[15075]: ERROR: Cannot get contacts for INVITE <sip:jh_test_fi@192.98.101.10:5074;transport=udp>! nowhere in dialog module docs is mentioned that tm fr_inv_timer_avp would need to be defined. is defining fr_inv_timer_avp mandatory in order to make dlg_bridge to work? after i defined this avp, and give command mi dlg_bridge sip:jh@test.fi sip:test@test.fi sip:192.98.101.10:5060 sip:jh@test.fi rings, but when twinkle answers, it does not receive a refer. when sip:jh@test.fi then ends the call, by sending bye, i noticed that bye goes to sip:kamailio.org:5060 (contact uri in invite) although i have defined modparam("dialog", "bridge_controller", "sip:click2dial@192.98.101.10:5060") finally, if these issues get solved, is it even in theory possible to add an "extra headers" parameter to dlg_bridge mi command? -- juha

15 years, 6 months

SF.net SVN: openser:[5905] branches/1.5/modules

by Daniel-Constantin Mierla

Revision: 5905 http://openser.svn.sourceforge.net/openser/?rev=5905&view=rev Author: miconda Date: 2009-07-21 20:55:14 +0000 (Tue, 21 Jul 2009) Log Message: ----------- - applied patch from #2824350 - sorts out DB update for subscriptions based on fallback2db parameter - credits to Alex Hermann Modified Paths: -------------- branches/1.5/modules/presence/README branches/1.5/modules/presence/doc/presence_admin.xml branches/1.5/modules/presence/hash.c branches/1.5/modules/presence/hash.h branches/1.5/modules/presence/subscribe.c branches/1.5/modules/rls/rls.c branches/1.5/modules/rls/subscribe.c This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

15 years, 6 months

[ openser-Bugs-2824350 ] Presence DB support completely broken

by SourceForge.net

Bugs item #2824350, was opened at 2009-07-20 17:49 Message generated for change (Comment added) made by klaus_darilion You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2824350&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Presence DB support completely broken Initial Comment: As subject. commit 5840 did the damage ---------------------------------------------------------------------- >Comment By: Klaus Darilion (klaus_darilion) Date: 2009-07-21 15:43 Message: What about having a new parameter like userloc? db_mode= =0: no DB =1: read from cache, write/update to cache and DB =2: read from cache, write to cache and delayed write/update to DB =3: db_only, no cache ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-21 14:00 Message: Patch is ok, cleaner with new parameter rather than playing with falback2db value. I will apply it. Updating on timer is good for the cases of sudden crash, maybe a new mode to skip timer updates and store only at shutdown is more appropriate. ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2009-07-21 13:11 Message: I decided to dive into the code some more. It's a bit messy. There are 2 modes of operation determined by fallback2db. Both modes don't work correctly, the documentation for the modes contradict the code it contradicts ITSELF. So the first thing to do to fix this is to get the desired behavior for both modes documented. >From the code I deduced the following behavior: fallback mode: init: load from database, keep data in tables runtime: insert/update records in table on timer event shutdown: flush cache to db non-fallback mode: init: load from database, empty table runtime: no inserts but try to update table (won't work because table is emptied) shutdown: flush cache to db (fails, because all entries are marked NO_UPDATEDB_FLAG du to the (failed) updates at runtime). Result is an empty table after shutdown. The documentation says in fallback mode the cache isn't used. This is impossible in the current code. Later in the docs it is said only on cache misses, the db is used. This seems reasonable behavior. The main question is: should the db be updated during runtime or only on shutdown when in non-fallback mode? Attached patch creates the following behavior: for both modes: init: load from database, keep table contents runtime: update/insert into table on timer event shutdown: update/insert final time The only difference in the modes is on lookup (as documentation says) and is untouched by this patch. The non-fallback mode should be optimized by not updating the table if the answer to the above question says so, but that is not as trivial as this patch. ps. I found some nice descriptive function names: update_db_subs() and update_subs_db().... ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 19:52 Message: fallback to db is in presence and the insert function is used by rls module as well. I had no time to check the impact now. With this idea, to be safe, fallback2db param has to be directed to another variable, fallback2db initialized to 0 and set to param value in each child, via child_init. Otherwise can be a conflict of loading order. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 18:37 Message: I don't know if changing the API and ABI is appropriate for the stable series. What about setting the fallback2db variable only AFTER loading the DB contents? ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 18:22 Message: The function is used in presence and rls modules. Does not look like big changes to add a new param to specify the mode. Do you think of something else? ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2009-07-20 18:07 Message: New subscriptions don't get stored in the DB because the test for 'fallback2db' was wrong. I just noticed the insert_shtable() function is also used to load from DB initially, so my patch is wrong. Fix is a bit more non-trivial. The problem is that the function is used for both DB-load at startup and new subscriptions during runtime. The db_flag in the hash table record needs to be INSERTDB_FLAG during runtime, and NO_UPDATEDB_FLAG for initial load. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 17:53 Message: Please provide a bit more details of what got broken. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2824350&group_…

15 years, 6 months

git:master: Merge commit 'origin/tmp/build_local'

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 4bc6bf9e8469ffc67dc1e19f1695125180b40f9d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4bc6bf9… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Tue Jul 21 14:53:26 2009 +0200 Merge commit 'origin/tmp/build_local' * commit 'origin/tmp/build_local': core: init via_len to cope with no via update flag tm: local req. route: do not save/restore the avps tm: local req. route: cache route id tm: local req. route: always free the tmp sip msg tm: local req. route rcv init fix tm: updated execution of event route core: build_req_buf_from_sip_req() has a new parameter tm: update to new signature of build_req_buf_from_sip_req() tm: execute event_route[tm:local-request] if defined ---

15 years, 6 months

[ openser-Bugs-2824350 ] Presence DB support completely broken

by SourceForge.net

Bugs item #2824350, was opened at 2009-07-20 15:49 Message generated for change (Comment added) made by nobody You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2824350&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: modules Group: ver 1.5.x Status: Open Resolution: None Priority: 5 Private: No Submitted By: Alex Hermann (axlh) Assigned to: Nobody/Anonymous (nobody) Summary: Presence DB support completely broken Initial Comment: As subject. commit 5840 did the damage ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-21 12:00 Message: Patch is ok, cleaner with new parameter rather than playing with falback2db value. I will apply it. Updating on timer is good for the cases of sudden crash, maybe a new mode to skip timer updates and store only at shutdown is more appropriate. ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2009-07-21 11:11 Message: I decided to dive into the code some more. It's a bit messy. There are 2 modes of operation determined by fallback2db. Both modes don't work correctly, the documentation for the modes contradict the code it contradicts ITSELF. So the first thing to do to fix this is to get the desired behavior for both modes documented. >From the code I deduced the following behavior: fallback mode: init: load from database, keep data in tables runtime: insert/update records in table on timer event shutdown: flush cache to db non-fallback mode: init: load from database, empty table runtime: no inserts but try to update table (won't work because table is emptied) shutdown: flush cache to db (fails, because all entries are marked NO_UPDATEDB_FLAG du to the (failed) updates at runtime). Result is an empty table after shutdown. The documentation says in fallback mode the cache isn't used. This is impossible in the current code. Later in the docs it is said only on cache misses, the db is used. This seems reasonable behavior. The main question is: should the db be updated during runtime or only on shutdown when in non-fallback mode? Attached patch creates the following behavior: for both modes: init: load from database, keep table contents runtime: update/insert into table on timer event shutdown: update/insert final time The only difference in the modes is on lookup (as documentation says) and is untouched by this patch. The non-fallback mode should be optimized by not updating the table if the answer to the above question says so, but that is not as trivial as this patch. ps. I found some nice descriptive function names: update_db_subs() and update_subs_db().... ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 17:52 Message: fallback to db is in presence and the insert function is used by rls module as well. I had no time to check the impact now. With this idea, to be safe, fallback2db param has to be directed to another variable, fallback2db initialized to 0 and set to param value in each child, via child_init. Otherwise can be a conflict of loading order. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 16:37 Message: I don't know if changing the API and ABI is appropriate for the stable series. What about setting the fallback2db variable only AFTER loading the DB contents? ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 16:22 Message: The function is used in presence and rls modules. Does not look like big changes to add a new param to specify the mode. Do you think of something else? ---------------------------------------------------------------------- Comment By: Alex Hermann (axlh) Date: 2009-07-20 16:07 Message: New subscriptions don't get stored in the DB because the test for 'fallback2db' was wrong. I just noticed the insert_shtable() function is also used to load from DB initially, so my patch is wrong. Fix is a bit more non-trivial. The problem is that the function is used for both DB-load at startup and new subscriptions during runtime. The db_flag in the hash table record needs to be INSERTDB_FLAG during runtime, and NO_UPDATEDB_FLAG for initial load. ---------------------------------------------------------------------- Comment By: Nobody/Anonymous (nobody) Date: 2009-07-20 15:53 Message: Please provide a bit more details of what got broken. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=743020&aid=2824350&group_…

15 years, 6 months

git:tmp/build_local: core: init via_len to cope with no via update flag

by Daniel-Constantin Mierla

Module: sip-router Branch: tmp/build_local Commit: 6be3dfe5d0ae5f05fd5acb2e1b8858fa658044ed URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6be3dfe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Tue Jul 21 13:49:36 2009 +0200 core: init via_len to cope with no via update flag --- msg_translator.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/msg_translator.c b/msg_translator.c index 41878e3..2f14505 100644 --- a/msg_translator.c +++ b/msg_translator.c @@ -1551,6 +1551,7 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, received_buf=0; rport_buf=0; line_buf=0; + via_len=0; flags=msg->msg_flags|global_req_flags; /* Calculate message body difference and adjust Content-Length */

15 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev