sr-dev

sr-dev@lists.kamailio.org

15 participants
44233 discussions

git:master: * Core: Renamed ser.8 to sip-router.8

by Juha Heinanen

Module: sip-router Branch: master Commit: 5623ef894a6e15818de87a4a2b2fc95ede3972ef URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=5623ef8… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Jun 24 21:25:58 2009 +0300 * Core: Renamed ser.8 to sip-router.8 * Renamed ser.8 to sip-router.8. * Small edits in sip-router.8. --- ser.8 => sip-router.8 | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/ser.8 b/sip-router.8 similarity index 97% rename from ser.8 rename to sip-router.8 index cc4c5da..aa9c625 100644 --- a/ser.8 +++ b/sip-router.8 @@ -1,5 +1,5 @@ .\" $Id$ -.TH sip-router 8 15.07.2002 sip-router "Sip Express Router" +.TH sip-router 8 15.07.2002 sip-router "SIP Router" .\" Process with .\" groff -man -Tascii sip-router.8 .\" @@ -38,8 +38,7 @@ sip-router \- very fast and configurable sip proxy .SH DESCRIPTION .B sip-router or -.BR Sip -.BR Express +.BR SIP .BR Router is a very fast and configurable SIP proxy.

15 years, 6 months

git:master: make: excluded more modules by default

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 4e4228db232201f2921152303e969240d4f68c49 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4e4228d… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Jun 24 19:50:06 2009 +0200 make: excluded more modules by default Excluded more modules which either require external libraries or external includes to compile. New modules on the exclude_modules list: perl, dialplan, lcr, utils, presence, presence_dialoginfo, presence_xml, pua, pua_bla, pua_dialoginfo, pua_usrloc, pua_xmpp, regex, xcap_client, h350. --- Makefile | 11 +++++++++-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index dc17c9e..2bc4162 100644 --- a/Makefile +++ b/Makefile @@ -183,6 +183,7 @@ ifneq ($(group_include)$(cfg_group_include),) exclude_modules?= else # Old defaults for backwards compatibility + # excluded because they depend on external libraries exclude_modules?= cpl mangler postgres jabber mysql cpl-c \ auth_radius uri_radius avp_radius \ acc_radius dialog pa rls presence_b2b xcap xmlrpc\ @@ -190,9 +191,15 @@ else unixsock dbg print_lib auth_identity ldap \ db_berkeley db_mysql db_postgres db_oracle \ db_unixodbc memcached mi_xmlrpc \ - nat_traversal perlvdb purple seas siptrace \ + nat_traversal perl perlvdb purple seas siptrace \ snmpstats uac_redirect xmpp \ - carrierroute misc_radius peering + carrierroute misc_radius peering \ + dialplan lcr utils presence \ + presence_dialoginfo presence_xml pua pua_bla \ + pua_dialoginfo pua_usrloc pua_xmpp \ + regex xcap_client + #excluded because they depend on external *.h files + exclude_modules+= h350 # excluded because they do not compile (remove them only after they are # fixed) -- andrei exclude_modules+= avpops bdb dbtext iptrtpproxy pa rls

15 years, 6 months

git:master: tm: safety checks for possible escaped neg. ACKs

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 8632598cac189adb557ad0c65f15744ef4256e45 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=8632598… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Jun 24 20:01:46 2009 +0200 tm: safety checks for possible escaped neg. ACKs In normal operation looking up a transaction corresponding to an ACK to a neg. reply or to a local transaction should end up in script termination, so when t_relay_to() is called for a neg. ACK, the transaction should not have been looked up previously. If this assumption fails, the ACK will be processed normally (resulting at worst in calling the TMCB_ACK_NEG_IN callback multiple times for the same ACK) and a warning message will be logged. --- modules/tm/t_funcs.c | 28 +++++++++++++++++++++++----- 1 files changed, 23 insertions(+), 5 deletions(-) diff --git a/modules/tm/t_funcs.c b/modules/tm/t_funcs.c index d60c99e..aa7d1f4 100644 --- a/modules/tm/t_funcs.c +++ b/modules/tm/t_funcs.c @@ -271,11 +271,10 @@ int t_relay_to( struct sip_msg *p_msg , struct proxy_l *proxy, int proto, /* parsing error, memory alloc, whatever ... if via is bad and we are forced to reply there, return with 0 (->break), pass error status otherwise - - MMA: return value E_SCRIPT means that transaction was already started from the script - so continue with that transaction + MMA: return value E_SCRIPT means that transaction was already started + from the script so continue with that transaction */ - if (new_tran!=E_SCRIPT) { + if (likely(new_tran!=E_SCRIPT)) { if (new_tran<0) { ret = (ser_error==E_BAD_VIA && reply_to_via) ? 0 : new_tran; goto done; @@ -285,11 +284,30 @@ int t_relay_to( struct sip_msg *p_msg , struct proxy_l *proxy, int proto, ret = 1; goto done; } + }else if (unlikely(p_msg->REQ_METHOD==METHOD_ACK)) { + /* transaction previously found (E_SCRIPT) and msg==ACK + => ack to neg. reply or ack to local trans. + => process it and exit */ + /* FIXME: there's no way to distinguish here between acks to + local trans. and neg. acks */ + /* in normal operation we should never reach this point, if we + do WARN(), it might hide some real bug (apart from possibly + hiding a bug the most harm done is calling the TMCB_ACK_NEG + callbacks twice) */ + WARN("negative or local ACK caught, please report\n"); + t=get_t(); + if (unlikely(has_tran_tmcbs(t, TMCB_ACK_NEG_IN))) + run_trans_callbacks(TMCB_ACK_NEG_IN, t, p_msg, 0, + p_msg->REQ_METHOD); + t_release_transaction(t); + ret=1; + goto done; } /* new transaction */ - /* ACKs do not establish a transaction and are fwd-ed statelessly */ + /* at this point if the msg is an ACK it is an e2e ACK and + e2e ACKs do not establish a transaction and are fwd-ed statelessly */ if ( p_msg->REQ_METHOD==METHOD_ACK) { DBG( "SER: forwarding ACK statelessly \n"); if (proxy==0) {

15 years, 6 months

git:master: * modules/tls: ser to sip-router renaming

by Juha Heinanen

Module: sip-router Branch: master Commit: 16121d4615bd20baee32337958f0f42ee5a42f20 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=16121d4… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Jun 24 20:49:10 2009 +0300 * modules/tls: ser to sip-router renaming * Renamed ser files to sip-router files and updated README. --- modules/tls/README | 86 ++++++++++++----------- modules/tls/{ser-tls.cfg => sip-router-tls.cfg} | 0 modules/tls/{ser_cert.sh => sip-router_cert.sh} | 0 3 files changed, 44 insertions(+), 42 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=161…

15 years, 6 months

new version number

by Andrei Pelinescu-Onciul

If nobody disagrees, I'll change the version number to 2.99.0 in the idea that both kamailio and ser first releases based on sip-router will bear the 3.0.x number (3.0 is greater then both ser and k current versions). Andrei

15 years, 6 months

Server trying outgoing TCP (TLS) connection, gets blocked

by Ivan Genov

Hi, We have noticed that the server tries to connect to user's contact IP:port when there is no existing TCP connection with the client. This can happen when the client-server TLS connection brakes for some reason (for example flaky Internet). After that when consequent requests need to be proxied to that user (NOTIFYs, SUBSCRIBEs) we can see in the logs that the server tries to connect to the user's IP and port because there is not existing TCP (TLS) connection with it. In our setup though the cients are behind NAT and the serveer is in the public Internet. In most such cases the server fails "normally" after 10 seconds and during that time if the same client tries to REGISTER, the REGISTER packets are processed on the server by the same process that has been blocked for 10 seconds, after the blocking 10 secs have elapsed. In effect this makes it harder for the clent to re-REGISTER when the connection has been broken. There are cases though, when we can see in the server logs that there are no logs for more than 3 minutes and we can see that two server processes have been trying outgoing connection to the old client's IP:port for more than 3 minutes and we can see how both processes report unsuccessfull tcp blocking connect to the client after the logs resume after more than 3 minutes have elapsed. During such cases the server simply doesn't respond to client's attempts to REGISTER and is in effect blocked. We have no clue as to why the server is blocked for more than 3 minutes since the tcp connect timeout seems to be just 10 seconds. What we think is best is if we can configure the server to not try outgoing TCP connections to clients (when TCP conenction doesn't exist)? Is there a configration setting for that? If there is no configuration for that, what is the best place in code to make this change in the code? If this is not easy or not recommended, can we set the server's timeout for outgoing TCP connection to something smaller, for example 1-2 seconds, or even 0 seconds? We feel in our setup it will be better if the server does not try to connect at all, becasue anyway the connection attempt will fail. Any information will be appreciated. Thanks in advance, Ivan

15 years, 6 months

git:master: tm: fix t_check messing up replies branch

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 30ea1726754fdc12646e35a6ec49a636a57ab7f0 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=30ea172… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Wed Jun 24 15:06:26 2009 +0200 tm: fix t_check messing up replies branch - when t_check was called twice for a reply (e.g. t_check_trans() in script in the main onreply_route and then internally in tm reply_received), the second call did return an invalid branch. Now the current branch is remembered along T so t_check will always return a valid branch. - added T_branch, a new global variable that holds the current branch corresponding to T (is valid only if T is valid). - set_t() takes now 2 parameters: a transaction and the current branch for the transaction. If the current branch does not make sense (e.g. for requests), T_BR_UNDEFINED must be used. This change ensures that every time T is set or changed, the current branch is also updated. - more comments added --- modules/tm/t_lookup.c | 138 ++++++++++++++++++++++++++++++++++++++----------- modules/tm/t_lookup.h | 6 ++- modules/tm/t_reply.c | 17 ++++-- 3 files changed, 123 insertions(+), 38 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=30e…

15 years, 6 months

git:master: * modules/lcr: fixed crash when module initialization failed

by Juha Heinanen

Module: sip-router Branch: master Commit: f9477aa2bec8508197837875ebc199f1bf569fa4 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=f9477aa… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Jun 24 16:08:09 2009 +0300 * modules/lcr: fixed crash when module initialization failed * Added checks that shared memory has been really allocated before trying to free it. Fixes crash when during failed module initialization. --- modules/lcr/lcr_mod.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/modules/lcr/lcr_mod.c b/modules/lcr/lcr_mod.c index 5a1619f..d3e9d17 100644 --- a/modules/lcr/lcr_mod.c +++ b/modules/lcr/lcr_mod.c @@ -221,9 +221,11 @@ static int_str defunct_gw_avp; static int lcr_id_avp_type; static int_str lcr_id_avp; -struct gw_info **gwtp; /* Pointer to gw table pointer table */ +/* Pointer to gw table pointer table */ +struct gw_info **gwtp = (struct gw_info **)NULL; -struct lcr_info ***lcrtp; /* Pointer to lcr hash table pointer table */ +/* Pointer to lcr hash table pointer table */ +struct lcr_info ***lcrtp = (struct lcr_info ***)NULL; /* @@ -571,10 +573,6 @@ static int mod_init(void) } lcr_dbf.close(dbh); - /* Reset all shm pointers */ - gwtp = (struct gw_info **)NULL; - lcrtp = (struct lcr_info ***)NULL; - /* Allocate gw related shared memory */ /* gw table pointer table, index 0 points to temp gw table */ gwtp = (struct gw_info **)shm_malloc(sizeof(struct gw_info *) * @@ -583,6 +581,7 @@ static int mod_init(void) LM_ERR("no memory for gw table pointer table\n"); goto err; } + memset(gwtp, 0, sizeof(struct gw_info *) * (lcr_count + 1)); /* gw tables */ for (i = 0; i <= lcr_count; i++) { gwtp[i] = (struct gw_info *)shm_malloc(sizeof(struct gw_info) * @@ -602,6 +601,7 @@ static int mod_init(void) LM_ERR("no memory for lcr hash table pointer table\n"); goto err; } + memset(lcrtp, 0, sizeof(struct lcr_info **) * (lcr_count + 1)); /* lcr hash tables */ /* Last entry in hash table contains list of different prefix lengths */ for (i = 0; i <= lcr_count; i++) { @@ -677,18 +677,18 @@ static void free_shared_memory(void) { int i; for (i = 0; i <= lcr_count; i++) { - if (gwtp[i]) { + if (gwtp && gwtp[i]) { shm_free(gwtp[i]); gwtp[i] = 0; } - if (lcrtp[i]) { + if (lcrtp && lcrtp[i]) { lcr_hash_table_contents_free(lcrtp[i]); shm_free(lcrtp[i]); lcrtp[i] = 0; } } - shm_free(gwtp); - shm_free(lcrtp); + if (gwtp) shm_free(gwtp); + if (lcrtp) shm_free(lcrtp); if (reload_lock) { lock_destroy(reload_lock); lock_dealloc(reload_lock);

15 years, 6 months

Missing imports from Kamailio

by Jan Janak

Hello, I finished my import of missing pieces from Kamailio SVN repository. The commit message did not make it though to the list because it was too big. I haven't commited my changes into the master branch yet, I uploaded them to the branch janakj/missing_imports and I would appreciate if people (especially K. developers) could review them, here is a link to the new branch: http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=shortlog;h=refs… And here is a short summary of the changes: 1) kamailio/etc was imported into sip-router/etc In Kamailio trunk the etc directory contains a kamailio.cfg files, a RADIUS dictionary and TLS certificates and related files. 2) kamailio/packaging was imported into sip-router/pkg/kamailio I thought that it would be good to have both version of packaging files under one directory in the shared repository. To avoid conflicts with existing directories and files, I imported Kamailio stuff into pkg/kamailio. We will need to go through these files and merge them at some point (or alternatively keep one version and delete the other). 3) kamailio/scripts was imported into sip-router/tools No coflics there, so I did not touch the files imported from Kamailio. I would, however, suggest that as the next step we move kamctl and kamdbctl into subdirectories. Booth tools consist of several files and would be, IMHO, better to have them cleanly separated. 4) kamailio/utils/{db_berkeley,db_oracle,kamunix,profile} were imported into sip-router/utils. I omited kamailio/utils/fif_relay because the same tool is already present in sip-router repository--and it is not needed anymore anyway. What is missing: I also found extra TLS documentation in kamailio/tls/doc. The documentation was probably not yet imported into the sip-router repository so I will look into that. Please take a moment and review the layout, if people are happy with my proposed layout and nobody speaks up then I will merge those changes into the master branch on Wednesday. Jan.

15 years, 6 months

new version of lcr module

by jh＠tutpro.com

i just pushed a new version of lcr module, which resulted from discussions on the mailing lists. most important new feature is support for any number of independent lcr instances, which improves virtualization of sr. for example, different domains can now manage their own least cost routing to their own gws. i also replaced aliveness check with new defunct_gw() function, which script writer can use to defunct an unresponsive or busy gw for a desired period of time. in order to keep lcr module manageable, i removed gw group related functions (which were not efficient anyway). if someone is using them, i hope that they can be replaced by lcr instances. -- juha

15 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev