i recently added a new feature to k msilo module and now took a look how
does s msilo compare to k's. it turns out that k msilo module has lots
of stuff that is missing from s version.
there seems to be one difference though. in s module there is this:
registrar (string)
The SIP address used to inform users that destination of their message
is not online and the message will be delivered next time when that
user goes online. If the parameter is not set, the module will not
send any notification. All requests intended for this SIP address will
not be stored for lately delivery.
Default value is "NULL".
Example 5. Set the registrar parameter
...
modparam("msilo", "registrar", "sip:registrar@iptel.org")
and the corresponding thing in k is this:
1.3.3. from_address (string)
The SIP address used to inform users that destination of their
message is not online and the message will be delivered next
time when that user goes online. If the parameter is not set,
the module will not send any notification. It can contain
pseudo-variables.
Default value is "NULL".
Example 1.3. Set the "from_address" parameter
...
modparam("msilo", "from_address", "sip:registrar@example.org")
modparam("msilo", "from_address", "sip:$rU@example.org")
in my opnion the difference is so small that we could adopt k version of
msilo as is.
comments?
-- juha
Module: sip-router
Branch: master
Commit: 83d732f025fb4db086449e095b1c91e8fefaa754
URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=83d732f…
Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org>
Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org>
Date: Sun May 10 10:56:45 2009 +0200
doc: rpc makefile migrated to the new doc make system
---
doc/rpc/Makefile | 27 +++------------------------
1 files changed, 3 insertions(+), 24 deletions(-)
diff --git a/doc/rpc/Makefile b/doc/rpc/Makefile
index 5d2867c..8f32f6a 100644
--- a/doc/rpc/Makefile
+++ b/doc/rpc/Makefile
@@ -1,29 +1,8 @@
#
# The list of documents to build (without extensions)
#
-DOCUMENTS = ser_rpc
-#
-# The root directory containing Makefile.doc
-#
-ROOT_DIR=../..
-
-#
-# Validate docbook documents before generating output
-# (may be slow)
-#
-#VALIDATE=1
-
-#
-# You can override the stylesheet used to generate
-# xhtml documents here
-#
-#XHTML_XSL=$(ROOT_DIR)/doc/stylesheets/xhtml.xsl
-
-#
-# You can override the stylesheet used to generate
-# plain text documents here
-#
-#TXT_XSL=$(XHTML_XSL)
+docs = ser_rpc.xml
+docbook_dir = ../../docbook
-include $(ROOT_DIR)/Makefile.doc
+include $(docbook_dir)/Makefile
On May 10, 2009 at 12:24, Juha Heinanen <jh(a)tutpro.com> wrote:
Content-Description: message body text
> Andrei Pelinescu-Onciul writes:
>
> > Could you please send me also the output of:
> >
> > cd modules_k/tmx
> > make -wn
>
> jh@taimen:/usr/src/orig/sip-router/modules_k/tmx$ make -wn
> config.mak included
> make: Entering directory `/usr/src/orig/sip-router/modules_k/tmx'
> make -wC ../../lib/kmi/ compile_for_install= \
> NOREBUILD_DEFS=" " \
> NOREBUILD_INCLUDES=" "
> Makefile.defs defs skipped
> make[1]: Entering directory `/usr/src/orig/sip-router/lib/kmi'
> make[1]: `libkmi.so.1.0' is up to date.
> make[1]: Leaving directory `/usr/src/orig/sip-router/lib/kmi'
> make -wC ../../lib/kcore/ compile_for_install= \
> NOREBUILD_DEFS=" " \
> NOREBUILD_INCLUDES=" "
> Makefile.defs defs skipped
> make: *** [../../lib/kcore/libkcore.so] Error 2
> make: Leaving directory `/usr/src/orig/sip-router/modules_k/tmx'
>
> > and
> >
> > make -wd # warning: lots of output
>
It looks like you have a stale statistic.d file in lib/kcore/ which adds
a dependency on core_stats.h which does not exist anymore.
Try make proper or cd lib/kcore ; make proper (if you don't want to
recompile everything), or rm lib/kcore/statistics.d.
After any of the above commands it should work.
We could add this to some docs somewhere: when files are removed make
might fail. If make fails after an update (e.g. git pull or git checkout),
run make proper and then retry.
Andrei