sr-dev

sr-dev@lists.kamailio.org

13 participants
44204 discussions

git:master: core: pv - added wrapper to set function

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 858146a9910ae2e434fb1de3840678cf8b684ce2 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=858146a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 27 13:04:04 2009 +0200 core: pv - added wrapper to set function - wrapper for PV set function that takes in consideration cases of altering the msg context --- pvapi.c | 11 +++++++++++ pvar.h | 5 +++++ 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/pvapi.c b/pvapi.c index ed6a239..87de64a 100644 --- a/pvapi.c +++ b/pvapi.c @@ -35,6 +35,7 @@ #include "ut.h" #include "dprint.h" #include "hashes.h" +#include "route.h" #include "pvar.h" #define is_in_str(p, in) (p<in->s+in->len && *p) @@ -920,6 +921,16 @@ int pv_get_spec_value(struct sip_msg* msg, pv_spec_p sp, pv_value_t *value) return ret; } +int pv_set_spec_value(struct sip_msg* msg, pv_spec_p sp, int op, + pv_value_t *value) +{ + if(sp==NULL || !pv_is_w(sp)) + return 0; /* no op */ + if(pv_alter_context(sp) && is_route_type(LOCAL_ROUTE)) + return 0; /* no op */ + return sp->setf(msg, &sp->pvp, op, value); +} + /** * */ diff --git a/pvar.h b/pvar.h index e1a51a5..bb98ef0 100644 --- a/pvar.h +++ b/pvar.h @@ -134,6 +134,9 @@ typedef int (*pv_parse_name_f)(pv_spec_p sp, str *in); typedef int (*pv_parse_index_f)(pv_spec_p sp, str *in); typedef int (*pv_init_param_f)(pv_spec_p sp, int param); +#define pv_alter_context(pv) ((pv)->type==PVT_CONTEXT \ + || (pv)->type==PVT_BRANCH) + /*! \brief * PV spec format: * - $class_name @@ -166,6 +169,8 @@ typedef struct _pv_elem char* pv_parse_spec2(str *in, pv_spec_p sp, int silent); #define pv_parse_spec(in, sp) pv_parse_spec2((in), (sp), 0) int pv_get_spec_value(struct sip_msg* msg, pv_spec_p sp, pv_value_t *value); +int pv_set_spec_value(struct sip_msg* msg, pv_spec_p sp, int op, + pv_value_t *value); int pv_printf(struct sip_msg* msg, pv_elem_p list, char *buf, int *len); int pv_elem_free_all(pv_elem_p log); void pv_value_destroy(pv_value_t *val);

15 years, 8 months

git:master: added pv_isset() and pv_unset()

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 63be47a2d29d36408c42c7dc2d077865c2d19b98 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=63be47a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 27 13:01:33 2009 +0200 added pv_isset() and pv_unset() - functions to test and unset PV, aiming for K compatibility with null keyword --- modules_k/pv/pv.c | 41 ++++++++++++++++++++++++++++++++++++++++- 1 files changed, 40 insertions(+), 1 deletions(-) diff --git a/modules_k/pv/pv.c b/modules_k/pv/pv.c index b74fe12..9d7078a 100644 --- a/modules_k/pv/pv.c +++ b/modules_k/pv/pv.c @@ -26,6 +26,7 @@ #include "../../sr_module.h" #include "../../pvar.h" +#include "../../mod_fix.h" #include "../../lib/kmi/mi.h" #include "pv_branch.h" @@ -372,12 +373,24 @@ static mi_export_t mi_cmds[] = { static int mod_init(void); static void mod_destroy(void); +static int pv_isset(struct sip_msg* msg, char* pvid, char *foo); +static int pv_unset(struct sip_msg* msg, char* pvid, char *foo); + +static cmd_export_t cmds[]={ + {"pv_isset", (cmd_function)pv_isset, 1, fixup_pvar_null, 0, + ANY_ROUTE }, + {"pv_unset", (cmd_function)pv_unset, 1, fixup_pvar_null, 0, + ANY_ROUTE }, + {0,0,0,0,0,0} +}; + + /** module exports */ struct module_exports exports= { "pv", DEFAULT_DLFLAGS, /* dlopen flags */ - 0, + cmds, params, 0, /* exported statistics */ mi_cmds, /* exported MI functions */ @@ -416,3 +429,29 @@ int mod_register(char *path, int *dlflags, void *p1, void *p2) return register_trans_mod(path, mod_trans); } +static int pv_isset(struct sip_msg* msg, char* pvid, char *foo) +{ + pv_spec_t *sp; + pv_value_t value; + int ret; + + sp = (pv_spec_t*)pvid; + if(pv_get_spec_value(msg, sp, &value)!=0) + return -1; + ret =1; + if(value.flags & (PV_VAL_EMPTY|PV_VAL_NULL)) + ret = -1; + pv_value_destroy(&value); + return ret; +} + +static int pv_unset(struct sip_msg* msg, char* pvid, char *foo) +{ + pv_spec_t *sp; + + sp = (pv_spec_t*)pvid; + pv_set_spec_value(msg, sp, 0, NULL); + + return 1; +} +

15 years, 8 months

git:master: added $null

by Daniel-Constantin Mierla

Module: sip-router Branch: master Commit: 371332203b371aedd28c6611a00ea8355bc0d6b3 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3713322… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: Mon Apr 27 11:57:05 2009 +0200 added $null - PV representation of K 'null' keyword - can be used for assignemts to unset the PV (for easier K-compatibility reason, e.g., $ru = $null) - do not use it in logical expressions (avoid: if($avp(abc)==$null) ; use instead: if(! defined $avp(abc)) --- modules_k/pv/pv.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/modules_k/pv/pv.c b/modules_k/pv/pv.c index 11d9d90..b74fe12 100644 --- a/modules_k/pv/pv.c +++ b/modules_k/pv/pv.c @@ -199,6 +199,9 @@ static pv_export_t mod_pvs[] = { {{"ml", (sizeof("ml")-1)}, /* */ PVT_OTHER, pv_get_msg_len, 0, 0, 0, 0, 0}, + {{"null", (sizeof("null")-1)}, /* */ + PVT_NULL, pv_get_null, 0, + 0, 0, 0, 0}, {{"od", (sizeof("od")-1)}, /* */ PVT_OTHER, pv_get_ouri_attr, 0, 0, 0, pv_init_iname, 2},

15 years, 8 months

git:master: * Modules: presence

by Juha Heinanen

Module: sip-router Branch: master Commit: 59f30b6cbcf25d0ef0f517dad21fa8e711732293 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=59f30b6… Author: Juha Heinanen <jh(a)tutpro.com> Committer: Juha Heinanen <jh(a)tutpro.com> Date: Wed Apr 22 14:08:51 2009 +0300 * Modules: presence * Changed name of auth_status function to pres_auth_status. * Fixed and improved example (don't know how to generate new README). --- modules_k/presence/doc/presence_admin.xml | 15 ++++++++++----- modules_k/presence/presence.c | 6 +++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/modules_k/presence/doc/presence_admin.xml b/modules_k/presence/doc/presence_admin.xml index 057bc95..f39d676 100644 --- a/modules_k/presence/doc/presence_admin.xml +++ b/modules_k/presence/doc/presence_admin.xml @@ -455,11 +455,11 @@ if(method=="SUBSCRIBE") <section> <title> - <function moreinfo="none">auth_status(watcher_uri, presentity_uri)</function> + <function moreinfo="none">pres_auth_status(watcher_uri, presentity_uri)</function> </title> <para> The function checks if watcher is authorized to subscribe - presence of presentity. Both watcher_uri and + event 'presence' of presentity. Both watcher_uri and presentity_uri are pseudo variables. Function returns ACTIVE_STATUS, if subscription is allowed and PENDING_STATUS, TERMINATED_STATUS, or WAITING_STATUS @@ -472,11 +472,16 @@ if(method=="SUBSCRIBE") </para> <example> - <title><function>auth_status</function> usage</title> + <title><function>pres_auth_status</function> usage</title> <programlisting format="linespecific"> ... -if((method=="MESSAGE") && (auth_status("$fu", $ru"))) { - t_relay(); +if (method=="MESSAGE") { + pres_auth_status("$fu", $ru"); + if ($retcode == 1) { + t_relay(); + } else { + send_reply("403", "Forbidden"); + } } ... </programlisting> diff --git a/modules_k/presence/presence.c b/modules_k/presence/presence.c index 9aac54c..703050c 100644 --- a/modules_k/presence/presence.c +++ b/modules_k/presence/presence.c @@ -118,7 +118,7 @@ static struct mi_root* mi_cleanup(struct mi_root* cmd, void* param); static int update_pw_dialogs(subs_t* subs, unsigned int hash_code, subs_t** subs_array); int update_watchers_status(str pres_uri, pres_ev_t* ev, str* rules_doc); static int mi_child_init(void); -static int auth_status(struct sip_msg* _msg, char* _sp1, char* _sp2); +static int pres_auth_status(struct sip_msg* _msg, char* _sp1, char* _sp2); int counter =0; int pid = 0; @@ -140,7 +140,7 @@ static cmd_export_t cmds[]= {"handle_publish", (cmd_function)handle_publish, 0,fixup_presence,0, REQUEST_ROUTE}, {"handle_publish", (cmd_function)handle_publish, 1,fixup_presence, 0, REQUEST_ROUTE}, {"handle_subscribe",(cmd_function)handle_subscribe,0,fixup_subscribe,0, REQUEST_ROUTE}, - {"auth_status", (cmd_function)auth_status, 2, fixup_pvar_pvar, fixup_free_pvar_pvar, REQUEST_ROUTE}, + {"pres_auth_status", (cmd_function)pres_auth_status, 2, fixup_pvar_pvar, fixup_free_pvar_pvar, REQUEST_ROUTE}, {"bind_presence", (cmd_function)bind_presence, 1, 0, 0, 0}, { 0, 0, 0, 0, 0, 0} }; @@ -1078,7 +1078,7 @@ static int update_pw_dialogs(subs_t* subs, unsigned int hash_code, subs_t** subs return 0; } -static int auth_status(struct sip_msg* _msg, char* _sp1, char* _sp2) +static int pres_auth_status(struct sip_msg* _msg, char* _sp1, char* _sp2) { pv_spec_t *sp; pv_value_t pv_val;

15 years, 8 months

git:master: tm: TMCB_RESPONSE_OUT (callback) minor fix

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 98bfba70b755c1ea3844ecfbce35bd9b7f0b11a9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=98bfba7… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Apr 24 09:55:01 2009 +0200 tm: TMCB_RESPONSE_OUT (callback) minor fix - for local generated reply (via t_reply*()) call the TMCB_RESPONSE_OUT callback only if the send was successful (this brings it in-line with the proxied reply behaviour). Reported-by: Daniel-Constantin Mierla <miconda(a)gmail.com> --- modules/tm/t_reply.c | 26 +++++++++++--------------- 1 files changed, 11 insertions(+), 15 deletions(-) diff --git a/modules/tm/t_reply.c b/modules/tm/t_reply.c index a8d1ec3..5cb731f 100644 --- a/modules/tm/t_reply.c +++ b/modules/tm/t_reply.c @@ -563,17 +563,10 @@ static int _reply_light( struct cell *trans, char* buf, unsigned int len, /* do UAC cleanup procedures in case we generated a final answer whereas there are pending UACs */ if (code>=200) { - if ( is_local(trans) ) { - DBG("DEBUG: local transaction completed from _reply\n"); - if ( unlikely(has_tran_tmcbs(trans, TMCB_LOCAL_COMPLETED)) ) - run_trans_callbacks( TMCB_LOCAL_COMPLETED, trans, - 0, FAKED_REPLY, code); - } else { - if ( unlikely(has_tran_tmcbs(trans, TMCB_RESPONSE_OUT)) ) - run_trans_callbacks( TMCB_RESPONSE_OUT, trans, - trans->uas.request, FAKED_REPLY, code); - } - + if (unlikely(is_local(trans) && + has_tran_tmcbs(trans, TMCB_LOCAL_COMPLETED) )) + run_trans_callbacks(TMCB_LOCAL_COMPLETED, trans, + 0, FAKED_REPLY, code); cleanup_uac_timers( trans ); if (is_invite(trans)) cancel_uacs( trans, cancel_bitmap, F_CANCEL_B_KILL ); @@ -594,17 +587,20 @@ static int _reply_light( struct cell *trans, char* buf, unsigned int len, if (!trans->uas.response.dst.send_sock) { LOG(L_ERR, "ERROR: _reply_light: no resolved dst to send reply to\n"); } else { + if (likely(SEND_PR_BUFFER( rb, buf, len )>=0)){ + if (unlikely(code>=200 && !is_local(trans) && + has_tran_tmcbs(trans, TMCB_RESPONSE_OUT)) ) + run_trans_callbacks(TMCB_RESPONSE_OUT, trans, + trans->uas.request, FAKED_REPLY, code); #ifdef TMCB_ONSEND - if (SEND_PR_BUFFER( rb, buf, len )>=0) if (unlikely(has_tran_tmcbs(trans, TMCB_RESPONSE_SENT))){ INIT_TMCB_ONSEND_PARAMS(onsend_params, 0, 0, rb, &rb->dst, buf, len, TMCB_LOCAL_F, rb->branch, code); run_onsend_callbacks2(TMCB_RESPONSE_SENT, trans, &onsend_params); } -#else - SEND_PR_BUFFER( rb, buf, len ); -#endif +#endif /* TMCB_ONSEND */ + } DBG("DEBUG: reply sent out. buf=%p: %.9s..., shmem=%p: %.9s\n", buf, buf, rb->buffer, rb->buffer ); }

15 years, 8 months

git:master: tm: hooks comments update

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 89bfe93c18d4ec77ff8c1819d365bda2a85613fe URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=89bfe93… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Apr 24 10:52:46 2009 +0200 tm: hooks comments update - updated description for TMCB_RESPONSE_OUT and TMCB_LOCAL_RESPONSE_OUT. --- modules/tm/t_hooks.h | 34 ++++++++++++++++++++++++---------- 1 files changed, 24 insertions(+), 10 deletions(-) diff --git a/modules/tm/t_hooks.h b/modules/tm/t_hooks.h index b396737..de20c51 100644 --- a/modules/tm/t_hooks.h +++ b/modules/tm/t_hooks.h @@ -167,16 +167,27 @@ struct cell; * distinguish between the two, one would need to look at the method in * Cseq (look at t_reply.c:1630 (reply_received()) for an example). * - * TMCB_RESPONSE_OUT -- a final reply was sent out (either local - * or proxied) -- there is nothing more you can change from - * the callback, it is good for accounting-like uses. No lock is held. - * Known BUGS: it's called also for provisional replies for relayed replies. - * For local replies it's called only for the final reply. - * - * Note: the message passed to callback may also have + * TMCB_RESPONSE_OUT -- a final or provisional reply was sent out + * successfully (either a local reply or a proxied one). + * For final replies is called only for the first one (it's not called + * for retransmissions). + * For non-local replies (proxied) is called also for provisional responses + * (NOTE: this might change and in the future it might be called only + * for final replies --andrei). + * For local replies is called _only_ for the final reply. + * There is nothing more you can change from the callback, it is good for + * accounting-like uses. No lock is held. + * Known oddities: it's called for provisional replies for relayed replies, + * but not for local responses (see NOTE above). + * Note: if the send fails or via cannot be resolved, this callback is + * _not_ called. + * Note: local reply means locally generated reply (via t_reply() & friends) + * and not local transaction. + * + * Note: the message passed to the callback may also have * value FAKED_REPLY (like other reply callbacks) which - * indicates a pseudo_reply caused by a timer. Check for - * this value before deferring -- you will cause a segfault + * indicates a local reply caused by a timer, calling t_reply() a.s.o. +* Check for this value before deferring -- you will cause a segfault * otherwise. Check for t->uas.request validity too if you * need it ... locally initiated UAC transactions set it to 0. * @@ -249,9 +260,12 @@ struct cell; * transaction arrived. Message may be FAKED_REPLY. Can be called multiple * times, no lock is held. * - * TMCB_LOCAL_REPONSE_OUT -- provisional reply for localy initiated + * TMCB_LOCAL_RESPONSE_OUT -- provisional reply for localy initiated * transaction. The message may be a FAKED_REPLY and the callback might be * called multiple time quasi-simultaneously. No lock is held. + * Note: depends on tm.pass_provisional_replies. + * Note: the name is very unfortunate and it will probably be changed + * (e.g. TMCB_LOCAL_PROVISIONAL). * * TMCB_NEG_ACK_IN -- an ACK to a negative reply was received, thus ending * the transaction (this happens only when the final reply sent by tm is

15 years, 8 months

git:master: core expr: optimize $v==""

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: fe8ef674f5c5bdc72ecb1616537750d9a791854f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=fe8ef67… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Apr 24 15:35:17 2009 +0200 core expr: optimize $v=="" - optimize $v="" to strempty($v) (slightly faster) --- rvalue.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/rvalue.c b/rvalue.c index 74e8df5..2179844 100644 --- a/rvalue.c +++ b/rvalue.c @@ -2479,6 +2479,18 @@ static int rve_opt_01(struct rval_expr* rve, enum rval_type rve_type) ret=1; } break; + case RVE_EQ_OP: + if (rv->v.s.len==0){ + /* $v == "" -> strempty($v) + "" == $v -> strempty ($v) */ + rve_destroy(ct_rve); + /* replace current expr. with strempty(rve) */ + rve->op=RVE_STREMPTY_OP; + rve->left.rve=v_rve; + rve->right.rve=0; + ret=1; + } + break; default: break; }

15 years, 8 months

git:master: core expr: fix invalid pvar string conversions

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: 644f19d3722faef5928344c7dfbdd4c8fd512823 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=644f19d… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Apr 24 19:42:09 2009 +0200 core expr: fix invalid pvar string conversions - in some cases pvars where converted in a wrong way to string (an uninitialized value was used). --- rvalue.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/rvalue.c b/rvalue.c index 800a6b9..897fb4d 100644 --- a/rvalue.c +++ b/rvalue.c @@ -785,7 +785,6 @@ int rval_get_tmp_str(struct run_act_ctx* h, struct sip_msg* msg, struct rval_cache* tmp_cache) { avp_t* r_avp; - pv_value_t pval; int i; switch(rv->type){ @@ -857,18 +856,18 @@ int rval_get_tmp_str(struct run_act_ctx* h, struct sip_msg* msg, tmpv->s=int2str(i, &tmpv->len); }else goto error; }else{ - memset(&pval, 0, sizeof(pval)); + memset(&tmp_cache->c.pval, 0, sizeof(tmp_cache->c.pval)); if (likely(pv_get_spec_value(msg, &rv->v.pvs, &tmp_cache->c.pval)==0)){ - if (likely(pval.flags & PV_VAL_STR)){ + if (likely(tmp_cache->c.pval.flags & PV_VAL_STR)){ /* the value is not destroyed, but saved instead in tmp_cache so that it can be destroyed later when no longer needed */ tmp_cache->cache_type=RV_CACHE_PVAR; tmp_cache->val_type=RV_STR; *tmpv=tmp_cache->c.pval.rs; - }else if (likely(pval.flags & PV_VAL_INT)){ - i=pval.ri; + }else if (likely(tmp_cache->c.pval.flags & PV_VAL_INT)){ + i=tmp_cache->c.pval.ri; pv_value_destroy(&tmp_cache->c.pval); tmpv->s=int2str(i, &tmpv->len); }else{

15 years, 8 months

git:master: core expr: fixes fo RVE_STRLEN/STREMPTY/DEFINED

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: cbba772cadfb6cdd79e09db8cb2c36a1fe3dc216 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=cbba772… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Apr 24 19:39:51 2009 +0200 core expr: fixes fo RVE_STRLEN/STREMPTY/DEFINED - wrong return fixed - missing fixups added --- rvalue.c | 42 +++++++++++++++++++++++++----------------- 1 files changed, 25 insertions(+), 17 deletions(-) diff --git a/rvalue.c b/rvalue.c index 2179844..800a6b9 100644 --- a/rvalue.c +++ b/rvalue.c @@ -1094,6 +1094,7 @@ inline static int int_strop1(int* res, enum rval_expr_op op, str* s1) break; default: BUG("rv unsupported int_strop1 %d\n", op); + *res=0; return -1; } return 0; @@ -1355,6 +1356,7 @@ error: /** integer operation on rval evaluated as string. * Can use cached rvalues (c1 & c2). + * @param res - will be set to the result * @return 0 success, -1 on error */ inline static int rval_int_strop1(struct run_act_ctx* h, @@ -1375,38 +1377,39 @@ inline static int rval_int_strop1(struct run_act_ctx* h, rval_destroy(rv1); return ret; error: + *res=0; rval_destroy(rv1); - return 0; + return -1; } /** checks if rv is defined. - * @return 1 defined, 0 not defined, -1 on error + * @param res - set to the result 1 - defined, 0 not defined + * @return 0 on success, -1 on error * Can use cached rvalues (c1). * Note: a rv can be undefined if it's an undefined avp or pvar or * if it's NONE */ inline static int rv_defined(struct run_act_ctx* h, - struct sip_msg* msg, + struct sip_msg* msg, int* res, struct rvalue* rv, struct rval_cache* cache) { avp_t* r_avp; int_str avp_val; pv_value_t pval; - int ret; - ret=1; + *res=1; switch(rv->type){ case RV_AVP: if (unlikely(cache && cache->cache_type==RV_CACHE_AVP)){ if (cache->val_type==RV_NONE) - ret=0; + *res=0; }else{ r_avp = search_avp_by_index(rv->v.avps.type, rv->v.avps.name, &avp_val, rv->v.avps.index); if (unlikely(r_avp==0)){ - ret=0; + *res=0; } } break; @@ -1414,42 +1417,44 @@ inline static int rv_defined(struct run_act_ctx* h, /* PV_VAL_NULL or pv_get_spec_value error => undef */ if (unlikely(cache && cache->cache_type==RV_CACHE_PVAR)){ if (cache->val_type==RV_NONE) - ret=0; + *res=0; }else{ memset(&pval, 0, sizeof(pval)); if (likely(pv_get_spec_value(msg, &rv->v.pvs, &pval)==0)){ if ((pval.flags & PV_VAL_NULL) && ! (pval.flags & (PV_VAL_INT|PV_VAL_STR))){ - ret=0; + *res=0; } pv_value_destroy(&pval); }else{ - ret=0; /* in case of error, consider it undef */ + *res=0; /* in case of error, consider it undef */ } } break; case RV_NONE: - ret=0; + *res=0; break; default: break; } - return 1; /* defined */ + return 0; } /** defined (integer) operation on rve. - * @return 1 defined, 0 not defined, -1 on error + * @param res - set to 1 defined, 0 not defined + * @return - 0 on success, -1 on error */ inline static int int_rve_defined(struct run_act_ctx* h, - struct sip_msg* msg, + struct sip_msg* msg, int* res, struct rval_expr* rve) { /* only a rval can be undefined, any expression consisting on more then one rval => defined */ if (likely(rve->op==RVE_RVAL_OP)) - return rv_defined(h, msg, &rve->left.rval, 0); - return 1; + return rv_defined(h, msg, res, &rve->left.rval, 0); + *res=1; + return 0; } @@ -1580,7 +1585,7 @@ int rval_expr_eval_int( struct run_act_ctx* h, struct sip_msg* msg, ret=-1; break; case RVE_DEFINED_OP: - ret=int_rve_defined(h, msg, rve->left.rve); + ret=int_rve_defined(h, msg, res, rve->left.rve); break; case RVE_STRLEN_OP: case RVE_STREMPTY_OP: @@ -2799,6 +2804,9 @@ int fix_rval_expr(void** p) case RVE_UMINUS_OP: /* unary operators */ case RVE_BOOL_OP: case RVE_LNOT_OP: + case RVE_STRLEN_OP: + case RVE_STREMPTY_OP: + case RVE_DEFINED_OP: ret=fix_rval_expr((void**)&rve->left.rve); if (ret<0) return ret; break;

15 years, 8 months

git:master: core: new script operators: defined, strlen, strempty

by Andrei Pelinescu-Onciul

Module: sip-router Branch: master Commit: d47990275e5f604560d7ef6d93e8f2056110d7c8 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=d479902… Author: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Committer: Andrei Pelinescu-Onciul <andrei(a)iptel.org> Date: Fri Apr 24 21:02:05 2009 +0200 core: new script operators: defined, strlen, strempty Support for 3 new operators: defined expr - returns true if expr is defined, and false if not. Note: only a standalone avp or pvar can be undefined, everything else is defined. strlen(expr) - returns the lenght of expr evaluated as string. strempty(expr) - returns true if expr evaluates to the empty string (equivalent to expr==""). Example: if (defined $v) $len=strlen($v); else $len=0; --- NEWS | 14 ++++++++++++-- cfg.lex | 7 +++++++ cfg.y | 11 +++++++++++ 3 files changed, 30 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index ba832bf..fade123 100644 --- a/NEWS +++ b/NEWS @@ -6,6 +6,14 @@ $Id$ sip-router changes core: + - new script operators: defined, strlen, strempty + defined expr - returns true if expr is defined, and false if not. + Note: only a standalone avp or pvar can be + undefined, everything else is defined. + strlen(expr) - returns the lenght of expr evaluated as string. + strempty(expr) - returns true if expr evaluates to the empty + string (equivalent to expr==""). + e.g.: if (defined $v && !strempty($v)) $len=strlen($v); - module search path support: loadpath takes now a list of directories separated by ':'. The list is searched in-order. For each directory d $d/${module_name}.so and $d/${module_name}/${module_name}.so are tried. @@ -23,11 +31,13 @@ config script changes: - support for kamailio style pvars - C-like switch()/case (integer only) - while() - - max_while_loops - maximum iterations allowed for a while, can be changed - at runtime. Default 100. build system: - multiple modules directories are now supported (defined in Makefile.dirs) +new config variables: + - max_while_loops - maximum iterations allowed for a while (can be changed + at runtime). Default 100. + diff --git a/cfg.lex b/cfg.lex index 9f42697..b1f9c55 100644 --- a/cfg.lex +++ b/cfg.lex @@ -78,6 +78,7 @@ * 2008-11-28 added support for kamailio pvars and avp/pvar guessing (andrei) * 2008-12-11 added support for "string1" "string2" (andrei) * 2009-03-10 added SET_USERPHONE action (Miklos) + * 2009-04-24 addd strlen, strempty and defined operators (andrei) */ @@ -244,6 +245,9 @@ LOG_OR "or"|"||" BIN_OR "|" PLUS "+" MINUS "-" +STRLEN "strlen" +STREMPTY "strempty" +DEFINED "defined" /* Attribute specification */ ATTR_MARK "%" @@ -765,6 +769,9 @@ EAT_ABLE [\ \t\b\r] <INITIAL>{BIN_OR} { count(); return BIN_OR; } <INITIAL>{PLUS} { count(); return PLUS; } <INITIAL>{MINUS} { count(); return MINUS; } +<INITIAL>{STRLEN} { count(); return STRLEN; } +<INITIAL>{STREMPTY} { count(); return STREMPTY; } +<INITIAL>{DEFINED} { count(); return DEFINED; } <INITIAL>{SELECT_MARK} { count(); state = SELECT_S; BEGIN(SELECT); return SELECT_MARK; } <SELECT>{ID} { count(); addstr(&s_buf, yytext, yyleng); diff --git a/cfg.y b/cfg.y index de7643d..a281052 100644 --- a/cfg.y +++ b/cfg.y @@ -489,8 +489,13 @@ static int case_check_default(struct case_stms* stms); %left PLUS MINUS %left STAR SLASH %right NOT +%right DEFINED %left DOT +/* no precedence, they use () */ +%token STRLEN +%token STREMPTY + /* values */ %token <intval> NUMBER %token <strval> ID @@ -2247,6 +2252,9 @@ rval_expr: rval { $$=$1; | rval_expr LOG_AND rval_expr { $$=mk_rve2(RVE_LAND_OP, $1, $3);} | rval_expr LOG_OR rval_expr { $$=mk_rve2(RVE_LOR_OP, $1, $3);} | LPAREN rval_expr RPAREN { $$=$2;} + | STRLEN LPAREN rval_expr RPAREN { $$=mk_rve1(RVE_STRLEN_OP, $3);} + | STREMPTY LPAREN rval_expr RPAREN {$$=mk_rve1(RVE_STREMPTY_OP, $3);} + | DEFINED rval_expr { $$=mk_rve1(RVE_DEFINED_OP, $2);} | rve_un_op %prec NOT error { yyerror("bad expression"); } | rval_expr PLUS error { yyerror("bad expression"); } | rval_expr MINUS error { yyerror("bad expression"); } @@ -2260,6 +2268,9 @@ rval_expr: rval { $$=$1; { yyerror("bad expression"); } | rval_expr LOG_AND error { yyerror("bad expression"); } | rval_expr LOG_OR error { yyerror("bad expression"); } + | STRLEN LPAREN error RPAREN { yyerror("bad expression"); } + | STREMPTY LPAREN error RPAREN { yyerror("bad expression"); } + | DEFINED error { yyerror("bad expression"); } ; assign_action: lval assign_op rval_expr { $$=mk_action($2, 2, LVAL_ST, $1,

15 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev