sr-dev

sr-dev@lists.kamailio.org

12 participants
44183 discussions

git:janakj/bdb: - disable big integer (DB_BIGINT) support for non SQL DB modules for now

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: e4a39affff2140f41c031c94610236718efb7e03 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e4a39af… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Wed Sep 24 11:02:42 2008 +0000 - disable big integer (DB_BIGINT) support for non SQL DB modules for now - if such a value is used, an error will be returned and also logged git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@4986 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/bdb_res.c | 6 ++++++ modules/db_berkeley/bdb_val.c | 4 ++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/modules/db_berkeley/bdb_res.c b/modules/db_berkeley/bdb_res.c index c165122..93a408b 100644 --- a/modules/db_berkeley/bdb_res.c +++ b/modules/db_berkeley/bdb_res.c @@ -424,6 +424,9 @@ int bdb_is_neq_type(db_type_t _t0, db_type_t _t1) case DB_INT: if(_t0==DB_DATETIME || _t0==DB_BITMAP) return 0; + case DB_BIGINT: + LM_ERR("BIGINT not supported"); + return 0; case DB_DATETIME: if(_t0==DB_INT) return 0; @@ -514,6 +517,9 @@ int bdb_cmp_val(db_val_t* _vp, db_val_t* _v) case DB_INT: return (_vp->val.int_val<_v->val.int_val)?-1: (_vp->val.int_val>_v->val.int_val)?1:0; + case DB_BIGINT: + LM_ERR("BIGINT not supported"); + return -1; case DB_DOUBLE: return (_vp->val.double_val<_v->val.double_val)?-1: (_vp->val.double_val>_v->val.double_val)?1:0; diff --git a/modules/db_berkeley/bdb_val.c b/modules/db_berkeley/bdb_val.c index 1e239ed..1f20c9c 100644 --- a/modules/db_berkeley/bdb_val.c +++ b/modules/db_berkeley/bdb_val.c @@ -112,6 +112,10 @@ int bdb_str2val(db_type_t _t, db_val_t* _v, char* _s, int _l) } break; + case DB_BIGINT: + LM_ERR("BIGINT not supported"); + return -1; + case DB_BITMAP: if (db_str2int(_s, &VAL_INT(_v)) < 0) { LM_ERR("Error while converting BITMAP value from string\n");

15 years, 10 months

git:janakj/bdb: - port from opensips r4526, credits goes to bogdan

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: 49371467f5b3aaea20bcb1d4e18ac5a268812328 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=4937146… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Wed Aug 6 15:32:44 2008 +0000 - port from opensips r4526, credits goes to bogdan - 64bits compile warnings fixed git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@4618 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/bdb_res.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/db_berkeley/bdb_res.c b/modules/db_berkeley/bdb_res.c index cc5e7c3..c165122 100644 --- a/modules/db_berkeley/bdb_res.c +++ b/modules/db_berkeley/bdb_res.c @@ -74,8 +74,8 @@ int bdb_get_columns(table_p _tp, db_res_t* _res, int* _lres, int _nc) db_free_columns(_res); return -3; } - LM_DBG("allocate %d bytes for RES_NAMES[%d] at %p\n", sizeof(str), col, - RES_NAMES(_res)[col]); + LM_DBG("allocate %lu bytes for RES_NAMES[%d] at %p\n", + (unsigned long)sizeof(str), col, RES_NAMES(_res)[col]); /* The pointer that is here returned is part of the result structure. */ RES_NAMES(_res)[col]->s = cp->name.s;

15 years, 10 months

git:janakj/bdb: - fix link entity names, patch from Carsten Gross

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: 3f9123af99a5ced4eff8d253dcaeffbc73ccd61e URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3f9123a… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Thu Aug 7 09:15:08 2008 +0000 - fix link entity names, patch from Carsten Gross - regenerate READMEs git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@4630 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/README | 149 +++++++++++++++++++++---------------------- 1 files changed, 73 insertions(+), 76 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=3f9…

15 years, 10 months

git:janakj/bdb: - fix compilation on OpenBSD, related to missing includes paths and wrong

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: efadf6d6dabf6f6c5b11fd7603df545677a00129 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=efadf6d… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Oct 21 09:23:07 2008 +0000 - fix compilation on OpenBSD, related to missing includes paths and wrong order of headers, patches from Jason Creighton, jcreigh at gmail dot com - seas: move stdio.h include before <netinet/in.h>, closes #2183510 - ldap: also include localbase to Makefile, closes #2183544 - h350: also include localbase to Makefile, closes #2183551 - db_berkeley: add OpenBSD include directory to Makefile, closes #2183577 git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@5099 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/modules/db_berkeley/Makefile b/modules/db_berkeley/Makefile index 5671867..5f72c5a 100644 --- a/modules/db_berkeley/Makefile +++ b/modules/db_berkeley/Makefile @@ -8,7 +8,7 @@ # extra debug messages # -DBDB_EXTRA_DEBUG is optional DEFS +=-I$(LOCALBASE)/include -I$(LOCALBASE)/BerkeleyDB.4.6/include \ - -I$(SYSBASE)/include + -I$(LOCALBASE)/include/db4 -I$(SYSBASE)/include include ../../Makefile.defs

15 years, 10 months

git:janakj/bdb: - remove not reached return statement at the end of val2str functions

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: a59602242641e2d4df4763409da5fa5a36a01a85 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a596022… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Fri Sep 19 11:56:49 2008 +0000 - remove not reached return statement at the end of val2str functions git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@4965 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/bdb_val.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/modules/db_berkeley/bdb_val.c b/modules/db_berkeley/bdb_val.c index 3d568da..1e239ed 100644 --- a/modules/db_berkeley/bdb_val.c +++ b/modules/db_berkeley/bdb_val.c @@ -279,5 +279,4 @@ int bdb_val2str(db_val_t* _v, char* _s, int* _len) LM_DBG("Unknown data type\n"); return -8; } - return -9; }

15 years, 10 months

git:janakj/bdb: - unify common rows and row allocation functionality in the DB API core

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: 423e2078e1fb99c4f5bd2575ba0d739c96d159df URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=423e207… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Dec 15 16:33:22 2008 +0000 - unify common rows and row allocation functionality in the DB API core git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@5362 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/bdb_res.c | 31 ++++++------------------------- 1 files changed, 6 insertions(+), 25 deletions(-) diff --git a/modules/db_berkeley/bdb_res.c b/modules/db_berkeley/bdb_res.c index 93a408b..0049d7b 100644 --- a/modules/db_berkeley/bdb_res.c +++ b/modules/db_berkeley/bdb_res.c @@ -120,20 +120,10 @@ int bdb_convert_row(db_res_t* _res, char *bdb_result, int* _lres) /* Save the number of rows in the current fetch */ RES_ROW_N(_res) = 1; - /* Allocate storage to hold the bdb result values */ - len = sizeof(db_val_t) * RES_COL_N(_res); - ROW_VALUES(row) = (db_val_t*)pkg_malloc(len); - - if (!ROW_VALUES(row)) { - LM_ERR("no private memory left\n"); - return -1; + if (db_allocate_row(_res, row) != 0) { + LM_ERR("could not allocate row"); + return -2; } - LM_DBG("allocate %d bytes for row values at %p\n", len, ROW_VALUES(row)); - memset(ROW_VALUES(row), 0, len); - - /* Save the number of columns in the ROW structure */ - ROW_N(row) = RES_COL_N(_res); - /* * Allocate an array of pointers one per column. * It that will be used to hold the address of the string representation of each column. @@ -257,19 +247,10 @@ int bdb_append_row(db_res_t* _res, char *bdb_result, int* _lres, int _rx) row = &(RES_ROWS(_res)[_rx]); - /* Allocate storage to hold the bdb result values */ - len = sizeof(db_val_t) * RES_COL_N(_res); - ROW_VALUES(row) = (db_val_t*)pkg_malloc(len); - - if (!ROW_VALUES(row)) { - LM_ERR("no private memory left\n"); - return -1; + if (db_allocate_row(_res, row) != 0) { + LM_ERR("could not allocate row"); + return -2; } - LM_DBG("allocate %d bytes for row values at %p\n", len, ROW_VALUES(row)); - memset(ROW_VALUES(row), 0, len); - - /* Save the number of columns in the ROW structure */ - ROW_N(row) = RES_COL_N(_res); /* * Allocate an array of pointers one per column.

15 years, 10 months

git:janakj/bdb: further cleanups in core database API

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: 3904bb0de19f991292c69e61ebfe387d2d10809f URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3904bb0… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Mon Jan 7 14:26:27 2008 +0000 further cleanups in core database API - move use_table and close function for SQL DBs to core - move query, raw_query, insert, update, delete functions for SQL DBs to core - all this functions were almost identical implemented in the three DB, this functions uses now a function pointer based interface to do the work - the use_table functions from dbtext and db_berkeley uses also now the core API - move result management function from db_col to db_res to the other result management functions, they are not useful alone - change postgres module to match more the structure of mysql and unixodbc, remove the 'PARANOID' #define, the other modules don't have this and prefix all functions with db_postgres, make this more consistent to mysql module - prefix all functions in unixodbc module with db_unixodbc, make this consistent to the other modules, cleanup the namespace - prefix val2str function in mysql with db_mysql too - move the SQL_BUF_LENGTH to core API, all modules need this - remove the static SQL char buffer from postgres and unixodbc, uses the one provided from the core API - move documentation from db/doc to API files in doxygen format - improve and extend documentation for the whole API - make database API const correct, to guard against implementation errors and allow better compiler optimizations - change interface free_connection function in SQL DBs to connection structure to allow the usage of core API do_close - fix indention for postgres driver and make logging messages consistent - remove now unneeded system header includes for SQL DBs - remove transaction related code from postgres driver, this is not used at all and according to Klaus also brings no performance benefit if used. - probably some other smaller cleanups Tested with the testcases, so basic functionality should work.. Please test! :-) git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@3506 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/db_berkeley.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/modules/db_berkeley/db_berkeley.c b/modules/db_berkeley/db_berkeley.c index b4ccc7c..8049baf 100644 --- a/modules/db_berkeley/db_berkeley.c +++ b/modules/db_berkeley/db_berkeley.c @@ -134,11 +134,7 @@ static void destroy(void) int bdb_use_table(db_con_t* _h, const char* _t) { - if ((!_h) || (!_t)) - return -1; - - CON_TABLE(_h) = _t; - return 0; + return db_use_table(_h, _t); } /*

15 years, 10 months

git:janakj/bdb: - port database interface (almost) complete from ' const char*' to 'str'

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: 49ca652fc15332b9451a119f87d88b397d1ed8cb URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=49ca652… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Tue Jan 22 13:55:43 2008 +0000 - port database interface (almost) complete from 'const char*' to 'str' for more safety (e.g. not null terminated strings) and performance (save strlen calls in core and library code) - adapt existing modules to use the new interface - change bind_dbmod and use_table function to the naming scheme of the other functions of the API - port existing module to use 'str' values for database related parameters - if modules uses already 'str' functions internally, remove the unnecessary temporary variables - make functions and parameter that needs only locally be used static - introduce new column variables needed for the keys for modules that don't have them already, this could be used to make them configurable later on - add 'const' to more db related functions - fix postgres driver, async queries must be finished, otherwise the next one will not complete - smaller whitespace and formatting changes and cleanups all over the place - reviewed and tested with testcases, but probably not error free because of the change size - basic DB operations should work, but no extensive load testing has yet be done, as some work still remains: - remove dead code and superflous comments in postgres driver - clean up memory management, at the moment there exists two flavors: don't copy that much (mysql, unixodbc), don't trust the driver, copy everything (postgres, db_berkeley) - after this is unified, then only one implementation for the memory management of the db API could be used for all modules - Foundations of this change have been created from Frederick Bullik, Frederick.Bullik at 1und1 dot de - Please review and test. git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@3563 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/bdb_res.c | 61 +++++++++++++++++++++++-------------- modules/db_berkeley/db_berkeley.c | 50 ++++++++++-------------------- modules/db_berkeley/db_berkeley.h | 4 +- 3 files changed, 56 insertions(+), 59 deletions(-) diff --git a/modules/db_berkeley/bdb_res.c b/modules/db_berkeley/bdb_res.c index 78f2ac5..0e80d41 100644 --- a/modules/db_berkeley/bdb_res.c +++ b/modules/db_berkeley/bdb_res.c @@ -34,9 +34,6 @@ #include "bdb_res.h" -/** -* -*/ int bdb_get_columns(table_p _tp, db_res_t* _res, int* _lres, int _nc) { int col, len; @@ -105,24 +102,40 @@ int bdb_get_columns(table_p _tp, db_res_t* _res, int* _lres, int _nc) column_p cp = NULL; cp = (_lres) ? _tp->colp[_lres[col]] : _tp->colp[col]; len = cp->name.len; - RES_NAMES(_res)[col] = pkg_malloc(len+1); + + RES_NAMES(_res)[col] = (str*)pkg_malloc(sizeof(str)); + if (! RES_NAMES(_res)[col]) { + LM_ERR("no private memory left\n"); + pkg_free(RES_NAMES(_res)); + pkg_free(RES_TYPES(_res)); + // FIXME we should also free all previous allocated RES_NAMES[col] + return -5; + } #ifdef BDB_EXTRA_DEBUG LM_DBG("%p=pkg_malloc(%d) RES_NAMES[%d]\n" - , RES_NAMES(_res)[col], len+1, col); + , RES_NAMES(_res)[col], len, col); +#endif + + RES_NAMES(_res)[col]->s = (char*)pkg_malloc(len); + +#ifdef BDB_EXTRA_DEBUG + LM_DBG("%p=pkg_malloc(%d) RES_NAMES[%d]->s\n" + , RES_NAMES(_res)[col]->s, len, col); #endif - if (! RES_NAMES(_res)[col]) + if (! RES_NAMES(_res)[col]->s) { LM_ERR("Failed to allocate %d bytes to hold column name\n", len+1); return -1; } - memset((char *)RES_NAMES(_res)[col], 0, len+1); - strncpy((char *)RES_NAMES(_res)[col], cp->name.s, len); + memset((char *)RES_NAMES(_res)[col]->s, 0, len); + strncpy((char *)RES_NAMES(_res)[col]->s, cp->name.s, len); + RES_NAMES(_res)[col]->len = len; - LM_DBG("RES_NAMES(%p)[%d]=[%s]\n", RES_NAMES(_res)[col] - , col, RES_NAMES(_res)[col]); + LM_DBG("RES_NAMES(%p)[%d]=[%.*s]\n", RES_NAMES(_res)[col] + , col, RES_NAMES(_res)[col]->len, RES_NAMES(_res)[col]->s); RES_TYPES(_res)[col] = cp->type; } @@ -136,7 +149,7 @@ int bdb_get_columns(table_p _tp, db_res_t* _res, int* _lres, int _nc) */ int bdb_convert_row(db_res_t* _res, char *bdb_result, int* _lres) { - int col, len, i, j; + int col, len, i, j; char **row_buf, *s; db_row_t* row = NULL; col = len = i = j = 0; @@ -275,8 +288,8 @@ int bdb_convert_row(db_res_t* _res, char *bdb_result, int* _lres) break; default: #ifdef BDB_EXTRA_DEBUG - LM_DBG("col[%d] Col[%s] Type[%d] Freeing row_buf[%p]\n", col - , RES_NAMES(_res)[col], RES_TYPES(_res)[col] + LM_DBG("col[%d] Col[%.*s] Type[%d] Freeing row_buf[%p]\n", col + , RES_NAMES(_res)[col]->len, RES_NAMES(_res)[col]->s, RES_TYPES(_res)[col] , (char*) row_buf[col]); LM_DBG("%p=pkg_free() row_buf[%d]\n", (char *)row_buf[col], col); @@ -440,8 +453,8 @@ int bdb_append_row(db_res_t* _res, char *bdb_result, int* _lres, int _rx) if (RES_TYPES(_res)[col] != DB_STRING) { #ifdef BDB_EXTRA_DEBUG - LM_DBG("[%d][%d] Col[%s] Type[%d] Freeing row_buf[%i]\n" - , _rx, col, RES_NAMES(_res)[col], RES_TYPES(_res)[col], col); + LM_DBG("[%d][%d] Col[%.*s] Type[%d] Freeing row_buf[%i]\n" + , _rx, col, RES_NAMES(_res)[col]->len, RES_NAMES(_res)[col]->s, RES_TYPES(_res)[col], col); #endif pkg_free((char *)row_buf[col]); } @@ -478,8 +491,8 @@ int* bdb_get_colmap(table_p _dtp, db_key_t* _k, int _n) { for(j=0; j<_dtp->ncols; j++) { - if(strlen(_k[i])==_dtp->colp[j]->name.len - && !strncasecmp(_k[i], _dtp->colp[j]->name.s, + if(_k[i]->len==_dtp->colp[j]->name.len + && !strncasecmp(_k[i]->s, _dtp->colp[j]->name.s, _dtp->colp[j]->name.len)) { _lref[i] = j; @@ -489,7 +502,7 @@ int* bdb_get_colmap(table_p _dtp, db_key_t* _k, int _n) if(i>=_dtp->ncols) { - LM_DBG("ERROR column <%s> not found\n", _k[i]); + LM_DBG("ERROR column <%.*s> not found\n", _k[i]->len, _k[i]->s); pkg_free(_lref); return NULL; } @@ -592,13 +605,15 @@ int bdb_free_columns(db_res_t* _res) for(col = 0; col < RES_COL_N(_res); col++) { #ifdef BDB_EXTRA_DEBUG - LM_DBG("Freeing RES_NAMES(%p)[%d] -> free(%p) '%s'\n", _res - , col, RES_NAMES(_res)[col], RES_NAMES(_res)[col]); LM_DBG("%p=pkg_free() RES_NAMES[%d]\n", RES_NAMES(_res)[col], col); -#endif - + LM_DBG("Freeing RES_NAMES(%p)[%d] -> free(%p) '%s'\n", _res + , col, RES_NAMES(_res)[col], RES_NAMES(_res)[col]->s); + LM_DBG("%p=pkg_free() RES_NAMES[%d]->s\n", RES_NAMES(_res)[col]->s, col); +#endif + + pkg_free((char *)RES_NAMES(_res)[col]->s); pkg_free((char *)RES_NAMES(_res)[col]); - RES_NAMES(_res)[col] = (char *)NULL; + RES_NAMES(_res)[col] = (str*)NULL; } if (RES_NAMES(_res)) diff --git a/modules/db_berkeley/db_berkeley.c b/modules/db_berkeley/db_berkeley.c index 8049baf..74fea05 100644 --- a/modules/db_berkeley/db_berkeley.c +++ b/modules/db_berkeley/db_berkeley.c @@ -33,6 +33,7 @@ #include "../../str.h" +#include "../../ut.h" #include "../../mem/mem.h" #include "../../sr_module.h" @@ -132,7 +133,7 @@ static void destroy(void) bdblib_destroy(); } -int bdb_use_table(db_con_t* _h, const char* _t) +int bdb_use_table(db_con_t* _h, const str* _t) { return db_use_table(_h, _t); } @@ -140,17 +141,19 @@ int bdb_use_table(db_con_t* _h, const char* _t) /* * Initialize database connection */ -db_con_t* bdb_init(const char* _sqlurl) +db_con_t* bdb_init(const str* _sqlurl) { db_con_t* _res; str _s; char bdb_path[BDB_PATH_LEN]; - if (!_sqlurl) - return NULL; + if (!_sqlurl || !_sqlurl->s) { + LM_ERR("invalid parameter value\n"); + return 0; + } - _s.s = (char*)_sqlurl; - _s.len = strlen(_sqlurl); + _s.s = _sqlurl->s; + _s.len = _sqlurl->len; if(_s.len <= BDB_ID_LEN || strncmp(_s.s, BDB_ID, BDB_ID_LEN)!=0) { LM_ERR("invalid database URL - should be:" @@ -237,7 +240,6 @@ int bdb_reload(char* _n) */ void bdb_check_reload(db_con_t* _con) { - str s; char* p; int rc, len; @@ -277,8 +279,8 @@ void bdb_check_reload(db_con_t* _con) p++; /*get table name*/ - s.s = (char*)CON_TABLE(_con); - s.len = strlen(CON_TABLE(_con)); + s.s = CON_TABLE(_con)->s; + s.len = CON_TABLE(_con)->len; len+=s.len; if((len>MAX_ROW_SIZE) || (s.len > MAX_TABLENAME_SIZE) ) @@ -345,7 +347,6 @@ int bdb_query(db_con_t* _con, db_key_t* _k, db_op_t* _op, db_val_t* _v, u_int32_t i, len, ret; int klen=MAX_ROW_SIZE; int *lkey=NULL, *lres=NULL; - str s; DBT key, data; DB *db; DBC *dbcp; @@ -363,10 +364,7 @@ int bdb_query(db_con_t* _con, db_key_t* _k, db_op_t* _op, db_val_t* _v, if(auto_reload) bdb_check_reload(_con); - s.s = (char*)CON_TABLE(_con); - s.len = strlen(CON_TABLE(_con)); - - _tbc = bdblib_get_table(BDB_CON_CONNECTION(_con), &s); + _tbc = bdblib_get_table(BDB_CON_CONNECTION(_con), (str*)CON_TABLE(_con)); if(!_tbc) { LM_WARN("table does not exist!\n"); return -1; @@ -629,7 +627,6 @@ int bdb_insert(db_con_t* _h, db_key_t* _k, db_val_t* _v, int _n) int *lkey=NULL; DBT key, data; DB *db; - str s; i = j = ret = 0; klen=MAX_ROW_SIZE; @@ -647,10 +644,7 @@ int bdb_insert(db_con_t* _h, db_key_t* _k, db_val_t* _v, int _n) return -2; } - s.s = (char*)CON_TABLE(_h); - s.len = strlen(CON_TABLE(_h)); - - _tbc = bdblib_get_table(BDB_CON_CONNECTION(_h), &s); + _tbc = bdblib_get_table(BDB_CON_CONNECTION(_h), (str*)CON_TABLE(_h)); if(!_tbc) { LM_WARN("table does not exist!\n"); return -3; @@ -769,7 +763,6 @@ int bdb_delete(db_con_t* _h, db_key_t* _k, db_op_t* _op, db_val_t* _v, int _n) DBT key; DB *db; DBC *dbcp; - str s; i = j = ret = 0; klen=MAX_ROW_SIZE; @@ -780,10 +773,7 @@ int bdb_delete(db_con_t* _h, db_key_t* _k, db_op_t* _op, db_val_t* _v, int _n) if ((!_h) || !CON_TABLE(_h)) return -1; - s.s = (char*)CON_TABLE(_h); - s.len = strlen(CON_TABLE(_h)); - - _tbc = bdblib_get_table(BDB_CON_CONNECTION(_h), &s); + _tbc = bdblib_get_table(BDB_CON_CONNECTION(_h), (str*)CON_TABLE(_h)); if(!_tbc) { LM_WARN("table does not exist!\n"); return -3; @@ -901,17 +891,13 @@ int _bdb_delete_cursor(db_con_t* _h, db_key_t* _k, db_op_t* _op, db_val_t* _v, i DB *db; DBC *dbcp; int *lkey=NULL; - str s; i = ret = 0; if ((!_h) || !CON_TABLE(_h)) return -1; - s.s = (char*)CON_TABLE(_h); - s.len = strlen(CON_TABLE(_h)); - - _tbc = bdblib_get_table(BDB_CON_CONNECTION(_h), &s); + _tbc = bdblib_get_table(BDB_CON_CONNECTION(_h), (str*)CON_TABLE(_h)); if(!_tbc) { LM_WARN("table does not exist!\n"); return -3; @@ -1023,7 +1009,6 @@ error: int bdb_update(db_con_t* _con, db_key_t* _k, db_op_t* _op, db_val_t* _v, db_key_t* _uk, db_val_t* _uv, int _n, int _un) { - str s; char *c, *t; int ret, i, qcol, len, sum; int *lkey=NULL; @@ -1039,11 +1024,8 @@ int bdb_update(db_con_t* _con, db_key_t* _k, db_op_t* _op, db_val_t* _v, if (!_con || !CON_TABLE(_con) || !_uk || !_uv || _un <= 0) return -1; - - s.s = (char*)CON_TABLE(_con); - s.len = strlen(CON_TABLE(_con)); - _tbc = bdblib_get_table(BDB_CON_CONNECTION(_con), &s); + _tbc = bdblib_get_table(BDB_CON_CONNECTION(_con), (str*)CON_TABLE(_con)); if(!_tbc) { LM_ERR("table does not exist\n"); return -1; diff --git a/modules/db_berkeley/db_berkeley.h b/modules/db_berkeley/db_berkeley.h index a9f9793..869983a 100644 --- a/modules/db_berkeley/db_berkeley.h +++ b/modules/db_berkeley/db_berkeley.h @@ -41,12 +41,12 @@ int bdb_reload(char* _n); void bdb_check_reload(db_con_t* _con); -int bdb_use_table(db_con_t* _h, const char* _t); +int bdb_use_table(db_con_t* _h, const str* _t); /* * Initialize database connection */ -db_con_t* bdb_init(const char* _sqlurl); +db_con_t* bdb_init(const str* _sqlurl); /*

15 years, 10 months

git:janakj/bdb: further changes after the db name change

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: bbd5ceca0c61b5346e38e7c8a0efbcb4ea9a0a9d URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=bbd5cec… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Wed Feb 6 15:46:09 2008 +0000 further changes after the db name change - update INSTALL file - fix Makefile skip modules variable - fix module Makefile, lib name - change db_bind_mod to add the db prefix in the function - change db url defines in db_berkeley and db_text - change database modules names in module struct - fix debian packaging - fix tests git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@3642 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/README | 4 ++-- modules/db_berkeley/db_berkeley.c | 2 +- modules/db_berkeley/doc/db_berkeley_user.sgml | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/modules/db_berkeley/README b/modules/db_berkeley/README index 1f7dda5..4cc84b4 100644 --- a/modules/db_berkeley/README +++ b/modules/db_berkeley/README @@ -228,8 +228,8 @@ by default none is loaded Modify the OpenSER configuration file to use db_berkeley module. The database URL for modules must be the path to the directory where the Berkeley DB table-files are located, - prefixed by "db_berkeley://", e.g., - "db_berkeley:///usr/local/etc/openser/db_berkeley". + prefixed by "berkeley://", e.g., + "berkeley:///usr/local/etc/openser/db_berkeley". A couple other IMPORTANT things to consider are the 'db_mode' and the 'use_domain' modparams. The description of these diff --git a/modules/db_berkeley/db_berkeley.c b/modules/db_berkeley/db_berkeley.c index 74fea05..7c69751 100644 --- a/modules/db_berkeley/db_berkeley.c +++ b/modules/db_berkeley/db_berkeley.c @@ -47,7 +47,7 @@ #define CFG_DIR "/tmp" #endif -#define BDB_ID "db_berkeley://" +#define BDB_ID "berkeley://" #define BDB_ID_LEN (sizeof(BDB_ID)-1) #define BDB_PATH_LEN 256 diff --git a/modules/db_berkeley/doc/db_berkeley_user.sgml b/modules/db_berkeley/doc/db_berkeley_user.sgml index c08222f..b2bd6e3 100644 --- a/modules/db_berkeley/doc/db_berkeley_user.sgml +++ b/modules/db_berkeley/doc/db_berkeley_user.sgml @@ -253,8 +253,8 @@ modparam("db_berkeley", "journal_roll_interval", 3600) <para> Modify the OpenSER configuration file to use db_berkeley module. The database URL for modules must be the path to the directory where - the Berkeley DB table-files are located, prefixed by "db_berkeley://", - e.g., "db_berkeley:///usr/local/etc/openser/db_berkeley". + the Berkeley DB table-files are located, prefixed by "berkeley://", + e.g., "berkeley:///usr/local/etc/openser/db_berkeley". </para> <para>

15 years, 10 months

git:janakj/bdb: - port db_text and db_berkeley to the new core DB API

by Jan Janak

Module: sip-router Branch: janakj/bdb Commit: 44dab431e3f9b04d33d5d0ea88f90840ad4ef464 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=44dab43… Author: Henning Westerholt <henning.westerholt(a)1und1.de> Committer: Henning Westerholt <henning.westerholt(a)1und1.de> Date: Fri Feb 8 14:32:23 2008 +0000 - port db_text and db_berkeley to the new core DB API - remove free_* methods that are not needed anymore - adjust structure to the other SQL based modules - basic queries works, but otherwise not that much tested git-svn-id: https://openser.svn.sourceforge.net/svnroot/openser/trunk@3668 689a6050-402a-0410-94f2-e92a70836424 --- modules/db_berkeley/bdb_res.c | 426 +++++++++---------------------------- modules/db_berkeley/bdb_res.h | 5 - modules/db_berkeley/bdb_val.c | 2 + modules/db_berkeley/db_berkeley.c | 10 +- 4 files changed, 107 insertions(+), 336 deletions(-) Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=44d…

15 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev