sr-dev

sr-dev@lists.kamailio.org

3 participants
45453 discussions

git:master:98feec09: tls: implement match_domain,match_connections_domain hooks
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 98feec09b3cc0fe67d1a2f8484b5c9583a4beb21 URL: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 tls: implement match_domain,match_connections_domain hooks * save tls_domain_str() to the tls_extra_data and use it for connections matching * rpc tls.list: add 'dom' attribute --- Modified: src/modules/tls/tls_mod.c Modified: src/modules/tls/tls_rpc.c Modified: src/modules/tls/tls_server.c Modified: src/modules/tls/tls_server.h --- Diff: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95… Patch: https://github.com/kamailio/kamailio/commit/98feec09b3cc0fe67d1a2f8484b5c95…

1 0

git:master:69f22ad4: core: support tls connection domain matching
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 69f22ad49be1302c884f47903d0e32d8491912fd URL: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d… Author: Michael Furmur <furmur(a)pm.me> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:32:35+02:00 core: support tls connection domain matching * add tls_connection_match_domain core option (default: 0) * add match_domain, match_connections_domain tls hooks * modify _tcpconn_find, _tcpconn_add_alias_unsafe to use newly added tls hooks --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/globals.h Modified: src/core/tcp_main.c Modified: src/core/tls_hooks.h Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d… Patch: https://github.com/kamailio/kamailio/commit/69f22ad49be1302c884f47903d0e32d…

1 0

[kamailio/kamailio] cdp: Cast time for printing and Improve cdp docs (PR #4227)
by Xenofon Karamanos 06 May '25

06 May '25

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4226 #### Description  - Improve and add missing function documentation `list_peers`. - Use correct identifier in `struct_add` rpc function and cast `time_t` for time_t field. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4227 -- Commit Summary -- * cdp: Cast time_t and use 'L' (long long) identifier in rpc function. * cdp/docs: Add missing list_peers function -- File Changes -- M src/modules/cdp/cdp_rpc.c (4) M src/modules/cdp/doc/cdp_admin.xml (29) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4227.patch https://github.com/kamailio/kamailio/pull/4227.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4227 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4227(a)github.com>

2 2

git:master:11275ccb: cdp: docs: Add missing list_peers function
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 11275ccb94cdddfec49191eaf80b2bc2f083c284 URL: https://github.com/kamailio/kamailio/commit/11275ccb94cdddfec49191eaf80b2bc… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:31:54+02:00 cdp: docs: Add missing list_peers function - Fix some typos - Remove unused section 7.2 --- Modified: src/modules/cdp/doc/cdp_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/11275ccb94cdddfec49191eaf80b2bc… Patch: https://github.com/kamailio/kamailio/commit/11275ccb94cdddfec49191eaf80b2bc… --- diff --git a/src/modules/cdp/doc/cdp_admin.xml b/src/modules/cdp/doc/cdp_admin.xml index d1e313247e1..afc93be5066 100644 --- a/src/modules/cdp/doc/cdp_admin.xml +++ b/src/modules/cdp/doc/cdp_admin.xml @@ -365,7 +365,7 @@ if(!cdp_check_peer("hss.mnc001.mcc001.3gppnetwork.org")) { </listitem> </itemizedlist> <example> - <title><function>cdp_check_peer</function> usage</title> + <title><function>cdp_has_app</function> usage</title> <programlisting format="linespecific"> ... if(!cdp_has_app("10415", "4")) { @@ -376,7 +376,7 @@ if(!cdp_has_app("10415", "4")) { </programlisting> </example> <example> - <title><function>cdp_check_peer</function> usage</title> + <title><function>cdp_has_app</function> usage</title> <programlisting format="linespecific"> ... if(!cdp_has_app("16777216")) { @@ -392,7 +392,20 @@ if(!cdp_has_app("16777216")) { <section> <title>RPC Commands</title> - <para>exported RPC commands.</para> + <section id="cdp.states"> + <title>States</title> + <itemizedlist id="cdp.cdp_states" title="States"> + <listitem><para>Closed (0) - Not connected</para></listitem> + <listitem><para>Wait_Conn_Ack (1) - Connecting - waiting for Ack</para></listitem> + <listitem><para>Wait_I_CEA (2) - Connecting - waiting for Capabilities Exchange Answer</para></listitem> + <listitem><para>Wait_Conn_Ack_Elect (3) - Connecting - Acknowledged and going for Election</para></listitem> + <listitem><para>Wait_Returns (4) - Connecting - done</para></listitem> + <listitem><para>R_Open (5) - Connected as receiver</para></listitem> + <listitem><para>I_Open (6) - Connected as initiator</para></listitem> + <listitem><para>Closing (7) - Closing the connection</para></listitem> + </itemizedlist> + </section> + <para>Exported RPC commands.</para> <section> <title>cdp.disable_peer</title> @@ -405,6 +418,14 @@ if(!cdp_has_app("16777216")) { <para>enable/re-enable a diameter peer</para> </section> + + <section> + <title>cdp.list_peers</title> + <para>list all configured diameter peers</para> + <para> + State details can be found in the list above (<xref linkend="cdp.states" />) + </para> + </section> </section> <section> @@ -538,7 +559,5 @@ if(!cdp_has_app("16777216")) { </programlisting> </example> </section> - - <section/> </section> </chapter>

1 0

git:master:4e945720: cdp: Cast time_t and use 'L' (long long) identifier in rpc function.
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 4e94572059d46b6bdd6726abfd52cb59793f5b03 URL: https://github.com/kamailio/kamailio/commit/4e94572059d46b6bdd6726abfd52cb5… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:31:54+02:00 cdp: Cast time_t and use 'L' (long long) identifier in rpc function. --- Modified: src/modules/cdp/cdp_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/4e94572059d46b6bdd6726abfd52cb5… Patch: https://github.com/kamailio/kamailio/commit/4e94572059d46b6bdd6726abfd52cb5… --- diff --git a/src/modules/cdp/cdp_rpc.c b/src/modules/cdp/cdp_rpc.c index 576b1ba8fcc..8df60230c51 100644 --- a/src/modules/cdp/cdp_rpc.c +++ b/src/modules/cdp/cdp_rpc.c @@ -101,10 +101,10 @@ static void cdp_rpc_list_peers(rpc_t *rpc, void *ctx) lock_release(i->lock); return; } - if(rpc->struct_add(peerdetail_container, "ssd", "State", + if(rpc->struct_add(peerdetail_container, "ssL", "State", dp_states[(int)i->state], "Disabled", i->disabled ? "True" : "False", "Last used", - i->last_selected) + TIME_T_CAST(i->last_selected)) < 0) { rpc->fault(ctx, 500, "Internal error creating peer detail container struct");

1 0

[kamailio/kamailio] core: docs: Update type identifiers that can be used in the RPC API (PR #4228)
by Xenofon Karamanos 06 May '25

06 May '25

- format as well   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to issue #4227 #### Description  There was missing information of type identifiers that can be used in [rpc tutorial docs](https://www.kamailio.org/docs/docbooks/5.7.x/rpc_api/rpc_api.html#rpc…. This is an update to those docs. The most recent I could find was for 5.7. Maybe there is a need for manual updating the page? Also during the relevant PR #4227 , we found the `t` identifier is never used in the code. since it can overflow on 64bit systems due to being a `long` and not `int` type when saved/load, maybe we can remove it completely?. One can just cast the `time_t` to the relevant type and use the correct identifier as done in https://github.com/kamailio/kamailio/blob/2081b3aac394223b68b849fbac2a9e5ac… You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/4228 -- Commit Summary -- * Update type identifiers that can be used in the RPC API -- File Changes -- M doc/tutorials/rpc/kamailio_rpc.xml (86) -- Patch Links -- https://github.com/kamailio/kamailio/pull/4228.patch https://github.com/kamailio/kamailio/pull/4228.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/4228 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/4228(a)github.com>

2 3

git:master:9a8ab319: core: docs - Update type identifiers that can be used in the RPC API
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: 9a8ab3199488f02bd01e39bb6e13ef192321b37c URL: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1… Author: Xenofon Karamanos <xk(a)gilawa.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:31:05+02:00 core: docs - Update type identifiers that can be used in the RPC API - format as well --- Modified: doc/tutorials/rpc/kamailio_rpc.xml --- Diff: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1… Patch: https://github.com/kamailio/kamailio/commit/9a8ab3199488f02bd01e39bb6e13ef1…

1 0

git:master:c9fbf6f4: core: sdp - update start pointer only after len adjustment
by Daniel-Constantin Mierla 06 May '25

06 May '25

Module: kamailio Branch: master Commit: c9fbf6f46898dbb2a8413a1c9d824a56241f2288 URL: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-06T13:29:44+02:00 core: sdp - update start pointer only after len adjustment - len is adjusted first by the amount of chars consumed so far - start pointer is adjusted to start new search --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… Patch: https://github.com/kamailio/kamailio/commit/c9fbf6f46898dbb2a8413a1c9d824a5… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 2e7d996bc54..0d18d787242 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -330,8 +330,8 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) fl = space - start; - start = space + 1; len = len - (space - start + 1); + start = space + 1; space = memchr(start, 32, len); if(space == NULL) {

1 0

[kamailio/kamailio] core(sdp_helpr_funcs.c): always parsing a=candidate: as "no component … " (Issue #4229)
by space88man 06 May '25

06 May '25

space88man created an issue (kamailio/kamailio#4229)  ### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/4229 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/4229(a)github.com>

2 3

git:master:444fef80: core: sdp - removed invalid condition
by Daniel-Constantin Mierla 05 May '25

05 May '25

Module: kamailio Branch: master Commit: 444fef809c21b250402cfdbd48de65926ac6286a URL: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2025-05-05T16:48:21+02:00 core: sdp - removed invalid condition - introduced in commit 3198b66 - GH #4229 --- Modified: src/core/parser/sdp/sdp_helpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… Patch: https://github.com/kamailio/kamailio/commit/444fef809c21b250402cfdbd48de659… --- diff --git a/src/core/parser/sdp/sdp_helpr_funcs.c b/src/core/parser/sdp/sdp_helpr_funcs.c index 5e9b3f121ab..2e7d996bc54 100644 --- a/src/core/parser/sdp/sdp_helpr_funcs.c +++ b/src/core/parser/sdp/sdp_helpr_funcs.c @@ -332,10 +332,7 @@ int extract_candidate(str *body, sdp_stream_cell_t *stream) start = space + 1; len = len - (space - start + 1); - if(start + len > body->s + body->len) { - LM_ERR("no component in `a=candidate'\n"); - return -1; - } + space = memchr(start, 32, len); if(space == NULL) { LM_ERR("no component in `a=candidate'\n");

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev