[sr-dev] Re: [kamailio/kamailio] ims_icscf: add missing documents for database params (PR #3874)

@henningw commented on this pull request.

Thanks for the PR, I have added two comments related to the usage of database URLs.

@@ -71,7 +71,7 @@ stat_var *uar_replies_response_time = NULL;

stat_var *lir_replies_response_time = NULL;

//module parameters -char *ims_icscf_db_url = "mysql://icscf:heslo@localhost/hssdata"; /**< DB URL */ +char *ims_icscf_db_url = "mysql://kamailio:kamailiorw@localhost/kamailio"; /**< DB URL */

Consider using the correct define for it: DEFAULT_RODB_URL

•  <para>
  

+ If the db_url string is empty, the default database URL + will be used. + </para> + + <para> + <emphasis> + Default value is <quote>&defaultrodb;</quote>. + </emphasis> + </para> + + <example> + <title>Set <varname>db_url</varname> parameter</title> + <programlisting format="linespecific"> +... +modparam("ims_icscf", "db_url", "mysql://username:password@localhost/kamailio")

You could use also here the definition "&exampledb;