Homer can't relate callids encrypted and decrypted, originated by module topoh, issue https://groups.google.com/forum/#!topic/homer-discuss/1_a01BbgnD0
Issue fixed changing function sip_capture_store to decrypt callid and save decrypted callid in database. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/422
-- Commit Summary --
* Decrypt callid encrypted by topoh module before save in database
-- File Changes --
M modules/sipcapture/sipcapture.c (11) A modules/sipcapture/th_mask.c (179) A modules/sipcapture/th_mask.h (36)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/422.patch https://github.com/kamailio/kamailio/pull/422.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/422
thank you for your patch, but the th_ parameters should not be hardcoded, please add them to param_export_t params. As reference, use: https://github.com/kamailio/kamailio/blob/master/modules/topoh/topoh_mod.c#L... or https://github.com/kamailio/kamailio/blob/master/modules/sipcapture/sipcaptu...
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/422#issuecomment-160120952
Few more things that need to be done:
* the commit message must have the format as per guidelines at: * http://www.kamailio.org/wiki/devel/github-contributions#commit_message_forma... * this patch seems to just copy a lot of code from topoh module to sipcapture. It means that if there is a change in topoh, it needs to be resync'ed in sipcapture. This is not the right way to do. Better export an intermodule API in topoh and bind to that one from sipcapture. In this way, the code and parameters from topoh will be used by sipcapture. Sipcapture should get a new module parameter to control if it should bind or not to topoh.
You can look at sl module how it exports some functions (modules/sl/sl.h, the sl_api_t structure and the sl_load_api() function) and then at registrar module how it binds to sl in mod_init() and use sl functions.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/422#issuecomment-160122006
Re-implemented via exporting topoh module api -- see topoh_unmask parameter for sipcapture module. Testing is needed.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/422#issuecomment-179490043
Closed #422.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/422#event-538266427
-
Alexandr Dubovikov -
Daniel-Constantin Mierla
-
pseabra