#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Caller LIS server may use namepace prefix `gml` or any other. When created LOST request, then `location-info` payload created from `pidf-lo` and `p2` prefix namespace not used.
I suggest make some code cleanup and remove not used strings. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2584
-- Commit Summary --
* lost: removed not used namespace
-- File Changes --
M src/modules/lost/utilities.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2584.patch https://github.com/kamailio/kamailio/pull/2584.diff
The module includes a fallback in case `xpath` fails due to a malformed `pidf-lo` (observed at ETSI Plugtests events). In such a case it just looks for attributes like `lat/lon` (point) or `lat/lon/radius` (circle) and creates a new location object, which I guess requires a `gml` namespace, therefore I would suggest the following change:
` if(loc->xpath == NULL) {xmlNewProp(ptrFindService, BAD_CAST "xmlns:p2", BAD_CAST "http://www.opengis.net/gml%22);%7D `
@wkampich i have updated PR. Could you look
Works for me! Thanks
@wkampich - you are the developer/maintainer of the module, if you do not want to wait for other comments, you can merge the PR at any time.
Merged #2584 into master.