2 Mar
2018
2 Mar
'18
1:33 p.m.
### Description
rtpengine module is hijacking the DTLS key
rtpengine_manage("DTLS=off")
DTLS=off is a valid command to rtpengine, but the module uses that flag
to set transport as UDP/TLS/RTP/SAVP
Unfortunately even though the transport can be fixed by RTP/SAVP, the lines outputted by
rtpengine
a=setup:actpass
a=fingerprint:xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
confuse some UACs that were expecting only SDES. FreeSWITCH is affected.
### Troubleshooting
#### Reproduction
rtpengine_manage("DTLS=off"). tcpdump the traffic between kamailio and
rtpengine.
Obseve that there is no DTLS=off key.
#### Debugging Data
#### Log Messages
#### SIP Traffic
### Possible Solutions
Don't look for DTLS key, let that be passthrough to kamailio
### Additional Information
5.1.2
* **Operating System**:
Linux CentOS 7.4
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468
2 Mar
2 Mar
1:45 p.m.
New subject: [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)
@rfuchs hoping you can take a look at this. The merge to master and backport to 5.1.2 has
broken my use of rtpengine_manage("DTLS=off") since the DTLS key is removed from
the ng-protocol messaged and not processed by rtpengine.
It is needed specifically for FreeSWITCH in SDES (who for some reason does not like
a=setup:actpass and a=fingerprint)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369888212
1:56 p.m.
New subject: [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)
It is a side effect of PR #1460.
More specific, from mailing list discussion
(https://lists.kamailio.org/pipermail/sr-users/2018-March/100539.html), the related change
should be:
```
+ else if (str_eq(&key, "DTLS"))
+ ng_flags->transport |= 0x104;
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369890586
2:08 p.m.
New subject: [kamailio/kamailio] 5.1.2: rtpengine module hijacks DTLS key (#1468)
The following attempted workaround also fails:
1. don't use DTLS=off, force transport
rtpengine_manage("ICE=remove transport-protocol=RTP/SAVP");
2. rtpengine side use dtls-passive
rtpengine --dtls-passive
For some reason this also doesn't work, as rtpengine after rewritng SDP adds
a=setup:actpass
a=fingerprint:sha-1 0F:21:F8:06:56:09:51:EC:B2:0B:47:A8:2D:98:D0:E7:E9:F7:0F:A9
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369893139
3:24 p.m.
New subject: [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)
First of all, I am sorry for crating this regression - I have clearly not fully
appreciated how the fall through of flags in rtpengine module works.
Using "DTLS" for declaring transport is just a shortcut for the log version
UDP/TLS/RTP/SAVP, so removing it will not make much difference.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369907637
4:04 p.m.
New subject: [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)
Ya sorry, my bad. I should have caught this when reviewing it. Will fix.
I suggest "DTLS" alone as a switch to enable UDP/TLS transport, while DTLS=...
as a flag would keep its old meaning.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369915617
4:37 p.m.
New subject: [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)
Closed #1468 via 0d89dc5e3c4c06084af8aae03e9b705673289703.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#event-1501156028
5:05 p.m.
New subject: [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)
Thanks @rfuchs for the quick reaction! Otherwise, no worries, it's software!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369929110
5:06 p.m.
New subject: [kamailio/kamailio] master/5.1.2: rtpengine module hijacks DTLS key (#1468)
Yes, indeed - thanks for fixing it so fast. Much appreciated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/1468#issuecomment-369929528
2460
days inactive
2460
days old
8 comments
4 participants
participants (4)
-
aalba6675 -
Daniel-Constantin Mierla
-
jerzyptak
-
Richard Fuchs