6 Jan
2015
6 Jan
'15
1:25 p.m.
Hello,
your pull request to merge the usrloc_dmq module was accepted few days ago.
I wrote in the merge comment some remarks about few thinks to be cared of:
- add the license text at the top of .c/.h files (license must be gplv2
or bsd, at your choice)
- variables to be declared at the beginning of functions or blocks, to
be sure it still compiles with old strict C compilers
Giving a second thought and considering the current common naming
patterns, I propose to rename the module from usrloc_dmq to dmq_usrloc
(we have similar for pua_usrloc or pua_reginfo) -- the idea is that the
main purpose of the module is extending dmq with a new data flow type,
rather than usrloc specific extensions. Is that ok for you? If you don't
have time for it in short term, I can do it.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
12 Jan
12 Jan
9:11 a.m.
Hello,
I have tried to make changes in the module, but I do not have the rights
for this.
________________________________
Andrey Rybkin
JID: rybkin.a(a)bks.tv
E-Mail: rybkin.a(a)bks.tv
2015-01-06 14:25 GMT+03:00 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
Hello,
your pull request to merge the usrloc_dmq module was accepted few days ago.
I wrote in the merge comment some remarks about few thinks to be cared of:
- add the license text at the top of .c/.h files (license must be gplv2
or bsd, at your choice)
- variables to be declared at the beginning of functions or blocks, to
be sure it still compiles with old strict C compilers
Giving a second thought and considering the current common naming
patterns, I propose to rename the module from usrloc_dmq to dmq_usrloc
(we have similar for pua_usrloc or pua_reginfo) -- the idea is that the
main purpose of the module is extending dmq with a new data flow type,
rather than usrloc specific extensions. Is that ok for you? If you don't
have time for it in short term, I can do it.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
11:59 a.m.
Hello,
I wanted first to discuss and see if you are interested in maintaining
the module for a while (at least one year -- this is more like a
gentlemen agreement) on the official repository.
If yes, you will receive an invitation very soon. Next are several remarks:
- your commits will trigger email notifications sent to sr-dev mailing
list. The email you use for those git commits must be subscribed to
sr-dev (it is now, just to be clear you need to do it in case you change
to another email)
- more details on how the commits should be done
* http://www.kamailio.org/wiki/devel/git-commit-guidelines
- special care to the formatting of commit:
* first line with short description of the commit, then if needed, an
empty line and the extra details in the following lines
- fixes - if there is a bug that applies to master branch as well, the
commit must be done first there and then use 'git cherry-pick -x
COMMITID' to backport it in stable branches.
Cheers,
Daniel
On 12/01/15 08:11, Andrey Rybkin wrote:
Hello,
I have tried to make changes in the module, but I do not have the
rights for this.
________________________________
Andrey Rybkin
JID: rybkin.a(a)bks.tv <mailto:rybkin.a@bks.tv>
E-Mail: rybkin.a(a)bks.tv <mailto:rybkin.a@bks.tv>
2015-01-06 14:25 GMT+03:00 Daniel-Constantin Mierla <miconda(a)gmail.com
<mailto:miconda@gmail.com>>:
Hello,
your pull request to merge the usrloc_dmq module was accepted few
days ago.
I wrote in the merge comment some remarks about few thinks to be
cared of:
- add the license text at the top of .c/.h files (license must be
gplv2
or bsd, at your choice)
- variables to be declared at the beginning of functions or blocks, to
be sure it still compiles with old strict C compilers
Giving a second thought and considering the current common naming
patterns, I propose to rename the module from usrloc_dmq to dmq_usrloc
(we have similar for pua_usrloc or pua_reginfo) -- the idea is
that the
main purpose of the module is extending dmq with a new data flow type,
rather than usrloc specific extensions. Is that ok for you? If you
don't
have time for it in short term, I can do it.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda <http://twitter.com/#%21/miconda> -
http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
12:16 p.m.
Hello,
Yes, I'm interested in maintaining this module.
________________________________
Andrey Rybkin
JID: rybkin.a(a)bks.tv
E-Mail: rybkin.a(a)bks.tv
2015-01-12 12:59 GMT+03:00 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
Hello,
I wanted first to discuss and see if you are interested in maintaining the
module for a while (at least one year -- this is more like a gentlemen
agreement) on the official repository.
If yes, you will receive an invitation very soon. Next are several remarks:
- your commits will trigger email notifications sent to sr-dev mailing
list. The email you use for those git commits must be subscribed to sr-dev
(it is now, just to be clear you need to do it in case you change to
another email)
- more details on how the commits should be done
* http://www.kamailio.org/wiki/devel/git-commit-guidelines
- special care to the formatting of commit:
* first line with short description of the commit, then if needed, an
empty line and the extra details in the following lines
- fixes - if there is a bug that applies to master branch as well, the
commit must be done first there and then use 'git cherry-pick -x COMMITID'
to backport it in stable branches.
Cheers,
Daniel
On 12/01/15 08:11, Andrey Rybkin wrote:
Hello,
I have tried to make changes in the module, but I do not have the rights
for this.
________________________________
Andrey Rybkin
JID: rybkin.a(a)bks.tv
E-Mail: rybkin.a(a)bks.tv
2015-01-06 14:25 GMT+03:00 Daniel-Constantin Mierla <miconda(a)gmail.com>om>:
Hello,
your pull request to merge the usrloc_dmq module was accepted few days
ago.
I wrote in the merge comment some remarks about few thinks to be cared of:
- add the license text at the top of .c/.h files (license must be gplv2
or bsd, at your choice)
- variables to be declared at the beginning of functions or blocks, to
be sure it still compiles with old strict C compilers
Giving a second thought and considering the current common naming
patterns, I propose to rename the module from usrloc_dmq to dmq_usrloc
(we have similar for pua_usrloc or pua_reginfo) -- the idea is that the
main purpose of the module is extending dmq with a new data flow type,
rather than usrloc specific extensions. Is that ok for you? If you don't
have time for it in short term, I can do it.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierlahttp://twitter.com/#!/miconda -
http://www.linkedin.com/in/miconda
4 p.m.
Hello,
invitation was sent on github, as you already noticed.
Can you rename the module in dmq_usrloc (you can use git mv to keep the
history linked to it)?
Then we can make a news as we can link to a name that will stay.
Cheers,
Daniel
On 12/01/15 11:16, Andrey Rybkin wrote:
Hello,
Yes, I'm interested in maintaining this module.
________________________________
Andrey Rybkin
JID: rybkin.a(a)bks.tv <mailto:rybkin.a@bks.tv>
E-Mail: rybkin.a(a)bks.tv <mailto:rybkin.a@bks.tv>
2015-01-12 12:59 GMT+03:00 Daniel-Constantin Mierla <miconda(a)gmail.com
<mailto:miconda@gmail.com>>:
Hello,
I wanted first to discuss and see if you are interested in
maintaining the module for a while (at least one year -- this is
more like a gentlemen agreement) on the official repository.
If yes, you will receive an invitation very soon. Next are several
remarks:
- your commits will trigger email notifications sent to sr-dev
mailing list. The email you use for those git commits must be
subscribed to sr-dev (it is now, just to be clear you need to do
it in case you change to another email)
- more details on how the commits should be done
* http://www.kamailio.org/wiki/devel/git-commit-guidelines
- special care to the formatting of commit:
* first line with short description of the commit, then if
needed, an empty line and the extra details in the following lines
- fixes - if there is a bug that applies to master branch as well,
the commit must be done first there and then use 'git cherry-pick
-x COMMITID' to backport it in stable branches.
Cheers,
Daniel
On 12/01/15 08:11, Andrey Rybkin wrote:
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Hello,
I have tried to make changes in the module, but I do not have the
rights for this.
________________________________
Andrey Rybkin
JID: rybkin.a(a)bks.tv <mailto:rybkin.a@bks.tv>
E-Mail: rybkin.a(a)bks.tv <mailto:rybkin.a@bks.tv>
2015-01-06 14:25 GMT+03:00 Daniel-Constantin Mierla
<miconda(a)gmail.com <mailto:miconda@gmail.com>>:
Hello,
your pull request to merge the usrloc_dmq module was accepted
few days ago.
I wrote in the merge comment some remarks about few thinks to
be cared of:
- add the license text at the top of .c/.h files (license
must be gplv2
or bsd, at your choice)
- variables to be declared at the beginning of functions or
blocks, to
be sure it still compiles with old strict C compilers
Giving a second thought and considering the current common naming
patterns, I propose to rename the module from usrloc_dmq to
dmq_usrloc
(we have similar for pua_usrloc or pua_reginfo) -- the idea
is that the
main purpose of the module is extending dmq with a new data
flow type,
rather than usrloc specific extensions. Is that ok for you?
If you don't
have time for it in short term, I can do it.
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda
<http://twitter.com/#%21/miconda> -
http://www.linkedin.com/in/miconda
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda <http://twitter.com/#%21/miconda> -
http://www.linkedin.com/in/miconda
3607
days inactive
3613
days old
4 comments
2 participants
participants (2)
-
Andrey Rybkin -
Daniel-Constantin Mierla