<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3561
-- Commit Summary --
* core: Add option for increasing socket send buffer size
-- File Changes --
M src/core/cfg.lex (2) M src/core/cfg.y (7) M src/core/globals.h (1) M src/core/udp_server.c (104) M src/core/udp_server.h (1) M src/main.c (28)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3561.patch https://github.com/kamailio/kamailio/pull/3561.diff
@btriller pushed 1 commit.
286bdf9897403ef0e1f2f13405685c4e0349db86 core: Add option for increasing socket send buffer size
The diff has a lot of formatting changes, did you run `clang-format` or you did them manually?
New features should be made as a clean PR, without formatting changes, because it is hard to follow up what is new and what is reformatting, you also relocated some lines, adding to the volume of the changes.
Reformatting PR's are also welcome, but they have to be done separately, so one knows it is not about behavioural changes. But not that clang-format should be used at the end to ensure coherency.
Can you split the PR in two, one with the new feature and the second with formatting/relocating changes?
@btriller pushed 1 commit.
f381988d5f70343a66e187a48708fc4c40e77a9b core: Add option for increasing socket send buffer size
Did a `clang-format` after `check-format` failed. Force pushed w/o format changes.
Thanks! Merging this one.
You can make a new PR with the format changes.
Merged #3561 into master.
-
Bastian Triller -
Daniel-Constantin Mierla