Yes, and nat_uac_test("16") for testing the ports. g-)

Klaus Darilion wrote:

Hi!

Just out of curiosity - do you know how fix_nated_contact from nathelper module behaves in this scenario? If it works right, you can use the nathelper module for fixing the contact.

regards, klaus

Kanakatti Mahesh Subramanya wrote:

...

Currently, fix_contact immediately returns if src_ip == contact_ip

However, there are a bunch-a situations where src_ip==contact_ip, but src_port != contact_port (Dont even ask. Just blame the *really* bizarre cable routers that Comcast deploys every now and then)

I *could* go about modifying FixContact in functions.c to check both the ip and port.

Question is, should I? Is there something I am missing as to why we check only the IP? Should I be explicitly *not* checking the port?

Cheers

---

Serusers mailing list Serusers@iptel.org http://mail.iptel.org/mailman/listinfo/serusers

---

Serusers mailing list Serusers@iptel.org http://mail.iptel.org/mailman/listinfo/serusers

Hi Klaus,

fix_nated_contact() does not perform any checking prior to contact replacement. But it may be used in tandem with nat_uac_test("19") - http://www.openser.org/docs/modules/0.9.x/nathelper.html#AEN288 for flags description.

..... if (nat_uac_test("19")) { fix_nated_contact() / fix_contact() ; } ....

regards, bogdan

Klaus Darilion wrote:

Hi!

Just out of curiosity - do you know how fix_nated_contact from nathelper module behaves in this scenario? If it works right, you can use the nathelper module for fixing the contact.

regards, klaus

Kanakatti Mahesh Subramanya wrote:

...

Currently, fix_contact immediately returns if src_ip == contact_ip

However, there are a bunch-a situations where src_ip==contact_ip, but src_port != contact_port (Dont even ask. Just blame the *really* bizarre cable routers that Comcast deploys every now and then)

I *could* go about modifying FixContact in functions.c to check both the ip and port.

Question is, should I? Is there something I am missing as to why we check only the IP? Should I be explicitly *not* checking the port?

Cheers