24 Apr
2014
24 Apr
'14
5:10 p.m.
wiki was this related to $(hdr(name)[N]):
If [N] is omitted then the body of the first header is printed. The
first header is got when N=0, for the second N=1, a.s.o. In case of a
comma-separated multi-body headers, it returns all the bodies,
comma-separated.
i don't understand the last sentence. how can i get all bodies of all
headers of name=x as a comma separated list?
-- juha
25 Apr
25 Apr
5:15 p.m.
Juha Heinanen writes:
wiki was this related to $(hdr(name)[N]):
If [N] is omitted then the body of the first header is printed. The
first header is got when N=0, for the second N=1, a.s.o. In case of a
comma-separated multi-body headers, it returns all the bodies,
comma-separated.
i don't understand the last sentence. how can i get all bodies of all
headers of name=x as a comma separated list?
perhaps the above "In case" sentence should read:
In case of comma-separated multi-body headers, $(hdr(name)[*]) returns
all the bodies, comma-separated.
while testing this, i found a bug. when incoming request has
Test: <sip:user1@foo.bar>.
Test: <sip:user2@foo.bar>,<sip:user3@foo.bar>.
xlog("L_INFO", "Test '$(hdr(test)[*])'\n");
produces:
Apr 25 17:11:37 siika /usr/sbin/sip-proxy[9801]: INFO: Test
'<sip:user1@foo.bar>, <sip:user2@foo.bar>,<sip:user3@foo.bar>'
the bug is the extra space char after first comma.
-- juha
28 Apr
28 Apr
10:44 a.m.
On 25/04/14 16:15, Juha Heinanen wrote:
Juha Heinanen writes:
I guess the $hdr(X[*]) uses
comma-space for separation (haven't checked
the sources). In your example, the second header test has two values in
one line and $hdr(...) is simply returning all of them.
If you would have:
Test: <sip:user1@foo.bar>.
Test: <sip:user2@foo.bar>,<sip:user3@foo.bar>.
Test: <sip:user4@foo.bar>.
Probably the result would be:
'<sip:user1@foo.bar>, <sip:user2@foo.bar>,<sip:user3@foo.bar>,
<sip:user4@foo.bar>'
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
wiki was this related to $(hdr(name)[N]):
If [N] is omitted then the body of the first header is printed. The
first header is got when N=0, for the second N=1, a.s.o. In case of a
comma-separated multi-body headers, it returns all the bodies,
comma-separated.
i don't understand the last sentence. how can i get all bodies of all
headers of name=x as a comma separated list?
perhaps the above "In case"
sentence should read:
In case of comma-separated multi-body headers, $(hdr(name)[*]) returns
all the bodies, comma-separated.
while testing this, i found a bug. when incoming request has
Test: <sip:user1@foo.bar>.
Test: <sip:user2@foo.bar>,<sip:user3@foo.bar>.
xlog("L_INFO", "Test '$(hdr(test)[*])'\n");
produces:
Apr 25 17:11:37 siika /usr/sbin/sip-proxy[9801]: INFO: Test
'<sip:user1@foo.bar>, <sip:user2@foo.bar>,<sip:user3@foo.bar>'
the bug is the extra space char after first comma.
10:49 a.m.
Daniel-Constantin Mierla writes:
I guess the $hdr(X[*]) uses comma-space for separation
(haven't checked
the sources). In your example, the second header test has two values in
one line and $hdr(...) is simply returning all of them.
since there is no need for space, it should not be there.
-- juha
11:02 a.m.
On 28/04/14 09:49, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
It can be removed.
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
I guess the $hdr(X[*]) uses comma-space for
separation (haven't checked
the sources). In your example, the second header test has two values in
one line and $hdr(...) is simply returning all of them.
since there is no need for
space, it should not be there.
11:51 a.m.
Daniel-Constantin Mierla writes:
It can be removed.
i looked at the source and found in pv_core.c/pv_get_hdr() this:
memcpy(p, PV_FIELD_DELIM, PV_FIELD_DELIM_LEN);
the constants:
#define PV_FIELD_DELIM ", "
#define PV_FIELD_DELIM_LEN (sizeof(PV_FIELD_DELIM) - 1)
are used all over the place and it would thus not be a good idea to edit
them. perhaps adding a new ones:
#define PV_HDR_DELIM ", "
#define PV_HDR_DELIM_LEN (sizeof(PV_HDR_DELIM) - 1)
would be ok.
-- juha
I guess the $hdr(X[*]) uses comma-space for separation
(haven't checked
the sources). In your example, the second header test has two values in
one line and $hdr(...) is simply returning all of them.
since there is no need for
space, it should not be there.
11:54 a.m.
On 28/04/14 10:51, Juha Heinanen wrote:
Daniel-Constantin Mierla writes:
It can be removed. i looked at the source and
found in pv_core.c/pv_get_hdr() this:
memcpy(p, PV_FIELD_DELIM, PV_FIELD_DELIM_LEN);
the constants:
#define PV_FIELD_DELIM ", "
#define PV_FIELD_DELIM_LEN (sizeof(PV_FIELD_DELIM) - 1)
are used all over the place and it would thus not be a good idea to edit
them. perhaps adding a new ones:
#define PV_HDR_DELIM ", "
#define PV_HDR_DELIM_LEN (sizeof(PV_HDR_DELIM) - 1)
would be ok.
New ones can be added, indeed.
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
I guess the $hdr(X[*]) uses comma-space for separation
(haven't checked
the sources). In your example, the second header test has two values in
one line and $hdr(...) is simply returning all of them.
since there is no need for
space, it should not be there.
10:40 a.m.
On 24/04/14 16:10, Juha Heinanen wrote:
wiki was this related to $(hdr(name)[N]):
If [N] is omitted then the body of the first header is printed. The
first header is got when N=0, for the second N=1, a.s.o. In case of a
comma-separated multi-body headers, it returns all the bodies,
comma-separated.
i don't understand the last sentence. how can i get all bodies of all
headers of name=x as a comma separated list?
It is related to headers like:
H: v1, v2
H: v3
$hdr(H) returns 'v1, v2'.
Cheers,
Daniel
--
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
3868
days inactive
3872
days old
8 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Juha Heinanen