Hi!
Is it possible to deactivate the 100 Trying during t_relay? I want to use sl_send_reply("100","trying"), thus the implicit 100 trying during t_relay is not needed.
regards klaus
I vote also for moving it to the config file, so you can choose the reply message. It's very unconvenient having it coded....
Samuel.
2006/11/15, Klaus Darilion klaus.mailinglists@pernau.at:
Hi!
Is it possible to deactivate the 100 Trying during t_relay? I want to use sl_send_reply("100","trying"), thus the implicit 100 trying during t_relay is not needed.
regards klaus
-- Klaus Darilion nic.at
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
On Wed, Nov 15, 2006 at 10:10:00AM +0100, samuel wrote:
I vote also for moving it to the config file, so you can choose the reply message. It's very unconvenient having it coded....
It should be something like in this patch
modparam("tm", "trying_replay", 1) - send replay 100 replay on INVITE. modparam("tm", "trying_replay", 0) - don't send replay on INVITE
Samuel.
Wbr,
Hi all,
yes, it make sense to have the possibility to send or not a 100 reply. The question is : to have a module param as Alex suggested, or to control it only from the script (by sending or not a reply).
I personally go for 1) as it maintain backward compatibility and may simplify the script.
regards, bogdan
Alexandr Dubovikov wrote:
On Wed, Nov 15, 2006 at 10:10:00AM +0100, samuel wrote:
I vote also for moving it to the config file, so you can choose the reply message. It's very unconvenient having it coded....
It should be something like in this patch
modparam("tm", "trying_replay", 1) - send replay 100 replay on INVITE. modparam("tm", "trying_replay", 0) - don't send replay on INVITE
Samuel.
Wbr,
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
Bogdan-Andrei Iancu wrote:
Hi all,
yes, it make sense to have the possibility to send or not a 100 reply. The question is : to have a module param as Alex suggested, or to control it only from the script (by sending or not a reply).
There would be also another possibility - a new function t_relay_no100();
Nevertheless I also vote for Alex's patch
regards klaus
I personally go for 1) as it maintain backward compatibility and may simplify the script.
regards, bogdan
Alexandr Dubovikov wrote:
On Wed, Nov 15, 2006 at 10:10:00AM +0100, samuel wrote:
I vote also for moving it to the config file, so you can choose the reply message. It's very unconvenient having it coded....
It should be something like in this patch
modparam("tm", "trying_replay", 1) - send replay 100 replay on INVITE. modparam("tm", "trying_replay", 0) - don't send replay on INVITE
Samuel.
Wbr,
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
I also vote for Alex's patch with the default value of 1 to keep backward compatibility.
Samuel.
2006/11/16, Klaus Darilion klaus.mailinglists@pernau.at:
Bogdan-Andrei Iancu wrote:
Hi all,
yes, it make sense to have the possibility to send or not a 100 reply. The question is : to have a module param as Alex suggested, or to control it only from the script (by sending or not a reply).
There would be also another possibility - a new function t_relay_no100();
Nevertheless I also vote for Alex's patch
regards klaus
I personally go for 1) as it maintain backward compatibility and may simplify the script.
regards, bogdan
Alexandr Dubovikov wrote:
On Wed, Nov 15, 2006 at 10:10:00AM +0100, samuel wrote:
I vote also for moving it to the config file, so you can choose the reply message. It's very unconvenient having it coded....
It should be something like in this patch
modparam("tm", "trying_replay", 1) - send replay 100 replay on INVITE. modparam("tm", "trying_replay", 0) - don't send replay on INVITE
Samuel.
Wbr,
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
-- Klaus Darilion nic.at
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
wok, it seams we have a case. I see two ways of implementing it: 1) using a module parameter (as in Alex patch) to control if a provisional reply should be automatically send; by default a 100 will be configure to maintain backward compatibility modparam("tm","auto_provisional_code",100) 2) having a new function to do relay without any auto provisional reply (as Klaus suggested).
any opinions?
regards, bogdan
samuel wrote:
I also vote for Alex's patch with the default value of 1 to keep backward compatibility.
Samuel.
2006/11/16, Klaus Darilion klaus.mailinglists@pernau.at:
Bogdan-Andrei Iancu wrote:
Hi all,
yes, it make sense to have the possibility to send or not a 100 reply. The question is : to have a module param as Alex suggested, or to control it only from the script (by sending or not a reply).
There would be also another possibility - a new function t_relay_no100();
Nevertheless I also vote for Alex's patch
regards klaus
I personally go for 1) as it maintain backward compatibility and may simplify the script.
regards, bogdan
Alexandr Dubovikov wrote:
On Wed, Nov 15, 2006 at 10:10:00AM +0100, samuel wrote:
I vote also for moving it to the config file, so you can choose the reply message. It's very unconvenient having it coded....
It should be something like in this patch
modparam("tm", "trying_replay", 1) - send replay 100 replay on
INVITE.
modparam("tm", "trying_replay", 0) - don't send replay on INVITE
Samuel.
Wbr,
why not both? solution 1. will give you the ability to globally turn on/off the 100 behaviour - no need to modify the logic of the script solution 2. will give you the ability to play with 100 behaviour per request - if (REGISTER) t_relay_no100(); else t_relay();
t_relay() will obey the modparam t_relay_no100() will relay without 100
Regards, Ovidiu Sas
On 11/17/06, Bogdan-Andrei Iancu bogdan@voice-system.ro wrote:
wok, it seams we have a case. I see two ways of implementing it: 1) using a module parameter (as in Alex patch) to control if a provisional reply should be automatically send; by default a 100 will be configure to maintain backward compatibility modparam("tm","auto_provisional_code",100) 2) having a new function to do relay without any auto provisional reply (as Klaus suggested).
any opinions?
regards, bogdan
samuel wrote:
I also vote for Alex's patch with the default value of 1 to keep backward compatibility.
Samuel.
2006/11/16, Klaus Darilion klaus.mailinglists@pernau.at:
Bogdan-Andrei Iancu wrote:
Hi all,
yes, it make sense to have the possibility to send or not a 100 reply. The question is : to have a module param as Alex suggested, or to control it only from the script (by sending or not a reply).
There would be also another possibility - a new function t_relay_no100();
Nevertheless I also vote for Alex's patch
regards klaus
I personally go for 1) as it maintain backward compatibility and may simplify the script.
regards, bogdan
Alexandr Dubovikov wrote:
On Wed, Nov 15, 2006 at 10:10:00AM +0100, samuel wrote:
I vote also for moving it to the config file, so you can choose the reply message. It's very unconvenient having it coded....
It should be something like in this patch
modparam("tm", "trying_replay", 1) - send replay 100 replay on
INVITE.
modparam("tm", "trying_replay", 0) - don't send replay on INVITE
Samuel.
Wbr,
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
On Wed, Nov 15, 2006 at 10:04:12AM +0100, Klaus Darilion wrote:
Hi!
Hi,
Is it possible to deactivate the 100 Trying during t_relay? I want to use sl_send_reply("100","trying"), thus the implicit 100 trying during t_relay is not needed.
The easy way comment it out:
t_funcs.c: row: 249
if (!t_reply( t, p_msg , 100 , "trying -- your call is important to us")) DBG("SER: ERROR: t_reply (100)\n");
regards klaus
-- Klaus Darilion nic.at
Users mailing list Users@openser.org http://openser.org/cgi-bin/mailman/listinfo/users
Wbr,
-
Alexandr Dubovikov -
Bogdan-Andrei Iancu -
Klaus Darilion -
Ovidiu Sas -
samuel