[kamailio 5.4.3] xavp_rm_by_index removes (N+1) first indexes instead of index N

List overview All Threads
Download

newer

older

Kamailio v5.4 install

Dialog Tracking with Inconsistent...

Chaigneau, Nicolas

20 Jan 2021 20 Jan '21

5:25 p.m.

Hello

I’m trying to use function xavp_rm_by_index to remove a specific index from a given xavp. I’m observing an unexpected behaviour, I think it might be a bug : Instead of just removing the index, the function removes the index and all others before it.

E.g : if called with « idx = 1 », it removes indexes 0 and 1.

Reading the code of xavp_rm_internal (which is called by xavp_rm_by_index), I don’t think it behaves at it should :

/* Remove xavps * idx: <0 remove all xavps with the same name * >=0 remove only the specified index xavp * Returns number of xavps that were deleted */

For example when I do this :

LM_ERR("COUNT BEFORE: %d\n", xavp_count(rname, NULL)); int rm_count = xavp_rm_by_index(rname, 1, NULL); // TEST LM_ERR("REMOVED: %d\n", rm_count); LM_ERR("COUNT AFTER: %d\n", xavp_count(rname, NULL));

« rm_count » returned is 1 (which is expected). However, « count after » is decremented by 2. And when I look at the contents of my xavp, I notice that the first two elements have been removed.

Likewise if xavp_rm_by_index is invoked with idx = 2 => the first 3 elements are removed.

So… do you think this is a bug ? or something I didn’t understand ?

Thanks for your help !

Regards, Nicolas.

Attachments:

attachment.html (text/html — 6.9 KB)

Show replies by date

Daniel-Constantin Mierla

20 Jan 20 Jan

6:35 p.m.

Hello,

looking at the code, I cannot spot anything wrong with xavp_rm_internal().

Being about C code you wrote, can you double check your code or share the entire function you tested with?

Cheers, Daniel

On Wed, Jan 20, 2021 at 6:26 PM Chaigneau, Nicolas < nicolas.chaigneau@capgemini.com> wrote:

...

Hello

I’m trying to use function xavp_rm_by_index to remove a specific index from a given xavp.

I’m observing an unexpected behaviour, I think it might be a bug :

Instead of just removing the index, the function removes the index and all others before it.

E.g : if called with « idx = 1 », it removes indexes 0 and 1.

Reading the code of xavp_rm_internal (which is called by xavp_rm_by_index), I don’t think it behaves at it should :

/* Remove xavps
idx: <0 remove all xavps with the same name
 >=0 remove only the specified index xavp
Returns number of xavps that were deleted
*/

For example when I do this :

LM_ERR("COUNT BEFORE: %d\n", xavp_count(rname, NULL));

int rm_count = xavp_rm_by_index(rname, 1, NULL); // TEST

LM_ERR("REMOVED: %d\n", rm_count);

LM_ERR("COUNT AFTER: %d\n", xavp_count(rname, NULL));

« rm_count » returned is 1 (which is expected). However, « count after » is decremented by 2.

And when I look at the contents of my xavp, I notice that the first two elements have been removed.

Likewise if xavp_rm_by_index is invoked with idx = 2 => the first 3 elements are removed.

So… do you think this is a bug ? or something I didn’t understand ?

Thanks for your help !

Regards,

Nicolas.

This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. _______________________________________________ Kamailio (SER) - Users Mailing List sr-users@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

-- Daniel-Constantin Mierla - https://www.asipto.com https://twitter.com/miconda - https://www.linkedin.com/in/miconda Kamailio Advanced Training - https://www.asipto.com/u/kat

Chaigneau, Nicolas

9:43 p.m.

Hello,

Here is some code that shows the issue :

1) a test cmd_function in a module defined as follows :

static int was_test(struct sip_msg *msg, char *param1, char *param2);

static cmd_export_t cmds[] = { {"was_test", (cmd_function)was_test, 2, 0, 0, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} };

/** * For testing purposes. */ static int was_test(struct sip_msg *msg, char *param1, char *param2) { LM_WARN("Called with param1: [%s], param2: [%s]\n", param1, param2);

str my_str; my_str.s = param1; my_str.len = strlen(param1);

int idx = atoi(param2); str *rname = &my_str;

LM_ERR("COUNT BEFORE: %d\n", xavp_count(rname, NULL));

int rm_count = xavp_rm_by_index(rname, idx, NULL);

LM_ERR("REMOVED: %d\n", rm_count); LM_ERR("COUNT AFTER: %d\n", xavp_count(rname, NULL));

return 1; }

2) Kamailio script :

request_route {

# push 4 rows to xavp "test": $xavp(test=>a) = "3.a"; $xavp(test[0]=>b) = "3.b";

$xavp(test=>a) = "2.a"; $xavp(test[0]=>b) = "2.b";

$xavp(test=>a) = "1.a"; $xavp(test[0]=>b) = "1.b";

$xavp(test=>a) = "0.a"; $xavp(test[0]=>b) = "0.b";

# then try to call xavp_rm_by_index with a non-zero idx xlog("L_INFO", "BEFORE\n"); xlog("L_INFO", "test[*]: [$(was_xavp_serialize(test)[*])]\n"); pv_xavp_print();

was_test("test", "1"); // expecting only row 1 to be removed (1.a / 1.b)

xlog("L_INFO", "AFTER\n"); xlog("L_INFO", "test[*]: [$(was_xavp_serialize(test)[*])]\n"); pv_xavp_print();

}

And the resulting logs :

2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <script>: BEFORE 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <script>: test[*]: [(0):b=0.b;a=0.a, (1):b=1.b;a=1.a, 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) WARNING: {1 INVITE 1-22211@10.31.22.1} was_utils [was_utils.c:169]: was_test(): Called 2(16546) ERROR: {1 INVITE 1-22211@10.31.22.1} was_utils [was_utils.c:178]: was_test(): COUNT BEFORE: 4 2(16546) ERROR: {1 INVITE 1-22211@10.31.22.1} was_utils [was_utils.c:180]: was_test(): REMOVED: 1 2(16546) ERROR: {1 INVITE 1-22211@10.31.22.1} was_utils [was_utils.c:181]: was_test(): COUNT AFTER: 2 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <script>: AFTER 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <script>: test[*]: [(0):b=2.b;a=2.a, (1):b=3.b;a=3.a 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:629]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:601]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:605]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:606]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:607]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:616]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:642]: xavx_print_list_content(): 2(16546) INFO: {1 INVITE 1-22211@10.31.22.1} <core> [core/xavp.c:645]: xavx_print_list_content(): (2):b=2.b;a=2.a, (3):b=3.b;a=3.a] +++++ start XAVP list: 0x7f7193dff798 ((nil)) (level=0) *** (l:0 - 0x7f7193dff798) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff840 +++++ start XAVP list: 0x7f7193dff840 (0x7f7193dff7b8) (level=1) *** (l:1 - 0x7f7193dff840) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 0.b *** (l:1 - 0x7f7193dff840) end *** (l:1 - 0x7f7193dff6f0) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 0.a *** (l:1 - 0x7f7193dff6f0) end ----- end XAVP list: 0x7f7193dff840 (level=1) *** (l:0 - 0x7f7193dff798) end *** (l:0 - 0x7f7193dff5a0) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff648 +++++ start XAVP list: 0x7f7193dff648 (0x7f7193dff5c0) (level=1) *** (l:1 - 0x7f7193dff648) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 1.b *** (l:1 - 0x7f7193dff648) end *** (l:1 - 0x7f7193dff4f8) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 1.a *** (l:1 - 0x7f7193dff4f8) end ----- end XAVP list: 0x7f7193dff648 (level=1) *** (l:0 - 0x7f7193dff5a0) end *** (l:0 - 0x7f7193dff3a8) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff450 +++++ start XAVP list: 0x7f7193dff450 (0x7f7193dff3c8) (level=1) *** (l:1 - 0x7f7193dff450) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 2.b *** (l:1 - 0x7f7193dff450) end *** (l:1 - 0x7f7193dff300) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 2.a *** (l:1 - 0x7f7193dff300) end ----- end XAVP list: 0x7f7193dff450 (level=1) *** (l:0 - 0x7f7193dff3a8) end *** (l:0 - 0x7f7193dff1b0) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff258 +++++ start XAVP list: 0x7f7193dff258 (0x7f7193dff1d0) (level=1) *** (l:1 - 0x7f7193dff258) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 3.b *** (l:1 - 0x7f7193dff258) end *** (l:1 - 0x7f7193dff108) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 3.a *** (l:1 - 0x7f7193dff108) end ----- end XAVP list: 0x7f7193dff258 (level=1) *** (l:0 - 0x7f7193dff1b0) end ----- end XAVP list: 0x7f7193dff798 (level=0) with param1: [test], param2: [1] ] +++++ start XAVP list: 0x7f7193dff3a8 ((nil)) (level=0) *** (l:0 - 0x7f7193dff3a8) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff450 +++++ start XAVP list: 0x7f7193dff450 (0x7f7193dff3c8) (level=1) *** (l:1 - 0x7f7193dff450) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 2.b *** (l:1 - 0x7f7193dff450) end *** (l:1 - 0x7f7193dff300) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 2.a *** (l:1 - 0x7f7193dff300) end ----- end XAVP list: 0x7f7193dff450 (level=1) *** (l:0 - 0x7f7193dff3a8) end *** (l:0 - 0x7f7193dff1b0) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff258 +++++ start XAVP list: 0x7f7193dff258 (0x7f7193dff1d0) (level=1) *** (l:1 - 0x7f7193dff258) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 3.b *** (l:1 - 0x7f7193dff258) end *** (l:1 - 0x7f7193dff108) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 3.a *** (l:1 - 0x7f7193dff108) end ----- end XAVP list: 0x7f7193dff258 (level=1) *** (l:0 - 0x7f7193dff1b0) end ----- end XAVP list: 0x7f7193dff3a8 (level=0) +++++ start XAVP list: 0x7f7193dff3a8 ((nil)) (level=0) *** (l:0 - 0x7f7193dff3a8) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff450 +++++ start XAVP list: 0x7f7193dff450 (0x7f7193dff3c8) (level=1) *** (l:1 - 0x7f7193dff450) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 2.b *** (l:1 - 0x7f7193dff450) end *** (l:1 - 0x7f7193dff300) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 2.a *** (l:1 - 0x7f7193dff300) end ----- end XAVP list: 0x7f7193dff450 (level=1) *** (l:0 - 0x7f7193dff3a8) end *** (l:0 - 0x7f7193dff1b0) XAVP name: test XAVP id: 2063405720 XAVP value type: 6 XAVP value: xavp:0x7f7193dff258 +++++ start XAVP list: 0x7f7193dff258 (0x7f7193dff1d0) (level=1) *** (l:1 - 0x7f7193dff258) XAVP name: b XAVP id: 110 XAVP value type: 2 XAVP value (str): 3.b *** (l:1 - 0x7f7193dff258) end *** (l:1 - 0x7f7193dff108) XAVP name: a XAVP id: 109 XAVP value type: 2 XAVP value (str): 3.a *** (l:1 - 0x7f7193dff108) end ----- end XAVP list: 0x7f7193dff258 (level=1) *** (l:0 - 0x7f7193dff1b0) end ----- end XAVP list: 0x7f7193dff3a8 (level=0)

Regards, Nicolas.

De : sr-users sr-users-bounces@lists.kamailio.org De la part de Daniel-Constantin Mierla Envoyé : mercredi 20 janvier 2021 19:35 À : Kamailio (SER) - Users Mailing List Objet : Re: [SR-Users] [kamailio 5.4.3] xavp_rm_by_index removes (N+1) first indexes instead of index N

Hello,

looking at the code, I cannot spot anything wrong with xavp_rm_internal().

Being about C code you wrote, can you double check your code or share the entire function you tested with?

Cheers, Daniel

On Wed, Jan 20, 2021 at 6:26 PM Chaigneau, Nicolas <nicolas.chaigneau@capgemini.commailto:nicolas.chaigneau@capgemini.com> wrote: Hello

E.g : if called with « idx = 1 », it removes indexes 0 and 1.

Reading the code of xavp_rm_internal (which is called by xavp_rm_by_index), I don’t think it behaves at it should :

/* Remove xavps * idx: <0 remove all xavps with the same name * >=0 remove only the specified index xavp * Returns number of xavps that were deleted */

For example when I do this :

« rm_count » returned is 1 (which is expected). However, « count after » is decremented by 2. And when I look at the contents of my xavp, I notice that the first two elements have been removed.

Likewise if xavp_rm_by_index is invoked with idx = 2 => the first 3 elements are removed.

So… do you think this is a bug ? or something I didn’t understand ?

Thanks for your help !

Regards, Nicolas.

This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message. _______________________________________________ Kamailio (SER) - Users Mailing List sr-users@lists.kamailio.orgmailto:sr-users@lists.kamailio.org https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

-- Daniel-Constantin Mierla - https://www.asipto.com https://twitter.com/miconda - https://www.linkedin.com/in/miconda Kamailio Advanced Training - https://www.asipto.com/u/kat

1506

Age (days ago)

1506

Last active (days ago)

sr-users@lists.kamailio.org

2 comments

2 participants

tags (0)

participants (2)

Chaigneau, Nicolas
Daniel-Constantin Mierla