23 Feb
2015
23 Feb
'15
4:49 a.m.
allow_trusted() function of permissions module doesn't work right with ipv6
addresses - it treats IP addresses as strings and doesn't take into account
variations aaa:bbb::0 vs aaa:bbb:0:0:0:0:0:0.
23 Feb
23 Feb
10:53 a.m.
Hello,
trusted does string comparison for the address field, it is not
considered an ip address.
You should use address table instead if you just need matching on any ip
address or subnet.
Cheers,
Daniel
On 23/02/15 03:49, Sergey Okhapkin wrote:
allow_trusted() function of permissions module
doesn't work right with ipv6
addresses - it treats IP addresses as strings and doesn't take into account
variations aaa:bbb::0 vs aaa:bbb:0:0:0:0:0:0.
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
10:23 p.m.
Address() functions are incompatible with mysql views/casts,
reload_address_table() expects columns grp, mask and port to be type DB1_INT
(mysql LONG) but views and casts always return column type LONGLONG
(DB1_BIGINT). reload_address_table() always fail because of that.
On Monday 23 February 2015 09:53:08 Daniel-Constantin Mierla wrote:
Hello,
trusted does string comparison for the address field, it is not
considered an ip address.
You should use address table instead if you just need matching on any ip
address or subnet.
Cheers,
Daniel
On 23/02/15 03:49, Sergey Okhapkin wrote:
> allow_trusted() function of permissions module doesn't work right with
> ipv6
> addresses - it treats IP addresses as strings and doesn't take into
> account
> variations aaa:bbb::0 vs aaa:bbb:0:0:0:0:0:0.
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> sr-users(a)lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
24 Feb
24 Feb
12:34 a.m.
Interesting to learn that mysql views are not using same type as the
source column...
I guess we should handle this case internally, doing views is quite
common out there.
Cheers,
Daniel
On 23/02/15 21:23, Sergey Okhapkin wrote:
Address() functions are incompatible with mysql
views/casts,
reload_address_table() expects columns grp, mask and port to be type DB1_INT
(mysql LONG) but views and casts always return column type LONGLONG
(DB1_BIGINT). reload_address_table() always fail because of that.
On Monday 23 February 2015 09:53:08 Daniel-Constantin Mierla wrote:
> Hello,
>
> trusted does string comparison for the address field, it is not
> considered an ip address.
>
> You should use address table instead if you just need matching on any ip
> address or subnet.
>
> Cheers,
> Daniel
>
> On 23/02/15 03:49, Sergey Okhapkin wrote:
>> allow_trusted() function of permissions module doesn't work right with
>> ipv6
>> addresses - it treats IP addresses as strings and doesn't take into
>> account
>> variations aaa:bbb::0 vs aaa:bbb:0:0:0:0:0:0.
>>
>> _______________________________________________
>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
>> sr-users(a)lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
12:42 a.m.
I think the problem is not in the source column type, but in casts. I found no
way to create a view using existing table with "select cast(1 as unsigned) as
grp" to return LONG. It always returns LONGLONG. I don't have concept of group
in my DB schema and I don't need one, I just need to emulate the table
structure kamailio expects.
On Monday 23 February 2015 23:34:12 you wrote:
Interesting to learn that mysql views are not using
same type as the
source column...
I guess we should handle this case internally, doing views is quite
common out there.
Cheers,
Daniel
On 23/02/15 21:23, Sergey Okhapkin wrote:
> Address() functions are incompatible with mysql views/casts,
> reload_address_table() expects columns grp, mask and port to be type
> DB1_INT (mysql LONG) but views and casts always return column type
> LONGLONG (DB1_BIGINT). reload_address_table() always fail because of
> that.
>
> On Monday 23 February 2015 09:53:08 Daniel-Constantin Mierla wrote:
>> Hello,
>>
>> trusted does string comparison for the address field, it is not
>> considered an ip address.
>>
>> You should use address table instead if you just need matching on any ip
>> address or subnet.
>>
>> Cheers,
>> Daniel
>>
>> On 23/02/15 03:49, Sergey Okhapkin wrote:
>>> allow_trusted() function of permissions module doesn't work right with
>>> ipv6
>>> addresses - it treats IP addresses as strings and doesn't take into
>>> account
>>> variations aaa:bbb::0 vs aaa:bbb:0:0:0:0:0:0.
>>>
>>> _______________________________________________
>>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
>>> sr-users(a)lists.sip-router.org
>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
9:19 p.m.
Looks like I found a solution:
create function toint(num int) returns int NO SQL
begin
return num;
end;
select toint(1) as grp
returns LONG datatype.
On Monday 23 February 2015 17:42:30 Sergey Okhapkin wrote:
I think the problem is not in the source column type,
but in casts. I found
no way to create a view using existing table with "select cast(1 as
unsigned) as grp" to return LONG. It always returns LONGLONG. I don't have
concept of group in my DB schema and I don't need one, I just need to
emulate the table structure kamailio expects.
On Monday 23 February 2015 23:34:12 you wrote:
Interesting to learn that mysql views are not
using same type as the
source column...
I guess we should handle this case internally, doing views is quite
common out there.
Cheers,
Daniel
On 23/02/15 21:23, Sergey Okhapkin wrote:
> Address() functions are incompatible with mysql views/casts,
> reload_address_table() expects columns grp, mask and port to be type
> DB1_INT (mysql LONG) but views and casts always return column type
> LONGLONG (DB1_BIGINT). reload_address_table() always fail because of
> that.
>
> On Monday 23 February 2015 09:53:08 Daniel-Constantin Mierla wrote:
>> Hello,
>>
>> trusted does string comparison for the address field, it is not
>> considered an ip address.
>>
>> You should use address table instead if you just need matching on any
>> ip
>> address or subnet.
>>
>> Cheers,
>> Daniel
>>
>> On 23/02/15 03:49, Sergey Okhapkin wrote:
>>> allow_trusted() function of permissions module doesn't work right with
>>> ipv6
>>> addresses - it treats IP addresses as strings and doesn't take into
>>> account
>>> variations aaa:bbb::0 vs aaa:bbb:0:0:0:0:0:0.
>>>
>>> _______________________________________________
>>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing
>>> list
>>> sr-users(a)lists.sip-router.org
>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
_______________________________________________
SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
sr-users(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users 
27 Feb
27 Feb
9:46 a.m.
Hi,
On Mon, Feb 23, 2015 at 11:34 PM, Daniel-Constantin Mierla <
miconda(a)gmail.com> wrote:
Interesting to learn that mysql views are not using
same type as the
source column...
I guess we should handle this case internally, doing views is quite
common out there.
Interesting to read that. And it reminds me, that we stumbled upon this
years ago already. Back then we wanted to do avp_db_load from the
usr_preferences table, which was a view in our scenario. Kamailio threw a
type error in that case, too.
Best Regards,
Sebastian
24 Feb
24 Feb
1:05 a.m.
On Monday, February 23, 2015 09:53:08 AM Daniel-Constantin Mierla wrote:
trusted does string comparison for the address field,
it is not
considered an ip address.
You should use address table instead if you just need matching on any ip
address or subnet.
That's interesting. Is there a reason for the string comparison? Reading the
README, trusted and address functions look incredibly similar, except trusted
can match proto, and the address commands can match ports. What would be the
advantage or use case of using either trusted or address?
On 23/02/15 03:49, Sergey Okhapkin wrote:
> allow_trusted() function of permissions module doesn't work right with
> ipv6 addresses - it treats IP addresses as strings and doesn't take into
> account variations aaa:bbb::0 vs aaa:bbb:0:0:0:0:0:0.
--
Anthony - https://messinet.com/ - https://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E
1:35 p.m.
On 24/02/15 00:05, Anthony Messina wrote:
On Monday, February 23, 2015 09:53:08 AM
Daniel-Constantin Mierla wrote:
I am not the developer of
that function and haven't used it for a while.
IIRC, it was added like 2003-2004 and kept being so. I use address table
as it has more features in matching subnets and does pre-compilation of
ip addresses, thus is fast.
If someone provides a patch for doing ip-based comparison for trusted
table, it will be accepted. The C helper functions are available, so the
patch should not be big (ipops module can be used as example of C code
for comparing ip addresses).
Cheers,
Daniel
--
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, May 27-29, 2015
Berlin, Germany - http://www.kamailioworld.com
trusted does string comparison for the address
field, it is not
considered an ip address.
You should use address table instead if you just need matching on any ip
address or subnet.
That's interesting. Is there a reason for the string
comparison? Reading the
README, trusted and address functions look incredibly similar, except trusted
can match proto, and the address commands can match ports. What would be the
advantage or use case of using either trusted or address?
2:01 p.m.
On Tuesday, February 24, 2015 12:35:54 Daniel-Constantin Mierla wrote:
On 24/02/15 00:05, Anthony Messina wrote:
Understood. I am using the address table as well for that very reason. I
just didn't know if it was an *intentional* difference. Thanks. -A
--
Anthony - https://messinet.com/ - https://messinet.com/~amessina/gallery
8F89 5E72 8DF0 BCF0 10BE 9967 92DC 35DC B001 4A4E
On Monday, February 23, 2015 09:53:08 AM
Daniel-Constantin Mierla wrote:
I am not the developer of that function and haven't used it for a while.
IIRC, it was added like 2003-2004 and kept being so. I use address table
as it has more features in matching subnets and does pre-compilation of
ip addresses, thus is fast.
If someone provides a patch for doing ip-based comparison for trusted
table, it will be accepted. The C helper functions are available, so the
patch should not be big (ipops module can be used as example of C code
for comparing ip addresses).
Cheers,
Daniel trusted does string comparison for the address
field, it is not
considered an ip address.
You should use address table instead if you just need matching on any ip
address or subnet.
That's interesting. Is there a reason for the string comparison? Reading
the README, trusted and address functions look incredibly similar,
except trusted can match proto, and the address commands can match
ports. What would be the advantage or use case of using either trusted
or address?
3556
days inactive
3560
days old
9 comments
4 participants
participants (4)
-
Anthony Messina -
Daniel-Constantin Mierla -
Sebastian Damm -
Sergey Okhapkin