sr-dev July 2015

sr-dev@lists.kamailio.org

26 participants
301 discussions

git:4.3:5a0b8a45: core: fix mips compilation

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: 5a0b8a4550df2de15e40b5d7e664322815a48aea URL: https://github.com/kamailio/kamailio/commit/5a0b8a4550df2de15e40b5d7e664322… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-29T12:09:05+02:00 core: fix mips compilation Patch from http://anonscm.debian.org/cgit/pkg-voip/kamailio.git/tree/debian/patches/fi… by Dejan Latinovic <Dejan.Latinovic(a)imgtec.com> (cherry picked from commit ed894111f6f15170f87336bfa73ec4e8fce1c7d1) --- Modified: Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/5a0b8a4550df2de15e40b5d7e664322… Patch: https://github.com/kamailio/kamailio/commit/5a0b8a4550df2de15e40b5d7e664322… --- diff --git a/Makefile.defs b/Makefile.defs index 3e7f726..6d6a04f 100644 --- a/Makefile.defs +++ b/Makefile.defs @@ -1319,12 +1319,13 @@ ifeq ($(CC_NAME), gcc) CFLAGS= -mips2 $(CC_OPT) -funroll-loops $(PROFILE) #if gcc 5.0+, 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+ 5.0+,$(CC_SHORTVER)))) - CFLAGS+=-minline-all-stringops -ftree-vectorize \ - -fno-strict-overflow + CFLAGS+=-ftree-vectorize -fno-strict-overflow + # not supported on mips: -minline-all-stringops else #if gcc 4.0+ ifeq ($(CC_SHORTVER), 4.x) - CFLAGS+=-minline-all-stringops -ftree-vectorize + CFLAGS+=-ftree-vectorize + # not supported on mips: -minline-all-stringops else #if gcc 3.4+ ifeq ($(CC_SHORTVER), 3.4) @@ -1364,12 +1365,14 @@ ifeq ($(CC_NAME), gcc) CFLAGS= -mips64 $(CC_OPT) -funroll-loops $(PROFILE) #if gcc 5.0+, 4.5+ or 4.2+ ifeq (,$(strip $(filter-out 4.2+ 4.5+ 5.0+,$(CC_SHORTVER)))) - CFLAGS+=-minline-all-stringops -ftree-vectorize \ - -fno-strict-overflow + CFLAGS+=-ftree-vectorize -fno-strict-overflow + # not supported on mips: -minline-all-stringops + else #if gcc 4.0+ ifeq ($(CC_SHORTVER), 4.x) - CFLAGS+=-minline-all-stringops -ftree-vectorize + CFLAGS+=-ftree-vectorize + # not supported on mips: -minline-all-stringops else #if gcc 3.4+ ifeq ($(CC_SHORTVER), 3.4)

9 years, 4 months

git:4.3:fb2af610: kex: support VERSION_NODATE and VERSION_DATE for reproducible builds

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: fb2af6107a9c6cd3552fe0a95c699c30e4edad4c URL: https://github.com/kamailio/kamailio/commit/fb2af6107a9c6cd3552fe0a95c699c3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-29T12:08:42+02:00 kex: support VERSION_NODATE and VERSION_DATE for reproducible builds support added e03d1279f49709e0d320478fa1ff7c27161c30ed Related: #60 (cherry picked from commit 8f1fbd7b17440b1b7d87cbee5793ae9b1adebf90) --- Modified: modules/kex/mi_core.c --- Diff: https://github.com/kamailio/kamailio/commit/fb2af6107a9c6cd3552fe0a95c699c3… Patch: https://github.com/kamailio/kamailio/commit/fb2af6107a9c6cd3552fe0a95c699c3… --- diff --git a/modules/kex/mi_core.c b/modules/kex/mi_core.c index 9174809..9a1dcc8 100644 --- a/modules/kex/mi_core.c +++ b/modules/kex/mi_core.c @@ -51,7 +51,15 @@ #include "../../cfg/cfg.h" #include "../../cfg/cfg_ctx.h" +#ifdef VERSION_NODATE +#define BUILD_STR __FILE__ " compiled with " COMPILER "\n" +#else +#ifdef VERSION_DATE +#define BUILD_STR __FILE__ " compiled on " VERSION_DATE " with " COMPILER "\n" +#else #define BUILD_STR __FILE__ " compiled on "__TIME__ " " __DATE__ " with " COMPILER "\n" +#endif +#endif #define BUILD_STR_LEN (sizeof(BUILD_STR)-1) #ifndef SVNREVISION

9 years, 4 months

git:master:c007a062: tm: regenerated readme

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: c007a06228d3ccc39d17b93b5c7d173e8a68b5f1 URL: https://github.com/kamailio/kamailio/commit/c007a06228d3ccc39d17b93b5c7d173… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-28T10:24:10+02:00 tm: regenerated readme --- Modified: modules/tm/README --- Diff: https://github.com/kamailio/kamailio/commit/c007a06228d3ccc39d17b93b5c7d173… Patch: https://github.com/kamailio/kamailio/commit/c007a06228d3ccc39d17b93b5c7d173…

9 years, 4 months

git:master:e5f472ca: tm: added note in docs for t_set_no_e2e_cancel_reason()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e5f472ca5d8d2e16adb8b5a5a316521a618c8d9f URL: https://github.com/kamailio/kamailio/commit/e5f472ca5d8d2e16adb8b5a5a316521… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-28T10:23:28+02:00 tm: added note in docs for t_set_no_e2e_cancel_reason() - it has to be used when processing the INVITE --- Modified: modules/tm/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/e5f472ca5d8d2e16adb8b5a5a316521… Patch: https://github.com/kamailio/kamailio/commit/e5f472ca5d8d2e16adb8b5a5a316521… --- diff --git a/modules/tm/doc/functions.xml b/modules/tm/doc/functions.xml index b53b97d..b022fd9 100644 --- a/modules/tm/doc/functions.xml +++ b/modules/tm/doc/functions.xml @@ -1665,6 +1665,10 @@ t_relay_to("0x01"); parameter) for the current transaction. </para> <para> + Note: the function has to be used when processing the INVITE + (not when processing the CANCEL). + </para> + <para> See also: <varname>e2e_cancel_reason</varname>. </para> <example>

9 years, 4 months

[kamailio] Permissions module does not check if hash table exists (#248)

by Olle E. Johansson

We have a 4.3 Kamailio with Permissions, trying to use address* functions.The table is in a text file with db_text with some error in it, so Kamailio fails to load a hash table. The server starts, but if we run a RPC command or call a function in the routing script, we get a core dump. The permissions module checks should always check if the address table exist before accessing it. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/248

9 years, 4 months

git:master:6fcd35ba: permissions: check if hash tables exist for address config functions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6fcd35ba5bb71df680b89c2bafceccde0439b6f1 URL: https://github.com/kamailio/kamailio/commit/6fcd35ba5bb71df680b89c2bafceccd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-28T10:02:03+02:00 permissions: check if hash tables exist for address config functions - reported by Olle E. Johansson, GH#248 --- Modified: modules/permissions/address.c --- Diff: https://github.com/kamailio/kamailio/commit/6fcd35ba5bb71df680b89c2bafceccd… Patch: https://github.com/kamailio/kamailio/commit/6fcd35ba5bb71df680b89c2bafceccd…

9 years, 4 months

git:master:56e41533: permissions: safety check if hash tables exist for rpc dump commands

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 56e41533cae52cf5f782064ed23393d2d18aff08 URL: https://github.com/kamailio/kamailio/commit/56e41533cae52cf5f782064ed23393d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-28T09:47:48+02:00 permissions: safety check if hash tables exist for rpc dump commands - reported by Olle E. Johansson, GH#248 --- Modified: modules/permissions/mi.c --- Diff: https://github.com/kamailio/kamailio/commit/56e41533cae52cf5f782064ed23393d… Patch: https://github.com/kamailio/kamailio/commit/56e41533cae52cf5f782064ed23393d… --- diff --git a/modules/permissions/mi.c b/modules/permissions/mi.c index 35f2cca..844a86e 100644 --- a/modules/permissions/mi.c +++ b/modules/permissions/mi.c @@ -92,7 +92,7 @@ struct mi_root* mi_trusted_dump(struct mi_root *cmd_tree, void *param) void rpc_trusted_dump(rpc_t* rpc, void* c) { if (hash_table==NULL) { - rpc->fault(c, 500, "Reload failed. No trusted table"); + rpc->fault(c, 500, "No trusted table"); return; } @@ -154,6 +154,10 @@ struct mi_root* mi_address_dump(struct mi_root *cmd_tree, void *param) */ void rpc_address_dump(rpc_t* rpc, void* c) { + if(addr_hash_table==NULL) { + rpc->fault(c, 500, "No address table"); + return; + } if(addr_hash_table_rpc_print(*addr_hash_table, rpc, c) < 0 ) { LM_DBG("failed to print a subnet_table dump\n"); } @@ -185,6 +189,10 @@ struct mi_root* mi_subnet_dump(struct mi_root *cmd_tree, void *param) * RPC function to dump subnet table */ void rpc_subnet_dump(rpc_t* rpc, void* c) { + if(subnet_table==NULL) { + rpc->fault(c, 500, "No subnet table"); + return; + } if(subnet_table_rpc_print(*subnet_table, rpc, c) < 0) { LM_DBG("failed to print a subnet_table dump\n"); } @@ -217,6 +225,10 @@ struct mi_root* mi_domain_name_dump(struct mi_root *cmd_tree, void *param) */ void rpc_domain_name_dump(rpc_t* rpc, void* c) { + if(domain_list_table==NULL) { + rpc->fault(c, 500, "No domain list table"); + return; + } if ( domain_name_table_rpc_print(*domain_list_table, rpc, c) < 0 ) { LM_DBG("failed to print a subnet_table dump\n"); }

9 years, 4 months

git:master:0c42a848: rr: fix detecting next strict router

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0c42a848258d475f57ea25458bc75e55dcee948d URL: https://github.com/kamailio/kamailio/commit/0c42a848258d475f57ea25458bc75e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T18:57:53+02:00 rr: fix detecting next strict router - a regression after adding support for sip-outbound - more verbose debug messages - reported by Antonio Real, GH #267 --- Modified: modules/rr/loose.c --- Diff: https://github.com/kamailio/kamailio/commit/0c42a848258d475f57ea25458bc75e5… Patch: https://github.com/kamailio/kamailio/commit/0c42a848258d475f57ea25458bc75e5… --- diff --git a/modules/rr/loose.c b/modules/rr/loose.c index de06bb3..76204c9 100644 --- a/modules/rr/loose.c +++ b/modules/rr/loose.c @@ -757,7 +757,7 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) int status = RR_DRIVEN; str uri; struct socket_info *si; - int uri_is_myself, next_is_strict; + int uri_is_myself; int use_ob = 0; hdr = _m->route; @@ -768,11 +768,11 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) routed_msg_id = 0; if (parse_uri(uri.s, uri.len, &puri) < 0) { - LM_ERR("failed to parse the first route URI\n"); + LM_ERR("failed to parse the first route URI (%.*s)\n", + uri.len, ZSW(uri.s)); return RR_ERROR; } - next_is_strict = is_strict(&puri.params); routed_params = puri.params; uri_is_myself = is_myself(&puri); @@ -815,7 +815,8 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) /* double route may occure due different IP and port, so force as * send interface the one advertise in second Route */ if (parse_uri(rt->nameaddr.uri.s,rt->nameaddr.uri.len,&puri)<0) { - LM_ERR("failed to parse the double route URI\n"); + LM_ERR("failed to parse the double route URI (%.*s)\n", + rt->nameaddr.uri.len, ZSW(rt->nameaddr.uri.s)); return RR_ERROR; } @@ -852,7 +853,8 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) uri = rt->nameaddr.uri; if (parse_uri(uri.s, uri.len, &puri) < 0) { - LM_ERR("failed to parse the first route URI\n"); + LM_ERR("failed to parse the next route URI (%.*s)\n", + uri.len, ZSW(uri.s)); return RR_ERROR; } } else { @@ -867,7 +869,7 @@ static inline int after_loose(struct sip_msg* _m, int preloaded) } LM_DBG("URI to be processed: '%.*s'\n", uri.len, ZSW(uri.s)); - if (next_is_strict) { + if (is_strict(&puri.params)) { LM_DBG("Next URI is a strict router\n"); if (handle_sr(_m, hdr, rt) < 0) { LM_ERR("failed to handle strict router\n");

9 years, 4 months

[kamailio] Acc_Radius Ack packet and acc run egines bug- Kamailo 4.2.5 (#266)

by Yasin

Hello. When i tested acc_radius module , i realize module doesn't send ACK/ALIVE packets. So i digged the code i found acc module sends INVITE request instead of ACK. I fixed these on my local so you can check it and fix it ? First of all in acc_logic.c at acc_onack function - acc_run_engines(req, 0, NULL); +acc_run_engines(ack, 0, NULL); Second in acc.c at acc_run_engines - if((type==0) && ((e->acc_flag))) { +if((type==0) && (msg->flags&(e->acc_flag))) { Thanks http://sip-router.1086192.n5.nabble.com/About-Acc-radius-rad-sttaus-Functio… --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/266

9 years, 4 months

git:4.3:c68a6dca: acc: note about setting acc flag for ACKs that should be recorded

by Daniel-Constantin Mierla

Module: kamailio Branch: 4.3 Commit: c68a6dcad598130bc6894f1de5ef3b39eb789660 URL: https://github.com/kamailio/kamailio/commit/c68a6dcad598130bc6894f1de5ef3b3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-27T18:24:59+02:00 acc: note about setting acc flag for ACKs that should be recorded (cherry picked from commit 6656d4459f0c7d4c1b7cb5d2b214201c5a587c5c) --- Modified: modules/acc/README Modified: modules/acc/doc/acc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c68a6dcad598130bc6894f1de5ef3b3… Patch: https://github.com/kamailio/kamailio/commit/c68a6dcad598130bc6894f1de5ef3b3… --- diff --git a/modules/acc/README b/modules/acc/README index 2c742ee..a019b0e 100644 --- a/modules/acc/README +++ b/modules/acc/README @@ -767,7 +767,8 @@ modparam("acc", "failed_filter", "404,407") Shall acc attempt to account e2e ACKs too ? Note that this is really only an attempt, as e2e ACKs may take a different path (unless RR enabled) and mismatch original INVITE (e2e ACKs are a separate - transaction). + transaction). The flag for accounting has to be set for each ACK as + well. Default value is 0 (no). diff --git a/modules/acc/doc/acc_admin.xml b/modules/acc/doc/acc_admin.xml index 820f480..fbe7dc3 100644 --- a/modules/acc/doc/acc_admin.xml +++ b/modules/acc/doc/acc_admin.xml @@ -559,7 +559,8 @@ modparam("acc", "failed_filter", "404,407") Shall acc attempt to account e2e ACKs too ? Note that this is really only an attempt, as e2e ACKs may take a different path (unless RR enabled) and mismatch original INVITE (e2e ACKs are - a separate transaction). + a separate transaction). The flag for accounting has to be set + for each ACK as well. </para> <para> Default value is 0 (no).

9 years, 4 months

← Newer
1
...
8
9
10
11
12
13
14
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2015