sr-dev July 2015

sr-dev@lists.kamailio.org

26 participants
302 discussions

git:4.3:8ba3be20: siptrace: check if To header is parsed and available
by Daniel-Constantin Mierla 24 Jul '15

24 Jul '15

Module: kamailio Branch: 4.3 Commit: 8ba3be202f70a90ea88cdaac47fd2a7f9a9ef4f4 URL: https://github.com/kamailio/kamailio/commit/8ba3be202f70a90ea88cdaac47fd2a7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-24T12:44:51+02:00 siptrace: check if To header is parsed and available - it is accessed and can lead to crash if not prepared - reported by GH #263 (cherry picked from commit 93b297e16134b0e74cf83e3604da01355a52e700) --- Modified: modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/8ba3be202f70a90ea88cdaac47fd2a7… Patch: https://github.com/kamailio/kamailio/commit/8ba3be202f70a90ea88cdaac47fd2a7… --- diff --git a/modules/siptrace/siptrace.c b/modules/siptrace/siptrace.c index 4ee8f00..df6ceff 100644 --- a/modules/siptrace/siptrace.c +++ b/modules/siptrace/siptrace.c @@ -535,6 +535,11 @@ static int sip_trace_prepare(sip_msg_t *msg) goto error; } + if(parse_to_header(msg)==-1 || msg->to==NULL || get_to(msg)==NULL) { + LM_ERR("cannot parse To header\n"); + goto error; + } + if(parse_headers(msg, HDR_CALLID_F, 0)!=0 || msg->callid==NULL || msg->callid->body.s==NULL) { LM_ERR("cannot parse call-id\n");

1 0

git:master:93b297e1: siptrace: check if To header is parsed and available
by Daniel-Constantin Mierla 24 Jul '15

24 Jul '15

Module: kamailio Branch: master Commit: 93b297e16134b0e74cf83e3604da01355a52e700 URL: https://github.com/kamailio/kamailio/commit/93b297e16134b0e74cf83e3604da013… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-24T12:43:26+02:00 siptrace: check if To header is parsed and available - it is accessed and can lead to crash if not prepared - reported by GH #263 --- Modified: modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/93b297e16134b0e74cf83e3604da013… Patch: https://github.com/kamailio/kamailio/commit/93b297e16134b0e74cf83e3604da013… --- diff --git a/modules/siptrace/siptrace.c b/modules/siptrace/siptrace.c index 4ee8f00..df6ceff 100644 --- a/modules/siptrace/siptrace.c +++ b/modules/siptrace/siptrace.c @@ -535,6 +535,11 @@ static int sip_trace_prepare(sip_msg_t *msg) goto error; } + if(parse_to_header(msg)==-1 || msg->to==NULL || get_to(msg)==NULL) { + LM_ERR("cannot parse To header\n"); + goto error; + } + if(parse_headers(msg, HDR_CALLID_F, 0)!=0 || msg->callid==NULL || msg->callid->body.s==NULL) { LM_ERR("cannot parse call-id\n");

1 0

[kamailio] SipTrace module core dump on startup (#262)
by 00Asgaroth00 24 Jul '15

24 Jul '15

When I attempt to enable the siptrace module in my configuration, I am presented with the following error and the core dump: ``` /usr/sbin/kamailio[9782]: INFO: rr [../outbound/api.h:54]: ob_load_api(): Failed to import bind_ob /usr/sbin/kamailio[9782]: INFO: rr [rr_mod.c:174]: mod_init(): outbound module not available /usr/sbin/kamailio[9782]: INFO: path [../outbound/api.h:54]: ob_load_api(): Failed to import bind_ob /usr/sbin/kamailio[9782]: INFO: path [path_mod.c:147]: mod_init(): outbound module not available /usr/sbin/kamailio[9782]: INFO: permissions [permissions.c:608]: mod_init(): default allow file (/shared/kamailio/etc/permissions.allow) not found => empty rule set /usr/sbin/kamailio[9782]: INFO: permissions [permissions.c:617]: mod_init(): default deny file (/shared/kamailio/etc/permissions.deny) not found => empty rule set /usr/sbin/kamailio[9782]: INFO: pua [pua.c:447]: db_restore(): the query returned no result /usr/sbin/kamailio[9782]: WARNING: pua_dialoginfo [pua_dialoginfo.c:627]: mod_init(): pubruri_caller_dlg_var is not set - restore on restart disabled /usr/sbin/kamailio[9782]: WARNING: pua_dialoginfo [pua_dialoginfo.c:630]: mod_init(): pubruri_callee_dlg_var is not set - restore on restart disabled /usr/sbin/kamailio[9782]: ERROR: dispatcher [dispatcher.c:768]: ds_warn_fixup(): failover functions used, but required AVP parameters are NULL -- feature disabled /usr/sbin/kamailio[9782]: ERROR: dispatcher [dispatcher.c:768]: ds_warn_fixup(): failover functions used, but required AVP parameters are NULL -- feature disabled /usr/sbin/kamailio[9782]: INFO: <core> [udp_server.c:150]: probe_max_receive_buffer(): SO_RCVBUF is initially 124928 /usr/sbin/kamailio[9782]: INFO: <core> [udp_server.c:200]: probe_max_receive_buffer(): SO_RCVBUF is finally 249856 /usr/sbin/kamailio[9782]: INFO: <core> [udp_server.c:150]: probe_max_receive_buffer(): SO_RCVBUF is initially 124928 /usr/sbin/kamailio[9782]: INFO: <core> [udp_server.c:200]: probe_max_receive_buffer(): SO_RCVBUF is finally 249856 /usr/sbin/kamailio[9782]: INFO: <core> [udp_server.c:150]: probe_max_receive_buffer(): SO_RCVBUF is initially 124928 /usr/sbin/kamailio[9782]: INFO: <core> [udp_server.c:200]: probe_max_receive_buffer(): SO_RCVBUF is finally 249856 /usr/sbin/kamailio[9790]: INFO: ctl [io_listener.c:214]: io_listen_loop(): io_listen_loop: using epoll_lt io watch method (config) /usr/sbin/kamailio[9791]: ERROR: <core> [db.c:448]: db_use_table(): invalid parameter value /usr/sbin/kamailio[9791]: ERROR: <core> [db_query.c:203]: db_do_insert_cmd(): invalid parameter value /usr/sbin/kamailio[9792]: ERROR: <core> [db.c:448]: db_use_table(): invalid parameter value /usr/sbin/kamailio[9792]: ERROR: <core> [db_query.c:203]: db_do_insert_cmd(): invalid parameter value /usr/sbin/kamailio[9793]: ERROR: <core> [db.c:448]: db_use_table(): invalid parameter value /usr/sbin/kamailio[9793]: ERROR: <core> [db_query.c:203]: db_do_insert_cmd(): invalid parameter value /usr/sbin/kamailio[9794]: ERROR: <core> [db.c:448]: db_use_table(): invalid parameter value /usr/sbin/kamailio[9794]: ERROR: <core> [db_query.c:203]: db_do_insert_cmd(): invalid parameter value /usr/sbin/kamailio[9782]: ALERT: <core> [main.c:728]: handle_sigs(): child process 9792 exited by a signal 11 /usr/sbin/kamailio[9782]: ALERT: <core> [main.c:731]: handle_sigs(): core was generated /usr/sbin/kamailio[9782]: INFO: <core> [main.c:743]: handle_sigs(): terminating due to SIGCHLD /usr/sbin/kamailio[9795]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9783]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9789]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9796]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9787]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9790]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9785]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9784]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9788]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received /usr/sbin/kamailio[9786]: INFO: <core> [main.c:794]: sig_usr(): signal 15 received ``` The associate "thread apply all bt full" of the core file is as follows: ``` (gdb) thread apply all bt full Thread 1 (Thread 0x7fceace32700 (LWP 9792)): #0 0x00007fcea8237173 in db_postgres_store_result () from /usr/lib64/kamailio/modules/db_postgres.so No symbol table info available. #1 0x00007fcea8238898 in db_postgres_insert () from /usr/lib64/kamailio/modules/db_postgres.so No symbol table info available. #2 0x00007fce9ebd9ee6 in ?? () from /usr/lib64/kamailio/modules/siptrace.so No symbol table info available. #3 0x00007fce9ebd94dd in ?? () from /usr/lib64/kamailio/modules/siptrace.so No symbol table info available. #4 0x00007fce9ebe3223 in ?? () from /usr/lib64/kamailio/modules/siptrace.so No symbol table info available. #5 0x00007fcea3759735 in sl_run_callbacks () from /usr/lib64/kamailio/modules/sl.so No symbol table info available. #6 0x00007fcea3756835 in sl_reply_helper () from /usr/lib64/kamailio/modules/sl.so No symbol table info available. #7 0x00007fcea37575d2 in sl_send_reply () from /usr/lib64/kamailio/modules/sl.so No symbol table info available. #8 0x00007fcea374e7c5 in send_reply () from /usr/lib64/kamailio/modules/sl.so No symbol table info available. #9 0x00007fcea15cfaab in worker_loop () from /usr/lib64/kamailio/modules/dmq.so No symbol table info available. #10 0x00007fcea15b432c in ?? () from /usr/lib64/kamailio/modules/dmq.so No symbol table info available. #11 0x0000000000594031 in ?? () No symbol table info available. #12 0x0000000000593d6c in ?? () No symbol table info available. #13 0x0000000000593d6c in ?? () No symbol table info available. #14 0x0000000000593d6c in ?? () No symbol table info available. #15 0x0000000000593d6c in ?? () No symbol table info available. #16 0x0000000000593d6c in ?? () No symbol table info available. #17 0x0000000000593d6c in ?? () No symbol table info available. #18 0x0000000000593d6c in ?? () No symbol table info available. #19 0x0000000000593d6c in ?? () No symbol table info available. #20 0x0000000000593d6c in ?? () No symbol table info available. #21 0x0000000000593d6c in ?? () No symbol table info available. #22 0x0000000000593d6c in ?? () No symbol table info available. #23 0x0000000000593d6c in ?? () No symbol table info available. #24 0x0000000000593d6c in ?? () No symbol table info available. #25 0x0000000000593d6c in ?? () No symbol table info available. #26 0x0000000000593d6c in ?? () No symbol table info available. #27 0x0000000000593d6c in ?? () No symbol table info available. #28 0x000000000059433b in init_child () No symbol table info available. #29 0x00000000004a8880 in main_loop () No symbol table info available. #30 0x00000000004ae2d2 in main () No symbol table info available. ``` Kamailio version is 4.3.1: ``` # kamailio -V version: kamailio 4.3.1 (x86_64/linux) f38e67 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, F_MALLOC, DBG_F_MALLOC, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: f38e67 compiled on 18:15:23 Jul 20 2015 with gcc 4.4.7 ``` Siptrace parameters set are: ``` modparam("siptrace", "db_url", DBURL) modparam("siptrace", "hep_mode_on", 1) modparam("siptrace", "trace_to_database", 1) modparam("siptrace", "trace_flag", 22) modparam("siptrace", "trace_on", 1) ``` I came accross the following archive mail thread where it mentioned that there may be some issues with the mi module when loading siptrace: http://lists.sip-router.org/pipermail/sr-dev/2011-June/011417.html I'm not sure if it is in any way related, but if it is, I am loading the mi_rpc module as well, however, I did not issue any commands over rpc to activate the above crash. Let me know if you need any additional info from me to debug this further. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/262

2 4

git:4.3:ba7b0eab: siptrace: safety check if db connection is set
by Daniel-Constantin Mierla 24 Jul '15

24 Jul '15

Module: kamailio Branch: 4.3 Commit: ba7b0eaba0c14db6ea27190787aea25d30cfb2ca URL: https://github.com/kamailio/kamailio/commit/ba7b0eaba0c14db6ea27190787aea25… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-24T12:33:06+02:00 siptrace: safety check if db connection is set - reported in GH #262 (cherry picked from commit 740cfa0ebed20ba7b5ae2cab1b25aa2f6cd83899) --- Modified: modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/ba7b0eaba0c14db6ea27190787aea25… Patch: https://github.com/kamailio/kamailio/commit/ba7b0eaba0c14db6ea27190787aea25… --- diff --git a/modules/siptrace/siptrace.c b/modules/siptrace/siptrace.c index 07e3a1a..4ee8f00 100644 --- a/modules/siptrace/siptrace.c +++ b/modules/siptrace/siptrace.c @@ -757,6 +757,11 @@ static int sip_trace_store(struct _siptrace_data *sto, struct dest_info *dst) static int sip_trace_store_db(struct _siptrace_data *sto) { + if(db_con==NULL) { + LM_DBG("database connection not initialized\n"); + return -1; + } + if(trace_to_database_flag==NULL || *trace_to_database_flag==0) goto done;

1 0

git:master:740cfa0e: siptrace: safety check if db connection is set
by Daniel-Constantin Mierla 24 Jul '15

24 Jul '15

Module: kamailio Branch: master Commit: 740cfa0ebed20ba7b5ae2cab1b25aa2f6cd83899 URL: https://github.com/kamailio/kamailio/commit/740cfa0ebed20ba7b5ae2cab1b25aa2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2015-07-24T12:30:58+02:00 siptrace: safety check if db connection is set - reported in GH #262 --- Modified: modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/740cfa0ebed20ba7b5ae2cab1b25aa2… Patch: https://github.com/kamailio/kamailio/commit/740cfa0ebed20ba7b5ae2cab1b25aa2… --- diff --git a/modules/siptrace/siptrace.c b/modules/siptrace/siptrace.c index 07e3a1a..4ee8f00 100644 --- a/modules/siptrace/siptrace.c +++ b/modules/siptrace/siptrace.c @@ -757,6 +757,11 @@ static int sip_trace_store(struct _siptrace_data *sto, struct dest_info *dst) static int sip_trace_store_db(struct _siptrace_data *sto) { + if(db_con==NULL) { + LM_DBG("database connection not initialized\n"); + return -1; + } + if(trace_to_database_flag==NULL || *trace_to_database_flag==0) goto done;

1 0

git:4.2:8029691b: modules/tm: cycle through all the uac while checking for already existing branches
by Federico Cabiddu 23 Jul '15

23 Jul '15

Module: kamailio Branch: 4.2 Commit: 8029691be7d64960100590d08bdb1006d18d0f3b URL: https://github.com/kamailio/kamailio/commit/8029691be7d64960100590d08bdb100… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-07-23T15:28:50+02:00 modules/tm: cycle through all the uac while checking for already existing branches (cherry picked from commit 96ac163139976e8a9dea0e7252c66294054281b4) --- Modified: modules/tm/t_append_branches.c --- Diff: https://github.com/kamailio/kamailio/commit/8029691be7d64960100590d08bdb100… Patch: https://github.com/kamailio/kamailio/commit/8029691be7d64960100590d08bdb100… --- diff --git a/modules/tm/t_append_branches.c b/modules/tm/t_append_branches.c index 384c301..37f8025 100644 --- a/modules/tm/t_append_branches.c +++ b/modules/tm/t_append_branches.c @@ -119,7 +119,7 @@ int t_append_branches(void) { &bflags, &si, &ruid, &instance, &location_ua))) { LM_DBG("Current uri %.*s\n",current_uri.len, current_uri.s); - for (i=0; i<nr_branches; i++) { + for (i=0; i<=nr_branches; i++) { if (t->uac[i].ruid.len == ruid.len && !memcmp(t->uac[i].ruid.s, ruid.s, ruid.len)) { LM_DBG("branch already added [%.*s]\n", ruid.len, ruid.s);

1 0

git:4.3:5100ba7f: modules/tm: cycle through all the uac while checking for already existing branches
by Federico Cabiddu 23 Jul '15

23 Jul '15

Module: kamailio Branch: 4.3 Commit: 5100ba7f3e15456d45b78444c415cefd36485921 URL: https://github.com/kamailio/kamailio/commit/5100ba7f3e15456d45b78444c415cef… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-07-23T15:28:20+02:00 modules/tm: cycle through all the uac while checking for already existing branches (cherry picked from commit 96ac163139976e8a9dea0e7252c66294054281b4) --- Modified: modules/tm/t_append_branches.c --- Diff: https://github.com/kamailio/kamailio/commit/5100ba7f3e15456d45b78444c415cef… Patch: https://github.com/kamailio/kamailio/commit/5100ba7f3e15456d45b78444c415cef… --- diff --git a/modules/tm/t_append_branches.c b/modules/tm/t_append_branches.c index b276d9e..8060021 100644 --- a/modules/tm/t_append_branches.c +++ b/modules/tm/t_append_branches.c @@ -116,7 +116,7 @@ int t_append_branches(void) { &bflags, &si, &ruid, &instance, &location_ua))) { LM_DBG("Current uri %.*s\n",current_uri.len, current_uri.s); - for (i=0; i<nr_branches; i++) { + for (i=0; i<=nr_branches; i++) { if (t->uac[i].ruid.len == ruid.len && !memcmp(t->uac[i].ruid.s, ruid.s, ruid.len)) { LM_DBG("branch already added [%.*s]\n", ruid.len, ruid.s);

1 0

git:master:96ac1631: modules/tm: cycle through all the uac while checking for already existing branches
by Federico Cabiddu 23 Jul '15

23 Jul '15

Module: kamailio Branch: master Commit: 96ac163139976e8a9dea0e7252c66294054281b4 URL: https://github.com/kamailio/kamailio/commit/96ac163139976e8a9dea0e7252c6629… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2015-07-23T15:25:44+02:00 modules/tm: cycle through all the uac while checking for already existing branches --- Modified: modules/tm/t_append_branches.c --- Diff: https://github.com/kamailio/kamailio/commit/96ac163139976e8a9dea0e7252c6629… Patch: https://github.com/kamailio/kamailio/commit/96ac163139976e8a9dea0e7252c6629… --- diff --git a/modules/tm/t_append_branches.c b/modules/tm/t_append_branches.c index b276d9e..8060021 100644 --- a/modules/tm/t_append_branches.c +++ b/modules/tm/t_append_branches.c @@ -116,7 +116,7 @@ int t_append_branches(void) { &bflags, &si, &ruid, &instance, &location_ua))) { LM_DBG("Current uri %.*s\n",current_uri.len, current_uri.s); - for (i=0; i<nr_branches; i++) { + for (i=0; i<=nr_branches; i++) { if (t->uac[i].ruid.len == ruid.len && !memcmp(t->uac[i].ruid.s, ruid.s, ruid.len)) { LM_DBG("branch already added [%.*s]\n", ruid.len, ruid.s);

1 0

RFC: about the self signed tls certificates
by Daniel-Constantin Mierla 22 Jul '15

22 Jul '15

Hello, (cross-posting as it impacts users as well) Currently we generate and install the TLS self-signed certificates when tls module is installed, including them in the debian packages (and I guess in rpms). Debian has a policy of reproducible builds, meaning that from same source tree snapshot the same binary packages should result. Even more important considering the impact on security, it would be better that the certificates are generated locally on the installation server, to be distinct. Right now, people relying on default installation config/certificates (and I guess there are many, at least in testing phase), are exposed to eavesdropping, because the private key is available in public packages. My proposal is to move generation of self signed certificates to kamctl. There can be a kamctl.tls file to be deployed by the tls package (same is done by kamctl.mysql, being part of mysql package), which should add a new group of commands, among them something like: kamctl tls generate-certificate The drawback is that before enabling tls and starting kamailio, one has to run the above command. We can document that in tls module readme and in kamailio.cfg in the comments related to WITH_TLS define. Anyone with comments, pros/cons? Other suggestions on how to address the reproducible builds as well as solve the security issue for the default installation? Cheers, Daniel -- Daniel-Constantin Mierla http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Book: SIP Routing With Kamailio - http://www.asipto.com

6 5

[kamailio] cfgutils: sleep and usleep with pseudovariables support (#259)
by zolia 21 Jul '15

21 Jul '15

Hello, i would like to propose a support for pseudovariables in sleep and usleep functions. I know that there is such function as async_sleep, but it accepts only integer numbers (seconds) as a value. Delay in range of seconds for some SIP messages is way too long in some circumstances. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/259

2 3

← Newer
1
...
11
12
13
14
15
16
17
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2015