sr-dev January 2017

sr-dev@lists.kamailio.org

33 participants
538 discussions

git:master:63d63cb8: cdp: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: 63d63cb86f9fa5dc0c3c51d4161d31cbd92832d4 URL: https://github.com/kamailio/kamailio/commit/63d63cb86f9fa5dc0c3c51d4161d31c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-16T11:11:52+01:00 cdp: fix compiler warnings > receiver.c: In function 'send_fd': > receiver.c:287:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] > *(int*)CMSG_DATA(cmsg)=fd; > ^ > receiver.c: In function 'receive_fd': > receiver.c:385:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] > *fd=*((int*) CMSG_DATA(cmsg)); > ^ --- Modified: src/modules/cdp/receiver.c --- Diff: https://github.com/kamailio/kamailio/commit/63d63cb86f9fa5dc0c3c51d4161d31c… Patch: https://github.com/kamailio/kamailio/commit/63d63cb86f9fa5dc0c3c51d4161d31c… --- diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index 10660d2..a572384 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -266,6 +266,7 @@ static int send_fd(int pipe_fd,int fd, peer *p) struct msghdr msg; struct iovec iov[1]; int ret; + int *tmp = NULL; #ifdef HAVE_MSGHDR_MSG_CONTROL struct cmsghdr* cmsg; @@ -284,7 +285,8 @@ static int send_fd(int pipe_fd,int fd, peer *p) cmsg->cmsg_level = SOL_SOCKET; cmsg->cmsg_type = SCM_RIGHTS; cmsg->cmsg_len = CMSG_LEN(sizeof(fd)); - *(int*)CMSG_DATA(cmsg)=fd; + tmp = (int*)CMSG_DATA(cmsg); + *tmp = fd; msg.msg_flags=0; #else msg.msg_accrights=(caddr_t) &fd; @@ -328,6 +330,7 @@ static int receive_fd(int pipe_fd, int* fd,peer **p) struct iovec iov[1]; int new_fd; int ret; + int *tmp = NULL; #ifdef HAVE_MSGHDR_MSG_CONTROL struct cmsghdr* cmsg; @@ -382,7 +385,8 @@ static int receive_fd(int pipe_fd, int* fd,peer **p) LM_ERR("receive_fd: msg level != SOL_SOCKET\n"); goto error; } - *fd=*((int*) CMSG_DATA(cmsg)); + tmp = (int*)CMSG_DATA(cmsg); + *fd = *tmp; }else{ if(!cmsg) LM_ERR("receive_fd: no descriptor passed, empty control message");

7 years, 10 months

git:master:b6b1128c: cdp: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: b6b1128cb108ed248e6bdd57d9530ab22d0a7d21 URL: https://github.com/kamailio/kamailio/commit/b6b1128cb108ed248e6bdd57d9530ab… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-16T10:47:54+01:00 cdp: fix compiler warnings > In file included from ../../core/mem/shm.h:39:0, > from ../../core/mem/shm_mem.h:34, > from utils.h:50, > from diameter_peer.c:49: > ../../core/mem/../lock_ops.h:88:28: warning: 'futex_release' is static but used in inline function 'dp_del_pid' which is not static > #define lock_release(lock) futex_release(lock) > ^ > diameter_peer.c:141:2: note: in expansion of macro 'lock_release' > lock_release(pid_list_lock); > ^~~~~~~~~~~~ > ../../core/mem/../lock_ops.h:88:28: warning: 'futex_release' is static but used in inline function 'dp_del_pid' which is not static > #define lock_release(lock) futex_release(lock) > ^ > diameter_peer.c:130:3: note: in expansion of macro 'lock_release' > lock_release(pid_list_lock); > ^~~~~~~~~~~~ > ../../core/mem/../lock_ops.h:87:25: warning: 'futex_get' is static but used in inline function 'dp_del_pid' which is not static > #define lock_get(lock) futex_get(lock) > ^ > diameter_peer.c:127:2: note: in expansion of macro 'lock_get' > lock_get(pid_list_lock); > ^~~~~~~~ > ../../core/mem/../lock_ops.h:88:28: warning: 'futex_release' is static but used in inline function 'dp_last_pid' which is not static > #define lock_release(lock) futex_release(lock) > ^ > diameter_peer.c:116:2: note: in expansion of macro 'lock_release' > lock_release(pid_list_lock); > ^~~~~~~~~~~~ > ../../core/mem/../lock_ops.h:87:25: warning: 'futex_get' is static but used in inline function 'dp_last_pid' which is not static > #define lock_get(lock) futex_get(lock) > ^ > diameter_peer.c:113:2: note: in expansion of macro 'lock_get' > lock_get(pid_list_lock); > ^~~~~~~~ > ../../core/mem/../lock_ops.h:88:28: warning: 'futex_release' is static but used in inline function 'dp_add_pid' which is not static > #define lock_release(lock) futex_release(lock) > ^ > diameter_peer.c:103:2: note: in expansion of macro 'lock_release' > lock_release(pid_list_lock); > ^~~~~~~~~~~~ > ../../core/mem/../lock_ops.h:88:28: warning: 'futex_release' is static but used in inline function 'dp_add_pid' which is not static > #define lock_release(lock) futex_release(lock) > ^ > diameter_peer.c:94:3: note: in expansion of macro 'lock_release' > lock_release(pid_list_lock); > ^~~~~~~~~~~~ > ../../core/mem/../lock_ops.h:87:25: warning: 'futex_get' is static but used in inline function 'dp_add_pid' which is not static > #define lock_get(lock) futex_get(lock) > ^ > diameter_peer.c:90:2: note: in expansion of macro 'lock_get' > lock_get(pid_list_lock); > ^~~~~~~~ --- Modified: src/modules/cdp/diameter_peer.c --- Diff: https://github.com/kamailio/kamailio/commit/b6b1128cb108ed248e6bdd57d9530ab… Patch: https://github.com/kamailio/kamailio/commit/b6b1128cb108ed248e6bdd57d9530ab… --- diff --git a/src/modules/cdp/diameter_peer.c b/src/modules/cdp/diameter_peer.c index 782011b..7efc867 100644 --- a/src/modules/cdp/diameter_peer.c +++ b/src/modules/cdp/diameter_peer.c @@ -84,7 +84,7 @@ extern gen_lock_t *peer_list_lock; /**< lock for the list of peers */ * @param pid newly forked pid * @returns 1 on success or 0 on error */ -inline int dp_add_pid(pid_t pid) +static inline int dp_add_pid(pid_t pid) { pid_list_t *n; lock_get(pid_list_lock); @@ -107,7 +107,7 @@ inline int dp_add_pid(pid_t pid) /** * Returns the last pid in the local process list. */ -inline int dp_last_pid() +static inline int dp_last_pid() { int pid; lock_get(pid_list_lock); @@ -121,7 +121,7 @@ inline int dp_last_pid() * Delete a pid from the process list * @param pid - the pid to remove */ -inline void dp_del_pid(pid_t pid) +static inline void dp_del_pid(pid_t pid) { pid_list_t *i; lock_get(pid_list_lock);

7 years, 10 months

git:master:6af1dee2: ims_registrar_pcscf: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: 6af1dee2c72e681cdeccc7390c621c20eb46b267 URL: https://github.com/kamailio/kamailio/commit/6af1dee2c72e681cdeccc7390c621c2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-16T10:14:47+01:00 ims_registrar_pcscf: fix compiler warnings > ul_callback.c: In function 'send_partial_publish': > ul_callback.c:258:5: warning: 'body' may be used uninitialized in this function [-Wmaybe-uninitialized] > if (body) { > ^ --- Modified: src/modules/ims_registrar_pcscf/ul_callback.c --- Diff: https://github.com/kamailio/kamailio/commit/6af1dee2c72e681cdeccc7390c621c2… Patch: https://github.com/kamailio/kamailio/commit/6af1dee2c72e681cdeccc7390c621c2… --- diff --git a/src/modules/ims_registrar_pcscf/ul_callback.c b/src/modules/ims_registrar_pcscf/ul_callback.c index 0691bf2..57b89da 100644 --- a/src/modules/ims_registrar_pcscf/ul_callback.c +++ b/src/modules/ims_registrar_pcscf/ul_callback.c @@ -193,6 +193,7 @@ int send_partial_publish(ppublic_t *impu, struct pcontact *c, int type) str p_asserted_identity_header; str publ_id; reginfo_event_t *new_event; + str *body = NULL; content_type.s = "application/reginfo+xml"; content_type.len = 23; @@ -216,7 +217,7 @@ int send_partial_publish(ppublic_t *impu, struct pcontact *c, int type) LM_DBG("p_asserted_identity_header: [%.*s]", p_asserted_identity_header.len, p_asserted_identity_header.s); LM_DBG("Sending publish\n"); - str *body = build_reginfo_partial(impu, c, type); + body = build_reginfo_partial(impu, c, type); if (body == NULL || body->s == NULL) { LM_ERR("Error on creating XML-Body for publish\n");

7 years, 10 months

git:master:73557ec8: ims_qos: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: 73557ec8db6747f7fb1544e558eec385880d5ed2 URL: https://github.com/kamailio/kamailio/commit/73557ec8db6747f7fb1544e558eec38… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-16T10:11:44+01:00 ims_qos: fix compiler warnings > rx_avp.c:955:19: warning: 'port_rtcp_b.len' may be used uninitialized in this function [-Wmaybe-uninitialized] > len2 = (permit_in.len + from_s.len + to_s.len + 3 /*for 'any'*/ + ipB->len + 4 + > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > proto_len + port_rtcp_b.len + 1/*nul terminator*/) * sizeof(char); > ~~~~~~~~~~^~~~~~~~~~~~~~~~~ > rx_avp.c:1055:19: warning: 'port_rtcp_a.len' may be used uninitialized in this function [-Wmaybe-uninitialized] > len2 = (permit_in.len + from_s.len + to_s.len + 3 /*for 'any'*/ + ipA->len + 4 + > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > proto_len + port_rtcp_a.len + 1/*nul terminator*/) * sizeof(char); > ~~~~~~~~~~^~~~~~~~~~~~~~~~~ --- Modified: src/modules/ims_qos/rx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/73557ec8db6747f7fb1544e558eec38… Patch: https://github.com/kamailio/kamailio/commit/73557ec8db6747f7fb1544e558eec38… --- diff --git a/src/modules/ims_qos/rx_avp.c b/src/modules/ims_qos/rx_avp.c index ecdbee0..fcf529e 100644 --- a/src/modules/ims_qos/rx_avp.c +++ b/src/modules/ims_qos/rx_avp.c @@ -680,7 +680,7 @@ AAA_AVP *rx_create_media_subcomponent_avp(int number, str* proto, int len, len2; int int_port_rctp_a,int_port_rctp_b; - str port_rtcp_a, port_rtcp_b; + str port_rtcp_a = STR_NULL, port_rtcp_b = STR_NULL; AAA_AVP *flow_description1 = 0, *flow_description2 = 0, *flow_description3 = 0, *flow_description4 = 0, *flow_number = 0; AAA_AVP *flow_description5 = 0, *flow_description6 = 0, *flow_description7 = 0, *flow_description8 = 0; AAA_AVP *flow_usage = 0;

7 years, 10 months

git:master:49fa527a: ims_icscf: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: 49fa527af4028904a13122517b61a6535837c4b6 URL: https://github.com/kamailio/kamailio/commit/49fa527af4028904a13122517b61a65… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-16T10:06:29+01:00 ims_icscf: fix compiler warnings > cxdx_avp.c: In function 'cxdx_get_auth_data_item_answer': > cxdx_avp.c:625:26: warning: comparison of constant '4' with boolean expression is always false [-Wbool-compare] > if (!avp||!avp->data.len==4) *item_number=0; > ^~ > cxdx_avp.c:625:26: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] --- Modified: src/modules/ims_icscf/cxdx_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/49fa527af4028904a13122517b61a65… Patch: https://github.com/kamailio/kamailio/commit/49fa527af4028904a13122517b61a65… --- diff --git a/src/modules/ims_icscf/cxdx_avp.c b/src/modules/ims_icscf/cxdx_avp.c index 8d833b7..7dbcc36 100644 --- a/src/modules/ims_icscf/cxdx_avp.c +++ b/src/modules/ims_icscf/cxdx_avp.c @@ -622,7 +622,7 @@ int cxdx_get_auth_data_item_answer(AAAMessage *msg, AAA_AVP **auth_data, avp = cdpb.AAAFindMatchingAVPList(list,0,AVP_IMS_SIP_Item_Number, IMS_vendor_id_3GPP,0); - if (!avp||!avp->data.len==4) *item_number=0; + if (!avp||avp->data.len!=4) *item_number=0; else *item_number = get_4bytes(avp->data.s); avp = cdpb.AAAFindMatchingAVPList(list,0,AVP_IMS_SIP_Authentication_Scheme,

7 years, 10 months

git:master:be969c36: ims_icscf: fix compiler warning

by Victor Seva

Module: kamailio Branch: master Commit: be969c3643fca5f07b32f434b454a1ef9b596fce URL: https://github.com/kamailio/kamailio/commit/be969c3643fca5f07b32f434b454a1e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-16T09:48:30+01:00 ims_icscf: fix compiler warning > cxdx_lir.c: In function 'async_cdp_lir_callback': > cxdx_lir.c:82:24: warning: unused variable 'ra_ctx' [-Wunused-variable] > struct run_act_ctx ra_ctx; > ^~~~~~ --- Modified: src/modules/ims_icscf/cxdx_lir.c --- Diff: https://github.com/kamailio/kamailio/commit/be969c3643fca5f07b32f434b454a1e… Patch: https://github.com/kamailio/kamailio/commit/be969c3643fca5f07b32f434b454a1e… --- diff --git a/src/modules/ims_icscf/cxdx_lir.c b/src/modules/ims_icscf/cxdx_lir.c index 25d7fef..efc0413 100644 --- a/src/modules/ims_icscf/cxdx_lir.c +++ b/src/modules/ims_icscf/cxdx_lir.c @@ -79,7 +79,6 @@ void free_saved_lir_transaction_data(saved_lir_transaction_t* data) { } void async_cdp_lir_callback(int is_timeout, void *param, AAAMessage *lia, long elapsed_msecs) { - struct run_act_ctx ra_ctx; str server_name; int *m_capab = 0, m_capab_cnt = 0; int *o_capab = 0, o_capab_cnt = 0;

7 years, 10 months

git:master:153f1fe2: ims_isc: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: 153f1fe21f3ee328262fc834eee2b6f554e30759 URL: https://github.com/kamailio/kamailio/commit/153f1fe21f3ee328262fc834eee2b6f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-16T09:37:52+01:00 ims_isc: fix compiler warnings > third_party_reg.c: In function 'r_send_third_party_reg': > third_party_reg.c:349:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation] > if (r->path.len) > ^~ > third_party_reg.c:352:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' > str pauri = {0,0}; > ^~~ --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/153f1fe21f3ee328262fc834eee2b6f… Patch: https://github.com/kamailio/kamailio/commit/153f1fe21f3ee328262fc834eee2b6f… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index 5d7fe96..b54d4e0 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -335,20 +335,21 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) { h.len += contact_s.len + isc_my_uri_sip.len + contact_e.len; - if (r->pvni.len) - h.len += p_visited_network_id_s.len + p_visited_network_id_e.len - + r->pvni.len; - - if (r->pani.len) - h.len += p_access_network_info_s.len + p_access_network_info_e.len - + r->pani.len; - - if (r->cv.len) - h.len += p_charging_vector_s.len + p_charging_vector_e.len + r->cv.len; - - if (r->path.len) - h.len += path_s.len + path_e.len + r->path.len + 6/*',' and ';lr' and '<' and '>'*/ + r->from.len /*adding our own address to path*/; - + if (r->pvni.len) { + h.len += p_visited_network_id_s.len + p_visited_network_id_e.len + + r->pvni.len; + } + if (r->pani.len) { + h.len += p_access_network_info_s.len + p_access_network_info_e.len + + r->pani.len; + } + if (r->cv.len) { + h.len += p_charging_vector_s.len + p_charging_vector_e.len + r->cv.len; + } + if (r->path.len) { + h.len += path_s.len + path_e.len + r->path.len + 6/*',' and ';lr' and '<' and '>'*/ + + r->from.len /*adding our own address to path*/; + } str pauri = {0,0}; if (p_associated_uri.data_len > 0)

7 years, 10 months

git:master:8ed750ea: tm: timer - updated old style log messages

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 8ed750ea5af5950527ce1f6984f731aa170b139e URL: https://github.com/kamailio/kamailio/commit/8ed750ea5af5950527ce1f6984f731a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-15T11:22:41+01:00 tm: timer - updated old style log messages --- Modified: src/modules/tm/timer.c Modified: src/modules/tm/timer.h Modified: src/modules/tm/tm.c --- Diff: https://github.com/kamailio/kamailio/commit/8ed750ea5af5950527ce1f6984f731a… Patch: https://github.com/kamailio/kamailio/commit/8ed750ea5af5950527ce1f6984f731a…

7 years, 10 months

git:master:1dc6da87: modules: readme files regenerated - tls ...

by Kamailio Dev

Module: kamailio Branch: master Commit: 1dc6da87180a01f21554f2e857ec280814ba05e5 URL: https://github.com/kamailio/kamailio/commit/1dc6da87180a01f21554f2e857ec280… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2017-01-14T22:01:15+01:00 modules: readme files regenerated - tls ... --- Modified: src/modules/tls/README --- Diff: https://github.com/kamailio/kamailio/commit/1dc6da87180a01f21554f2e857ec280… Patch: https://github.com/kamailio/kamailio/commit/1dc6da87180a01f21554f2e857ec280…

7 years, 10 months

git:master:b6458e9d: tls Update README - update links to openssl.org, add ref to BCP, remove mention of "SSL"

by Olle E. Johansson

Module: kamailio Branch: master Commit: b6458e9d1436936101b1fe3a3895c9857969d810 URL: https://github.com/kamailio/kamailio/commit/b6458e9d1436936101b1fe3a3895c98… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2017-01-14T21:51:47+01:00 tls Update README - update links to openssl.org, add ref to BCP, remove mention of "SSL" --- Modified: src/modules/tls/doc/params.xml Modified: src/modules/tls/doc/rpc.xml Modified: src/modules/tls/doc/tls.xml --- Diff: https://github.com/kamailio/kamailio/commit/b6458e9d1436936101b1fe3a3895c98… Patch: https://github.com/kamailio/kamailio/commit/b6458e9d1436936101b1fe3a3895c98…

7 years, 10 months

← Newer
1
...
20
21
22
23
24
25
26
...
54
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2017