sr-dev January 2017

sr-dev@lists.kamailio.org

33 participants
538 discussions

git:master:b1e49b5a: textopsx: updated old log messages

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b1e49b5ac14eca64e16ffef8d4b8aac41b7a31c9 URL: https://github.com/kamailio/kamailio/commit/b1e49b5ac14eca64e16ffef8d4b8aac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-13T13:41:58+01:00 textopsx: updated old log messages - use clang format --- Modified: src/modules/textopsx/api.h Modified: src/modules/textopsx/textopsx.c --- Diff: https://github.com/kamailio/kamailio/commit/b1e49b5ac14eca64e16ffef8d4b8aac… Patch: https://github.com/kamailio/kamailio/commit/b1e49b5ac14eca64e16ffef8d4b8aac…

7 years, 10 months

git:master:03e6757d: cdp: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: 03e6757d78d4439ce16df3d6e7f8023993c17df7 URL: https://github.com/kamailio/kamailio/commit/03e6757d78d4439ce16df3d6e7f8023… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-13T11:51:49+01:00 cdp: fix compiler warnings > acctstatemachine.c: In function 'update_gsu_response_timers': > acctstatemachine.c:80:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] > if (mscc_avp_list.head); > ^~ > acctstatemachine.c:81:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' > AAAFreeAVPList(&mscc_avp_list); > ^~~~~~~~~~~~~~ > authstatemachine.c: In function 'add_auth_session_timers': > authstatemachine.c:234:32: warning: 'lifetime' may be used uninitialized in this function [-Wmaybe-uninitialized] > x->last_requested_timeout = lifetime; > ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~ --- Modified: src/modules/cdp/acctstatemachine.c Modified: src/modules/cdp/authstatemachine.c --- Diff: https://github.com/kamailio/kamailio/commit/03e6757d78d4439ce16df3d6e7f8023… Patch: https://github.com/kamailio/kamailio/commit/03e6757d78d4439ce16df3d6e7f8023… --- diff --git a/src/modules/cdp/acctstatemachine.c b/src/modules/cdp/acctstatemachine.c index 29536fb..9d1a451 100644 --- a/src/modules/cdp/acctstatemachine.c +++ b/src/modules/cdp/acctstatemachine.c @@ -77,7 +77,7 @@ void update_gsu_response_timers(cdp_cc_acc_session_t* session, AAAMessage* msg) mscc_avp = mscc_avp->next; } - if (mscc_avp_list.head); + if (mscc_avp_list.head) AAAFreeAVPList(&mscc_avp_list); if (y.head) diff --git a/src/modules/cdp/authstatemachine.c b/src/modules/cdp/authstatemachine.c index eaefb0b..db0e244 100644 --- a/src/modules/cdp/authstatemachine.c +++ b/src/modules/cdp/authstatemachine.c @@ -157,7 +157,8 @@ void add_auth_session_timers(cdp_auth_session_t *x, AAAMessage *msg) { AAA_AVP *avp; char data[4]; uint32_t v; - uint32_t lifetime, timeout, grace; + uint32_t lifetime = 0; + uint32_t timeout, grace; avp = AAAFindMatchingAVP(msg, 0, AVP_Authorization_Lifetime, 0, 0); if (!avp) {

7 years, 10 months

git:master:f018b88b: ims_registrar_scscf: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: f018b88bfe0620f22e6c76a388eeb7e3408a4496 URL: https://github.com/kamailio/kamailio/commit/f018b88bfe0620f22e6c76a388eeb7e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-13T11:43:05+01:00 ims_registrar_scscf: fix compiler warnings > xdx_avp.c: In function 'cxdx_get_auth_data_item_answer': > cxdx_avp.c:655:26: warning: comparison of constant '4' with boolean expression is always false [-Wbool-compare] > if (!avp||!avp->data.len==4) *item_number=0; > ^~ > cxdx_callbacks.c: In function 'cxdx_process_rtr': > cxdx_callbacks.c:55:9: warning: unused variable 'i' [-Wunused-variable] > int i = 0; > ^ > lookup.c: In function 'term_impu_has_contact': > lookup.c:303:9: warning: unused variable 'i' [-Wunused-variable] > int i = 0; > ^ > reg_rpc.c: In function 'reg_rpc_dereg_impu': > reg_rpc.c:35:7: warning: unused variable 'i' [-Wunused-variable] > int i; > ^ > reply.c: In function 'calc_buf_len': > reply.c:95:9: warning: unused variable 'i' [-Wunused-variable] > int i=0; > ^ > reply.c: In function 'build_contact': > reply.c:434:9: warning: unused variable 'i' [-Wunused-variable] > int i=0; > ^ > registrar_notify.c: In function 'get_reginfo_partial': > registrar_notify.c:1791:9: warning: unused variable 'i' [-Wunused-variable] > int i; > ^ > save.c: In function 'get_number_of_valid_contacts': > save.c:674:9: warning: unused variable 'i' [-Wunused-variable] > int i; > ^ > save.c: In function 'update_contacts_helper.part.1': > save.c:110:6: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized] > int r; > ^ > save.c: In function 'update_contacts': > save.c:110:6: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized] > save.c:110:6: warning: 'r' may be used uninitialized in this function [-Wmaybe-uninitialized] --- Modified: src/modules/ims_registrar_scscf/cxdx_avp.c Modified: src/modules/ims_registrar_scscf/cxdx_callbacks.c Modified: src/modules/ims_registrar_scscf/lookup.c Modified: src/modules/ims_registrar_scscf/reg_rpc.c Modified: src/modules/ims_registrar_scscf/registrar_notify.c Modified: src/modules/ims_registrar_scscf/reply.c Modified: src/modules/ims_registrar_scscf/save.c --- Diff: https://github.com/kamailio/kamailio/commit/f018b88bfe0620f22e6c76a388eeb7e… Patch: https://github.com/kamailio/kamailio/commit/f018b88bfe0620f22e6c76a388eeb7e… --- diff --git a/src/modules/ims_registrar_scscf/cxdx_avp.c b/src/modules/ims_registrar_scscf/cxdx_avp.c index ab9490a..9fa122b 100644 --- a/src/modules/ims_registrar_scscf/cxdx_avp.c +++ b/src/modules/ims_registrar_scscf/cxdx_avp.c @@ -652,7 +652,7 @@ int cxdx_get_auth_data_item_answer(AAAMessage *msg, AAA_AVP **auth_data, avp = cdpb.AAAFindMatchingAVPList(list,0,AVP_IMS_SIP_Item_Number, IMS_vendor_id_3GPP,0); - if (!avp||!avp->data.len==4) *item_number=0; + if (!avp||avp->data.len!=4) *item_number=0; else *item_number = get_4bytes(avp->data.s); avp = cdpb.AAAFindMatchingAVPList(list,0,AVP_IMS_SIP_Authentication_Scheme, diff --git a/src/modules/ims_registrar_scscf/cxdx_callbacks.c b/src/modules/ims_registrar_scscf/cxdx_callbacks.c index d21b1d3..8fc5142 100644 --- a/src/modules/ims_registrar_scscf/cxdx_callbacks.c +++ b/src/modules/ims_registrar_scscf/cxdx_callbacks.c @@ -52,7 +52,6 @@ AAAMessage* cxdx_process_rtr(AAAMessage *rtr) { AAA_AVP* avp; str public_id; impurecord_t* r; - int i = 0; int res = 0; udomain_t* udomain; impu_contact_t *impucontact; diff --git a/src/modules/ims_registrar_scscf/lookup.c b/src/modules/ims_registrar_scscf/lookup.c index 2855efc..6652bab 100644 --- a/src/modules/ims_registrar_scscf/lookup.c +++ b/src/modules/ims_registrar_scscf/lookup.c @@ -300,7 +300,7 @@ int term_impu_has_contact(struct sip_msg* _m, udomain_t* _d, char* _s) { ucontact_t* ptr = 0; int res; int ret; - int i = 0; + impu_contact_t *impucontact; if (_m->new_uri.s) uri = _m->new_uri; diff --git a/src/modules/ims_registrar_scscf/reg_rpc.c b/src/modules/ims_registrar_scscf/reg_rpc.c index 66d4262..40c6e73 100644 --- a/src/modules/ims_registrar_scscf/reg_rpc.c +++ b/src/modules/ims_registrar_scscf/reg_rpc.c @@ -32,7 +32,6 @@ extern usrloc_api_t ul; static void reg_rpc_dereg_impu(rpc_t* rpc, void* ctx) { - int i; str impu; int res; udomain_t* domain; diff --git a/src/modules/ims_registrar_scscf/registrar_notify.c b/src/modules/ims_registrar_scscf/registrar_notify.c index 7ab41ac..61e1430 100644 --- a/src/modules/ims_registrar_scscf/registrar_notify.c +++ b/src/modules/ims_registrar_scscf/registrar_notify.c @@ -1788,7 +1788,6 @@ str generate_reginfo_full(udomain_t* _t, str* impu_list, int num_impus, str *exp str get_reginfo_partial(impurecord_t *r, ucontact_t *c, int event_type) { str x = {0, 0}; - int i; str buf, pad; char bufc[MAX_REGINFO_SIZE], padc[MAX_REGINFO_SIZE]; int expires = -1; diff --git a/src/modules/ims_registrar_scscf/reply.c b/src/modules/ims_registrar_scscf/reply.c index 559135a..0b99b7f 100644 --- a/src/modules/ims_registrar_scscf/reply.c +++ b/src/modules/ims_registrar_scscf/reply.c @@ -92,7 +92,6 @@ static struct { static inline unsigned int calc_buf_len(impurecord_t* impurec) { unsigned int len; int qlen; - int i=0; ucontact_t* c; param_t *tmp; impu_contact_t *impucontact; @@ -431,7 +430,6 @@ int build_contact(impurecord_t* impurec, contact_for_header_t** contact_header) ucontact_t* c; param_t* tmp; *contact_header = 0; - int i=0; impu_contact_t *impucontact; contact_for_header_t* tmp_contact_header = shm_malloc(sizeof (contact_for_header_t)); diff --git a/src/modules/ims_registrar_scscf/save.c b/src/modules/ims_registrar_scscf/save.c index e5c06f5..83d6cce 100644 --- a/src/modules/ims_registrar_scscf/save.c +++ b/src/modules/ims_registrar_scscf/save.c @@ -107,7 +107,7 @@ static inline int randomize_expires(int expires, int range) { * the default value */ static inline int calc_contact_expires(contact_t *c, int expires_hdr, int sos_reg) { - int r; + int r = 0; if(c && c->expires) str2int(&(c->expires->body), (unsigned int*) &r); else if (expires_hdr >= 0) @@ -671,7 +671,6 @@ static inline int unregister_contact(contact_t* chi, contact_state_t state) { * @return */ int get_number_of_valid_contacts(impurecord_t* impu) { - int i; int ret = 0; impu_contact_t *impucontact; get_act_time();

7 years, 10 months

git:master:b5dd54e9: ims_usrloc_scscf: fix compiler warnings

by Victor Seva

Module: kamailio Branch: master Commit: b5dd54e980bda1ed850d4899d2b6e3ce139832bb URL: https://github.com/kamailio/kamailio/commit/b5dd54e980bda1ed850d4899d2b6e3c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-13T11:17:37+01:00 ims_usrloc_scscf: fix compiler warnings > ul_rpc.c:49:2: note: in expansion of macro 'LM_DBG' > LM_DBG("Dumping S-CSCF usrloc snapshot to file: [%.s]\n", filename.len, filename.s); > ^~~~~~ > ucontact.c: In function 'print_ucontact': > ucontact.c:255:11: warning: unused variable 'st' [-Wunused-variable] > char* st = ""; > ^~ > ucontact.c: In function 'new_ucontact': > ucontact.c:143:17: warning: 'prev' may be used uninitialized in this function [-Wmaybe-uninitialized] > prev->next = curr; > ~~~~~~~~~~~^~~~~~ > impurecord.c:330:12: warning: 'rollback' defined but not used [-Wunused-variable] > static str rollback = str_init("ROLLBACK"); > ^~~~~~~~ --- Modified: src/modules/ims_usrloc_scscf/impurecord.c Modified: src/modules/ims_usrloc_scscf/ucontact.c Modified: src/modules/ims_usrloc_scscf/ul_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/b5dd54e980bda1ed850d4899d2b6e3c… Patch: https://github.com/kamailio/kamailio/commit/b5dd54e980bda1ed850d4899d2b6e3c… --- diff --git a/src/modules/ims_usrloc_scscf/impurecord.c b/src/modules/ims_usrloc_scscf/impurecord.c index b4a289b..8c50577 100644 --- a/src/modules/ims_usrloc_scscf/impurecord.c +++ b/src/modules/ims_usrloc_scscf/impurecord.c @@ -327,7 +327,7 @@ static str autocommit_off = str_init("SET AUTOCOMMIT=0"); static str fail_isolation_level = str_init("SET TRANSACTION ISOLATION LEVEL READ COMMITTED"); static str start_transaction = str_init("START TRANSACTION"); static str commit = str_init("COMMIT"); -static str rollback = str_init("ROLLBACK"); +/* static str rollback = str_init("ROLLBACK"); */ static str autocommit_on = str_init("SET AUTOCOMMIT=1"); static inline void start_dbtransaction() { diff --git a/src/modules/ims_usrloc_scscf/ucontact.c b/src/modules/ims_usrloc_scscf/ucontact.c index e4c41fd..2b7e074 100644 --- a/src/modules/ims_usrloc_scscf/ucontact.c +++ b/src/modules/ims_usrloc_scscf/ucontact.c @@ -82,7 +82,8 @@ extern int db_mode; */ ucontact_t* new_ucontact(str* _dom, str* _aor, str* _contact, ucontact_info_t* _ci) { ucontact_t *c; - param_t *prev, *curr, *param; + param_t *prev = NULL; + param_t *curr, *param; int first = 1; c = (ucontact_t*) shm_malloc(sizeof (ucontact_t)); @@ -252,7 +253,6 @@ void free_ucontact(ucontact_t* _c) { */ void print_ucontact(FILE* _f, ucontact_t* _c) { time_t t = time(0); - char* st = ""; param_t * tmp; fprintf(_f, "\t~~~Contact(%p) (refcount: %d)~~~\n", _c, _c->ref_count); diff --git a/src/modules/ims_usrloc_scscf/ul_rpc.c b/src/modules/ims_usrloc_scscf/ul_rpc.c index d47c358..b3e3f2a 100644 --- a/src/modules/ims_usrloc_scscf/ul_rpc.c +++ b/src/modules/ims_usrloc_scscf/ul_rpc.c @@ -46,7 +46,7 @@ static void ul_rpc_snapshot(rpc_t* rpc, void *ctx) { } - LM_DBG("Dumping S-CSCF usrloc snapshot to file: [%.s]\n", filename.len, filename.s); + LM_DBG("Dumping S-CSCF usrloc snapshot to file: [%.*s]\n", filename.len, filename.s); current_time = time(NULL); t = localtime(&current_time);

7 years, 10 months

git:master:77d88007: sanity: updated from old style of log messages

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 77d8800767612d6ae198eddcd07c51a7e91174c0 URL: https://github.com/kamailio/kamailio/commit/77d8800767612d6ae198eddcd07c51a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-13T10:46:11+01:00 sanity: updated from old style of log messages - prefix with function names is no longer needed, it is added automatically --- Modified: src/modules/sanity/sanity.c Modified: src/modules/sanity/sanity_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/77d8800767612d6ae198eddcd07c51a… Patch: https://github.com/kamailio/kamailio/commit/77d8800767612d6ae198eddcd07c51a…

7 years, 10 months

git:master:5d7fe2c2: sanity: main file of the module renamed to sanity_mod.c

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5d7fe2c2e9d4669003681086651041ec5e74500a URL: https://github.com/kamailio/kamailio/commit/5d7fe2c2e9d4669003681086651041e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-13T10:46:11+01:00 sanity: main file of the module renamed to sanity_mod.c --- Added: src/modules/sanity/sanity_mod.c Added: src/modules/sanity/sanity_mod.h Modified: src/modules/sanity/Makefile Modified: src/modules/sanity/sanity.c Modified: src/modules/sanity/sanity.h Removed: src/modules/sanity/mod_sanity.c Removed: src/modules/sanity/mod_sanity.h --- Diff: https://github.com/kamailio/kamailio/commit/5d7fe2c2e9d4669003681086651041e… Patch: https://github.com/kamailio/kamailio/commit/5d7fe2c2e9d4669003681086651041e… --- diff --git a/src/modules/sanity/Makefile b/src/modules/sanity/Makefile old mode 100755 new mode 100644 diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 99faca9..7ddbb3d 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -21,7 +21,7 @@ * */ -#include "mod_sanity.h" +#include "sanity_mod.h" #include "sanity.h" #include "../../core/ut.h" #include "../../core/trim.h" diff --git a/src/modules/sanity/sanity.h b/src/modules/sanity/sanity.h index eec273e..2bf50c7 100644 --- a/src/modules/sanity/sanity.h +++ b/src/modules/sanity/sanity.h @@ -24,7 +24,7 @@ #ifndef SANITY_CHK_H #define SANITY_CHK_H -#include "mod_sanity.h" +#include "sanity_mod.h" #define SIP_VERSION_TWO_POINT_ZERO "2.0" #define SIP_VERSION_TWO_POINT_ZERO_LENGTH 3 diff --git a/src/modules/sanity/mod_sanity.c b/src/modules/sanity/sanity_mod.c similarity index 99% rename from src/modules/sanity/mod_sanity.c rename to src/modules/sanity/sanity_mod.c index 5a2579e..0575fd1 100644 --- a/src/modules/sanity/mod_sanity.c +++ b/src/modules/sanity/sanity_mod.c @@ -21,7 +21,7 @@ * */ -#include "mod_sanity.h" +#include "sanity_mod.h" #include "sanity.h" #include "api.h" #include "../../core/sr_module.h" diff --git a/src/modules/sanity/mod_sanity.h b/src/modules/sanity/sanity_mod.h similarity index 100% rename from src/modules/sanity/mod_sanity.h rename to src/modules/sanity/sanity_mod.h

7 years, 10 months

git:master:50854467: erlang: fix compuler warning

by Victor Seva

Module: kamailio Branch: master Commit: 5085446772fa43ffde30c752f955fe4a3067c826 URL: https://github.com/kamailio/kamailio/commit/5085446772fa43ffde30c752f955fe4… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2017-01-13T10:28:27+01:00 erlang: fix compuler warning > erlang_mod.c: In function 'erl_rpc': > erlang_mod.c:632:11: warning: 'pvn' may be used uninitialized in this function [-Wmaybe-uninitialized] > xrepl = xbuff_new(&pvn->u.isname.name.s); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- Modified: src/modules/erlang/erlang_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5085446772fa43ffde30c752f955fe4… Patch: https://github.com/kamailio/kamailio/commit/5085446772fa43ffde30c752f955fe4… --- diff --git a/src/modules/erlang/erlang_mod.c b/src/modules/erlang/erlang_mod.c index 0c15b9d..2753842 100644 --- a/src/modules/erlang/erlang_mod.c +++ b/src/modules/erlang/erlang_mod.c @@ -443,7 +443,7 @@ static int erl_rpc(struct sip_msg *msg, char *_m, char *_f, char *_a, char *_r) pv_spec_t sp; pv_spec_t *nsp; pv_param_t pvp; - pv_name_t *pvn; + pv_name_t *pvn=NULL; pv_index_t *pvi; int idx; int idxf;

7 years, 10 months

git:master:36e28f83: kamcmd: removed svn ids, history

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 36e28f83e7ae64409370c8163ccab749532944fc URL: https://github.com/kamailio/kamailio/commit/36e28f83e7ae64409370c8163ccab74… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2017-01-13T08:58:54+01:00 kamcmd: removed svn ids, history --- Modified: utils/kamcmd/kamcmd.c Modified: utils/kamcmd/license.h Modified: utils/kamcmd/parse_listen_id.c Modified: utils/kamcmd/parse_listen_id.h --- Diff: https://github.com/kamailio/kamailio/commit/36e28f83e7ae64409370c8163ccab74… Patch: https://github.com/kamailio/kamailio/commit/36e28f83e7ae64409370c8163ccab74…

7 years, 10 months

[kamailio/kamailio] sending repeated CANCEL (#870)

by sergey19

When you call, we use dlg_manage (); function to authorize the ISP with the following settings dialog module loadmodule "dialog.so" modparam ( "dialog", "enable_stats", 0) modparam ( "dialog", "db_url", DBURL) modparam ( "dialog", "db_mode", 1) modparam ( "dialog", "table_name", "dialog") modparam ( "dialog", "dlg_match_mode", 1) modparam ( "dialog", "dlg_flag", 4) modparam ( "dialog", "track_cseq_updates", 1) When sending a request ISP CANCEL get answers to 200 and 487, but instead of ACK otpralyaem COI new CANCEL. 10.1.244.235:5060 176.99.138.244:5060│ ──────────┬───────── ──────────┬───────── │ │ │ │ │ │ │ │ │ INVITE (SDP) │ │ ──────────────────────────> │ │ 401 Unauthorized │ │ <────────────────────────── │ │ ACK │ │ ──────────────────────────> │ │ INVITE (SDP) │ │ ──────────────────────────> │ │ 100 Trying │ │ <────────────────────────── │ │ 180 Ringing │ │ <────────────────────────── │ │ CANCEL │ │ ──────────────────────────> │ │ 487 Request Terminated │ │ <────────────────────────── │ │ 200 OK │ │ <────────────────────────── │ │ CANCEL │ │ ──────────────────────────> │ │ 500 Server error │ │ <────────────────────────── │ │ 487 Request Terminated │ │ <────────────────────────── │ │ 487 Request Terminated │ │ <<<──────────────────────── │ │ 487 Request Terminated │ │ <<<──────────────────────── │ how to remove the second CANCEL? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/870

7 years, 10 months

[kamailio/kamailio] CSeq issues with CANCEL after INVITE (#918)

by greggcz

Hi, I have a provider that requires proxy auth for all outgoing calls so I create the following config: ``` loadmodule "uac.so" loadmodule "dialog.so" modparam("dialog", "dlg_flag", 4) modparam("dialog", "track_cseq_updates", 1) modparam("dialog", "send_bye", 1) modparam("dialog", "timeout_noreset", 1) modparam("uac","auth_realm_avp","$avp(s:auth_realm_avp)") modparam("uac","auth_username_avp","$avp(s:auth_username_avp)") modparam("uac","auth_password_avp","$avp(s:auth_password_avp)") route { ...... dlg_manage(); # dispatch destinations to PSTN route(PSTN); ...... } failure_route[MANAGE_FAILURE] { route(NATMANAGE); if (t_is_canceled()) { exit; } if (t_check_status("401|407")) { $avp(s:auth_realm_avp) = "realm"; $avp(s:auth_username_avp) = "user"; $avp(s:auth_password_avp) = "pass"; if (uac_auth()) { xlog("L_INFO", "[MANAGE_FAILURE] did auth. Relaying to new destination. from=$fu, callee-selected-by=$ou, uri=$ru"); t_relay(); exit; } else { xlog("L_INFO", "[MANAGE_FAILURE] no matching realm found. realm=$ar"); } } } ``` Based on this authentication happens correctly however when canceling the call from the caller side, incorrect CSeq value is sent to the PSTN trunk: INVITE sip:48221028000@__provider__:6050 SIP/2.0 Record-Route: <sip:x.x.216.50;lr=on;ftag=327099285;did=14e.8df> Max-Forwards: 19 Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.0 Via: SIP/2.0/UDP x.x.219.61:1049;received=x.x.219.61;rport=1049;branch=z9hG4bK1237457362 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50> Call-ID: 1015351791(a)x.x.216.50 Allow: ACK, INVITE, BYE, CANCEL, OPTIONS, INFO CSeq: 74 INVITE Content-Type: application/sdp Content-Length: 481 v=0 o=yate 1483794545 1483794545 IN IP4 x.x.219.61 s=SIP Call c=IN IP4 x.x.219.61 t=0 0 m=audio 21596 RTP/AVP 0 8 11 98 97 102 103 104 105 106 101 a=rtpmap:0 PCMU/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:11 L16/8000 a=rtpmap:98 iLBC/8000 a=fmtp:98 mode=20 a=rtpmap:97 iLBC/8000 a=fmtp:97 mode=30 a=rtpmap:102 SPEEX/8000 a=rtpmap:103 SPEEX/16000 a=rtpmap:104 SPEEX/32000 a=rtpmap:105 iSAC/16000 a=rtpmap:106 iSAC/32000 a=rtpmap:101 telephone-event/8000 a=ptime:30 SIP/2.0 407 Proxy Authentication Required Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.0;received=x.x.216.50 Via: SIP/2.0/UDP x.x.219.61:1049;received=x.x.219.61;rport=1049;branch=z9hG4bK1237457362 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50>;tag=as386df8c6 Call-ID: 1015351791(a)x.x.216.50 CSeq: 74 INVITE User-Agent: Adescom CTM5000 Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO Max-Forwards: 70 Proxy-Authenticate: Digest realm="adescom", nonce="080cd7c6" Content-Length: 0 ACK sip:48221028000@__provider__:6050 SIP/2.0 Max-Forwards: 19 Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.0 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50>;tag=as386df8c6 Call-ID: 1015351791(a)x.x.216.50 CSeq: 74 ACK Content-Length: 0 INVITE sip:48221028000@__provider__:6050 SIP/2.0 Record-Route: <sip:x.x.216.50;lr=on;ftag=327099285;did=14e.8df> Max-Forwards: 19 Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.1.cs74 Via: SIP/2.0/UDP x.x.219.61:1049;received=x.x.219.61;rport=1049;branch=z9hG4bK1237457362 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50> Call-ID: 1015351791(a)x.x.216.50 Allow: ACK, INVITE, BYE, CANCEL, OPTIONS, INFO CSeq: 75 INVITE Content-Type: application/sdp Content-Length: 481 Proxy-Authorization: Digest username="___USER___", realm="adescom", nonce="080cd7c6", uri="sip:48221028000@__provider__:6050", response="521afedacdfa7033339e4956580bb0ec", algorithm=MD5 v=0 o=yate 1483794545 1483794545 IN IP4 x.x.219.61 s=SIP Call c=IN IP4 x.x.219.61 t=0 0 m=audio 21596 RTP/AVP 0 8 11 98 97 102 103 104 105 106 101 a=rtpmap:0 PCMU/8000 a=rtpmap:8 PCMA/8000 a=rtpmap:11 L16/8000 a=rtpmap:98 iLBC/8000 a=fmtp:98 mode=20 a=rtpmap:97 iLBC/8000 a=fmtp:97 mode=30 a=rtpmap:102 SPEEX/8000 a=rtpmap:103 SPEEX/16000 a=rtpmap:104 SPEEX/32000 a=rtpmap:105 iSAC/16000 a=rtpmap:106 iSAC/32000 a=rtpmap:101 telephone-event/8000 a=ptime:30 SIP/2.0 100 Trying Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.1.cs74;received=x.x.216.50 Via: SIP/2.0/UDP x.x.219.61:1049;received=x.x.219.61;rport=1049;branch=z9hG4bK1237457362 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50> Call-ID: 1015351791(a)x.x.216.50 CSeq: 75 INVITE User-Agent: Adescom CTM5000 Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO Max-Forwards: 70 Contact: <sip:48221028000@85.14.79.130:6050> Content-Length: 0 X-CTMG-HangupCause: Normal Clearing SIP/2.0 183 Session Progress Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.1.cs74;received=x.x.216.50 Via: SIP/2.0/UDP x.x.219.61:1049;received=x.x.219.61;rport=1049;branch=z9hG4bK1237457362 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50>;tag=as1fa0d5d0 Call-ID: 1015351791(a)x.x.216.50 CSeq: 75 INVITE User-Agent: Adescom CTM5000 Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO Max-Forwards: 70 Contact: <sip:48221028000@85.14.79.130:6050> Content-Type: application/sdp Content-Length: 226 v=0 o=root 7839 7839 IN IP4 85.14.79.130 s=session c=IN IP4 85.14.79.130 t=0 0 m=audio 30688 RTP/AVP 8 101 a=rtpmap:8 PCMA/8000 a=ptime:20 a=rtpmap:101 telephone-event/8000 a=fmtp:101 0-16 a=silenceSupp:off - - - - CANCEL sip:48221028000@__provider__:6050 SIP/2.0 Max-Forwards: 19 Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.1 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50> Call-ID: 1015351791(a)x.x.216.50 CSeq: 74 CANCEL Content-Length: 0 SIP/2.0 500 Server error Via: SIP/2.0/UDP x.x.216.50;branch=z9hG4bKa108.115652a5d470ecc5427124e7926af3b2.1;received=x.x.216.50 From: <sip:48221028008@x.x.216.50>;tag=327099285 To: <sip:48221028000@x.x.216.50>;tag=as1fa0d5d0 Call-ID: 1015351791(a)x.x.216.50 CSeq: 74 CANCEL User-Agent: Adescom CTM5000 Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO Max-Forwards: 70 Content-Length: 0 X-CTMG-HangupCause: Normal Clearing Since I'm new to Kamailio, I figured I must be doing something wrong but don't seem to find any working example anywhere.... -G -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/918

7 years, 10 months

← Newer
1
...
23
24
25
26
27
28
29
...
54
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2017