sr-dev December 2018

sr-dev@lists.kamailio.org

23 participants
314 discussions

[kamailio/kamailio] core: fixed segmentation fault when handling multipart bodies (#1759)
by Nacho G. 07 Dec '18

07 Dec '18

Function check_boundaries() in msg_translator.c not handling property the length of the buffers when it needs to repair the boundary, getting a negative lenght and causing a segmentation fault.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #1758 #### Description  Function check_boundaries() in msg_translator.c not handling property the length of the buffers when it needs to repair the boundary, getting a negative lenght and causing a segmentation fault. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1759 -- Commit Summary -- * core: fixed segmentation fault when handling multipart bodies -- File Changes -- M src/core/msg_translator.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1759.patch https://github.com/kamailio/kamailio/pull/1759.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1759

2 2

git:master:18e485a3: core: fixed segmentation fault when handling multipart bodies
by Victor Seva 07 Dec '18

07 Dec '18

Module: kamailio Branch: master Commit: 18e485a3172055fa5c808c2423629d5bbd10b37e URL: https://github.com/kamailio/kamailio/commit/18e485a3172055fa5c808c2423629d5… Author: Nacho Garcia Segovia <nacho.gs(a)zaleos.net> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-07T11:54:06+01:00 core: fixed segmentation fault when handling multipart bodies Function check_boundaries() in msg_translator.c not handling property the length of the buffers when it needs to repair the boundary, getting a negative lenght and causing a segmentation fault. --- Modified: src/core/msg_translator.c --- Diff: https://github.com/kamailio/kamailio/commit/18e485a3172055fa5c808c2423629d5… Patch: https://github.com/kamailio/kamailio/commit/18e485a3172055fa5c808c2423629d5… --- diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index a272aeb6bc..08e518a9d8 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -1838,10 +1838,10 @@ int check_boundaries(struct sip_msg *msg, struct dest_info *send_info) tmp.len = get_line(lb_t->s); if(tmp.len!=b.len || strncmp(b.s, tmp.s, b.len)!=0) { - LM_DBG("malformed bondary in the middle\n"); + LM_DBG("malformed boundary in the middle\n"); memcpy(pb, b.s, b.len); body.len = body.len + b.len; pb = pb + b.len; - t = lb_t->s.s - (lb_t->s.s + tmp.len); + t = lb_t->next->s.s - (lb_t->s.s + tmp.len); memcpy(pb, lb_t->s.s+tmp.len, t); pb = pb + t; /*LM_DBG("new chunk[%d][%.*s]\n", t, t, pb-t);*/ }

1 0

git:master:1285f784: core: small whitespace fix in event definition
by Henning Westerholt 06 Dec '18

06 Dec '18

Module: kamailio Branch: master Commit: 1285f7849d597aaa825d6a91955f03529f3d44f3 URL: https://github.com/kamailio/kamailio/commit/1285f7849d597aaa825d6a91955f035… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-06T22:28:54+01:00 core: small whitespace fix in event definition --- Modified: src/core/events.h --- Diff: https://github.com/kamailio/kamailio/commit/1285f7849d597aaa825d6a91955f035… Patch: https://github.com/kamailio/kamailio/commit/1285f7849d597aaa825d6a91955f035… --- diff --git a/src/core/events.h b/src/core/events.h index 191fe85cc8..9c4c54a2e5 100644 --- a/src/core/events.h +++ b/src/core/events.h @@ -26,7 +26,7 @@ #define SREV_NET_DATA_OUT 2 #define SREV_CORE_STATS 3 #define SREV_CFG_RUN_ACTION 4 -#define SREV_PKG_UPDATE_STATS 5 +#define SREV_PKG_UPDATE_STATS 5 #define SREV_RCV_NOSIP 6 #define SREV_NET_DGRAM_IN 7 #define SREV_TCP_HTTP_100C 8

1 0

git:master:d196ed8f: misc/examples/kemi/kamailio-basic-kemi-sqlang.js: use functions to match methods and myself
by Daniel-Constantin Mierla 06 Dec '18

06 Dec '18

Module: kamailio Branch: master Commit: d196ed8fa1483a1aa7ba24d22b452404ad83ecad URL: https://github.com/kamailio/kamailio/commit/d196ed8fa1483a1aa7ba24d22b45240… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-06T10:54:14+01:00 misc/examples/kemi/kamailio-basic-kemi-sqlang.js: use functions to match methods and myself --- Modified: misc/examples/kemi/kamailio-basic-kemi-sqlang.sq --- Diff: https://github.com/kamailio/kamailio/commit/d196ed8fa1483a1aa7ba24d22b45240… Patch: https://github.com/kamailio/kamailio/commit/d196ed8fa1483a1aa7ba24d22b45240…

1 0

git:master:856d2e03: misc/examples/kemi/kamailio-basic-kemi-jsdt.js: match from uri myself with function
by Daniel-Constantin Mierla 06 Dec '18

06 Dec '18

Module: kamailio Branch: master Commit: 856d2e03ea54cab6756dc61c3175df3638af9ce3 URL: https://github.com/kamailio/kamailio/commit/856d2e03ea54cab6756dc61c3175df3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-06T10:53:22+01:00 misc/examples/kemi/kamailio-basic-kemi-jsdt.js: match from uri myself with function --- Modified: misc/examples/kemi/kamailio-basic-kemi-jsdt.js --- Diff: https://github.com/kamailio/kamailio/commit/856d2e03ea54cab6756dc61c3175df3… Patch: https://github.com/kamailio/kamailio/commit/856d2e03ea54cab6756dc61c3175df3… --- diff --git a/misc/examples/kemi/kamailio-basic-kemi-jsdt.js b/misc/examples/kemi/kamailio-basic-kemi-jsdt.js index d7d55e465d..ea45b5a746 100644 --- a/misc/examples/kemi/kamailio-basic-kemi-jsdt.js +++ b/misc/examples/kemi/kamailio-basic-kemi-jsdt.js @@ -247,7 +247,7 @@ function ksr_route_auth() } } - if (KSR.is_REGISTER() || KSR.is_myself(KSR.pv.get("$fu"))) { + if (KSR.is_REGISTER() || KSR.is_myself_furi()) { // authenticate requests if (KSR.auth_db.auth_check(KSR.pv.get("$fd"), "subscriber", 1)<0) { KSR.auth.auth_challenge(KSR.pv.get("$fd"), 0);

1 0

git:master:d9c38917: misc/examples/kemi/kamailio-basic-kemi-jsdt.js: removed extra parenthesis
by Daniel-Constantin Mierla 06 Dec '18

06 Dec '18

Module: kamailio Branch: master Commit: d9c38917ad0fea678449c41a60d52c68b697f8a1 URL: https://github.com/kamailio/kamailio/commit/d9c38917ad0fea678449c41a60d52c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-06T10:34:54+01:00 misc/examples/kemi/kamailio-basic-kemi-jsdt.js: removed extra parenthesis --- Modified: misc/examples/kemi/kamailio-basic-kemi-jsdt.js --- Diff: https://github.com/kamailio/kamailio/commit/d9c38917ad0fea678449c41a60d52c6… Patch: https://github.com/kamailio/kamailio/commit/d9c38917ad0fea678449c41a60d52c6… --- diff --git a/misc/examples/kemi/kamailio-basic-kemi-jsdt.js b/misc/examples/kemi/kamailio-basic-kemi-jsdt.js index b1f5239cc8..d7d55e465d 100644 --- a/misc/examples/kemi/kamailio-basic-kemi-jsdt.js +++ b/misc/examples/kemi/kamailio-basic-kemi-jsdt.js @@ -40,7 +40,7 @@ function ksr_request_route() // -- only initial requests (no To tag) // handle retransmissions - if (!KSR.is_ACK())) { + if (!KSR.is_ACK()) { if (KSR.tmx.t_precheck_trans()>0) { KSR.tm.t_check_trans(); return;

1 0

git:master:323e96db: misc/examples/kemi/kamailio-basic-kemi-python.py: fix condition on user agent
by Daniel-Constantin Mierla 06 Dec '18

06 Dec '18

Module: kamailio Branch: master Commit: 323e96dbe5f263d66134183de8b2e8cff268431f URL: https://github.com/kamailio/kamailio/commit/323e96dbe5f263d66134183de8b2e8c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-06T10:22:12+01:00 misc/examples/kemi/kamailio-basic-kemi-python.py: fix condition on user agent --- Modified: misc/examples/kemi/kamailio-basic-kemi-python.py --- Diff: https://github.com/kamailio/kamailio/commit/323e96dbe5f263d66134183de8b2e8c… Patch: https://github.com/kamailio/kamailio/commit/323e96dbe5f263d66134183de8b2e8c… --- diff --git a/misc/examples/kemi/kamailio-basic-kemi-python.py b/misc/examples/kemi/kamailio-basic-kemi-python.py index eb31480f01..dc0f7957da 100644 --- a/misc/examples/kemi/kamailio-basic-kemi-python.py +++ b/misc/examples/kemi/kamailio-basic-kemi-python.py @@ -156,7 +156,7 @@ def ksr_route_reqinit(self, msg): KSR.pv.seti("$sht(ipban=>$si)", 1); return -255; - if KSR.corex.has_user_agent() : + if KSR.corex.has_user_agent() > 0 : ua = KSR.pv.gete("$ua") if (ua.find("friendly-scanner")!=-1 or ua.find("sipcli")!=-1) :

1 0

git:master:c3f3f088: misc/examples/kemi/kamailio-basic-kemi-lua.lua: fix condition on user agent
by Daniel-Constantin Mierla 06 Dec '18

06 Dec '18

Module: kamailio Branch: master Commit: c3f3f088cdcff566970c8af0e07e7ae5abb50504 URL: https://github.com/kamailio/kamailio/commit/c3f3f088cdcff566970c8af0e07e7ae… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-06T10:21:53+01:00 misc/examples/kemi/kamailio-basic-kemi-lua.lua: fix condition on user agent --- Modified: misc/examples/kemi/kamailio-basic-kemi-lua.lua --- Diff: https://github.com/kamailio/kamailio/commit/c3f3f088cdcff566970c8af0e07e7ae… Patch: https://github.com/kamailio/kamailio/commit/c3f3f088cdcff566970c8af0e07e7ae… --- diff --git a/misc/examples/kemi/kamailio-basic-kemi-lua.lua b/misc/examples/kemi/kamailio-basic-kemi-lua.lua index c9c1b0c5bc..4ae0b0e6ab 100644 --- a/misc/examples/kemi/kamailio-basic-kemi-lua.lua +++ b/misc/examples/kemi/kamailio-basic-kemi-lua.lua @@ -134,7 +134,7 @@ function ksr_route_reqinit() KSR.x.exit(); end end - if KSR.corex.has_user_agent() then + if KSR.corex.has_user_agent() > 0 then local ua = KSR.pv.gete("$ua"); if string.find(ua, "friendly-scanner") or string.find(ua, "sipcli") then @@ -178,7 +178,7 @@ function ksr_route_withindlg() elseif KSR.is_ACK() then -- ACK is forwarded statelessly ksr_route_natmanage(); - elseif KSR.is_NOTIFY() then + elseif KSR.is_NOTIFY() then -- Add Record-Route for in-dialog NOTIFY as per RFC 6665. KSR.rr.record_route(); end

1 0

git:master:3991bcf5: misc/examples/kemi/kamailio-basic-kemi-jsdt.js: use functions to match methods and myself
by Daniel-Constantin Mierla 06 Dec '18

06 Dec '18

Module: kamailio Branch: master Commit: 3991bcf5541d22d3a7ccaa3f89a9e0d189fd41b8 URL: https://github.com/kamailio/kamailio/commit/3991bcf5541d22d3a7ccaa3f89a9e0d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-06T10:21:05+01:00 misc/examples/kemi/kamailio-basic-kemi-jsdt.js: use functions to match methods and myself --- Modified: misc/examples/kemi/kamailio-basic-kemi-jsdt.js --- Diff: https://github.com/kamailio/kamailio/commit/3991bcf5541d22d3a7ccaa3f89a9e0d… Patch: https://github.com/kamailio/kamailio/commit/3991bcf5541d22d3a7ccaa3f89a9e0d…

1 0

New features: dialog - list dialogs via rpc using matching expressions
by Daniel-Constantin Mierla 06 Dec '18

06 Dec '18

Hello, being discussed and requested couple of times via lists, irc channel and discussions at events world wide, I just want to send a short note to announce that yesterday I pushed a new rpc command to dialog module that returns dialog records that match on conditions applied to request uri, from uri, to uri or callid fields. The filtering can be done with string comparison, regular expression or starts-with (prefix) matching. See more details at: - https://www.kamailio.org/docs/modules/devel/modules/dialog.html#dlg.r.list_… It should enable listing dialogs only for specific users, caller or callee, without dumping all dialogs. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference -- www.kamailioworld.com Kamailio Advanced Training, Nov 12-14, 2018, in Berlin -- www.asipto.com

1 0

← Newer
1
...
24
25
26
27
28
29
30
31
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2018