sr-dev December 2018

sr-dev@lists.kamailio.org

23 participants
313 discussions

[kamailio/kamailio] Module development - Best place for "km_log_func_set" logging call (#1753)

by Luis Martin Gil

When using the "km_log_func_set" to configure a customized Kamailio logging function: - **log_custom** module is setting this [per child](https://github.com/kamailio/kamailio/blob/master/src/modules/log_cus… in the **child_init** function. - **log_systemd** module is setting this in the [mod_register](https://github.com/kamailio/kamailio/blob/master/src/modules/… function. What is the best practice to follow? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1753

5 years, 11 months

git:master:b5dd847e: app_lua: support executing kemi functions with (str*, str*, int, int, str*) params

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b5dd847e5b81fe8ad0b32fc566d8524382b2d5d2 URL: https://github.com/kamailio/kamailio/commit/b5dd847e5b81fe8ad0b32fc566d8524… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T14:58:32+01:00 app_lua: support executing kemi functions with (str*, str*, int, int, str*) params --- Modified: src/modules/app_lua/app_lua_sr.c --- Diff: https://github.com/kamailio/kamailio/commit/b5dd847e5b81fe8ad0b32fc566d8524… Patch: https://github.com/kamailio/kamailio/commit/b5dd847e5b81fe8ad0b32fc566d8524… --- diff --git a/src/modules/app_lua/app_lua_sr.c b/src/modules/app_lua/app_lua_sr.c index 89b3a9fd40..8009f2970a 100644 --- a/src/modules/app_lua/app_lua_sr.c +++ b/src/modules/app_lua/app_lua_sr.c @@ -1853,6 +1853,16 @@ int sr_kemi_lua_exec_func_ex(lua_State* L, sr_kemi_t *ket, int pdelta) &vps[0].s, &vps[1].s, &vps[2].s, &vps[3].s, &vps[4].s); return sr_kemi_lua_return_int(L, ket, ret); + } else if(ket->ptypes[0]==SR_KEMIP_STR + && ket->ptypes[1]==SR_KEMIP_STR + && ket->ptypes[2]==SR_KEMIP_INT + && ket->ptypes[3]==SR_KEMIP_INT + && ket->ptypes[4]==SR_KEMIP_STR) { + ret = ((sr_kemi_fmssnns_f)(ket->func))(env_L->msg, + &vps[0].s, &vps[1].s, vps[2].n, vps[3].n, + &vps[4].s); + return sr_kemi_lua_return_int(L, ket, ret); + } else { LM_ERR("invalid parameters for: %.*s\n", fname->len, fname->s);

5 years, 11 months

git:master:a23f98c1: core: kemi - define for function type with (str*, str*, int, int, str*) params

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a23f98c1751fffb80463ea61c4de76f62f8dbb6f URL: https://github.com/kamailio/kamailio/commit/a23f98c1751fffb80463ea61c4de76f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T14:57:41+01:00 core: kemi - define for function type with (str*, str*, int, int, str*) params --- Modified: src/core/kemi.h --- Diff: https://github.com/kamailio/kamailio/commit/a23f98c1751fffb80463ea61c4de76f… Patch: https://github.com/kamailio/kamailio/commit/a23f98c1751fffb80463ea61c4de76f… --- diff --git a/src/core/kemi.h b/src/core/kemi.h index 0822c752f4..51ea72b43b 100644 --- a/src/core/kemi.h +++ b/src/core/kemi.h @@ -108,6 +108,7 @@ typedef int (*sr_kemi_fmssss_f)(sip_msg_t*, str*, str*, str*, str*); /* sip_msg_t and five int|str params */ typedef int (*sr_kemi_fmsssss_f)(sip_msg_t*, str*, str*, str*, str*, str*); +typedef int (*sr_kemi_fmssnns_f)(sip_msg_t*, str*, str*, int, int, str*); /* sip_msg_t and six int|str params */ typedef int (*sr_kemi_fmssssss_f)(sip_msg_t*, str*, str*, str*, str*, str*, str*);

5 years, 11 months

git:master:45cecdef: misc/examples: sample default config with websocket enabled

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 45cecdef62b43ea19a8be607faddbe9918b67f06 URL: https://github.com/kamailio/kamailio/commit/45cecdef62b43ea19a8be607faddbe9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T14:35:53+01:00 misc/examples: sample default config with websocket enabled --- Added: misc/examples/webrtc/kamailio-default-websocket.cfg --- Diff: https://github.com/kamailio/kamailio/commit/45cecdef62b43ea19a8be607faddbe9… Patch: https://github.com/kamailio/kamailio/commit/45cecdef62b43ea19a8be607faddbe9…

5 years, 11 months

git:master:52c236e6: misc/examples: kamailio-basic-kemi-python.py - use functions for method and myself checks

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 52c236e6417581b1f0354cc52f2eb5f762bc3b31 URL: https://github.com/kamailio/kamailio/commit/52c236e6417581b1f0354cc52f2eb5f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T11:45:38+01:00 misc/examples: kamailio-basic-kemi-python.py - use functions for method and myself checks --- Modified: misc/examples/kemi/kamailio-basic-kemi-python.py --- Diff: https://github.com/kamailio/kamailio/commit/52c236e6417581b1f0354cc52f2eb5f… Patch: https://github.com/kamailio/kamailio/commit/52c236e6417581b1f0354cc52f2eb5f…

5 years, 11 months

git:master:01f5ecbc: auth_xkeys: clone value before inserting the lump inside auth_xkeys_add()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 01f5ecbc45c236daea62d6638a02c168720c8479 URL: https://github.com/kamailio/kamailio/commit/01f5ecbc45c236daea62d6638a02c16… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T11:17:35+01:00 auth_xkeys: clone value before inserting the lump inside auth_xkeys_add() --- Modified: src/modules/auth_xkeys/auth_xkeys.c --- Diff: https://github.com/kamailio/kamailio/commit/01f5ecbc45c236daea62d6638a02c16… Patch: https://github.com/kamailio/kamailio/commit/01f5ecbc45c236daea62d6638a02c16… --- diff --git a/src/modules/auth_xkeys/auth_xkeys.c b/src/modules/auth_xkeys/auth_xkeys.c index 980260988e..53b7325dff 100644 --- a/src/modules/auth_xkeys/auth_xkeys.c +++ b/src/modules/auth_xkeys/auth_xkeys.c @@ -202,6 +202,7 @@ int auth_xkeys_add(sip_msg_t* msg, str *hdr, str *key, auth_xkey_t *itc; char xout[SHA512_DIGEST_STRING_LENGTH]; struct lump* anchor; + char *p; if(_auth_xkeys_list==NULL || *_auth_xkeys_list==NULL) { LM_ERR("no stored keys\n"); @@ -266,8 +267,16 @@ int auth_xkeys_add(sip_msg_t* msg, str *hdr, str *key, LM_ERR("can't get anchor\n"); return -1; } - if (insert_new_lump_before(anchor, xdata.s, xdata.len, 0) == 0) { + p = (char*)pkg_malloc(xdata.len+1); + if(p==NULL) { + LM_ERR("no more pkg memory\n"); + return -2; + } + memcpy(p, xdata.s, xdata.len); + p[xdata.len] = '\0'; + if (insert_new_lump_before(anchor, p, xdata.len, 0) == 0) { LM_ERR("cannot insert the new header [%.*s]\n", hdr->len, hdr->s); + pkg_free(p); return -1; } return 0;

5 years, 11 months

git:5.1:9d301849: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.1 Commit: 9d301849a145e89d2c82a7195234232e032fb8fb URL: https://github.com/kamailio/kamailio/commit/9d301849a145e89d2c82a7195234232… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2018-12-04T09:46:31+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/ims_charging/README Modified: src/modules/topos/README Modified: src/modules/websocket/README --- Diff: https://github.com/kamailio/kamailio/commit/9d301849a145e89d2c82a7195234232… Patch: https://github.com/kamailio/kamailio/commit/9d301849a145e89d2c82a7195234232… --- diff --git a/src/modules/ims_charging/README b/src/modules/ims_charging/README index 2d26fbaa4f..15941a0dfa 100644 --- a/src/modules/ims_charging/README +++ b/src/modules/ims_charging/README @@ -66,7 +66,7 @@ Carlos Ruiz Diaz 5. Functions 5.1. Ro_CCR(route_name, direction, reservation_units, - domain, incoming_trunk_id, outgoing_trunk_id + incoming_trunk_id, outgoing_trunk_id) 5.2. Ro_set_session_id_avp() @@ -163,8 +163,8 @@ Chapter 1. Admin Guide 5. Functions - 5.1. Ro_CCR(route_name, direction, reservation_units, domain, - incoming_trunk_id, outgoing_trunk_id + 5.1. Ro_CCR(route_name, direction, reservation_units, + incoming_trunk_id, outgoing_trunk_id) 5.2. Ro_set_session_id_avp() @@ -689,13 +689,13 @@ modparam("ims_charging", "custom_user_avp", "$avp(from_user)") 5. Functions - 5.1. Ro_CCR(route_name, direction, reservation_units, domain, - incoming_trunk_id, outgoing_trunk_id + 5.1. Ro_CCR(route_name, direction, reservation_units, + incoming_trunk_id, outgoing_trunk_id) 5.2. Ro_set_session_id_avp() -5.1. Ro_CCR(route_name, direction, reservation_units, domain, -incoming_trunk_id, outgoing_trunk_id +5.1. Ro_CCR(route_name, direction, reservation_units, incoming_trunk_id, +outgoing_trunk_id) Perform a CCR on Diameter Ro interface for Charging @@ -704,7 +704,6 @@ incoming_trunk_id, outgoing_trunk_id * direction "orig"inating or "term"inating * reservation_units how many units (at the moment seconds) should be reservated at the moment. - * domain Logical domain within registrar. * incoming_trunk_id Identifies the trunk group from which this originates. * outgoing_trunk_id Identifies the trunk group where this will be diff --git a/src/modules/topos/README b/src/modules/topos/README index c921117131..a9bd0d8327 100644 --- a/src/modules/topos/README +++ b/src/modules/topos/README @@ -161,7 +161,7 @@ modparam("topos", "mask_callid", 1) 3.4. sanity_checks (int) - If set to 1, topoh module will bind to sanity module in order to + If set to 1, topos module will bind to sanity module in order to perform sanity checks over received SIP request. Default sanity checks are done. It is useful to check if received request is well formated before proceeding to encoding/decoding. @@ -170,7 +170,7 @@ modparam("topos", "mask_callid", 1) Example 1.4. Set sanity_checks parameter ... -modparam("topoh", "sanity_checks", 1) +modparam("topos", "sanity_checks", 1) ... 3.5. branch_expire (int) diff --git a/src/modules/websocket/README b/src/modules/websocket/README index 158248654a..6421646e09 100644 --- a/src/modules/websocket/README +++ b/src/modules/websocket/README @@ -203,7 +203,7 @@ event_route[xhttp:request] { # Optional... perform HTTP authentication # ws_handle_handshake() exits (no further configuration file - # processing of the request) when complete. + # processing of the request) when complete in case of failure. if (ws_handle_handshake()) { # Optional... cache some information about the @@ -500,7 +500,8 @@ end Note This function returns 0, stopping all further processing of the - request, when there is a problem. + request, when there is a problem. Otherwise, it returns 1 (or positive + number) in case of success. Example 1.12. ws_handle_handshake usage ...

5 years, 11 months

git: new commits in branch 5.1

by Daniel-Constantin Mierla

- URL: https://github.com/kamailio/kamailio/commit/4ffe23dc473b170ec21ba9c6c32acfb… Author: Claudiu Boriga <paul.boriga(a)1and1.ro> Date: 2018-12-04T09:23:40+01:00 presence: test if event is dialog to avoid unnecessary xml parsing (cherry picked from commit 6d0f8994611b50faa7ef7d1299acf0c390a2eed1) - URL: https://github.com/kamailio/kamailio/commit/083c21b2070625e07fcd1eab4f9e293… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:27:25+01:00 core: cfg select - safety check accessing vars before initialization (cherry picked from commit 97855a1766edf4ecc2cc4e38f3cc0d3cea3190db) - URL: https://github.com/kamailio/kamailio/commit/1c506f448216e366d6a06ff5c1713f2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:27:36+01:00 topos: docs - replaced c&p topoh with topos (cherry picked from commit 56c40ebefcbe0954c5c40470b22d4f26e163a2d0) - URL: https://github.com/kamailio/kamailio/commit/d2a6728c6d7fd39d009150ddfa4c598… Author: dnadares <dnadares(a)gmail.com> Date: 2018-12-04T09:27:54+01:00 evapi: minor fix in tag length compare It was assigning the length instead of comparing it. (cherry picked from commit 3da3aa0c9ee3fcd5aadd3924ee883666d2a15ac6) - URL: https://github.com/kamailio/kamailio/commit/00720d55c2f838486a68b799e8f92ab… Author: mtirpak <miklos.tirpak(a)gmail.com> Date: 2018-12-04T09:28:11+01:00 core: variables declared in the config file could cause memory corruption The config variables that are declared in the config file were recorded in the reverse order as their padding was calculated, which could cause the allocated memory block to be smaller as required at the end. Credits go to vinesinha. (cherry picked from commit 2ecf601c472bb81b9cf4ffd5b1ac17c4dfd742f2) - URL: https://github.com/kamailio/kamailio/commit/64afdf27e7ea8e2ef38211af1233d78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:28:21+01:00 uac: test if qop field has a list of values for remote auth challenge - GH #1684 (cherry picked from commit 6e6a2f442e06a23aa180f07c2a954068dfc58843) - URL: https://github.com/kamailio/kamailio/commit/9bad6f16ce9b21b3f298eb03bb6c8ef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:28:39+01:00 dialog: handle alias in contact address for local bye only when no route headers - GH #1689 (cherry picked from commit 810d84981b4ed83b11e4090740a36653ec10ef16) - URL: https://github.com/kamailio/kamailio/commit/cd36828b3abb49ccb541e38f634e6a5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:28:53+01:00 rabbitmq: use fixup spve all - allow tracking parameter number - prefix to avoid conflict of common name function (cherry picked from commit 6745a6c784218130a28896cbfa4ea520047d8fc6) - URL: https://github.com/kamailio/kamailio/commit/5ca5ee2beed67efd5ab8a973367e754… Author: Lucian Balaceanu <lucian.balaceanu(a)1and1.ro> Date: 2018-12-04T09:29:01+01:00 pdb: fix SIGABRT in case of too long uris buf in pdb_msg_dbg should correctly accomodate for pdb_bdy size pdb_hdr + pdb_bdy should add to pdb_hdr.length (max 255) (cherry picked from commit 783763e8accef47aa563cd17d1e170250268751c) - URL: https://github.com/kamailio/kamailio/commit/d2b805d335c283ef5570c6cb5d61bd5… Author: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-04T09:29:50+01:00 core: add helper function for flag reset - add helper function for flag reset (needed for bugfix in #GH1674) - patch from: Julien Chavanton jchavanton at gmail dot com (cherry picked from commit 253d35c84bc1886c9eae774a731452f5d2f521cd) - URL: https://github.com/kamailio/kamailio/commit/f8ebc379063e316badf09faf368bd9a… Author: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-04T09:29:58+01:00 acc: fix generating duplicates for missed calls - fix generating duplicates for missed calls (#GH1674) - patch from Julien Chavanton jchavanton at gmail dot com (cherry picked from commit a7525829309427fbb9357e0104b9dba1016f6777) - URL: https://github.com/kamailio/kamailio/commit/54d00e9c4dfd8a30dd5f12930720bf7… Author: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-04T09:30:08+01:00 acc_diameter: fix generating duplicates for missed calls - fix generating duplicates for missed calls (#GH1674) - patch from Julien Chavanton jchavanton at gmail dot com (cherry picked from commit 3a471af738c6b8f7e717b7f2f4c6f9c579a2d9c8) - URL: https://github.com/kamailio/kamailio/commit/d3676df7e414aa995447488ba0977b7… Author: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-04T09:30:23+01:00 acc_radius: fix generating duplicates for missed calls - fix generating duplicates for missed calls (#GH1674) - patch from Julien Chavanton jchavanton at gmail dot com (cherry picked from commit 8cce4f243bc00f243671da7349edd3a11d5dc2ec) - URL: https://github.com/kamailio/kamailio/commit/348ede7e461e3482e93be161e4b98c8… Author: Sebastian Kemper <sebastian_ml(a)gmx.net> Date: 2018-12-04T09:30:53+01:00 dialplan: fix dp_replace() in cmd_export_t struct In the struct 'int param_no' is set to '2'. But dp_replace() has actually three parameters (dpid, inval, outvar), so kamailio's cfg parser fails when dp_replace() is called: yyparse(): cfg. parser: failed to find command dp_replace (params 3) yyerror_at(): parse error in config file /etc/kamailio/kamailio.cfg, line 366, column 45: unknown command, missing loadmodule? This commit fixes 'int param_no' to address this. Signed-off-by: Sebastian Kemper <sebastian_ml(a)gmx.net> (cherry picked from commit cbff35909edccffe778d04f3871d880195d82b7a) - URL: https://github.com/kamailio/kamailio/commit/aded9a07fdecaed51fb0af40db7ca2d… Author: Henning Westerholt <hw(a)kamailio.org> Date: 2018-12-04T09:31:11+01:00 kazoo: add kz prefix to str_split utility function - add kz prefix to str_split utility function, to prevent overlapping with a function with similar name in the json module (cherry picked from commit e8b905006e1a768cd8e328bd836ac43e5a2bc2f2) - URL: https://github.com/kamailio/kamailio/commit/921f1771d2bfd7d2f06bd6822b4b7ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:31:22+01:00 misc/examples: check return code for has_totag() in kemi lua script (cherry picked from commit 0d869c90eff536aea0f42c7e368535fec344f2f2) - URL: https://github.com/kamailio/kamailio/commit/57193ad2783cb3b170caa93aa107525… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:31:42+01:00 rabbitmq: renamed global variable, same name being used in some functions - global variables made static (cherry picked from commit 4f303b6fd548e89c59b074db94656f58aaff6adf) - URL: https://github.com/kamailio/kamailio/commit/b43dea08aed9ba24485e5851cce16dd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:31:53+01:00 rabbitmq: call function to release the amqp buffers (cherry picked from commit 88ebe33b6f8a21df6fa0720fef62dabe6b089c87) - URL: https://github.com/kamailio/kamailio/commit/afa6eecd1587d4fc566aaa29dc7f902… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:32:15+01:00 regex: fixed section ids for functions - removed trailing whitespaces (cherry picked from commit e8aec6d15bcef95f628108398e682571763464c5) - URL: https://github.com/kamailio/kamailio/commit/cb997ba65ffe5c159e9480f45b1b7f3… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-04T09:33:26+01:00 db_berkeley: fix compilation warning > CC (clang) [M db_berkeley.so] db_berkeley.o > db_berkeley.c:916:5: warning: variable 'dbcp' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if((ret = bdb_get_columns(_tp, _r, 0, 0)) != 0) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > db_berkeley.c:966:5: note: uninitialized use occurs here > if(dbcp) > ^~~~ > db_berkeley.c:916:2: note: remove the 'if' if its condition is always false > if((ret = bdb_get_columns(_tp, _r, 0, 0)) != 0) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > db_berkeley.c:901:6: warning: variable 'dbcp' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if(!lkey) { > ^~~~~ > db_berkeley.c:966:5: note: uninitialized use occurs here > if(dbcp) > ^~~~ > db_berkeley.c:901:3: note: remove the 'if' if its condition is always false > if(!lkey) { > ^~~~~~~~~~~ > db_berkeley.c:875:11: note: initialize the variable 'dbcp' to silence this warning > DBC *dbcp; > ^ > = NULL > 2 warnings generated. (cherry picked from commit 93e0b7e7bcefa900e8686e7e60f1a59cc32f9b39) (cherry picked from commit e377ec1fb2ce841b0b96c7f9c4cea935ad6f10f6) - URL: https://github.com/kamailio/kamailio/commit/34da446f129153c2254275f4cad1f5f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2018-12-04T09:33:37+01:00 kazoo: fix compilation warnings > kz_amqp.c:1884:5: warning: variable 'binding' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if(bind == NULL) { > ^~~~~~~~~~~~ > kz_amqp.c:1919:5: note: uninitialized use occurs here > if(binding != NULL) > ^~~~~~~ > kz_amqp.c:1884:2: note: remove the 'if' if its condition is always false > if(bind == NULL) { > ^~~~~~~~~~~~~~~~~~ > kz_amqp.c:1896:2: note: variable 'binding' is declared here > kz_amqp_binding_ptr binding = shm_malloc(sizeof(kz_amqp_binding)); > ^ > kz_amqp.c:1965:5: warning: variable 'binding' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if(bind == NULL) { > ^~~~~~~~~~~~ > kz_amqp.c:1992:8: note: uninitialized use occurs here > if(binding != NULL) > ^~~~~~~ > kz_amqp.c:1965:2: note: remove the 'if' if its condition is always false > if(bind == NULL) { > ^~~~~~~~~~~~~~~~~~ > kz_amqp.c:1972:2: note: variable 'binding' is declared here > kz_amqp_binding_ptr binding = shm_malloc(sizeof(kz_amqp_binding)); > ^ > kz_amqp.c:2875:5: warning: variable 'json_obj' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if(payload == NULL) { > ^~~~~~~~~~~~~~~ > kz_amqp.c:2927:5: note: uninitialized use occurs here > if(json_obj) > ^~~~~~~~ > kz_amqp.c:2875:2: note: remove the 'if' if its condition is always false > if(payload == NULL) { > ^~~~~~~~~~~~~~~~~~~~~ > kz_amqp.c:2880:2: note: variable 'json_obj' is declared here > json_obj_ptr json_obj = kz_json_parse(payload ); > ^ > 3 warnings generated. (cherry picked from commit 232e8400caf7173e73229627af0270a704824f62) (cherry picked from commit b2b8bc03d0658b0786a72e1e589b8b129ee7599e) - URL: https://github.com/kamailio/kamailio/commit/0c2ddea18d6c5a7d309cfffce4163d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:33:54+01:00 cfgutils: error log message mentioning the param lock_set_size (cherry picked from commit 55347626b189cd009c29b0e058949ed7671ae0d0) (cherry picked from commit 9374328bb2c05955658042fbf31807bd060a04de) - URL: https://github.com/kamailio/kamailio/commit/9883fbc438da48ea399d0f107e4bdc8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:34:07+01:00 tmx: use branch index for $T_rpl() cache invalidation (cherry picked from commit e2ca5516ae086cf33c61dbb9e653a5484cca2074) (cherry picked from commit 0305e2773a07472f442ab8cf4fbecdc0bffaf32b) - URL: https://github.com/kamailio/kamailio/commit/35204e8eec1f5830b89a331dac274b4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:34:25+01:00 websocket: aligned example statements - few more details about return code of handshake process (cherry picked from commit d33ee59bc807acf95b07838d24b888b14a286ddd) (cherry picked from commit 0327674281bcd27ef72bf617215f8e6e8f85a0a4) - URL: https://github.com/kamailio/kamailio/commit/792847b2a1b003f72caadf9334581f6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:34:53+01:00 tm: t_serial - safety check for searched xavps (cherry picked from commit 372993c82d2ebdafe9f7e1a672a3e3141a8ae2f5) (cherry picked from commit 0532b6fec0fecf5a6262b04a0e2e31d6b2cc315f) - URL: https://github.com/kamailio/kamailio/commit/f876ce5b5aba544495abb982f56fb00… Author: Yasin CANER <ycaner06(a)users.noreply.github.com> Date: 2018-12-04T09:36:06+01:00 core : add word to log get_boundary function added word to log for more understanding (cherry picked from commit 2daa351dd0cf716284ff90cd57d2241ee97f165d) (cherry picked from commit a1a95ab27911ce0ff02c3a7ec7c9286cfee82894) - URL: https://github.com/kamailio/kamailio/commit/2820a9620e31de907185d33de272773… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:36:34+01:00 core: function to test if a msg structure is faked request (cherry picked from commit ab72c5e7188266baef0da70f1aa7d7d28b6d077c) (cherry picked from commit e2ffc481a3f6673debf45f45abb7914e679c9f1b) - URL: https://github.com/kamailio/kamailio/commit/8b5b0466ab5524a9493d04bee89c903… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:36:42+01:00 async: return error if trying to execute for faked message - GH #1727 (cherry picked from commit 8b71c46ba0db05051ee24bf88491f00387e1ca8b) (cherry picked from commit 652180a88a549a6f2d91c39b053efce6b508c2ec) - URL: https://github.com/kamailio/kamailio/commit/bd234545b018512ae0adb04c27686f8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:36:54+01:00 topos: allow various replies for INVITE without contact - GH #1720 (cherry picked from commit 416d79b462986317f2c3a3ed8aa30a502d116095) (cherry picked from commit 3b586d554740ae578283024c1508e91b6ad886a2) - URL: https://github.com/kamailio/kamailio/commit/3b44a67b2d0910a0f5e92801a918a08… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:37:09+01:00 tm: info log message if attempting to create transaction for faked request (cherry picked from commit 4dd53abf13f9a98272af625f2a6591669730b374) (cherry picked from commit 156706c03a29a7aed5b8f73fab8216e4630c1f15) - URL: https://github.com/kamailio/kamailio/commit/42865170f9acddd0b3c2e14de8019d2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:37:20+01:00 tmx: do no suspend faked request (cherry picked from commit 6f6a0d136dfefe98631264092177344ed8d173a8) (cherry picked from commit eb661d2284d2d004b7affbcf0728ff6d32862283) - URL: https://github.com/kamailio/kamailio/commit/1a6dc025088f5a74e0f8593f930b536… Author: Surendra Tiwari <surendratiwari3(a)gmail.com> Date: 2018-12-04T09:37:33+01:00 rtpengine: print command in log message on timeout - few indentation fixes - GH #1732 (cherry picked from commit 9d1e8e256e49968776f7abb740a6d02739547ec2) (cherry picked from commit e9320c09738766d80fae2fe2b1704facbce6221a) - URL: https://github.com/kamailio/kamailio/commit/fa33d2be1321bba3238f536f1a4eeb4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:37:43+01:00 topos: do not add contact header in outgoing 1xx responses if not present - GH #1720 (cherry picked from commit dcf9ee88dbf68eeaf0f64d203ce831eb6f536a85) (cherry picked from commit 3e3b51b3989c02b97b825e6e8b8285d4d2b99ca3) - URL: https://github.com/kamailio/kamailio/commit/9c1e900ea4913dc4e2d7989dc899251… Author: Joonas Keskitalo <git(a)joonake.fi> Date: 2018-12-04T09:37:57+01:00 misc/examples/kemi: Added 'msg' argument to ksr_route_relay (cherry picked from commit a35503b3837cfc804f30c7493fbd13573c1a55e1) (cherry picked from commit 7dbeb45fd481d77a4ddee2432193eb7c1f1a937d) - URL: https://github.com/kamailio/kamailio/commit/6e1c4b6807e2b31e8e7400bc358a7b6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:38:07+01:00 topoh: safety checks for couple of mandatory headers - first via and call-id - GH #1735 (cherry picked from commit 97da6b1a5f656db4a91c8909167706fc8ec3d932) (cherry picked from commit 01828ecdff3e048845ee0cee58cfe1ffbceb761f) - URL: https://github.com/kamailio/kamailio/commit/4b9aef025073a850822a22d1359f657… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:38:16+01:00 topos: safety checks for couple of mandatory headers - first via and call-id (cherry picked from commit 93e40d5b7fb66d33f31c46dfaea5425062505127) (cherry picked from commit 69a34ef19e9365c810ecd2ea91a3d47076eed33a) - URL: https://github.com/kamailio/kamailio/commit/7409c34169e8f9976a435bae2ec782a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:38:26+01:00 topos: proper condition to detect 3xx redirect for contact updates - GH #1720 (cherry picked from commit 1f02ee62951523f001899d12d1750046f1ba53b6) (cherry picked from commit 6c768803e544cf8cf060b4099c601a9df0c1b7b8) - URL: https://github.com/kamailio/kamailio/commit/03c971d27b235b71d343e2771b87a34… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:39:21+01:00 presence: test if event is dialog when attempting to delete old records (cherry picked from commit 55c7f781be7cc40d0cd161640a47244aad60c0e7) (cherry picked from commit 8b6665b5d27fa8c36764078b9ae615075486a4b3) - URL: https://github.com/kamailio/kamailio/commit/24064631d8de14a9af89ad0748eff99… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:39:39+01:00 core: parse body - debug instead of error log message when mime mismatch - GH #1746 (cherry picked from commit 08820db104c7dbfce36af0f59dfcc28f97cffbd0) (cherry picked from commit 81f328095f6c06b5ca7cb18b6cdcfad430fb7359) - URL: https://github.com/kamailio/kamailio/commit/732f1b9c037f22c0d9932c2565ba9bf… Author: Yasin CANER <12412027+ycaner06(a)users.noreply.github.com> Date: 2018-12-04T09:39:51+01:00 ims_charging : doc is fixed ims_charging : doc is fixed (cherry picked from commit 37dae368667fc82bc2f60639d722354e6528ec7f) (cherry picked from commit 2375d07b774aa2d820bbeb155698305576e2ba74) - URL: https://github.com/kamailio/kamailio/commit/893562c7e698e001f6fe883ea7e5497… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2018-12-04T09:39:59+01:00 dialog: safety checks for local cseq and contact vars - avoid crash on systems not printing null string of length 0 - GH #1717 (cherry picked from commit 46401e465d88495d510d2cb36dc36ec86978c53e) (cherry picked from commit 79946bbb6d1731f503fc378ae38311b630e55999)

5 years, 11 months

[kamailio/kamailio] rtpengine : crash is fixed and codec flags added to doc (#1742)

by Yasin CANER

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Kamailio crashes when codec-flags value are not setted with codecs. it is fixed. codec-flags information added to document. An example is added to document. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1742 -- Commit Summary -- * rtpengine : add information to doc about transcode * rtpengine : codec flag crash is fixed * rtpengine : codec-transcode and other flags are added to doc -- File Changes -- M src/modules/rtpengine/doc/rtpengine_admin.xml (32) M src/modules/rtpengine/rtpengine.c (20) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1742.patch https://github.com/kamailio/kamailio/pull/1742.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1742

5 years, 11 months

git:master:a9a3ec02: rtpengine : crash is fixed and codec flags added to doc (#1742)

by Richard Fuchs

Module: kamailio Branch: master Commit: a9a3ec0214227d272338a827ceb4fd12cea94429 URL: https://github.com/kamailio/kamailio/commit/a9a3ec0214227d272338a827ceb4fd1… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2018-12-04T03:37:04-05:00 rtpengine : crash is fixed and codec flags added to doc (#1742) * rtpengine : add information to doc about transcode rtpengine : add information to doc about transcode parameter * rtpengine : codec flag crash is fixed codec-transcode , codec-strip , codec-mask , codec-offer gives crash without codec value.It is fixed and some logs are added for help. * rtpengine : codec-transcode and other flags are added to doc codec-transcode , codec-strip , codec-mask , codec-strip are added to doc with example. * rtpengine : str_key_val_prefix is fixed for null values str_key_val_prefix is fixed for null values * rtpengine : b parameter is changed with via-branch in document b parameter is changed with via-branch in document --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/a9a3ec0214227d272338a827ceb4fd1… Patch: https://github.com/kamailio/kamailio/commit/a9a3ec0214227d272338a827ceb4fd1…

5 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2018