Module: kamailio
Branch: master
Commit: 19572a828ffeb08b190dab5ae4aee93f03d9a7f2
URL: https://github.com/kamailio/kamailio/commit/19572a828ffeb08b190dab5ae4aee93…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2023-12-19T10:57:40+01:00
tm: clearer reply code handling for uac dlg
---
Modified: src/modules/tm/dlg.c
---
Diff: https://github.com/kamailio/kamailio/commit/19572a828ffeb08b190dab5ae4aee93…
Patch:…
[View More]https://github.com/kamailio/kamailio/commit/19572a828ffeb08b190dab5ae4aee93…
---
diff --git a/src/modules/tm/dlg.c b/src/modules/tm/dlg.c
index 420f95a98d2..29b8d50769f 100644
--- a/src/modules/tm/dlg.c
+++ b/src/modules/tm/dlg.c
@@ -666,7 +666,7 @@ static inline int dlg_new_resp_uac(dlg_t *_d, struct sip_msg *_m)
code = _m->first_line.u.reply.statuscode;
if(code < 200) {
- /* A provisional response, do nothing, we could
+ /* 100-199: a provisional response, do nothing, we could
* update remote tag and route set but we will do that
* for a positive final response anyway and I don't want
* bet on presence of these fields in provisional responses
@@ -674,8 +674,8 @@ static inline int dlg_new_resp_uac(dlg_t *_d, struct sip_msg *_m)
* Send a request to jan(a)iptel.org if you need to update
* the structures here
*/
- } else if((code >= 200) && (code < 299)) {
- /* A final response, update the structures and transit
+ } else if(code < 299) {
+ /* 200-299: a final response, update the structures and transit
* into DLG_CONFIRMED
*/
if(response2dlg(_m, _d) < 0)
@@ -687,7 +687,7 @@ static inline int dlg_new_resp_uac(dlg_t *_d, struct sip_msg *_m)
return -2;
}
} else {
- /* A negative final response, mark the dialog as destroyed
+ /* 300-699: a negative final response, mark the dialog as destroyed
* Again, I do not update the structures here because it
* makes no sense to me, a dialog shouldn't be used after
* it is destroyed
[View Less]
Hello,
In the kamailio core cookbook (https://www.kamailio.org/wiki/cookbooks/5.5.x/core#event_route) I read that the name of an event_route should be like this:
event_route[groupid:eventid]
Where:
groupid - should be the name of the module that triggers the event
eventid - some meaningful short text describing the event
Some modules of kamailio have underscores in the name, for example: http_async_client
Years ago a fix have been committed in order to allow underscores in the second part …
[View More]of the name, after the semicolon:
https://github.com/kamailio/kamailio/commit/5806703c1ff72243457ff55758f41c3…
But it seems that an underscore is still not allowed in the first part of the name:
https://github.com/kamailio/kamailio/blob/master/src/core/cfg.lex
EVENT_RT_NAME [a-zA-Z][0-9a-zA-Z-]*(":"[a-zA-Z][0-9a-zA-Z_-]*)+
So I wonder if this is a bug in the code or a mistake in the cookbook.
Thanks,
Luca
[View Less]
Hello,
a short announcement to inform that the dates for next Kamailio World
Conference have been set to April 18-19, 2024, the event to take place
again in Berlin, Germany. It will be a different venue than the past
editions, that one not being available. A pre-conference day is
considered on April 17, 2024, but it is not yet known in what form and
where.
The conference is scheduled a bit earlier than the usual in the year
because Germany hosts the Euro 2024 football championship during
June-…
[View More]July 2024, making May very busy and harder to find adequate
conferencing space in Berlin.
The website and more details will be published soon.
Cheers,
Daniel
--
Daniel-Constantin Mierla (@ asipto.com)
twitter.com/miconda -- linkedin.com/in/miconda
Kamailio Consultancy and Development Services
Kamailio Advanced Training -- asipto.com
[View Less]