sr-dev December 2023

sr-dev@lists.kamailio.org

14 participants
234 discussions

git:master:4399fe39: sms: define buffer size for name field

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4399fe3966f6774b18e02ea6e54a5ba132c7c4ab URL: https://github.com/kamailio/kamailio/commit/4399fe3966f6774b18e02ea6e54a5ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-21T13:56:28+01:00 sms: define buffer size for name field - check size before copy and trucate large messages --- Modified: src/modules/sms/libsms_getsms.c Modified: src/modules/sms/sms_funcs.h --- Diff: https://github.com/kamailio/kamailio/commit/4399fe3966f6774b18e02ea6e54a5ba… Patch: https://github.com/kamailio/kamailio/commit/4399fe3966f6774b18e02ea6e54a5ba… --- diff --git a/src/modules/sms/libsms_getsms.c b/src/modules/sms/libsms_getsms.c index 0f6df6b7341..ea258ccf673 100644 --- a/src/modules/sms/libsms_getsms.c +++ b/src/modules/sms/libsms_getsms.c @@ -279,6 +279,7 @@ static int splitascii(struct modem *mdm, char *source, struct incame_sms *sms) char *end; char tbuf[TIME_LEN + 1]; char dbuf[DATE_LEN + 1]; + int l1 = 0; /* the text is after the \r */ for(start = source; *start && *start != '\r'; start++) @@ -313,7 +314,13 @@ static int splitascii(struct modem *mdm, char *source, struct incame_sms *sms) return 1; } *end = 0; - strcpy(sms->name, start); + l1 = strlen(start); + if(l1 >= SMS_NAME_LEN) { + /* truncate */ + l1 = SMS_NAME_LEN - 1; + } + memcpy(sms->name, start, l1); + sms->name[l1] = '\0'; } /* Get the date */ start = end + 3; diff --git a/src/modules/sms/sms_funcs.h b/src/modules/sms/sms_funcs.h index e49427c91b7..4123b92c514 100644 --- a/src/modules/sms/sms_funcs.h +++ b/src/modules/sms/sms_funcs.h @@ -91,10 +91,11 @@ struct sms_msg int ref; }; +#define SMS_NAME_LEN 64 struct incame_sms { char sender[31]; - char name[64]; + char name[SMS_NAME_LEN]; char date[DATE_LEN]; char time[TIME_LEN]; char ascii[500];

1 year

git:master:b2045d55: pv: remove another redunant variable definition related commit 8ed4165fd3b0a33

by Henning Westerholt

Module: kamailio Branch: master Commit: b2045d559ed720789df80f543fc00923a07ada83 URL: https://github.com/kamailio/kamailio/commit/b2045d559ed720789df80f543fc0092… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-12-21T11:54:52Z pv: remove another redunant variable definition related commit 8ed4165fd3b0a33 --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/b2045d559ed720789df80f543fc0092… Patch: https://github.com/kamailio/kamailio/commit/b2045d559ed720789df80f543fc0092… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 1c822d014fa..03d025bba2f 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2479,7 +2479,7 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) while(paib != NULL) { if(n + paib->num_ids > idx) { /* Calculate the index within this specific list */ - int innerIndex = idx - n; + innerIndex = idx - n; /* Access the desired element within this list */ sval.s = paib->id[innerIndex].body.s;

1 year

git:master:0547a4be: pv: remove another redunant variable definition (warning: unused variable âinnerIndexâ)

by Henning Westerholt

Module: kamailio Branch: master Commit: 0547a4becbc6a48fdc473cfd26cdeedfa2a9317d URL: https://github.com/kamailio/kamailio/commit/0547a4becbc6a48fdc473cfd26cdeed… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-12-21T11:34:14Z pv: remove another redunant variable definition (warning: unused variable ��innerIndex��) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/0547a4becbc6a48fdc473cfd26cdeed… Patch: https://github.com/kamailio/kamailio/commit/0547a4becbc6a48fdc473cfd26cdeed… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 5375e95c418..1c822d014fa 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2427,7 +2427,7 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) while(ppib != NULL) { if(n + ppib->num_ids > idx) { /* Calculate the index within this specific list */ - int innerIndex = idx - n; + innerIndex = idx - n; /* Access the desired element within this list */ sval.s = ppib->id[innerIndex].body.s;

1 year

git:master:8ed4165f: pv: remove redunant variable definition (warning: unused variable âinnerIndexâ)

by Henning Westerholt

Module: kamailio Branch: master Commit: 8ed4165fd3b0a331a4580894e2e7f83456b474fa URL: https://github.com/kamailio/kamailio/commit/8ed4165fd3b0a331a4580894e2e7f83… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-12-21T11:23:51Z pv: remove redunant variable definition (warning: unused variable ��innerIndex��) --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/8ed4165fd3b0a331a4580894e2e7f83… Patch: https://github.com/kamailio/kamailio/commit/8ed4165fd3b0a331a4580894e2e7f83… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 4b8f98bcfd3..5375e95c418 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2375,7 +2375,7 @@ int pv_get_hfl(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) while(db != NULL) { if(n + db->num_ids > idx) { /* Calculate the index within this specific list */ - int innerIndex = idx - n; + innerIndex = idx - n; /* Access the desired element within this list */ sval.s = db->id[innerIndex].body.s;

1 year

git:master:64e42882: Makefile.groups: add dlgs and sworker to extra modules

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 64e4288217d4a9dd2441687b56f5dbd02b8549f4 URL: https://github.com/kamailio/kamailio/commit/64e4288217d4a9dd2441687b56f5dbd… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-20T13:07:34+01:00 Makefile.groups: add dlgs and sworker to extra modules --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/64e4288217d4a9dd2441687b56f5dbd… Patch: https://github.com/kamailio/kamailio/commit/64e4288217d4a9dd2441687b56f5dbd… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index bc56672e56d..8d15b198cc3 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -23,7 +23,7 @@ mod_list_extra=avp auth_diameter call_control call_obj dmq domainpolicy msrp \ carrierroute pdb qos sca seas sms sst timer tmrec uac_redirect \ xhttp xhttp_rpc xprint jsonrpcs nosip dmq_usrloc statsd rtjson \ log_custom keepalive ss7ops acc_diameter evrexec \ - sipjson lrkproxy math posops xhttp_prom + sipjson lrkproxy math posops xhttp_prom dlgs sworker # - common modules depending on database mod_list_db=acc alias_db auth_db avpops cfg_db db_text db_flatstore \

1 year

[kamailio/kamailio] Makefile.groups: add dlgs and sworker to extra modules (PR #3684)

by Federico Cabiddu

#### Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Currently dlgs and sworker modules are not packaged. We propose with this PR to add them to the extra modules list. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3684 -- Commit Summary -- * Makefile.groups: add dlgs and sworker to extra modules -- File Changes -- M src/Makefile.groups (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3684.patch https://github.com/kamailio/kamailio/pull/3684.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3684 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3684(a)github.com>

1 year

git:master:9bb1976b: Makefile.groups: removed app_sqlang from modules list

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9bb1976b4b7d52542a4de37144194bfc24649222 URL: https://github.com/kamailio/kamailio/commit/9bb1976b4b7d52542a4de37144194bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-20T10:06:59+01:00 Makefile.groups: removed app_sqlang from modules list --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/9bb1976b4b7d52542a4de37144194bf… Patch: https://github.com/kamailio/kamailio/commit/9bb1976b4b7d52542a4de37144194bf… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index 48e06e0646c..bc56672e56d 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -22,7 +22,7 @@ mod_list_basic=async auth benchmark blst cfg_rpc cfgutils corex counters \ mod_list_extra=avp auth_diameter call_control call_obj dmq domainpolicy msrp \ carrierroute pdb qos sca seas sms sst timer tmrec uac_redirect \ xhttp xhttp_rpc xprint jsonrpcs nosip dmq_usrloc statsd rtjson \ - log_custom keepalive ss7ops app_sqlang acc_diameter evrexec \ + log_custom keepalive ss7ops acc_diameter evrexec \ sipjson lrkproxy math posops xhttp_prom # - common modules depending on database

1 year

git:master:bab926d0: app_sqlang: module relocated to kamailio-archive repository

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: bab926d0b3eb69b5f15e9a49fdc52c937e164612 URL: https://github.com/kamailio/kamailio/commit/bab926d0b3eb69b5f15e9a49fdc52c9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-20T10:04:24+01:00 app_sqlang: module relocated to kamailio-archive repository - module is considered obsolete, not maintained - app_jsdt should be considered a better alternative, or app_lua, app_python3/s - located now at: https://github.com/kamailio/kamailio-archive/tree/main/src/modules/app_sqla… --- Removed: src/modules/app_sqlang/Makefile Removed: src/modules/app_sqlang/README Removed: src/modules/app_sqlang/app_sqlang_api.c Removed: src/modules/app_sqlang/app_sqlang_api.h Removed: src/modules/app_sqlang/app_sqlang_kemi_export.c Removed: src/modules/app_sqlang/app_sqlang_kemi_export.h Removed: src/modules/app_sqlang/app_sqlang_mod.c Removed: src/modules/app_sqlang/doc/Makefile Removed: src/modules/app_sqlang/doc/app_sqlang.xml Removed: src/modules/app_sqlang/doc/app_sqlang_admin.xml Removed: src/modules/app_sqlang/squirrel/include/sqconfig.h Removed: src/modules/app_sqlang/squirrel/include/sqstdaux.h Removed: src/modules/app_sqlang/squirrel/include/sqstdblob.h Removed: src/modules/app_sqlang/squirrel/include/sqstdio.h Removed: src/modules/app_sqlang/squirrel/include/sqstdmath.h Removed: src/modules/app_sqlang/squirrel/include/sqstdstring.h Removed: src/modules/app_sqlang/squirrel/include/sqstdsystem.h Removed: src/modules/app_sqlang/squirrel/include/squirrel.h Removed: src/modules/app_sqlang/squirrel/sqstdlib/Makefile Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdaux.cpp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdblob.cpp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdblobimpl.h Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdio.cpp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdlib.dsp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdmath.cpp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdrex.cpp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdstream.cpp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdstream.h Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdstring.cpp Removed: src/modules/app_sqlang/squirrel/sqstdlib/sqstdsystem.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/Makefile Removed: src/modules/app_sqlang/squirrel/squirrel/sqapi.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqarray.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqbaselib.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqclass.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqclass.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqclosure.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqcompiler.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqcompiler.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqdebug.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqfuncproto.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqfuncstate.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqfuncstate.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqlexer.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqlexer.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqmem.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqobject.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqobject.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqopcodes.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqpcheader.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqstate.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqstate.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqstring.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqtable.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqtable.h Removed: src/modules/app_sqlang/squirrel/squirrel/squirrel.dsp Removed: src/modules/app_sqlang/squirrel/squirrel/squserdata.h Removed: src/modules/app_sqlang/squirrel/squirrel/squtils.h Removed: src/modules/app_sqlang/squirrel/squirrel/sqvm.cpp Removed: src/modules/app_sqlang/squirrel/squirrel/sqvm.h Removed: src/modules/app_sqlang/utils/app_sqlang_ctl --- Diff: https://github.com/kamailio/kamailio/commit/bab926d0b3eb69b5f15e9a49fdc52c9… Patch: https://github.com/kamailio/kamailio/commit/bab926d0b3eb69b5f15e9a49fdc52c9…

1 year

git:master:943ff442: pipelimit: reformat exported structures

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 943ff442d85a041ba0285cc494ce0697f4dbae59 URL: https://github.com/kamailio/kamailio/commit/943ff442d85a041ba0285cc494ce069… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-20T09:36:57+01:00 pipelimit: reformat exported structures --- Modified: src/modules/pipelimit/pipelimit.c --- Diff: https://github.com/kamailio/kamailio/commit/943ff442d85a041ba0285cc494ce069… Patch: https://github.com/kamailio/kamailio/commit/943ff442d85a041ba0285cc494ce069…

1 year

git:master:5e1f8e6c: pipelimit: renamed global variable with module prefix

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5e1f8e6c93dae914665b2e97b38e8a3a0673d1f2 URL: https://github.com/kamailio/kamailio/commit/5e1f8e6c93dae914665b2e97b38e8a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-20T09:33:17+01:00 pipelimit: renamed global variable with module prefix - avoid overlapping global symbols --- Modified: src/modules/pipelimit/pipelimit.c --- Diff: https://github.com/kamailio/kamailio/commit/5e1f8e6c93dae914665b2e97b38e8a3… Patch: https://github.com/kamailio/kamailio/commit/5e1f8e6c93dae914665b2e97b38e8a3… --- diff --git a/src/modules/pipelimit/pipelimit.c b/src/modules/pipelimit/pipelimit.c index 625da0e50dd..a3412866eb3 100644 --- a/src/modules/pipelimit/pipelimit.c +++ b/src/modules/pipelimit/pipelimit.c @@ -68,7 +68,7 @@ MODULE_VERSION #define PL_TIMER_INTERVAL_DEFAULT 10 /** SL API structure */ -sl_api_t slb; +static sl_api_t _pl_slb; enum { @@ -368,7 +368,7 @@ static int mod_init(void) } /* bind the SL API */ - if(sl_load_api(&slb) != 0) { + if(sl_load_api(&_pl_slb) != 0) { LM_ERR("cannot bind to SL API\n"); return -1; } @@ -479,7 +479,7 @@ static int pl_drop(struct sip_msg *msg, unsigned int low, unsigned int high) LM_DBG("(%d, %d)\n", low, high); - if(slb.freply != 0) { + if(_pl_slb.freply != 0) { if(low != 0 && high != 0) { hdr.s = (char *)pkg_malloc(64); if(hdr.s == 0) { @@ -505,11 +505,11 @@ static int pl_drop(struct sip_msg *msg, unsigned int low, unsigned int high) return 0; } - ret = slb.freply(msg, pl_drop_code, &pl_drop_reason); + ret = _pl_slb.freply(msg, pl_drop_code, &pl_drop_reason); pkg_free(hdr.s); } else { - ret = slb.freply(msg, pl_drop_code, &pl_drop_reason); + ret = _pl_slb.freply(msg, pl_drop_code, &pl_drop_reason); } } else { LM_ERR("Can't send reply\n");

1 year

← Newer
1
...
9
10
11
12
13
14
15
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2023