sr-dev December 2023

sr-dev@lists.kamailio.org

14 participants
235 discussions

git:master:09318b6d: seas: if expression on else not needed
by Daniel-Constantin Mierla 27 Dec '23

27 Dec '23

Module: kamailio Branch: master Commit: 09318b6d0f224cace31d7db925f792b66cefd469 URL: https://github.com/kamailio/kamailio/commit/09318b6d0f224cace31d7db925f792b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-27T09:24:33+01:00 seas: if expression on else not needed - evaluation of it is true on else branch --- Modified: src/modules/seas/event_dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/09318b6d0f224cace31d7db925f792b… Patch: https://github.com/kamailio/kamailio/commit/09318b6d0f224cace31d7db925f792b… --- diff --git a/src/modules/seas/event_dispatcher.c b/src/modules/seas/event_dispatcher.c index 57483212686..e827629e53f 100644 --- a/src/modules/seas/event_dispatcher.c +++ b/src/modules/seas/event_dispatcher.c @@ -312,9 +312,7 @@ int dispatcher_main_loop(void) poll_fds[3 + as_nr].revents = 0; as_nr++; /*not very sure if this is thread-safe*/ unc_as_nr--; - } else if( - fd - <= 0) { /* pull the upper set of incomplete AS down and take this one out*/ + } else { /* pull the upper set of incomplete AS down and take this one out*/ poll_tmp->revents = 0; for(k = i; k < (unc_as_nr - 1); k++) { j = 3 + as_nr + k;

1 0

git:master:440a9955: ss7ops: adapt if expression for uint
by Daniel-Constantin Mierla 27 Dec '23

27 Dec '23

Module: kamailio Branch: master Commit: 440a9955b4ce21b8c3dae9d6159d24a92ec28e7c URL: https://github.com/kamailio/kamailio/commit/440a9955b4ce21b8c3dae9d6159d24a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-27T09:24:33+01:00 ss7ops: adapt if expression for uint - equal 0 or less than 1 is same in this case --- Modified: src/modules/ss7ops/ss7ops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/440a9955b4ce21b8c3dae9d6159d24a… Patch: https://github.com/kamailio/kamailio/commit/440a9955b4ce21b8c3dae9d6159d24a… --- diff --git a/src/modules/ss7ops/ss7ops_mod.c b/src/modules/ss7ops/ss7ops_mod.c index b0f84694658..8772ff56b6b 100644 --- a/src/modules/ss7ops/ss7ops_mod.c +++ b/src/modules/ss7ops/ss7ops_mod.c @@ -221,9 +221,7 @@ static const uint8_t *extract_from_m2pa(const uint8_t *data, size_t *len) } data += 8; data_len -= 8; - if(data_len == 0) - return NULL; - else if(data_len < 1) { + if(data_len < 1) { LM_ERR("M2PA no space for prio %u\n", data_len); return NULL; }

1 0

git:master:439d451a: github: [skip ci]: bump tj-actions/changed-files from 40 to 41
by Victor Seva 26 Dec '23

26 Dec '23

Module: kamailio Branch: master Commit: 439d451ab3172c1a22f88fd4ba0756ede2318191 URL: https://github.com/kamailio/kamailio/commit/439d451ab3172c1a22f88fd4ba0756e… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-26T08:44:50+01:00 github: [skip ci]: bump tj-actions/changed-files from 40 to 41 Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](https://github.com/tj-actions/changed-files/compare/v40...v41) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/devcontainer.yaml --- Diff: https://github.com/kamailio/kamailio/commit/439d451ab3172c1a22f88fd4ba0756e… Patch: https://github.com/kamailio/kamailio/commit/439d451ab3172c1a22f88fd4ba0756e… --- diff --git a/.github/workflows/devcontainer.yaml b/.github/workflows/devcontainer.yaml index bfecd095f55..1c2a584ed84 100644 --- a/.github/workflows/devcontainer.yaml +++ b/.github/workflows/devcontainer.yaml @@ -33,14 +33,14 @@ jobs: - name: Get changed files if: ${{ ! inputs.force }} id: changed-files - uses: tj-actions/changed-files@v40 + uses: tj-actions/changed-files@v41 with: since_last_remote_commit: true - name: changes in relevant files if: ${{ ! inputs.force }} id: changed-files-builder - uses: tj-actions/changed-files@v40 + uses: tj-actions/changed-files@v41 with: files: | .devcontainer/**

1 0

[kamailio/kamailio] github: [skip ci]: bump tj-actions/changed-files from 40 to 41 (PR #3693)
by dependabot[bot] 26 Dec '23

26 Dec '23

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tj-actions/changed-files/releases">tj… releases</a>.</em></p> <blockquote> <h2>v41</h2> <h1>Changes in v41.0.1</h1> <h2>What's Changed</h2> <ul> <li>Upgraded to v41 by <a href="https://github.com/tj-actions-bot"><code>@tj-acti… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1811&q… <li>chore(deps): update dependency eslint-plugin-prettier to v5.1.2 by <a href="https://github.com/renovate"><code>@renovate</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1813&q… <li>fix: update characters escaped by safe output by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1815&q… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/tj-actions/changed-files/compare/v41...v41.0.… <hr /> <h1>Changes in v41.0.0</h1> <h2>🔥 🔥 BREAKING CHANGE 🔥 🔥</h2> <p>A new <code>safe_output</code> input is now available to prevent outputting unsafe filename characters (Enabled by default). This would escape characters in the filename that could be used for command injection.</p> <blockquote> <p>[!NOTE] This can be disabled by setting the <code>safe_output</code> to false this comes with a recommendation to store all outputs generated in an environment variable first before using them.</p> </blockquote> <h4>Example</h4> <pre lang="yaml"><code>... - name: Get changed files id: changed-files uses: tj-actions/changed-files@v40 with: safe_output: false # set to false because we are using an environment variable to store the output and avoid command injection. <pre><code>- name: List all added files env: ADDED_FILES: ${{ steps.changed-files.outputs.added_files }} run: | for file in &amp;quot;$ADDED_FILES&amp;quot;; do echo &amp;quot;$file was added&amp;quot; done </code></pre> <p>... </code></pre></p> <h2>What's Changed</h2> <ul> <li>chore(deps): update typescript-eslint monorepo to v6.15.0 by <a href="https://github.com/renovate"><code>@renovate</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1801&q… <li>Upgraded to v40.2.3 by <a href="https://github.com/tj-actions-bot"><code>@tj-acti… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1800&q… <li>chore(deps): update dependency eslint-plugin-prettier to v5.1.0 by <a href="https://github.com/renovate"><code>@renovate</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1802&q… <li>chore(deps): lock file maintenance by <a href="https://github.com/renovate"><code>@renovate</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1803&q… <li>chore(deps): update dependency eslint-plugin-prettier to v5.1.1 by <a href="https://github.com/renovate"><code>@renovate</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1804&q… <li>fix: update safe output regex and the docs by <a href="https://github.com/tj-actions-bot"><code>@tj-acti… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1805&q… <li>Revert &quot;chore(deps): update actions/download-artifact action to v4&quot; by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1806&q… <li>Update README.md by <a href="https://github.com/jackton1"><code>@jackton1</… in <a href="https://redirect.github.com/tj-actions/changed-files/pull/1808&q… </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tj-actions/changed-files/blob/main/HISTORY.md… changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h1><a href="https://github.com/tj-actions/changed-files/compare/v41.0.0...v4… - (2023-12-24)</h1> <h2>🐛 Bug Fixes</h2> <ul> <li>Update characters escaped by safe output (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1815…) (<a href="https://github.com/tj-actions/changed-files/commit/716b1e1304286…) - (Tonye Jack)</li> </ul> <h2>⚙️ Miscellaneous Tasks</h2> <ul> <li><strong>deps:</strong> Update dependency eslint-plugin-prettier to v5.1.2 (<a href="https://github.com/tj-actions/changed-files/commit/7aaf10d9eef19…) - (renovate[bot])</li> </ul> <h2>⬆️ Upgrades</h2> <ul> <li>Upgraded to v41 (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1811… </ul> <p>Co-authored-by: jackton1 <a href="mailto:jackton1@users.noreply.github.com">jackton1@users.noreply.github.com</a> (<a href="https://github.com/tj-actions/changed-files/commit/cc08e170f4447…) - (tj-actions[bot])</p> <h1><a href="https://github.com/tj-actions/changed-files/compare/v40.2.3...v4… - (2023-12-23)</h1> <h2>🐛 Bug Fixes</h2> <ul> <li>Update safe output regex and the docs (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1805…) (<a href="https://github.com/tj-actions/changed-files/commit/ff2f6e6b91913…) - (tj-actions[bot])</li> </ul> <h2>⏪ Reverts</h2> <ul> <li>Revert &quot;chore(deps): update actions/download-artifact action to v4&quot; (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1806… </ul> <p>(<a href="https://github.com/tj-actions/changed-files/commit/4f573fed06c9a…) - (Tonye Jack)</p> <h2>🔄 Update</h2> <ul> <li>Update README.md (<a href="https://github.com/tj-actions/changed-files/commit/6e79d6e3dbe48…) - (Tonye Jack)</li> <li>Update README.md (<a href="https://github.com/tj-actions/changed-files/commit/d13ac1942fb3c…) - (Tonye Jack)</li> <li>Update README.md (<a href="https://github.com/tj-actions/changed-files/commit/bb89f97963be9…) - (Tonye Jack)</li> <li>Updated README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1810… </ul> <p>Co-authored-by: renovate[bot]  (<a href="https://github.com/tj-actions/changed-files/commit/1864078d0afad…) - (tj-actions[bot])</p> <ul> <li>Update README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1808… </ul> <p>(<a href="https://github.com/tj-actions/changed-files/commit/47371c50e97c0…) - (Tonye Jack)</p> <h2>📝 Other</h2> <ul> <li>Merge pull request from GHSA-mcph-m25j-8j63</li> </ul> <ul> <li> <p>feat: add <code>safe_output</code> input enabled by default</p> </li> <li> <p>fix: migrate README to safe uses of interpolation</p> </li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tj-actions/changed-files/commit/716b1e1304286… fix: update characters escaped by safe output (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1815… <li><a href="https://github.com/tj-actions/changed-files/commit/7aaf10d9eef19… chore(deps): update dependency eslint-plugin-prettier to v5.1.2</li> <li><a href="https://github.com/tj-actions/changed-files/commit/cc08e170f4447… Upgraded to v41 (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1811… <li><a href="https://github.com/tj-actions/changed-files/commit/6e79d6e3dbe48… Update README.md</li> <li><a href="https://github.com/tj-actions/changed-files/commit/d13ac1942fb3c… Update README.md</li> <li><a href="https://github.com/tj-actions/changed-files/commit/bb89f97963be9… Update README.md</li> <li><a href="https://github.com/tj-actions/changed-files/commit/1864078d0afad… Updated README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1810… <li><a href="https://github.com/tj-actions/changed-files/commit/f495a0321d3ff… chore(deps): lock file maintenance</li> <li><a href="https://github.com/tj-actions/changed-files/commit/47371c50e97c0… Update README.md (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1808… <li><a href="https://github.com/tj-actions/changed-files/commit/4f573fed06c9a… Revert &quot;chore(deps): update actions/download-artifact action to v4&quot; (<a href="https://redirect.github.com/tj-actions/changed-files/issues/1806… <li>Additional commits viewable in <a href="https://github.com/tj-actions/changed-files/compare/v40...v41&qu… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3693 -- Commit Summary -- * github: [skip ci]: bump tj-actions/changed-files from 40 to 41 -- File Changes -- M .github/workflows/devcontainer.yaml (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3693.patch https://github.com/kamailio/kamailio/pull/3693.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3693 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3693(a)github.com>

2 1

Merry Christmas and Happy Holidays 2023-2024!
by Daniel-Constantin Mierla 25 Dec '23

25 Dec '23

Kamailio project continued to evolve steadily, a new major release was out during this year, next one planned in a few months, relying on an amazing community of developers and users. We hope it kept helping people and companies world wide to connect with the dear ones and build a better way of living. The season holidays are ahead, time to relax, spend time with family and friends! I take again this chance to express my thanks and greetings to all the friends, developers, supporting companies and community members that made 2023 another fantastic year for Kamailio project. Enjoy the holidays! Merry Christmas! Daniel * Santa is flying Kamailio! * -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy, Training and Development Services Kamailio World Conference - April 18-19, 2024, Berlin

2 1

git:master:973803b0: pkg/obs: removed auth_identity modules
by Daniel-Constantin Mierla 24 Dec '23

24 Dec '23

Module: kamailio Branch: master Commit: 973803b0a3944b9de7ebdc4366b23e933e66ffbe URL: https://github.com/kamailio/kamailio/commit/973803b0a3944b9de7ebdc4366b23e9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-24T19:59:52+01:00 pkg/obs: removed auth_identity modules --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/973803b0a3944b9de7ebdc4366b23e9… Patch: https://github.com/kamailio/kamailio/commit/973803b0a3944b9de7ebdc4366b23e9… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 978c1073ac8..1dc6687e645 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -2336,9 +2336,7 @@ fi %files tls %defattr(-,root,root) -%doc %{_docdir}/kamailio/modules/README.auth_identity %doc %{_docdir}/kamailio/modules/README.tls -%{_libdir}/kamailio/modules/auth_identity.so %{_libdir}/kamailio/modules/tls.so

1 0

git:master:8a07c21b: pkg/alpine: removed auth_identity module
by Daniel-Constantin Mierla 24 Dec '23

24 Dec '23

Module: kamailio Branch: master Commit: 8a07c21b45d8afd0a0b84c09bbac6361a0f979d3 URL: https://github.com/kamailio/kamailio/commit/8a07c21b45d8afd0a0b84c09bbac636… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-24T17:23:55+01:00 pkg/alpine: removed auth_identity module --- Modified: pkg/kamailio/alpine/APKBUILD --- Diff: https://github.com/kamailio/kamailio/commit/8a07c21b45d8afd0a0b84c09bbac636… Patch: https://github.com/kamailio/kamailio/commit/8a07c21b45d8afd0a0b84c09bbac636… --- diff --git a/pkg/kamailio/alpine/APKBUILD b/pkg/kamailio/alpine/APKBUILD index b3d5c4d64bd..0696216564a 100644 --- a/pkg/kamailio/alpine/APKBUILD +++ b/pkg/kamailio/alpine/APKBUILD @@ -131,7 +131,7 @@ _mod_list_purple="purple" _mod_list_memcached="memcached" # - modules depending on openssl library -_mod_list_tls="auth_identity crypto tls" +_mod_list_tls="crypto tls" # - modules depending on openssl library _mod_list_outbound="outbound"

1 0

git:master:3bdc5665: Makefile.groups: removed auth_identity module
by Daniel-Constantin Mierla 24 Dec '23

24 Dec '23

Module: kamailio Branch: master Commit: 3bdc56654874b7e94e7052823714440b6457a100 URL: https://github.com/kamailio/kamailio/commit/3bdc56654874b7e94e7052823714440… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-24T17:21:57+01:00 Makefile.groups: removed auth_identity module - relocated to kamailio-archive repository --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/3bdc56654874b7e94e7052823714440… Patch: https://github.com/kamailio/kamailio/commit/3bdc56654874b7e94e7052823714440… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index 8d15b198cc3..d730a7eb51b 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -91,9 +91,6 @@ mod_list_tlsdeps=crypto tls # - modules depending on static openssl library mod_list_tlsa=tlsa -# - modules depending on openssl (+curl) library -mod_list_tlsdeps_curl=auth_identity - # - modules depending on static wolfssl library mod_list_tls_wolfssl=tls_wolfssl @@ -255,7 +252,7 @@ mod_list_all=$(sort $(mod_list_basic) $(mod_list_extra) \ $(mod_list_xmpp) \ $(mod_list_berkeley) $(mod_list_utils) \ $(mod_list_memcached) \ - $(mod_list_tlsdeps) $(mod_list_tlsdeps_curl) \ + $(mod_list_tlsdeps) \ $(mod_list_websocket) \ $(mod_list_snmpstats) $(mod_list_presence) \ $(mod_list_lua) $(mod_list_python) \ @@ -314,7 +311,7 @@ module_group_standard=$(mod_list_basic) $(mod_list_extra) \ module_group_common=$(mod_list_db) $(mod_list_dbuid) \ $(mod_list_pcre) $(mod_list_radius) \ $(mod_list_xmldeps) $(mod_list_presence) \ - $(mod_list_tlsdeps) $(mod_list_tlsdeps_curl) + $(mod_list_tlsdeps) # For db use (db modules, excluding drivers) module_group_db=$(mod_list_db) @@ -409,10 +406,10 @@ module_group_ktls_basic=$(mod_list_tlsdeps) ifeq ($(KTLS_INCLUDE_TLSA),yes) # pkg tls module with curl -module_group_ktls=$(mod_list_tlsdeps) $(mod_list_tlsdeps_curl) $(mod_list_tlsa) +module_group_ktls=$(mod_list_tlsdeps) $(mod_list_tlsa) else # pkg tls module with curl -module_group_ktls=$(mod_list_tlsdeps) $(mod_list_tlsdeps_curl) +module_group_ktls=$(mod_list_tlsdeps) # pkg tlsa module module_group_ktlsa=$(mod_list_tlsa)

1 0

git:master:5192e5d2: tmx: rework cleaning up on init failure
by Daniel-Constantin Mierla 24 Dec '23

24 Dec '23

Module: kamailio Branch: master Commit: 5192e5d275761ccd1af49d4bf9dd12e1438947b7 URL: https://github.com/kamailio/kamailio/commit/5192e5d275761ccd1af49d4bf9dd12e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-24T12:20:57+01:00 tmx: rework cleaning up on init failure --- Modified: src/modules/tmx/tmx_pretran.c --- Diff: https://github.com/kamailio/kamailio/commit/5192e5d275761ccd1af49d4bf9dd12e… Patch: https://github.com/kamailio/kamailio/commit/5192e5d275761ccd1af49d4bf9dd12e… --- diff --git a/src/modules/tmx/tmx_pretran.c b/src/modules/tmx/tmx_pretran.c index 7600a3c7b4b..a7c7d52df87 100644 --- a/src/modules/tmx/tmx_pretran.c +++ b/src/modules/tmx/tmx_pretran.c @@ -103,10 +103,11 @@ int tmx_init_pretran_table(void) for(n = 0; n < _tmx_ptran_size; n++) { if(lock_init(&_tmx_ptran_table[n].lock) == NULL) { LM_ERR("cannot init the lock %d\n", n); - n--; - while(n >= 0) { - lock_destroy(&_tmx_ptran_table[n].lock); - n--; + if(n > 0) { + do { + n--; + lock_destroy(&_tmx_ptran_table[n].lock); + } while(n > 0); } shm_free(_tmx_ptran_table); _tmx_ptran_table = 0;

1 0

[kamailio/kamailio] JSONRPC-S does not support batch requests (Issue #3677)
by Matthias van der Vlies 23 Dec '23

23 Dec '23

### Description It would be nice if the JSONRPC-S module would support batch requests. For example if you want to set multiple values in htable simultaneously. ### Expected behavior That the implementation is in line with JSON-RPC 2.0 specification and support batching. For example: `[ {"jsonrpc": "2.0", "method": "htable.stats", "id": 22}, {"jsonrpc": "2.0", "method": "htable.listTables", "id": 23} ]` #### Actual observed behavior Get an empty result with no error code (see Debugging data) Only the first message is parsed when discarding the brackets (which should give a json format error anyway, but doesn't) ` {"jsonrpc": "2.0", "method": "htable.stats", "id": 22}, {"jsonrpc": "2.0", "method": "htable.listTables", "id": 23} ` Then I get an answer to only the first request instead of expected JSON validation error. #### Debugging Data `curl -X POST -H "Content-Type: application/json" -d '[{"jsonrpc": "2.0", "method": "htable.stats", "id": 22},{"jsonrpc": "2.0", "method": "htable.listTables", "id": 23}]' http://10.0.0.1:5060/RPC { "jsonrpc": "2.0", "result": { } }` #### Log Messages `254(260) ERROR: jsonrpcs [jsonrpcs_mod.c:1263]: jsonrpc_dispatch(): missing or invalid jsonrpc field in request` #### SIP Traffic N/A ### Possible Solutions Needs a code fix ### Additional Information https://www.jsonrpc.org/specification -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3677 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3677(a)github.com>

2 2

← Newer
1
...
6
7
8
9
10
11
12
...
24
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2023