sr-dev December 2023

sr-dev@lists.kamailio.org

14 participants
234 discussions

git:master:1b959ead: auth_identity: module relocated to kamailio-archive repository

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1b959ead18fc8d7d55b1abe6f03fa3f849b57385 URL: https://github.com/kamailio/kamailio/commit/1b959ead18fc8d7d55b1abe6f03fa3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-23T17:20:40+01:00 auth_identity: module relocated to kamailio-archive repository - module is considered obsolete, not maintained - based on precursor specs of stir/shaken, not actually deployed in production by carriers - located now at: https://github.com/kamailio/kamailio-archive/tree/main/src/modules/auth_ide… --- Removed: src/modules/auth_identity/Makefile Removed: src/modules/auth_identity/README Removed: src/modules/auth_identity/auth_crypt.c Removed: src/modules/auth_identity/auth_dynstr.c Removed: src/modules/auth_identity/auth_hdrs.c Removed: src/modules/auth_identity/auth_http.c Removed: src/modules/auth_identity/auth_identity.c Removed: src/modules/auth_identity/auth_identity.h Removed: src/modules/auth_identity/auth_tables.c Removed: src/modules/auth_identity/doc/Makefile Removed: src/modules/auth_identity/doc/auth_identity.xml Removed: src/modules/auth_identity/doc/auth_identity_functions.xml Removed: src/modules/auth_identity/doc/auth_identity_params.xml --- Diff: https://github.com/kamailio/kamailio/commit/1b959ead18fc8d7d55b1abe6f03fa3f… Patch: https://github.com/kamailio/kamailio/commit/1b959ead18fc8d7d55b1abe6f03fa3f…

1 year

git:master:904a718d: sms: define size and check lenght for sender and ascii fields

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 904a718d15e4a83d752b6d2f0fa692fb10cda4b4 URL: https://github.com/kamailio/kamailio/commit/904a718d15e4a83d752b6d2f0fa692f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-22T15:10:51+01:00 sms: define size and check lenght for sender and ascii fields --- Modified: src/modules/sms/libsms_getsms.c Modified: src/modules/sms/sms_funcs.h --- Diff: https://github.com/kamailio/kamailio/commit/904a718d15e4a83d752b6d2f0fa692f… Patch: https://github.com/kamailio/kamailio/commit/904a718d15e4a83d752b6d2f0fa692f… --- diff --git a/src/modules/sms/libsms_getsms.c b/src/modules/sms/libsms_getsms.c index ea258ccf673..4181560490e 100644 --- a/src/modules/sms/libsms_getsms.c +++ b/src/modules/sms/libsms_getsms.c @@ -287,7 +287,13 @@ static int splitascii(struct modem *mdm, char *source, struct incame_sms *sms) if(!*start) return 1; start++; - strcpy(sms->ascii, start); + l1 = strlen(start); + if(l1 >= SMS_ASCII_LEN) { + /* truncate */ + l1 = SMS_ASCII_LEN - 1; + } + memcpy(sms->ascii, start, l1); + sms->ascii[l1] = '\0'; /* get the senders MSISDN */ start = strstr(source, "\",\""); if(start == 0) { @@ -301,7 +307,14 @@ static int splitascii(struct modem *mdm, char *source, struct incame_sms *sms) return 1; } *end = 0; - strcpy(sms->sender, start); + l1 = strlen(start); + if(l1 >= SMS_SENDER_LEN) { + /* truncate */ + l1 = SMS_SENDER_LEN - 1; + } + memcpy(sms->sender, start, l1); + sms->sender[l1] = '\0'; + /* Siemens M20 inserts the senders name between MSISDN and date */ start = end + 3; // Workaround for Thomas Stoeckel // diff --git a/src/modules/sms/sms_funcs.h b/src/modules/sms/sms_funcs.h index 4123b92c514..84c35c2f3a4 100644 --- a/src/modules/sms/sms_funcs.h +++ b/src/modules/sms/sms_funcs.h @@ -92,14 +92,18 @@ struct sms_msg }; #define SMS_NAME_LEN 64 +#define SMS_SENDER_LEN 32 +#define SMS_ASCII_LEN 500 +#define SMS_SMSC_LEN 32 + struct incame_sms { - char sender[31]; + char sender[SMS_SENDER_LEN]; char name[SMS_NAME_LEN]; char date[DATE_LEN]; char time[TIME_LEN]; - char ascii[500]; - char smsc[31]; + char ascii[SMS_ASCII_LEN]; + char smsc[SMS_SMSC_LEN]; int userdatalength; int is_statusreport; int sms_id;

1 year

git:master:1f5444fd: tm: make lookup event_route[tm:local-response] only once

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 1f5444fd2e25d227ffd70f1087d057a3b8002558 URL: https://github.com/kamailio/kamailio/commit/1f5444fd2e25d227ffd70f1087d057a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-22T14:50:59+01:00 tm: make lookup event_route[tm:local-response] only once - related to issue #3064 and PR #3687 --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/1f5444fd2e25d227ffd70f1087d057a… Patch: https://github.com/kamailio/kamailio/commit/1f5444fd2e25d227ffd70f1087d057a… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index c5a58bba8ab..f52ecc7d3ad 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -443,7 +443,7 @@ inline static void start_final_repl_retr(struct cell *t) } -static int _tm_local_response_sent_lookup = 0; +static int _tm_local_response_sent_evrt = -2; static int _reply_light(struct cell *trans, char *buf, unsigned int len, unsigned int code, char *to_tag, unsigned int to_tag_len, int lock, @@ -573,9 +573,15 @@ static int _reply_light(struct cell *trans, char *buf, unsigned int len, } rt = -1; if(likely(keng == NULL)) { - if(_tm_local_response_sent_lookup == 0) { + if(_tm_local_response_sent_evrt == -2) { rt = route_lookup(&event_rt, "tm:local-response"); - _tm_local_response_sent_lookup = 1; + if(rt < 0) { + _tm_local_response_sent_evrt = -1; + } else { + _tm_local_response_sent_evrt = rt; + } + } else { + rt = _tm_local_response_sent_evrt; } } if((rt >= 0 && event_rt.rlist[rt] != NULL) || (keng != NULL)

1 year

git:master:61efad28: seas: fix build warning

by Victor Seva

Module: kamailio Branch: master Commit: 61efad28eeb84d8b8f80fe7fd38d7bbb634717f4 URL: https://github.com/kamailio/kamailio/commit/61efad28eeb84d8b8f80fe7fd38d7bb… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-22T10:06:29+01:00 seas: fix build warning > CC (gcc) [M seas.so] encode_contact.o > encode_allow.c:40: warning: "_GNU_SOURCE" redefined > 40 | #define _GNU_SOURCE > | > <command-line>: note: this is the location of the previous definition --- Modified: src/modules/seas/encode_allow.c Modified: src/modules/seas/encode_contact.c Modified: src/modules/seas/encode_content_disposition.c Modified: src/modules/seas/encode_content_length.c Modified: src/modules/seas/encode_content_type.c Modified: src/modules/seas/encode_cseq.c Modified: src/modules/seas/encode_digest.c Modified: src/modules/seas/encode_expires.c Modified: src/modules/seas/encode_header.c Modified: src/modules/seas/encode_msg.c Modified: src/modules/seas/encode_parameters.c Modified: src/modules/seas/encode_route.c Modified: src/modules/seas/encode_to_body.c Modified: src/modules/seas/encode_uri.c Modified: src/modules/seas/encode_via.c Modified: src/modules/seas/utils.c --- Diff: https://github.com/kamailio/kamailio/commit/61efad28eeb84d8b8f80fe7fd38d7bb… Patch: https://github.com/kamailio/kamailio/commit/61efad28eeb84d8b8f80fe7fd38d7bb…

1 year

git:master:90df7449: pv: fix build warning

by Victor Seva

Module: kamailio Branch: master Commit: 90df744978ee2a83700d36ef88161f00b2220acb URL: https://github.com/kamailio/kamailio/commit/90df744978ee2a83700d36ef88161f0… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-22T10:00:32+01:00 pv: fix build warning > CC (gcc) [M pv.so] pv_xavp.o > pv_core.c: In function 'pv_get_cnt': > pv_core.c:2841:61: warning: 'ravp' may be used uninitialized [-Wmaybe-uninitialized] > 2841 | if(ravp && ravp->val.type == SR_XTYPE_XAVP) { > | ~~~~~~~~~^~~~~ > pv_core.c:2776:36: note: 'ravp' was declared here > 2776 | sr_xavp_t *ravp, *sub_avp; > | ^~~~ --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/90df744978ee2a83700d36ef88161f0… Patch: https://github.com/kamailio/kamailio/commit/90df744978ee2a83700d36ef88161f0… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index 03d025bba2f..d98abbf975d 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -2773,7 +2773,7 @@ int pv_get_cnt(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) * But this would be less intuitive in our case for counting. */ pv_xavp_name_t *xname, *xname_sub; - sr_xavp_t *ravp, *sub_avp; + sr_xavp_t *ravp = NULL, *sub_avp = NULL; int root_idxf, root_idx_spec, root_idx; int sub_idxf, sub_idx_spec, sub_idx; int count;

1 year

git:master:86c57ef7: db_text: fix build warning

by Victor Seva

Module: kamailio Branch: master Commit: 86c57ef77848513e3224c73a6d2889e8a2bd6fc3 URL: https://github.com/kamailio/kamailio/commit/86c57ef77848513e3224c73a6d2889e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-22T09:58:39+01:00 db_text: fix build warning > CC (gcc) [M db_text.so] dbt_raw_query.o > dbt_raw_query.c:23: warning: "_GNU_SOURCE" redefined > 23 | #define _GNU_SOURCE > | > <command-line>: note: this is the location of the previous definition --- Modified: src/modules/db_text/dbt_raw_query.c --- Diff: https://github.com/kamailio/kamailio/commit/86c57ef77848513e3224c73a6d2889e… Patch: https://github.com/kamailio/kamailio/commit/86c57ef77848513e3224c73a6d2889e… --- diff --git a/src/modules/db_text/dbt_raw_query.c b/src/modules/db_text/dbt_raw_query.c index a6dc37a69b7..ede61fe3525 100644 --- a/src/modules/db_text/dbt_raw_query.c +++ b/src/modules/db_text/dbt_raw_query.c @@ -19,8 +19,9 @@ * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ - +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <string.h> #include "../../core/str.h"

1 year

git:master:8bfd6580: cfgt: fix build warning

by Victor Seva

Module: kamailio Branch: master Commit: 8bfd6580533b6d6005cd257632a5c0e575f75e39 URL: https://github.com/kamailio/kamailio/commit/8bfd6580533b6d6005cd257632a5c0e… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-22T09:57:25+01:00 cfgt: fix build warning > CC (gcc) [M cfgt.so] cfgt_mod.o > cfgt_int.c:22: warning: "_GNU_SOURCE" redefined > 22 | #define _GNU_SOURCE > | > <command-line>: note: this is the location of the previous definition --- Modified: src/modules/cfgt/cfgt_int.c --- Diff: https://github.com/kamailio/kamailio/commit/8bfd6580533b6d6005cd257632a5c0e… Patch: https://github.com/kamailio/kamailio/commit/8bfd6580533b6d6005cd257632a5c0e… --- diff --git a/src/modules/cfgt/cfgt_int.c b/src/modules/cfgt/cfgt_int.c index f1357bb87aa..f74c044b83b 100644 --- a/src/modules/cfgt/cfgt_int.c +++ b/src/modules/cfgt/cfgt_int.c @@ -19,7 +19,9 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA * */ +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <stdio.h> #include <sys/stat.h> #include <sys/time.h>

1 year

git:master:7562aed2: benchmark: fix build warning

by Victor Seva

Module: kamailio Branch: master Commit: 7562aed2b1c33942b508c6cae9aa7db5ab75196e URL: https://github.com/kamailio/kamailio/commit/7562aed2b1c33942b508c6cae9aa7db… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-22T09:56:08+01:00 benchmark: fix build warning > CC (gcc) [M benchmark.so] benchmark.o > benchmark.c:41: warning: "_GNU_SOURCE" redefined > 41 | #define _GNU_SOURCE > | > <command-line>: note: this is the location of the previous definition --- Modified: src/modules/benchmark/benchmark.c --- Diff: https://github.com/kamailio/kamailio/commit/7562aed2b1c33942b508c6cae9aa7db… Patch: https://github.com/kamailio/kamailio/commit/7562aed2b1c33942b508c6cae9aa7db… --- diff --git a/src/modules/benchmark/benchmark.c b/src/modules/benchmark/benchmark.c index d28f8ea38a8..45cbe38c329 100644 --- a/src/modules/benchmark/benchmark.c +++ b/src/modules/benchmark/benchmark.c @@ -37,8 +37,9 @@ * configuration sections. * */ - +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <string.h> #include <sys/time.h> #include <stdlib.h>

1 year

git:master:c413392a: jansson: fix build warning

by Victor Seva

Module: kamailio Branch: master Commit: c413392a3bae1efdc40671b11da83bec173caff5 URL: https://github.com/kamailio/kamailio/commit/c413392a3bae1efdc40671b11da83be… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-22T09:53:16+01:00 jansson: fix build warning > CC (gcc) [M jansson.so] jansson_utils.o > jansson_utils.c:23: warning: "_GNU_SOURCE" redefined > 23 | #define _GNU_SOURCE > | > <command-line>: note: this is the location of the previous definition --- Modified: src/modules/jansson/jansson_utils.c --- Diff: https://github.com/kamailio/kamailio/commit/c413392a3bae1efdc40671b11da83be… Patch: https://github.com/kamailio/kamailio/commit/c413392a3bae1efdc40671b11da83be… --- diff --git a/src/modules/jansson/jansson_utils.c b/src/modules/jansson/jansson_utils.c index c5e9a1560c2..61a9377c474 100644 --- a/src/modules/jansson/jansson_utils.c +++ b/src/modules/jansson/jansson_utils.c @@ -19,8 +19,9 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ - +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <stdio.h> #include <jansson.h> #include <limits.h>

1 year

git:master:9d4d9c0a: auth_identity: fix build warning

by Victor Seva

Module: kamailio Branch: master Commit: 9d4d9c0afce10d00f65eccb3c9bfd3c508bac336 URL: https://github.com/kamailio/kamailio/commit/9d4d9c0afce10d00f65eccb3c9bfd3c… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-22T09:51:28+01:00 auth_identity: fix build warning > CC (gcc) [M auth_identity.so] auth_dynstr.o > auth_crypt.c:29: warning: "_GNU_SOURCE" redefined > 29 | #define _GNU_SOURCE > | > <command-line>: note: this is the location of the previous definition --- Modified: src/modules/auth_identity/auth_crypt.c --- Diff: https://github.com/kamailio/kamailio/commit/9d4d9c0afce10d00f65eccb3c9bfd3c… Patch: https://github.com/kamailio/kamailio/commit/9d4d9c0afce10d00f65eccb3c9bfd3c… --- diff --git a/src/modules/auth_identity/auth_crypt.c b/src/modules/auth_identity/auth_crypt.c index 934c9cca347..4cc55a38fda 100644 --- a/src/modules/auth_identity/auth_crypt.c +++ b/src/modules/auth_identity/auth_crypt.c @@ -25,8 +25,9 @@ * Module: \ref auth-identity */ - +#ifndef _GNU_SOURCE #define _GNU_SOURCE +#endif #include <stdio.h> #include <stdlib.h> #include <string.h>

1 year

← Newer
1
...
7
8
9
10
11
12
13
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2023