sr-dev December 2023

sr-dev@lists.kamailio.org

14 participants
234 discussions

git:master:17e9e3f4: sipcapture: removed unused global variable

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 17e9e3f447867e34b8f320b8b93189f01fbc3f77 URL: https://github.com/kamailio/kamailio/commit/17e9e3f447867e34b8f320b8b93189f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-20T09:30:01+01:00 sipcapture: removed unused global variable - renamed local function variable that was conflicting --- Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/17e9e3f447867e34b8f320b8b93189f… Patch: https://github.com/kamailio/kamailio/commit/17e9e3f447867e34b8f320b8b93189f… --- diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index d39ee1fa7c4..320e351a371 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -298,8 +298,6 @@ static struct sock_filter BPF_code[] = { //str* table_names = NULL; -unsigned int no_tables = 0; - enum e_mt_mode mtmode = mode_random; enum hash_source source = hs_error; @@ -481,12 +479,12 @@ int parse_table_names(str table_name, str **table_names) { char *p = NULL; - unsigned int no_tables; + unsigned int l_no_tables; char *table_name_cpy; int i; /*parse and save table names*/ - no_tables = 1; + l_no_tables = 1; i = 0; str *names; @@ -503,12 +501,12 @@ int parse_table_names(str table_name, str **table_names) while(*p) { if(*p == '|') { - no_tables++; + l_no_tables++; } p++; } - names = (str *)pkg_malloc(sizeof(str) * no_tables); + names = (str *)pkg_malloc(sizeof(str) * l_no_tables); if(names == NULL) { PKG_MEM_ERROR; pkg_free(table_name_cpy); @@ -539,7 +537,7 @@ int parse_table_names(str table_name, str **table_names) *table_names = names; - return no_tables; + return l_no_tables; } /* checks for some missing fields*/

1 year

ERROR: ctl [init_socks.c:114]: init_unix_sock(): ERROR: init_unix_sock: bind: Permission denied [13]

by nguyenquocchinhdev＠gmail.com

Hi guys, When I ran below the command, an error appeared, how do I fix this? /etc/kamailio$ kamailio -E -e loading modules under config path: /usr/lib/x86_64-linux-gnu/kamailio/modules/ Listening on udp: 192.168.0.158:5090 tcp: 192.168.0.158:5090 tcp: 192.168.0.158:10080 sctp: 192.168.0.158:5090 Aliases: sctp: vizoai1:5090 tcp: vizoai1:10080 tcp: vizoai1:5090 udp: vizoai1:5090 0(564421) INFO: <core> [core/tcp_main.c:4999]: init_tcp(): using epoll_lt as the io watch method (auto detected) 0(564423) INFO: rr [../outbound/api.h:52]: ob_load_api(): unable to import bind_ob - maybe module is not loaded 0(564423) INFO: rr [rr_mod.c:188]: mod_init(): outbound module not available 0(564423) ERROR: ctl [init_socks.c:114]: init_unix_sock(): ERROR: init_unix_sock: bind: Permission denied [13] 0(564423) ERROR: ctl [ctl.c:291]: mod_init(): ERROR: ctl: mod_init: init ctrl. sockets failed 0(564423) ERROR: <core> [core/sr_module.c:945]: init_mod(): Error while initializing module ctl (/usr/lib/x86_64-linux-gnu/kamailio/modules/ctl.so) ERROR: error while initializing modules 0(564423) ERROR: jsonrpcs [jsonrpcs_fifo.c:599]: jsonrpc_fifo_destroy(): FIFO stat failed: Permission denied ============================================= grep loadmodule modules.cfg loadmodule "db_mysql.so" loadmodule "textopsx.so" loadmodule "websocket.so" loadmodule "xhttp.so" loadmodule "kex.so" loadmodule "corex.so" loadmodule "tm.so" loadmodule "tmx.so" loadmodule "sl.so" loadmodule "rr.so" loadmodule "pv.so" loadmodule "maxfwd.so" loadmodule "usrloc.so" loadmodule "registrar.so" loadmodule "textops.so" loadmodule "siputils.so" loadmodule "xlog.so" loadmodule "sanity.so" loadmodule "ctl.so" loadmodule "cfg_rpc.so" loadmodule "sdpops.so" loadmodule "jsonrpcs.so" loadmodule "auth.so" loadmodule "auth_db.so" loadmodule "nathelper.so" loadmodule "rtpengine.so" loadmodule "tls.so" loadmodule "debugger.so" loadmodule "sctp.so"

1 year

git:master:1068bbbf: README.md: remove irc reference

by GitHub

Module: kamailio Branch: master Commit: 1068bbbf9a7f2bf96d9ee2cefa1b81fbabac9805 URL: https://github.com/kamailio/kamailio/commit/1068bbbf9a7f2bf96d9ee2cefa1b81f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2023-12-19T21:18:03+01:00 README.md: remove irc reference --- Modified: README.md --- Diff: https://github.com/kamailio/kamailio/commit/1068bbbf9a7f2bf96d9ee2cefa1b81f… Patch: https://github.com/kamailio/kamailio/commit/1068bbbf9a7f2bf96d9ee2cefa1b81f… --- diff --git a/README.md b/README.md index a4616f9d66c..d06dd7a7822 100644 --- a/README.md +++ b/README.md @@ -101,13 +101,6 @@ For more information about the mailing lists, please see: * https://www.kamailio.org/w/mailing-lists/ -### IRC Channel - -An open IRC discussion channel is managed by the community: - - * irc server: irc.freenode.net - * irc channel: #kamailio - ### Matrix Channel An open Matrix discussion channel is managed by the community:

1 year

git:master:f036333b: ims_dialog: refactored kemi get/set profile functions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f036333b756c1021545e70871024561089954a56 URL: https://github.com/kamailio/kamailio/commit/f036333b756c1021545e70871024561… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-19T10:57:40+01:00 ims_dialog: refactored kemi get/set profile functions - expect final string values in the parameters, not with kamailio-specific variables, they can conflict in the external scripting languages and also leak pkg memory --- Modified: src/modules/ims_dialog/ims_dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/f036333b756c1021545e70871024561… Patch: https://github.com/kamailio/kamailio/commit/f036333b756c1021545e70871024561… --- diff --git a/src/modules/ims_dialog/ims_dialog.c b/src/modules/ims_dialog/ims_dialog.c index 3c0454e5045..16a76a8cbe1 100644 --- a/src/modules/ims_dialog/ims_dialog.c +++ b/src/modules/ims_dialog/ims_dialog.c @@ -1068,7 +1068,6 @@ static int ki_is_known_dlg(sip_msg_t *msg) static int ki_set_dlg_profile(sip_msg_t *msg, str *sprofile, str *svalue) { struct dlg_profile_table *profile = NULL; - pv_elem_t *pvvalue = NULL; if(sprofile == NULL || sprofile->s == NULL || sprofile->len <= 0) { LM_ERR("invalid profile identifier\n"); @@ -1080,14 +1079,18 @@ static int ki_set_dlg_profile(sip_msg_t *msg, str *sprofile, str *svalue) LM_CRIT("profile <%.*s> not defined\n", sprofile->len, sprofile->s); return -1; } - - if(pv_parse_format(svalue, &pvvalue) || pvvalue == NULL) { - LM_ERR("wrong format [%.*s] for value param!\n", svalue->len, - svalue->s); - return -1; + if(svalue != NULL && svalue->len > 0) { + if(set_dlg_profile(msg, svalue, profile) < 0) { + LM_ERR("failed to set profile with value\n"); + return -1; + } + } else { + if(set_dlg_profile(msg, NULL, profile) < 0) { + LM_ERR("failed to set profile\n"); + return -1; + } } - - return w_set_dlg_profile(msg, (char *)profile, (char *)pvvalue); + return 1; } static int ki_get_profile_size( @@ -1095,8 +1098,9 @@ static int ki_get_profile_size( { struct dlg_profile_table *profile = NULL; - pv_elem_t *pvvalue = NULL; pv_spec_t *pvs = NULL; + unsigned int size; + pv_value_t val; if(sprofile == NULL || sprofile->s == NULL || sprofile->len <= 0) { LM_ERR("invalid profile identifier\n"); @@ -1111,11 +1115,6 @@ static int ki_get_profile_size( LM_CRIT("profile <%.*s> not defined\n", sprofile->len, sprofile->s); return -1; } - if(pv_parse_format(svalue, &pvvalue) || pvvalue == NULL) { - LM_ERR("wrong format [%.*s] for value param!\n", svalue->len, - svalue->s); - return -1; - } pvs = pv_cache_get(spv); if(pvs == NULL) { LM_ERR("cannot get pv spec for [%.*s]\n", spv->len, spv->s); @@ -1125,9 +1124,22 @@ static int ki_get_profile_size( LM_ERR("return must be an AVP or SCRIPT VAR!\n"); return -1; } + if(svalue != NULL && svalue->len > 0 && profile->has_value != 0) { + size = get_profile_size(profile, svalue); + } else { + size = get_profile_size(profile, NULL); + } + + memset(&val, 0, sizeof(pv_value_t)); + val.flags = PV_VAL_INT | PV_TYPE_INT; + val.ri = (long)size; + + if(pvs->setf(msg, &pvs->pvp, (int)EQ_T, &val) < 0) { + LM_ERR("setting profile PV failed\n"); + return -1; + } - return w_get_profile_size3( - msg, (char *)profile, (char *)pvvalue, (char *)pvs); + return 1; } /* clang-format off */

1 year

git:master:19152caf: ims_dialog: reformat exported structures

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 19152caf44360eae533508ecd6f3f9e33af14fb7 URL: https://github.com/kamailio/kamailio/commit/19152caf44360eae533508ecd6f3f9e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-19T10:57:40+01:00 ims_dialog: reformat exported structures --- Modified: src/modules/ims_dialog/ims_dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/19152caf44360eae533508ecd6f3f9e… Patch: https://github.com/kamailio/kamailio/commit/19152caf44360eae533508ecd6f3f9e…

1 year

git:master:19572a82: tm: clearer reply code handling for uac dlg

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 19572a828ffeb08b190dab5ae4aee93f03d9a7f2 URL: https://github.com/kamailio/kamailio/commit/19572a828ffeb08b190dab5ae4aee93… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-19T10:57:40+01:00 tm: clearer reply code handling for uac dlg --- Modified: src/modules/tm/dlg.c --- Diff: https://github.com/kamailio/kamailio/commit/19572a828ffeb08b190dab5ae4aee93… Patch: https://github.com/kamailio/kamailio/commit/19572a828ffeb08b190dab5ae4aee93… --- diff --git a/src/modules/tm/dlg.c b/src/modules/tm/dlg.c index 420f95a98d2..29b8d50769f 100644 --- a/src/modules/tm/dlg.c +++ b/src/modules/tm/dlg.c @@ -666,7 +666,7 @@ static inline int dlg_new_resp_uac(dlg_t *_d, struct sip_msg *_m) code = _m->first_line.u.reply.statuscode; if(code < 200) { - /* A provisional response, do nothing, we could + /* 100-199: a provisional response, do nothing, we could * update remote tag and route set but we will do that * for a positive final response anyway and I don't want * bet on presence of these fields in provisional responses @@ -674,8 +674,8 @@ static inline int dlg_new_resp_uac(dlg_t *_d, struct sip_msg *_m) * Send a request to jan(a)iptel.org if you need to update * the structures here */ - } else if((code >= 200) && (code < 299)) { - /* A final response, update the structures and transit + } else if(code < 299) { + /* 200-299: a final response, update the structures and transit * into DLG_CONFIRMED */ if(response2dlg(_m, _d) < 0) @@ -687,7 +687,7 @@ static inline int dlg_new_resp_uac(dlg_t *_d, struct sip_msg *_m) return -2; } } else { - /* A negative final response, mark the dialog as destroyed + /* 300-699: a negative final response, mark the dialog as destroyed * Again, I do not update the structures here because it * makes no sense to me, a dialog shouldn't be used after * it is destroyed

1 year

[kamailio/kamailio] github: [skip ci]: bump actions/upload-artifact from 3 to 4 (PR #3681)

by dependabot[bot]

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">act… releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <h2>What's Changed</h2> <p>The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.</p> <p>For more information, see the <a href="https://github.com/actions/toolkit/tree/main/packages/artifact&q… documentation.</p> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/vmjoseph"><code>@vmjoseph</… made their first contribution in <a href="https://redirect.github.com/actions/upload-artifact/pull/464&quo… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v4.0.0&q… <h2>v3.1.3</h2> <h2>What's Changed</h2> <ul> <li>chore(github): remove trailing whitespaces by <a href="https://github.com/ljmf00"><code>@ljmf00</code… in <a href="https://redirect.github.com/actions/upload-artifact/pull/313&quo… <li>Bump <code>@actions/artifact</code> version to v1.1.2 by <a href="https://github.com/bethanyj28"><code>@bethanyj28&… in <a href="https://redirect.github.com/actions/upload-artifact/pull/436&quo… </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v3...v3.1.3&q… <h2>v3.1.2</h2> <ul> <li>Update all <code>@actions/*</code> NPM packages to their latest versions- <a href="https://redirect.github.com/actions/upload-artifact/issues/374&q… <li>Update all dev dependencies to their most recent versions - <a href="https://redirect.github.com/actions/upload-artifact/issues/375&q… </ul> <h2>v3.1.1</h2> <ul> <li>Update actions/core package to latest version to remove <code>set-output</code> deprecation warning <a href="https://redirect.github.com/actions/upload-artifact/issues/351&q… </ul> <h2>v3.1.0</h2> <h2>What's Changed</h2> <ul> <li>Bump <code>@actions/artifact</code> to v1.1.0 (<a href="https://redirect.github.com/actions/upload-artifact/pull/327&quo…) <ul> <li>Adds checksum headers on artifact upload (<a href="https://redirect.github.com/actions/toolkit/pull/1095">a…) (<a href="https://redirect.github.com/actions/toolkit/pull/1063">a… </ul> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/c7d193f32edcb7… Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/466&q… from actions/v4-beta</li> <li><a href="https://github.com/actions/upload-artifact/commit/13131bb095770b… licensed cache</li> <li><a href="https://github.com/actions/upload-artifact/commit/4a6c273b9834f6… Merge branch 'main' into v4-beta</li> <li><a href="https://github.com/actions/upload-artifact/commit/f391bb91a3d311… Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/465&q… from actions/robherley/v4-documentation</li> <li><a href="https://github.com/actions/upload-artifact/commit/9653d03c4b74c3… Apply suggestions from code review</li> <li><a href="https://github.com/actions/upload-artifact/commit/875b63076402f2… add limitations section</li> <li><a href="https://github.com/actions/upload-artifact/commit/ecb21463e93740… add compression example</li> <li><a href="https://github.com/actions/upload-artifact/commit/5e7604f84a0558… trim some repeated info</li> <li><a href="https://github.com/actions/upload-artifact/commit/d6437d07581fe3… naming</li> <li><a href="https://github.com/actions/upload-artifact/commit/1b561557037b49… s/v4-beta/v4/g</li> <li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/v3...v4"… view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?d… Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3681 -- Commit Summary -- * github: [skip ci]: bump actions/upload-artifact from 3 to 4 -- File Changes -- M .github/workflows/cifuzz.yml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3681.patch https://github.com/kamailio/kamailio/pull/3681.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3681 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3681(a)github.com>

1 year

git:master:68f653bf: github: [skip ci]: bump actions/upload-artifact from 3 to 4

by Victor Seva

Module: kamailio Branch: master Commit: 68f653bfc66d8f4ff2e11f5fc9348f4d2632fe8b URL: https://github.com/kamailio/kamailio/commit/68f653bfc66d8f4ff2e11f5fc9348f4… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-19T07:43:10+01:00 github: [skip ci]: bump actions/upload-artifact from 3 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/cifuzz.yml --- Diff: https://github.com/kamailio/kamailio/commit/68f653bfc66d8f4ff2e11f5fc9348f4… Patch: https://github.com/kamailio/kamailio/commit/68f653bfc66d8f4ff2e11f5fc9348f4… --- diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml index bb1b712cb5b..3ee2f6ef37f 100644 --- a/.github/workflows/cifuzz.yml +++ b/.github/workflows/cifuzz.yml @@ -27,7 +27,7 @@ jobs: dry-run: false language: c - name: Upload Crash - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: failure() && steps.build.outcome == 'success' with: name: artifacts

1 year

git:master:b2f1cd6e: github: [skip ci]: bump github/codeql-action from 2 to 3

by Victor Seva

Module: kamailio Branch: master Commit: b2f1cd6ed2cd5da84fe8ff48db688fc41f129ccb URL: https://github.com/kamailio/kamailio/commit/b2f1cd6ed2cd5da84fe8ff48db688fc… Author: dependabot[bot] <49699333+dependabot[bot](a)users.noreply.github.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-19T07:42:08+01:00 github: [skip ci]: bump github/codeql-action from 2 to 3 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/v2...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support(a)github.com> --- Modified: .github/workflows/codeql.yml --- Diff: https://github.com/kamailio/kamailio/commit/b2f1cd6ed2cd5da84fe8ff48db688fc… Patch: https://github.com/kamailio/kamailio/commit/b2f1cd6ed2cd5da84fe8ff48db688fc… --- diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 62fe2dc5c04..aa6d9194b07 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -41,13 +41,13 @@ jobs: run: export PKG_CONFIG_PATH=$RUNNER_TEMP/usr/lib/pkgconfig:$PKG_CONFIG_PATH && echo "PKG_CONFIG_PATH=$PKG_CONFIG_PATH" >> $GITHUB_ENV - name: Initialize CodeQL - uses: github/codeql-action/init@v2 + uses: github/codeql-action/init@v3 with: languages: ${{ matrix.language }} queries: +security-and-quality - name: Autobuild - uses: github/codeql-action/autobuild@v2 + uses: github/codeql-action/autobuild@v3 if: ${{ matrix.language == 'javascript' || matrix.language == 'python' }} - name: Build cpp @@ -55,6 +55,6 @@ jobs: run: make all - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v2 + uses: github/codeql-action/analyze@v3 with: category: "/language:${{ matrix.language }}"

1 year

[kamailio/kamailio] github: [skip ci]: bump github/codeql-action from 2 to 3 (PR #3680)

by dependabot[bot]

1 year

← Newer
1
...
10
11
12
13
14
15
16
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2023